Skip to content
This repository was archived by the owner on Sep 21, 2024. It is now read-only.

feat: Do not proactively create directories when creating spheres via CLI. Fixes #599 - #643

Open
jsantell wants to merge 1 commit into
mainfrom
599
Open

feat: Do not proactively create directories when creating spheres via CLI. Fixes #599#643
jsantell wants to merge 1 commit into
mainfrom
599

Conversation

@jsantell

@jsantelljsantell commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@cdata

cdata commented Sep 19, 2023

Copy link
Copy Markdown
Collaborator

Can you provide a rationale for the change? Maybe a test?

cdata
cdata reviewed Sep 19, 2023
View reviewed changes
Comment threadrust/noosphere/src/sphere/builder.rs Outdated
@jsantell

jsantell commented Sep 19, 2023

Copy link
Copy Markdown
ContributorAuthor

Can you provide a rationale for the change? Maybe a test?

In #599, for early failures (like an invalid key), the SpherePaths initialization proactively creates all of the .sphere dirs., preventing follow up commands with the correct key, as the sphere dirs are no longer uninitialized. Added a test in noosphere/tests/cli.rs

@cdata

cdata commented Sep 19, 2023

Copy link
Copy Markdown
Collaborator

Thanks, I missed that the bug was in the title at first 👍

cdata
cdata reviewed Sep 19, 2023
View reviewed changes
Comment threadrust/noosphere/tests/cli.rs
@jsantell
jsantellforce-pushed the 599 branch 3 times, most recently from f2c389e to 90f36d2CompareSeptember 20, 2023 22:43
@jsantell
jsantell requested a review from cdataSeptember 20, 2023 22:47
@github-actions

github-actionsBot commented Oct 31, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Test flake analysis

No flakes detected 🎉

statusplatformfeaturestoolchain
🟢macos-13test-kubo,headersstable
🟢macos-13test-kubo,headers,rocksdbstable
🟢ubuntu-latesttest-kubo,headers,rocksdbstable
🟢ubuntu-latesttest-kubo,headersstable
🟢windows-latesttest-kubo,headersstable

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cdatacdataAwaiting requested review from cdata

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsantell@cdata