feat(context): context bar by sudo-tee · Pull Request #69 · sudo-tee/opencode.nvim

sudo-tee · 2025-10-16T20:24:41Z

This PR is adding a context bar to manage/view context being sent by the plugin

cameronr · 2025-10-27T22:13:24Z

Ooh, I'm looking forward to this!

sudo-tee · 2025-10-27T23:30:52Z

Yes I have some small issues after the rebase. But it's coming together.

sudo-tee · 2025-10-30T12:08:21Z

@cameronr

Whenever you have time you can have a look ?

You can review the code if you like and also tell me if the feature works for you.

I think it's going to be a nice feature but I might be biased :)

cameronr · 2025-10-30T14:34:58Z

Yes, I'm very excited for this feature! will test and review today.

cameronr · 2025-10-30T21:01:46Z

I haven't looked at the code yet but, for this kind of feature, I like to start with a review of the design / functionality

Design:

Overall, it looks nice :)
The # popup menu is great
Given how tight the input_window area is on space, I think it's worth asking two questions:
1. Is the gear icon necessary?
2. The extra line between the context bar and the prompt looks nice but it might be sacrificing too much vertical space. If we right align the content, maybe we could get away without needing that extra line? Here's what that would look like (at least with my config):

Functionality:

Pressing #, highlighting an item, and then canceling selection / closing the blink autocomplete window, leaves the cursor on the line above where prompt input starts:

The lines seem to behave strangely when pressing enter. I think it's related to that extra padding line? Most noticeable with set nu in the input window.

It seems like that extra padding line is creating some interaction issues so I think the big question is if it's really necessary?

sudo-tee · 2025-10-30T23:21:51Z

Thanks for the great feedback.

You are right about the padding. I added it for looks because it looked weird with the winbar ( mostly my frontend dev background though it looked better 😅). I like the suggestion to align it to the right. I will see what I can do about it.

I also saw some quirky behaviour with the padded line. I will remove it and see if it feels better.

Don't hesitate if you have other ideas to improve it.

Thanks for your review.

cameronr

A really nice feature and will be great when it goes out!

cameronr · 2025-10-31T00:12:49Z

+ local _, col = unpack(vim.api.nvim_win_get_cursor(0))
+ local line = vim.api.nvim_get_current_line()
+ local key = config.get_key_for_function('input_window', 'context_items')
+
+ local completion_text = key .. (item.label or item.insert_text or '')
+ local text_start = col - #completion_text
+
+ if text_start >= 0 and line:sub(text_start + 1, col) == completion_text then
+ line = line:sub(1, text_start) .. line:sub(col + 1)
+ input_win.set_current_line(line)
+ vim.api.nvim_win_set_cursor(0, { vim.api.nvim_win_get_cursor(0)[1], text_start })
+ elseif col > 0 and line:sub(col, col) == key then
+ line = line:sub(1, col - 1) .. line:sub(col + 1)
+ input_win.set_current_line(line)
+ end


emmylua_ls suggests a nil check on col (and maybe this is a slightly cleaner way to get col):
localcol=vim.api.nvim_win_get_cursor(0)[2] ifnotcolthenreturnend

cameronr · 2025-10-31T00:52:43Z

+ vim.api.nvim_create_autocmd('BufWritePost', {
+ pattern = '*',
+ callback = function(args)
+ local buf = args.buf
+ local curr_buf = state.current_code_buf or vim.api.nvim_get_current_buf()
+ if buf == curr_buf and util.is_buf_a_file(buf) then
+ M.load()
+ end
+ end,
+ })
+
+ vim.api.nvim_create_autocmd('DiagnosticChanged', {
+ pattern = '*',
+ callback = function(args)
+ local buf = args.buf
+ local curr_buf = state.current_code_buf or vim.api.nvim_get_current_buf()
+ if buf == curr_buf and util.is_buf_a_file(buf) and M.is_context_enabled('diagnostics') then
+ M.load()
+ end
+ end,
+ })


could consider not setting up these autocmds if context is disabled?

I see your point, but if you toggle it later with something like
Opencode run context=enabled=true hello there
you might end up with some stale context.

cameronr · 2025-10-31T00:59:58Z

 -- context
 last_sent_context = nil,
+ current_context_config = {},
+ context_updated_at = nil,


I only see context_updated_at written to. Is it actually used/needed?

The context_bar is listening to it
This related to the reactive_state file. I wanted to wrap the context to be able to subscribe to individual fields, but it ended up more complex than just having a timestamp. It's a bit of an anti-pattern but LuaJit does not support ipairs in memtables so we cannot loop over indexed arrays when wrapped in memtables.
Maybe I will find a better pattern later, but this one works for now and is simple enough

sudo-tee · 2025-10-31T12:39:48Z

@cameronr

I did align the bar to the right and removed padding, It was a really great suggestion. It seems to work really well. I didn't encounter cursor jumps.

Let me know what you think.

There is still a couple of stuff I want to add like un the user message show that diagnostics have been shared like with section and now cursor data, a part from that I'm almost done

cameronr · 2025-10-31T14:22:01Z

I took a quick look and it looks great!

My only other thought was if we should move the guard icon to be left aligned in the context bar? I think that would make more sense and probably look good?

cameronr · 2025-10-31T14:28:38Z

Actually, now that I think about it, I wonder if the agent mode should be there too? It's not as clear (input guard is clearly input related) where as agent mode is more output related. That said, making sure the mode is set correctly before submitting is important and reducing the visual distance to verify that could be an improvement. Maybe it's worth at least looking at?

sudo-tee · 2025-10-31T14:31:18Z

Those are great suggestions.

Current Model is also something related to input, but this could make the bar a little to crowded

I will play around with that idea.

sudo-tee · 2025-10-31T19:31:47Z

I moved the prompt guard into the context-bar and you are right it make more sense there

sudo-tee · 2025-10-31T19:46:59Z

Not convinced about the mode though. It looks a bit odd to me

Maybe it could be a future task to find a better place for the model and mode

cameronr · 2025-10-31T19:57:33Z

Yeah, mode may be a stretch. My last idea is trying mode on the left rather than the right. My thinking is that from left to right it's conceptually:

can i submit? (prompt guard, and, most of the time, it's not there)
what mode am i submitting in (build/plan)
what context am i including?

but it's possible that mode on the left just won't look good :)

if it doesn't look good, we can leave it up in the output_window winbar for now.

sudo-tee · 2025-11-01T12:01:21Z

It could work.. but I think it's to punchy and to close to the content.

I will leave it at the top, until I find a better way to display it. Maybe the status bar which is almost empty might be a good place in the future

With the bar aligned to the right there is no need for the icon anymore

sudo-tee changed the title ~~Draft: feat(context): context bar~~DRAFT: feat(context): context barOct 16, 2025

sudo-tee mentioned this pull request Oct 17, 2025
Planned / In progress features #43
Open
15 tasks

sudo-tee force-pushed the context-bar branch from 0567056 to 2f1eddfCompare October 27, 2025 20:18

sudo-tee force-pushed the context-bar branch 6 times, most recently from 502a4c1 to ab1e7fdCompare October 30, 2025 10:06

sudo-tee changed the title ~~DRAFT: feat(context): context bar~~feat(context): context barOct 30, 2025

sudo-tee force-pushed the context-bar branch from ab1e7fd to 18e30f5Compare October 30, 2025 12:08

sudo-tee force-pushed the context-bar branch from ccf0c68 to 5d6629eCompare October 30, 2025 16:59

cameronr reviewed Oct 31, 2025
View reviewed changes

sudo-tee force-pushed the context-bar branch 3 times, most recently from dda859d to 7121f13Compare October 31, 2025 12:26

sudo-tee added 28 commits November 3, 2025 08:42

test(context-bar): add unit tests for context-bar rendering
b9d5401

feat(completion): make it work with vim_complete
d7a38f3

test(context_completion): add tests for context completion
2756615

feat(selection-context): add better description for selection menu
133f74f

docs(context-bar): add docs for the context-bar/completion
292ce5a

fix(highlight): fix highlight for context-bar file
ebeea1d

feat(completion): add icons to sources
f8163da

feat(completion): rely on kind_icon instead of deducing it
86e4802

feat(completion): better sorting for context items
617dd6c

fix(completion): fix wrong icons import
64baa57

feat(completion): add context trigger to nvim_cmp engine
79c0519

fix(completion): remove text/trigger after context completion
504255c

chore(completion): general cleanup
8d8849a

fix(context): add actual line content in cursor_data
eef92b8

feat(context): display cursor_data with the user prompt
828ba0e

fix(context): fix diagnostics overwrites
bea323b

feat(completion): add highlight to switches in context completion
0c7f72e

chore(mention): escape chars in mention pattern
c1d3f9e

chore(types): fix config typings
428a046

chore(context): add augroup to autocmds
2fceec7

chore: remove uneeded file
5a322a6

chore(state): remove unused field
e53aeaa

feat(context-bar): align the bar to the right
f173ffc
With the bar aligned to the right there is no need for the icon anymore

feat(docs): update README with new screenshots
8585f5e

feat(context-bar): move prompt-guard icon to the context bar
a6df8a2

feat(formatter): display diagnostics sent in user prompt
ee89d25

fix(context): merge context config properly before sending message
81fd96a

test(diagnostics): add snapshot test for diagnostics
c70b858

sudo-tee force-pushed the context-bar branch from 62c7dce to c70b858Compare November 3, 2025 13:43

sudo-tee merged commit 36f609d into mainNov 3, 2025
10 checks passed

Conversation

sudo-tee commented Oct 16, 2025

Uh oh!

cameronr commented Oct 27, 2025

Uh oh!

sudo-tee commented Oct 27, 2025

Uh oh!

sudo-tee commented Oct 30, 2025

Uh oh!

cameronr commented Oct 30, 2025

Uh oh!

cameronr commented Oct 30, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Design:

Functionality:

Uh oh!

sudo-tee commented Oct 30, 2025

Uh oh!

cameronr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cameronrOct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cameronrOct 31, 2025

Choose a reason for hiding this comment

Uh oh!

sudo-teeOct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cameronrOct 31, 2025

Choose a reason for hiding this comment

Uh oh!

sudo-teeOct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sudo-tee commented Oct 31, 2025

Uh oh!

cameronr commented Oct 31, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cameronr commented Oct 31, 2025

Uh oh!

sudo-tee commented Oct 31, 2025

Uh oh!

sudo-tee commented Oct 31, 2025

Uh oh!

sudo-tee commented Oct 31, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cameronr commented Oct 31, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sudo-tee commented Nov 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cameronr commented Oct 30, 2025•
edited
Loading

cameronr commented Oct 31, 2025•
edited
Loading

sudo-tee commented Oct 31, 2025•
edited
Loading

cameronr commented Oct 31, 2025•
edited
Loading