Skip to content

Class 03 - #4

Open
suhk wants to merge 16 commits into
masterfrom
class-03
Open

Class 03#4
suhk wants to merge 16 commits into
masterfrom
class-03

Conversation

@suhk

@suhksuhk commented Dec 4, 2015

Copy link
Copy Markdown
Owner

Didn't take too long as I was kinda already doing this from the start.

suhk added 13 commits December 1, 2015 13:31
still need to reset the other category to avoid AND
I cleaned up code such that there is no HTML code in the javascript
files and used clone statements.
Syntax/comments mostly
Made sure it looked okay on mobile/desktop
Comment threadindex.html Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a subtle bug, but it causes a pretty big difference to how your page displays. Essentially, this line isn't doing anything. If you look at your page on a mobile device, or an emulator, you should notice that your page isn't rendering responsively even though this line should make that happen.

What you have here is Smart Quotes (Unicode U+201C), but what you need is single or double quotes (' or "). Can you see how the first ones are slightly angled? You actually probably don't even have the angled quotes key on your keyboard.

This usually happens when you copy and paste code from a blog or something that renders the text differently than how it really should be typed. It's super hard to notice if you're not looking for it.

So this whole line should be:

<metaname="viewport" content="width=device-width, initial-scale=1">

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@suhk@joelstanner