Skip to content

feat: load import map reference in deno config - #3430

Merged
sweatybridge merged 4 commits into
developfrom
im-override
Apr 14, 2025
Merged

feat: load import map reference in deno config#3430
sweatybridge merged 4 commits into
developfrom
im-override

Conversation

@sweatybridge

@sweatybridgesweatybridge commented Apr 13, 2025

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

feature

What is the new behavior?

Addresses #3429

Additional context

Add any other context or screenshots.

@sweatybridge
sweatybridge requested a review from a team as a code ownerApril 13, 2025 18:20
@coveralls

coveralls commented Apr 13, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14432158384

Details

  • 118 of 141(83.69%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 51.023%

Changes Missing CoverageCovered LinesChanged/Added Lines%
pkg/function/deploy.go81266.67%
internal/utils/deno.go31127.27%
pkg/function/deno.go10711890.68%
Files with Coverage ReductionNew Missed Lines%
internal/storage/rm/rm.go289.53%
TotalsCoverage Status
Change from base Build 14417761518:0.07%
Covered Lines:6985
Relevant Lines:13690

💛 - Coveralls

@avalleteavallete left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadpkg/function/deno.go
Comment on lines +155 to +159
// Ignore URLs and directories, assuming no sloppy imports
// https://github.com/denoland/deno/issues/2506#issuecomment-2727635545
if len(path.Ext(mod)) == 0 {
continue
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note

Should we mention this in the Edge-Functions docs ?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup good idea. It's kind of niche feature though.

"github.com/stretchr/testify/require"
)

func TestResolveImports(t *testing.T) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise

Nice to get them all centralized in a single place.

@sweatybridge
sweatybridge merged commit 4b6489e into developApr 14, 2025
@sweatybridge
sweatybridge deleted the im-override branch April 14, 2025 13:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sweatybridge@coveralls@avallete