Skip to content

fix: race condition when deploying from concurrent jobs - #3469

Merged
sweatybridge merged 1 commit into
developfrom
fix-race
Apr 22, 2025
Merged

fix: race condition when deploying from concurrent jobs#3469
sweatybridge merged 1 commit into
developfrom
fix-race

Conversation

@sweatybridge

@sweatybridgesweatybridge commented Apr 21, 2025

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

If two jobs deploy at the same time, one job may see the function slug as new, while the other one sees it as exists.

Adds error handling for POST response so that the next retry will be using PATCH.

Additional context

Add any other context or screenshots.

@sweatybridge
sweatybridge requested a review from a team as a code ownerApril 21, 2025 17:01
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14577579773

Details

  • 1 of 6(16.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 51.164%

Changes Missing CoverageCovered LinesChanged/Added Lines%
pkg/function/batch.go1616.67%
TotalsCoverage Status
Change from base Build 14570424081:-0.008%
Covered Lines:6987
Relevant Lines:13656

💛 - Coveralls

@sweatybridge
sweatybridge merged commit ed28dfa into developApr 22, 2025
@sweatybridge
sweatybridge deleted the fix-race branch April 22, 2025 03:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sweatybridge@coveralls