Skip to content

fix: include scopes from deno.json - #3773

Merged
sweatybridge merged 1 commit into
developfrom
include-scope
Jun 26, 2025
Merged

fix: include scopes from deno.json#3773
sweatybridge merged 1 commit into
developfrom
include-scope

Conversation

@sweatybridge

@sweatybridgesweatybridge commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

supabase/supabase#35021 (comment)

What is the new behavior?

Mount scopes directories when serving and deploying functions.

Additional context

Add any other context or screenshots.

@sweatybridge
sweatybridge requested a review from a team as a code ownerJune 26, 2025 15:04
@coveralls

coveralls commented Jun 26, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15905585012

Details

  • 8 of 16(50.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 55.52%

Changes Missing CoverageCovered LinesChanged/Added Lines%
internal/utils/deno.go81650.0%
Files with Coverage ReductionNew Missed Lines%
internal/gen/keys/keys.go512.9%
TotalsCoverage Status
Change from base Build 15894489336:-0.06%
Covered Lines:6065
Relevant Lines:10924

💛 - Coveralls

@sweatybridge
sweatybridge merged commit 2e8672d into developJun 26, 2025
@sweatybridge
sweatybridge deleted the include-scope branch June 26, 2025 15:13
pullBot pushed a commit to oogalieboogalie/cli that referenced this pull request Aug 24, 2026
## TL;DR
Local Function bundling now mounts the workspace paths declared under an
import map's `scopes`, even when they resolve outside the Supabase
project.
## what's biting the users?
`supabase functions serve`, `supabase start`, and `supabase functions
deploy`
silently dropped `scopes` targets that resolve above the project, so an enclosing Deno workspace never reached the Edge Runtime container
and each Function died with `Relative import path "@acme/thing" ... not
in import map`.
This bites monorepos where the Supabase project is a nested repository
or a submodule, and nothing was logged at any level, so the failure
surfaced as a Deno resolution error rather than a missing mount....
## now fixed by: targets declared under `scopes` that resolve outside the project are
mounted read only, and each surviving mount prints a warning naming the
host path.
Those mounts are excluded from the file watch set, so a mounted
workspace directory cannot become a watch root.
Server side bundling, reached with `--use-api` or when the Docker daemon
is stopped, is unchanged and still does not carry scope targets...
## ref:
- closes: supabase/supabase#35021
- extends: supabase#3773
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sweatybridge@coveralls