Skip to content

Refactor code in menu options#40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
backsoul wants to merge 2 commits into from
Closed

Refactor code in menu options #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42f0b3a
Refactor code in menu options
Jun 30, 2021
f14ff2b
Delete yarn.lock
backsoul Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions src/commands/supabase.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,24 +35,21 @@ export default {
-v, --version Show version number
`)

for (const opt in options) {
if (opt === 'h' || opt === 'help') {
printHelp()
return
}

if (opt === 'v' || opt === 'version') {
info(version())
return
}

// unrecognized opt
const keyNotFound = (opt: string) => {
printHelp()
error(`Unknown or unexpected option: ${opt}.`)
process.exit(1)
}

// options.length === 0
const versionSupa = () => info(version())
for (const opt in options) {
let options_functions: any = {
h: printHelp,
help: printHelp,
version: versionSupa,
v: versionSupa,
}
options_functions[opt] || keyNotFound(opt)

@soedirgosoedirgoJul 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think the options_functions[opt] is missing the call? Also, there should be a return after a valid option.

I think a better alternative without introducing closures is to just switch on opt.

@backsoulbacksoulJul 1, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options functions [opt] if called, if opt does not exist in the options list, pass to the second parameter.

}
printHelp()
},
}