Skip to content

fix: pull changes from managed schemas separately - #4155

Merged
sweatybridge merged 2 commits into
developfrom
fix-pull
Sep 13, 2025
Merged

fix: pull changes from managed schemas separately#4155
sweatybridge merged 2 commits into
developfrom
fix-pull

Conversation

@sweatybridge

@sweatybridgesweatybridge commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bug fix#4068

What is the new behavior?

Using the pgkit/migra implementation, we can reliably pull triggers and policies from managed schemas.

Hence, we can start doing that automatically instead of printing a suggestion.

For user defined schemas, use original migra to avoid revoking permissions.

Additional context

Add any other context or screenshots.

@sweatybridge
sweatybridge requested a review from a team as a code ownerSeptember 12, 2025 16:05
@sweatybridgesweatybridge changed the title fix: pull managed schemas automaticallyfix: prompt to pull managed schemasSep 12, 2025
@sweatybridgesweatybridge changed the title fix: prompt to pull managed schemasfix: prompt to pull changes in managed schemasSep 12, 2025
@sweatybridgesweatybridge changed the title fix: prompt to pull changes in managed schemasfix: pull changes from managed schemas by defaultSep 13, 2025
@sweatybridgesweatybridge changed the title fix: pull changes from managed schemas by defaultfix: pull changes from managed schemas separatelySep 13, 2025
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 17692370276

Details

  • 18 of 63(28.57%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 54.792%

Changes Missing CoverageCovered LinesChanged/Added Lines%
internal/db/pull/pull.go186328.57%
Files with Coverage ReductionNew Missed Lines%
internal/db/pull/pull.go159.52%
internal/gen/keys/keys.go512.9%
TotalsCoverage Status
Change from base Build 17678821493:-0.2%
Covered Lines:6260
Relevant Lines:11425

💛 - Coveralls

@sweatybridge
sweatybridge merged commit 2b4de13 into developSep 13, 2025
11 checks passed
@sweatybridge
sweatybridge deleted the fix-pull branch September 13, 2025 05:37
@github-actionsgithub-actionsBot mentioned this pull request Sep 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing grants in generated migration generated with version 2.33.0 and above (db pull --linked)

2 participants

@sweatybridge@coveralls