Skip to content

fix: allow overriding config after load - #4336

Merged
sweatybridge merged 5 commits into
developfrom
pkg-mod
Oct 21, 2025
Merged

fix: allow overriding config after load#4336
sweatybridge merged 5 commits into
developfrom
pkg-mod

Conversation

@sweatybridge

@sweatybridgesweatybridge commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bug fix#3684 (comment)

What is the new behavior?

Allow library users to override config after loading from file.

Additional context

Add any other context or screenshots.

@sweatybridge
sweatybridge requested a review from a team as a code ownerOctober 21, 2025 12:31
@coveralls

coveralls commented Oct 21, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 18685816705

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 54.579%

Files with Coverage ReductionNew Missed Lines%
internal/storage/rm/rm.go280.61%
internal/gen/keys/keys.go512.9%
TotalsCoverage Status
Change from base Build 18675400641:-0.03%
Covered Lines:6389
Relevant Lines:11706

💛 - Coveralls

@sweatybridgesweatybridge changed the title fix: allow defining empty env varfix: ignore missing ssl paths errorOct 21, 2025
@sweatybridgesweatybridge changed the title fix: ignore missing ssl paths errorfix: allow overriding config after loadOct 21, 2025
@sweatybridge
sweatybridge merged commit 886a008 into developOct 21, 2025
11 checks passed
@sweatybridge
sweatybridge deleted the pkg-mod branch October 21, 2025 13:45
@github-actionsgithub-actionsBot mentioned this pull request Oct 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to provide custom self signed certificates

2 participants

@sweatybridge@coveralls