') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix: add StartPeriod to storage container health check by zlotnika · Pull Request #4956 · supabase/cli · GitHub
Skip to content

fix: add StartPeriod to storage container health check - #4956

Closed
zlotnika wants to merge 1 commit into
supabase:developfrom
zlotnika:fix/storage-healthcheck-start-period
Closed

fix: add StartPeriod to storage container health check#4956
zlotnika wants to merge 1 commit into
supabase:developfrom
zlotnika:fix/storage-healthcheck-start-period

Conversation

@zlotnika

@zlotnikazlotnika commented Mar 15, 2026

Copy link
Copy Markdown

Summary

Fixes#4941

  • Adds StartPeriod: 10 * time.Second to the storage container's Docker health check config

Why

Storage-api v1.41.8 (bumped in #4935) added a DB connection pool monitor (startMonitor) that can delay readiness on startup. Without a StartPeriod, Docker begins counting health check failures immediately from container start. With 10s intervals and 3 retries, the container can be marked unhealthy within ~30s — before the pool monitor finishes initializing. This causes ~50% failure rate on ARM CI runners.

How

StartPeriod tells Docker to ignore health check failures during the initial grace window. This is the same pattern already used by Logflare and Mailpit containers in this codebase. During the 10s start period, failed health checks don't count toward the retry limit, giving storage time to fully initialize before Docker starts tracking failures.

@zlotnika
fix: add StartPeriod to storage health check to prevent intermittent …
7c99dd1
…failures
Storage-api v1.41.8 added a DB connection pool monitor that can delay
readiness on startup. Without a StartPeriod, Docker begins counting
health check failures immediately, causing the container to be marked
unhealthy before it has time to fully initialize (~50% failure rate on
ARM CI runners).
Adding StartPeriod: 10s gives the storage container a grace window
before Docker starts counting failures, matching the pattern already
used by Logflare and Mailpit containers.
Fixessupabase#4941
@zlotnika
zlotnika requested a review from a team as a code ownerMarch 15, 2026 17:27
@coveralls

coveralls commented Mar 15, 2026

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 23115482145

Details

  • 4 of 4(100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 61.716%
Files with Coverage ReductionNew Missed Lines%
internal/storage/rm/rm.go280.61%
internal/utils/git.go557.14%
TotalsCoverage Status
Change from base Build 23067059123:-0.02%
Covered Lines:7720
Relevant Lines:12509
💛 - Coveralls

@avallete

avallete commented Mar 16, 2026

Copy link
Copy Markdown
Member

CF: #4941 (comment)

Closing for now.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

storage container unhealthy after v2.77.0 (storage-api v1.41.8)

3 participants

@zlotnika@coveralls@avallete