Skip to content

fix(cli): drop redundant identify from identity stitch#5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgoux merged 3 commits into from
Jun 1, 2026
Merged

fix(cli): drop redundant identify from identity stitch #5396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c691ac5
fix(cli): drop redundant identify from identity stitch
seanoliver May 29, 2026
a1dfc31
test(cli): align Go login stitch expectations
jgoux Jun 1, 2026
373c56b
Merge branch 'develop' into sean/growth-890-drop-redundant-identifydi…
jgoux Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/cli-go/internal/login/login_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -170,8 +170,7 @@ func TestLoginTelemetryStitching(t *testing.T) {
require.NoError(t, err)
require.Len(t, analytics.aliases, 1)
assert.Equal(t, "user-123", analytics.aliases[0].distinctID)
require.Len(t, analytics.identifies, 1)
assert.Equal(t, "user-123", analytics.identifies[0].distinctID)
assert.Empty(t, analytics.identifies)
require.Len(t, analytics.captures, 1)
assert.Equal(t, phtelemetry.EventLoginCompleted, analytics.captures[0].event)
assert.Equal(t, "user-123", analytics.captures[0].distinctID)
Expand DownExpand Up@@ -211,6 +210,9 @@ func TestLoginTelemetryStitching(t *testing.T) {
})

require.NoError(t, err)
require.Len(t, analytics.aliases, 1)
assert.Equal(t, "user-456", analytics.aliases[0].distinctID)
assert.Empty(t, analytics.identifies)
require.Len(t, analytics.captures, 1)
assert.Equal(t, "user-456", analytics.captures[0].distinctID)
})
Expand Down
3 changes: 0 additions & 3 deletions apps/cli-go/internal/telemetry/service.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,9 +137,6 @@ func (s *Service) StitchLogin(distinctID string) error {
if err := s.analytics.Alias(distinctID, s.state.DeviceID); err != nil {
return err
}
if err := s.analytics.Identify(distinctID, nil); err != nil {
return err
}
}
s.state.DistinctID = distinctID
return SaveState(s.state, s.fsys)
Expand Down
3 changes: 1 addition & 2 deletions apps/cli-go/internal/telemetry/service_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,8 +151,7 @@ func TestServiceStitchLoginPersistsDistinctID(t *testing.T) {
require.Len(t, analytics.aliases, 1)
assert.Equal(t, "user-123", analytics.aliases[0].distinctID)
assert.Equal(t, deviceID, analytics.aliases[0].alias)
require.Len(t, analytics.identifies, 1)
assert.Equal(t, "user-123", analytics.identifies[0].distinctID)
assert.Empty(t, analytics.identifies)
require.Len(t, analytics.captures, 1)
assert.Equal(t, "user-123", analytics.captures[0].distinctID)

Expand Down
1 change: 0 additions & 1 deletion apps/cli/src/legacy/auth/legacy-platform-api.layer.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,6 @@ const makeLegacyPlatformApiServices = Effect.gen(function* () {
stitchAttempted = true;

yield* analytics.alias(gotrueId, runtime.deviceId);
yield* analytics.identify(gotrueId);

const state: LegacyTelemetryState = {
enabled,
Expand Down
4 changes: 2 additions & 2 deletions apps/cli/src/legacy/auth/legacy-platform-api.layer.unit.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -296,7 +296,7 @@ describe("legacyPlatformApiLayer", () => {
yield* api.v1.listAllProjects();

expect(analytics.aliases).toEqual([{ distinctId: "user-123", alias: "device-123" }]);
expect(analytics.identifies).toEqual([{ distinctId: "user-123", properties: {} }]);
expect(analytics.identifies).toEqual([]);
const telemetry = readTelemetryConfig(configDir);
expect(telemetry.distinct_id).toBe("user-123");
expect(telemetry.enabled).toBe(true);
Expand DownExpand Up@@ -374,7 +374,7 @@ describe("legacyPlatformApiLayer", () => {
yield* api.v1.listAllProjects();

expect(analytics.aliases).toEqual([{ distinctId: "user-123", alias: "device-123" }]);
expect(analytics.identifies).toEqual([{ distinctId: "user-123", properties: {} }]);
expect(analytics.identifies).toEqual([]);
expect(readTelemetryConfig(configDir).distinct_id).toBe("user-123");
} finally {
rmSync(configDir, { recursive: true, force: true });
Expand Down
Loading