Uh oh!
There was an error while loading. Please reload this page.
feat(cli): port gen signing-key - #5501
Merged
Merged
Conversation
- Display the project-relative config path (Go's utils.ConfigPath) in the setup hint instead of the resolved absolute path. - Load and validate the signing-keys config before generating a key, matching Go's fail-fast order (no throwaway crypto on a broken config). - Drop the textOutputLayer bypass in confirmOverwrite; a json/stream-json NonInteractiveError now cleanly cancels the overwrite via orElseSucceed, preserving the CLI-1546 stdout-payload contract. - Pass '--' to 'git check-ignore' so a path beginning with '-' is never parsed as a flag. - Use Effect.fnUntraced for internal helpers; inline the vacuous isStoredSigningKeyJwk guard. - Tests: mock ChildProcessSpawner for the gitignore branch instead of spawning real git; merge setup/setupTracked; add RS256 JWK-field, malformed-config, non-array key file, and absolute signing_keys_path coverage.
Coly010
approved these changes
Jun 8, 2026
Uh oh!
There was an error while loading. Please reload this page.
mxcl pushed a commit
to automic-vault/supabase-cli
that referenced
this pull request
Jun 11, 2026
## TL;DR ports `supabase gen signing-key` to ts ## whats introduced This adds a native ts implementation for `supabase gen signing-key` preserves the existing behavior for `--algorithm` and `--append`, generates JWK signing keys, loads `auth.signing_keys_path` from `supabase/config.toml`, resolves the configured path the same way as go did, handles overwrite vs append flows, writes the signing keys file directly, keeps the existing stdout/stderr split so the generated key stays shell friendly also added integration coverage... ## ref: closes CLI-1311 --------- Co-authored-by: Colum Ferry <cferry09@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
ports
supabase gen signing-keyto tswhats introduced
This adds a native ts implementation for
supabase gen signing-keypreserves the existing behavior for
--algorithmand--append,generates JWK signing keys, loads
auth.signing_keys_pathfromsupabase/config.toml,resolves the configured path the same way as go did, handles overwrite vs append flows,
writes the signing keys file directly, keeps the existing stdout/stderr split so the generated key stays shell friendly
also added integration coverage...
ref:
closes CLI-1311