fix(process-compose): make unhealthy lifecycle terminal by jgoux · Pull Request #6080 · supabase/cli

jgoux · 2026-08-05T12:57:24Z

Summary

Health-check failures before first readiness were not reported, and exhausted unhealthy restart budgets left services non-terminal with stale process metadata. Hook failures could also publish Failed while their child remained active.

This change centralizes restart decisions, separates startup and liveness thresholds, and makes supervisory health termination explicit. Terminal states clear the PID, health exhaustion retains no fabricated exit code, and hook failures finalize their child before state publication.

Stack services now use explicit cold-start budgets. State contracts are covered through raw orchestration, stack projection, daemon transport, and dashboard fixtures, with cold-start coverage for PostgreSQL, Edge Runtime, and Analytics.

This PR is stacked on #6078, which provides the architecture documentation baseline.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:b2943a01a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-08-05T17:00:38Z

Supabase CLI preview

npx --yes https://pkg.pr.new/supabase/cli/supabase@eeac2a068c00cef31335b8f5976ee990bba1f39b

Preview package for commit eeac2a0.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d6dd4dd11d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:8e2ed7639a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d24cdb90dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:f1ade49a28

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:48a6057850

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c9de546136

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:db7d0157fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:af6c0275a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jgoux · 2026-08-06T12:32:31Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:5a298f1834

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:f2758593e8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:267de27ae0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

## Summary - Generalize detached orphan cleanup to validated, shell-free command and path actions. - Make lifecycle transition classification event-exhaustive and move ordered restart closure traversal into a pure module. - Remove confirmed dead error and log-buffer surface while documenting the supervisor entry and one-shot polling contracts. ## Why The process supervisor should remain domain-neutral and keep policy decisions independently testable without changing the lifecycle semantics established by the preceding work. Depends on supabase#6080 and transitively on supabase#6078.

## What changed - replaces the duplicate lifecycle coordinator tag and pass-through facade with one scoped local stack implementation that provides both the public stack and narrow activation interfaces - centralizes readiness policy enforcement across startup, activation, lifecycle operations, explicit waits, Promise calls, and daemon transport - adds typed readiness deadline failures with terminal scoped cleanup and daemon shutdown - validates readiness overrides over POST transport and documents the shared foreground/detached behavior - removes dead cleanup-query surface and uses structural Effect equality for projected state deduplication ## Why Lifecycle state previously had redundant interface layers and readiness deadlines were enforced only by the Promise adapter. Keeping policy and cleanup inside the single runtime owner makes every adapter observe the same semantics and prevents a timed-out runtime from relaunching resources after cleanup. Depends on supabase#6081 and supabase#6080 (and transitively supabase#6078).

## What changed - makes StackBuilder the sole owner of dependency topology and passes explicit dependencies into every service factory, including the native-initialization versus Docker-readiness choice for PostgREST - moves Docker network and port argument construction into service factories and migrates PostgreSQL, Auth, and PostgREST onto the common Docker definition helper - centralizes container identity so launch, exact cleanup, orphan cleanup, and catalog-derived candidate cleanup use the same naming source - captures exact build-produced cleanup targets before persistence and orchestrator setup, and disposes already-started resources after any partial startup failure - expands semantic service-definition coverage and documents the exact-versus-candidate cleanup model ## Why Service construction and resource identity were split across the builder, individual factories, and fallback cleanup code. Keeping topology in the builder while concentrating executable details and Docker identity in factories makes service definitions easier to change safely, prevents launch and cleanup names from drifting, and ensures failed startup cannot leave an earlier service running. Depends on supabase#6085 and supabase#6084 (and transitively supabase#6081, supabase#6080, and supabase#6078).

Verified every bullet against the actual v2.111.0..v2.112.0 tree diff (the range came from a rebased develop rollup, so commit subjects alone were misleading) and applied the Codex review feedback: - Drop #6072 and #6080: packages/next-only, not in the stable shell - Drop #6003 and #6057: the stable CLI does not exercise the stack binary cache; #6057's "rollup" was the develop->main rollup PR, not the Rollup bundler - Add breaking-change section for NPM_AUTH_TOKEN no longer being forwarded by functions deploy (#6005, ships in this tag) - Note the one-time stop/start needed for already-stuck stacks (#6093) - Scope #5956 to functions download path traversal - Point db pull --experimental users at --declarative (#6028) - Fix#6065 and #6066 descriptions to match the shipped changes - Recount the internal tail (33 uncited commits in the compare range) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018h8krKpNet85649nqtj95b

jgoux added 2 commits August 5, 2026 14:32

docs(stack): align runtime architecture documentation
95db7ba

fix(process-compose): make unhealthy lifecycle terminal
b2943a0

This was referenced Aug 5, 2026
refactor(process-compose): isolate supervisor policies #6084
Merged
refactor(stack): consolidate local lifecycle ownership #6085
Merged

jgoux marked this pull request as ready for review August 5, 2026 13:55

jgoux requested a review from a team as a code owner August 5, 2026 13:55

jgoux mentioned this pull request Aug 5, 2026
refactor(stack): restore service factory locality #6086
Merged

chatgpt-codex-connectorBot reviewed Aug 5, 2026
View reviewed changes

Comment threadpackages/process-compose/src/Orchestrator.ts Outdated
Comment threadpackages/process-compose/src/ServiceTransition.ts
Comment threadpackages/stack/tests/createStack-docker.e2e.test.ts Outdated

Base automatically changed from agent/architecture-docs-baseline to developAugust 5, 2026 16:02

chore(process-compose): merge current develop
d6dd4dd

chatgpt-codex-connectorBot reviewed Aug 5, 2026
View reviewed changes

Comment threadpackages/stack/tests/createStack-docker.e2e.test.ts

fix(process-compose): handle terminal health failures
8e2ed76

chatgpt-codex-connectorBot reviewed Aug 5, 2026
View reviewed changes

Comment threadpackages/process-compose/src/Orchestrator.ts
Comment threadpackages/stack/tests/createStack-docker.e2e.test.ts

fix(process-compose): surface recovery hook failures
d24cdb9

chatgpt-codex-connectorBot reviewed Aug 5, 2026
View reviewed changes

Comment threadpackages/process-compose/src/Orchestrator.ts

fix(process-compose): fail blocked healthy dependents
f1ade49

chatgpt-codex-connectorBot reviewed Aug 5, 2026
View reviewed changes

Comment threadpackages/process-compose/src/Orchestrator.ts Outdated
Comment threadpackages/stack/src/services/health-budgets.ts

jgoux added 2 commits August 5, 2026 21:31

fix(process-compose): await restartable dependencies
42c775c

fix(stack): synchronize status after readiness
48a6057

chatgpt-codex-connectorBot reviewed Aug 5, 2026
View reviewed changes

Comment threadpackages/stack/src/services/health-budgets.ts
Comment threadpackages/stack/src/ApiProxy.ts Outdated

fix(stack): derive startup coordination timeouts
c9de546

chatgpt-codex-connectorBot reviewed Aug 5, 2026
View reviewed changes

Comment threadpackages/stack/src/services/health-budgets.ts Outdated
Comment threadpackages/stack/tests/createStack-docker.e2e.test.ts Outdated
Comment threadpackages/stack/src/services/health-budgets.ts Outdated

jgoux added 2 commits August 6, 2026 10:37

fix(stack): align startup budget deadlines
a14d408

fix(process-compose): await restarting completed dependencies
db7d015

chatgpt-codex-connectorBot reviewed Aug 6, 2026
View reviewed changes

Comment threadpackages/stack/src/services/health-budgets.ts

fix(stack): align dependent startup deadlines
af6c027

chatgpt-codex-connectorBot reviewed Aug 6, 2026
View reviewed changes

Comment threadpackages/stack/tests/createStack-docker.e2e.test.ts

test(stack): align Docker setup timeout
5a298f1

Coly010 approved these changes Aug 6, 2026
View reviewed changes

chatgpt-codex-connectorBot reviewed Aug 6, 2026
View reviewed changes

Comment threadpackages/stack/src/services/health-budgets.ts
Comment threadpackages/process-compose/src/Orchestrator.ts Outdated
Comment threadpackages/stack/src/StackLifecycleCoordinator.ts Outdated

jgoux added 2 commits August 6, 2026 14:48

fix(process-compose): preserve active restart policy
e089d7d

fix(stack): serialize projected state snapshots
f275859

chatgpt-codex-connectorBot reviewed Aug 6, 2026
View reviewed changes

Comment threadpackages/process-compose/src/Orchestrator.ts Outdated
Comment threadpackages/stack/src/StackBuilder.ts Outdated

jgoux added 2 commits August 6, 2026 15:05

fix(process-compose): use active policy for readiness
ed31de0

fix(stack): budget native database initialization
267de27

chatgpt-codex-connectorBot reviewed Aug 6, 2026
View reviewed changes

Comment threadpackages/process-compose/src/Orchestrator.ts
Comment threadpackages/process-compose/src/Orchestrator.ts

fix(process-compose): handle stopped dependencies
eeac2a0

jgoux added this pull request to the merge queue Aug 6, 2026

Merged via the queue into develop with commit 54934f4Aug 6, 2026
28 checks passed

jgoux deleted the agent/process-compose-lifecycle-correctness branch August 6, 2026 13:57

avallete mentioned this pull request Aug 7, 2026
docs(release): notes for v2.112.0 #6114
Closed

Uh oh!

Conversation

jgoux commented Aug 5, 2026

Summary

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Aug 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Supabase CLI preview

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jgoux commented Aug 6, 2026

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

github-actionsBot commented Aug 5, 2026•
edited
Loading