Skip to content

test(stack): stabilize postgres persistence e2e - #6175

Merged
avallete merged 6 commits into
supabase:developfrom
7ttp:test/stack-postgres-container-isolation
Aug 13, 2026
Merged

test(stack): stabilize postgres persistence e2e#6175
avallete merged 6 commits into
supabase:developfrom
7ttp:test/stack-postgres-container-isolation

Conversation

@7ttp

@7ttp7ttp commented Aug 12, 2026

Copy link
Copy Markdown
Member

TL;DR

Stabilize the Postgres persistence e2e by checking only the Docker containers created during native stack startup.

The test previously checked every matching container on the runner. A container left by another test could therefore cause a failure even when native startup used no Docker containers.
Capture matching container IDs before startup and assert that no new IDs appear afterward.
This follows the stack test suite's existing snapshot and diff pattern while preserving Docker startup and data persistence coverage...

ref:

spotted on: https://github.com/supabase/cli/actions/runs/31634963213/job/94242831412

@7ttp
7ttp requested a review from a team as a code ownerAugust 12, 2026 20:26
@7ttp7ttp self-assigned this Aug 12, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:16fb0792ce

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment threadpackages/stack/tests/postgresDataPersistence.e2e.test.ts Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c9791ebbf0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment threadpackages/stack/tests/postgresDataPersistence.e2e.test.ts Outdated
@avallete
avallete added this pull request to the merge queueAug 13, 2026
Merged via the queue into supabase:develop with commit 34a4caaAug 13, 2026
21 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@7ttp@avallete