Skip to content

test: deflake more flaky suites - #6248

Merged
avallete merged 9 commits into
developfrom
7ttp/deflake-fixed-attempt-rebind-budgets
Aug 18, 2026
Merged

test: deflake more flaky suites#6248
avallete merged 9 commits into
developfrom
7ttp/deflake-fixed-attempt-rebind-budgets

Conversation

@7ttp

@7ttp7ttp commented Aug 18, 2026•
edited
Loading

Copy link
Copy Markdown
Member

TL;DR

Replaces every fixed attempt-count retry budget in tests with wall-clock deadlines,
retries managed control acquisition with a fresh workspace when the identity-derived port collides with a concurrent stack's live control server and makes the attempt count as "rule" in AGENTS.md ....

ref:

@7ttp
7ttp requested a review from a team as a code ownerAugust 18, 2026 09:10
@7ttp7ttp self-assigned this Aug 18, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Aug 18, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:51afc77c80

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment threadpackages/stack/src/supervisor.integration.test.ts
Comment threadapps/cli/src/next/commands/functions/dev/functions-dev-runtime.unit.test.ts Outdated
@github-actions

github-actionsBot commented Aug 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Supabase CLI preview

npx --yes https://pkg.pr.new/supabase/cli/supabase@775ff8dcedf4d38c8cba8e3a152e45a8b82b1cec

Preview package for commit 775ff8d.

@chatgpt-codex-connector

chatgpt-codex-connectorBot commented Aug 18, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit:99de620abe

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Aug 18, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:8244d18cbb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment threadpackages/stack/tests/helpers/managed-manager.ts Outdated
@7ttp7ttp changed the title test(stack): deflake attempt-count retry budgetstest: deflake more flaky suitesAug 18, 2026
@7ttp

7ttp commented Aug 18, 2026

Copy link
Copy Markdown
MemberAuthor

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Aug 18, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:92c7c37f9b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment threadapps/cli/src/legacy/commands/functions/serve/serve.integration.test.ts
Comment threadapps/cli/src/next/commands/functions/dev/functions-dev-runtime.unit.test.ts Outdated
Comment threadpackages/stack/src/supervisor.integration.test.ts
Comment threadpackages/stack/src/managed-manager-ports.integration.test.ts
@avallete
avallete added this pull request to the merge queueAug 18, 2026
Merged via the queue into develop with commit bf20385Aug 18, 2026
21 checks passed
@avallete
avallete deleted the 7ttp/deflake-fixed-attempt-rebind-budgets branch August 18, 2026 13:39
@supabase-cli-releasersupabase-cli-releaserBot mentioned this pull request Aug 25, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@avalleteavalleteavallete approved these changes

Assignees

@7ttp7ttp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@7ttp@avallete