Uh oh!
There was an error while loading. Please reload this page.
ci: shard package-local test suites - #6327
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:9d0417ceaa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
…ocal-tests # Conflicts: # CONTRIBUTING.md # nx.json # package.json # packages/api/package.json # packages/cli-test-helpers/package.json # packages/config/package.json # packages/process-compose/package.json
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@58fd79378ca5802df52da51144b6f70e9fd45527Preview package for commit |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:d99065a918
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
jgoux
commented
Aug 25, 2026
@codex review |
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
avallete
left a comment
There was a problem hiding this comment.
LGTM — verified the risky spots and they all check out:
- The 8
@parcel/watcher-*platform packages land indevDependenciesonly; the publishedsupabasepackage still ships justeciesjs+josewithfiles: ["dist/supabase.js"], so no platform-mismatch risk for npm consumers (and this quietly fixes thepnpm buildbreak on missing watcher binaries, including win32 whichsupportedArchitecturesdoesn't cover). - Forwarding
--shard=N/3to every e2e package is safe: all three e2e-owning vitest configs setpassWithNoTests: true(packages/stack only has 4 e2e files). - Dropping the keyring-unlock step from test.yml is correct:
cli-go-ci.ymlkeeps the unlock and itsmerge_grouptrigger has no path filter, so Go tests still gate every merge even when a PR doesn't touchapps/cli-go/. - No test files orphaned by the removed vitest project stanzas (api/config have zero integration/e2e files, process-compose zero e2e), and every package with unit tests declares
test:unit:run. test-summarypreserves the branch-protection check name and mirrors the existingtest-e2e-summaryskipped-handling pattern with identicalifconditions.- No stale
test:core/nx affected/NX_BASEreferences remain.
Two non-blocking comments inline about leftover Nx test-target inference and the dual build orchestrators.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
test:corealias and document explicit unit and integration commands.Context
The first e2e shard previously ran every non-CLI-harness e2e suite unsharded, making it consistently much slower than the other shards. Propagating the same Vitest shard to each package distributes those suites uniformly.
Turbo currently provides only the test task graph and prerequisite ordering. Test caching remains disabled until its inputs and outputs are designed separately.