Uh oh!
There was an error while loading. Please reload this page.
feat(cli): prompt for worker name if not provided - #6349
Open
johnstonmatt wants to merge 2 commits into
Open
Conversation
johnstonmatt
marked this pull request as ready for review
August 27, 2026 01:58
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:12693d1a8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@edc71990a255a0fd188063aa7f1ead65bcb9e998Preview package for commit |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Makes the `name` argument to `supabase workers new` optional and prompts for it when it is omitted, so a bare `supabase workers new` walks through name, runtime and size rather than failing the parse. The name is the one input this command cannot default — it is the directory, the `[workers.<name>]` key and the hostname all at once. So where the runtime and size prompts fall back to a default when there is nowhere to ask, the name prompt has nothing to fall back to: with `-o json|yaml|toml|env` or no interactive terminal, the command fails with a new `MissingWorkerNameError` pointing at `supabase workers new api`. The prompt validates against everything the command would otherwise refuse a moment later — a non-DNS-label name, and a name `config.toml` already records — so a typo is corrected in place instead of ending the run. That also means the project has to be loaded before the first prompt, and the machine-output check moves up with it: `-o` leaves `output.format` as `text`, and Clack writes its terminal UI to stdout, so a name prompt would land in front of the payload for the same reason the runtime prompt would. The handler's inline name validation is replaced by the shared `legacyValidateWorkerName`, which the rest of the command family already uses, so an explicitly-passed name and a prompted one are refused on identical terms. `mockOutput` now records `promptTextCalls` so tests can assert on the prompt's message and exercise its `validate` callback.
johnstonmattforce-pushed
the
FUNC-840/select-workers-new-name
branch
from
August 29, 2026 02:35
fecde22 to
d4e37d5Compare`output.interactive` is derived solely from `tty.stdoutIsTty`, so with stdin piped or redirected and stdout still on a terminal it stayed true. A bare `printf 'api\n' | supabase workers new` therefore opened Clack's name prompt and read the worker name off the pipe instead of taking the documented `MissingWorkerNameError` path — and the runtime and size prompts consumed whatever followed rather than falling back to their defaults. The three resolvers now share one `canPromptFor` decision, made once before the first prompt, which pairs `output.interactive` with `tty.stdinIsTty` the way `workers delete` already guards its confirmation. A prompt is only answerable from a keyboard, so both streams have to be a terminal.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
nameargument tosupabase workers newoptional and prompts for itwhen it is omitted, so a bare
supabase workers newwalks through name, runtimeand size rather than failing the parse.
The name is the one input this command cannot default — it is the directory, the
[workers.<name>]key and the hostname all at once. So where the runtime andsize prompts fall back to a default when there is nowhere to ask, the name
prompt has nothing to fall back to: with
-o json|yaml|toml|envor nointeractive terminal, the command fails with a new
MissingWorkerNameErrorpointing at
supabase workers new api.The prompt validates against everything the command would otherwise refuse a
moment later — a non-DNS-label name, and a name
config.tomlalready records —so a typo is corrected in place instead of ending the run. That also means the
project has to be loaded before the first prompt, and the machine-output check
moves up with it:
-oleavesoutput.formatastext, and Clack writes itsterminal UI to stdout, so a name prompt would land in front of the payload for
the same reason the runtime prompt would.
The handler's inline name validation is replaced by the shared
legacyValidateWorkerName, which the rest of the command family already uses,so an explicitly-passed name and a prompted one are refused on identical terms.
mockOutputnow recordspromptTextCallsso tests can assert on the prompt'smessage and exercise its
validatecallback.Stack 5, on top of
workers list/status/delete(#6263).Linked issue
FUNC-840 (Linear). Supabase maintainer, exempt from the
open-for-contributionflow.Checklist