Uh oh!
There was an error while loading. Please reload this page.
fix: clear stale heartbeat state on reconnect - #53
Open
AyobamiH wants to merge 1 commit into
Open
Conversation
AyobamiH
marked this pull request as ready for review
August 23, 2026 11:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Phoenix-side cause of supabase/supabase-js#2625.
onConnOpen() now clears pendingHeartbeatRef and heartbeatSentAt on every successful connection open, regardless of autoSendHeartbeat. Timer scheduling remains gated behind autoSendHeartbeat, so worker-mode clients can continue driving heartbeats externally without inheriting stale heartbeat state from the previous socket.
Includes a regression test for autoSendHeartbeat: false that seeds stale heartbeat state and verifies it is cleared on open without starting the automatic heartbeat timer.