Uh oh!
There was an error while loading. Please reload this page.
fix: harden oauth-protected-resource header and URL edge cases - #131
Merged
Conversation
commit: |
spydon
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final bug sweep of
src/oauth-protected-resource/, fixing the three edge cases from the #113 review that survived the #116/#117 rewrites. Advertised URLs now percent-encode"and\so a hostileX-Forwarded-Hostor configuredresourceServercannot break out of theWWW-Authenticatequoted-string; 401 enrichment sets the header in place with a copy fallback, so responses with immutable headers (fetch-proxied) or already-consumed bodies no longer throw and.url/.redirectedsurvive; and the Edge Functions derivation throwsMISSING_RESOURCE_SERVERon a root path with no function segment instead of silently advertising a bare/functions/v1. The other two deferred cases (local prefix inference, trailing-slash 404) were already resolved by the rewrites and stay covered by existing tests.