fix: optimize insertions in building when lists = 1 - #106
Conversation
Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
usamoi
commented
Nov 21, 2024
kemingy
commented
Nov 21, 2024
If you change the toolchain version, you may need to update the image. I'll create a CI to push the image to GitHub packages so developers can trigger the CI to update the image. |
usamoi
commented
Nov 21, 2024
Why do we need to update the image? Why not add targets when image is used? |
kemingy
commented
Nov 21, 2024
Adding targets later means you need to do it for every docker image run. Updating the version is not a highly frequent operation. |
usamoi
commented
Nov 21, 2024
I think adding a target takes less than one second on Github actions and downloading the docker image takes more than one. If we want it to be faster, we should remove docker for first. |
kemingy
commented
Nov 21, 2024
Adding targets costs about 17.8s in GitHub CI. Downloading the whole image is about 53s for now, almost the same as downloading from Docker Hub. |
usamoi
commented
Nov 21, 2024
Signed-off-by: usamoi <usamoi@outlook.com> Co-authored-by: Keming <kemingy94@gmail.com>
pick supervc-stack#106, supervc-stack#147 and supervc-stack#149 to vchordrqfscan Signed-off-by: usamoi <usamoi@outlook.com>

No description provided.