Skip to content

fix: optimize insertions in building when lists = 1 - #106

Merged
usamoi merged 4 commits into
supervc-stack:mainfrom
usamoi:fast-forward
Nov 21, 2024
Merged

fix: optimize insertions in building when lists = 1#106
usamoi merged 4 commits into
supervc-stack:mainfrom
usamoi:fast-forward

Conversation

@usamoi

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
@usamoi

Copy link
Copy Markdown
ContributorAuthor

@kemingy

Copy link
Copy Markdown
Contributor

If you change the toolchain version, you may need to update the image. I'll create a CI to push the image to GitHub packages so developers can trigger the CI to update the image.

@usamoi

Copy link
Copy Markdown
ContributorAuthor

If you change the toolchain version, you may need to update the image. I'll create a CI to push the image to GitHub packages so developers can trigger the CI to update the image.

Why do we need to update the image? Why not add targets when image is used?

@kemingy

Copy link
Copy Markdown
Contributor

If you change the toolchain version, you may need to update the image. I'll create a CI to push the image to GitHub packages so developers can trigger the CI to update the image.

Why do we need to update the image? Why not add targets when image is used?

Adding targets later means you need to do it for every docker image run. Updating the version is not a highly frequent operation.

@usamoi

Copy link
Copy Markdown
ContributorAuthor

If you change the toolchain version, you may need to update the image. I'll create a CI to push the image to GitHub packages so developers can trigger the CI to update the image.

Why do we need to update the image? Why not add targets when image is used?

Adding targets later means you need to do it for every docker image run. Updating the version is not a highly frequent operation.

I think adding a target takes less than one second on Github actions and downloading the docker image takes more than one. If we want it to be faster, we should remove docker for first.

@kemingy

Copy link
Copy Markdown
Contributor

Adding targets costs about 17.8s in GitHub CI. Downloading the whole image is about 53s for now, almost the same as downloading from Docker Hub. I thought accessing ghcr should be much faster.

@usamoi

Copy link
Copy Markdown
ContributorAuthor

Adding targets costs about 17.8s in GitHub CI.

Screenshot_20241121_204825

Their servers must be on the moon or Mars. It takes only 4 seconds even on my machine.

@usamoi
usamoi merged commit c4ac1c0 into supervc-stack:mainNov 21, 2024
@usamoi
usamoi deleted the fast-forward branch November 21, 2024 12:52
usamoi added a commit that referenced this pull request Jan 8, 2025
pick #106, #147 and #149 to vchordrqfscan
Signed-off-by: usamoi <usamoi@outlook.com>
spenc-r pushed a commit to spenc-r/VectorChord that referenced this pull request May 22, 2026
Signed-off-by: usamoi <usamoi@outlook.com>
Co-authored-by: Keming <kemingy94@gmail.com>
spenc-r pushed a commit to spenc-r/VectorChord that referenced this pull request May 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@usamoi@kemingy