fix: reserve capacity - #176
Closed
usamoi wants to merge 1 commit into
Closed
Conversation
usamoiforce-pushed
the
with-cap
branch
2 times, most recently
from
February 8, 2025 07:44
caa9cc1 to
995300bCompareusamoi
commented
Feb 8, 2025
ContributorAuthor
Why CI does not run? |
Signed-off-by: usamoi <usamoi@outlook.com>
ContributorAuthor
Tests show it's a debuff (33% slower). |
VoVAllen
commented
Feb 8, 2025
Contributor
I don't understand why reserve capacity for vec will degrade the performance |
usamoi
commented
Feb 8, 2025
ContributorAuthor
To know exact capacity, the process save it in a vector when scanning and make heap on it. The vector becomes bigger since the elements become bigger. It's unfriendly to cache. |
VoVAllen
commented
Feb 8, 2025
Contributor
We don't need exact size I think. Just some estimation should work? |
VoVAllen
commented
Feb 8, 2025
Contributor
Our target is just to reduce the number of resizing not really eliminate it |
usamoi
commented
Feb 8, 2025
ContributorAuthor
replaced by #182 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.