Fix orchestrator ship order: record completion before open-pr - #82
Merged
Conversation
Phase 7 of the orchestrator skill called open-pr (commit + push) before updating loops.md/PRD checkbox/decisions.md. open-pr only commits work that's uncommitted when it runs, so those completion writes landed after the push with no commit left to carry them — a dirty working tree post-ship. Reorder: record completion in .loopdeck/ first, then invoke open-pr so its commit step sweeps the memory writes in along with the code.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loopdeck:open-pr(commit + push) before the.loopdeck/completion writes (loops.md move-to-History, PRD checkbox, decisions.md), leaving those edits stranded and uncommitted after push.open-pris invoked — its commit step sweeps up whatever is uncommitted at that moment, so the memory writes ride the same shipped commit as the code.What changed
.agents/skills/loopdeck-orchestrator/SKILL.md— Phase 7 verdict table, the "Open PR" section (renamed "Record completion, then open PR"), the Memory Convention paragraph, and a new Important Rules bullet, all reordered/clarified to record-before-ship.templates/skills/loopdeck-orchestrator/SKILL.md— mirrored identically (this is the distributed copy for other projects; it was byte-identical to the source before this change).Why
User reported the working directory ends up dirty after a shipped loop: PRD/loops.md/execution.yaml completion marks were happening after commit+push, with no further commit to carry them.
Test plan
.loopdeck/loops.md/decisions.md/PRD checkbox updates land in the same commitopen-prpushes, leaving a clean tree after ship.