feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare - #13634

Merged
teemingc merged 24 commits into
mainfrom
merge-cloudflare-adapters
Apr 2, 2025
Merged

feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare#13634
teemingc merged 24 commits into
mainfrom
merge-cloudflare-adapters

Conversation

@teemingc

@teemingcteemingc commented Mar 24, 2025•
edited
Loading

Copy link
Copy Markdown
Member

an alternative that closes#13427

closes#13360
closes#13071
closes#13005
closes#12813
closes#13579
closes#10924

This PR adds a deprecation notice to the adapter-cloudflare-workers docs while adding support for Cloudflare Workers Static Assets by skipping Cloudflare Pages-specific build steps and respecting Wrangler configuration settings if building for Cloudflare Workers Static Assets.

We use a heuristic to guess whether we're building for Cloudflare Pages or Workers based on the Wrangler configuration file settings, but even if there is no Wrangler configuration file, the build output is compatible with both platforms.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-botBot commented Mar 24, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 49d28e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@sveltejs/adapter-cloudflareMajor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

svelte-docs-botBot commented Mar 24, 2025

Copy link
Copy Markdown

Preview: https://svelte-dev-git-preview-kit-13634-svelte.vercel.app/

@teemingc
teemingc requested a review from benmccannMarch 24, 2025 10:42
benmccann
benmccann reviewed Mar 24, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/index.d.ts Outdated
benmccann
benmccann reviewed Mar 24, 2025
View reviewed changes
Comment thread.changeset/kind-carrots-deliver.md Outdated
@teemingcteemingc mentioned this pull request Mar 25, 2025
Closed
6 tasks
dario-piotrowicz
dario-piotrowicz reviewed Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/ambient.d.ts Outdated
benmccann
benmccann reviewed Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/package.json Outdated
benmccann
benmccann reviewed Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/src/worker.js Outdated
dario-piotrowicz
dario-piotrowicz reviewed Mar 25, 2025
View reviewed changes

@dario-piotrowiczdario-piotrowicz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I love seeing a single adapter that chooses workers or pages for you based on the config file! 🫶

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md Outdated
Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Comment threadpackages/adapter-cloudflare/index.js Outdated
Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md Outdated
teemingcand others added 2 commits March 26, 2025 09:54
@teemingc@benmccann
Update packages/adapter-cloudflare/src/worker.js
5da476c
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Chew Tee Ming
changes according to feedback
3e1fb1b
@teemingc

teemingc commented Mar 26, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Thanks for the feedback guys. I've updated the docs and also bumped the minimum Wrangler version to v4. I've also updated the fallback option to work with Cloudflare Workers if the user has configured the assets 404-handling option.

EDIT: I've also added some simple tests to check that the build output is successful and works with the pages/workers dev environment provided by wrangler.

@teemingc
teemingc merged commit ebec1e9 into mainApr 2, 2025
@teemingc
teemingc deleted the merge-cloudflare-adapters branch April 2, 2025 02:26
@github-actionsgithub-actionsBot mentioned this pull request Apr 2, 2025
Merged
This was referenced Apr 2, 2025
Merged
Closed
@WarningImHack3rWarningImHack3r mentioned this pull request May 10, 2025
Merged
4 tasks
CopilotAI pushed a commit to Stadly/kit that referenced this pull request Mar 6, 2026
@teemingc@benmccann
feat: deprecate adapter-cloudflare-workers in favour of `adapter-cl…
942465c
…oudflare` (sveltejs#13634)
* merge adapters
* changeset
* it's valid to not specify a main entry if the user is only deploying static assets
* format
* adjust docs
* also use cf pages env var
* fix migration guide link
* try to fix doc build error
* Update index.d.ts
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update kind-carrots-deliver.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* validate assets key if main key is set
* delete adapter-cloudflare-workers
* adjust docs and workspace for removing cloudflare workers
* fix docs title
* clarify _routes.json belongs to cloudflare pages
* Update packages/adapter-cloudflare/src/worker.js
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* changes according to feedback
* revert type change
* fix lock file
* fixes
* tests
* fix lockfile
* format
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benmccannbenmccannbenmccann approved these changes
+1 more reviewer
@dario-piotrowiczdario-piotrowiczdario-piotrowicz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pkg:adapter-cloudflare

Projects

None yet

Milestone

No milestone

3 participants

@teemingc@benmccann@dario-piotrowicz
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare - #13634
Merged
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Apr 2, 2025
Merged
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare#13634
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Conversation
@teemingc
@teemingcteemingc
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

Member
an alternative that closes#13427
closes#13360
closes#13071
closes#13005
closes#12813
closes#13579
closes#10924
This PR adds a deprecation notice to the adapter-cloudflare-workers docs while adding support for Cloudflare Workers Static Assets by skipping Cloudflare Pages-specific build steps and respecting Wrangler configuration settings if building for Cloudflare Workers Static Assets.
We use a heuristic to guess whether we're building for Cloudflare Pages or Workers based on the Wrangler configuration file settings, but even if there is no Wrangler configuration file, the build output is compatible with both platforms.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
  •  It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  •  This message body should clearly illustrate what problems it solves.
  •  Ideally, include a test that fails without this PR but passes with it.
Tests
  •  Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
Changesets
  •  If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.
Edits
  •  Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
@changeset-bot
changeset-botBot
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 49d28e8
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@sveltejs/adapter-cloudflareMajor
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@svelte-docs-bot
svelte-docs-botBot
commented
Mar 24, 2025

Copy link


Copy Markdown

Preview: https://svelte-dev-git-preview-kit-13634-svelte.vercel.app/
@teemingc
teemingc
requested a review
from benmccannMarch 24, 2025 10:42
benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/index.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment thread.changeset/kind-carrots-deliver.md
Outdated

@teemingcteemingc
mentioned this pull request
Mar 25, 2025
 Closed

6 tasks
dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/ambient.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/package.json
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/src/worker.js
Outdated

dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
@dario-piotrowiczdario-piotrowicz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I love seeing a single adapter that chooses workers or pages for you based on the config file! 🫶
Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Comment threadpackages/adapter-cloudflare/index.js
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

teemingcand others
added 2 commits
March 26, 2025 09:54
@teemingc@benmccann
Update packages/adapter-cloudflare/src/worker.js
5da476c
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Chew Tee Ming
changes according to feedback
3e1fb1b
@teemingc
teemingc
commented
Mar 26, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the feedback guys. I've updated the docs and also bumped the minimum Wrangler version to v4. I've also updated the fallback option to work with Cloudflare Workers if the user has configured the assets 404-handling option.
EDIT: I've also added some simple tests to check that the build output is successful and works with the pages/workers dev environment provided by wrangler.
@teemingc
teemingc
merged commit ebec1e9
into
mainApr 2, 2025
@teemingc
teemingc
deleted the

merge-cloudflare-adapters

branch
April 2, 2025 02:26
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 2, 2025
 Merged


This was referenced Apr 2, 2025
 Merged

 Closed

@WarningImHack3rWarningImHack3r
mentioned this pull request
May 10, 2025
 Merged

4 tasks
CopilotAI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
@teemingc@benmccann
feat: deprecate adapter-cloudflare-workers in favour of `adapter-cl…
942465c
…oudflare` (sveltejs#13634)
* merge adapters
* changeset
* it's valid to not specify a main entry if the user is only deploying static assets
* format
* adjust docs
* also use cf pages env var
* fix migration guide link
* try to fix doc build error
* Update index.d.ts
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update kind-carrots-deliver.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* validate assets key if main key is set
* delete adapter-cloudflare-workers
* adjust docs and workspace for removing cloudflare workers
* fix docs title
* clarify _routes.json belongs to cloudflare pages
* Update packages/adapter-cloudflare/src/worker.js
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* changes according to feedback
* revert type change
* fix lock file
* fixes
* tests
* fix lockfile
* format
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benmccannbenmccannbenmccann approved these changes

+1 more reviewer

@dario-piotrowiczdario-piotrowiczdario-piotrowicz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

pkg:adapter-cloudflare

Projects


None yet


Milestone


No milestone


3 participants

@teemingc@benmccann@dario-piotrowicz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare - #13634
Merged
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Apr 2, 2025
Merged
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare#13634
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Conversation
@teemingc
@teemingcteemingc
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

Member
an alternative that closes#13427
closes#13360
closes#13071
closes#13005
closes#12813
closes#13579
closes#10924
This PR adds a deprecation notice to the adapter-cloudflare-workers docs while adding support for Cloudflare Workers Static Assets by skipping Cloudflare Pages-specific build steps and respecting Wrangler configuration settings if building for Cloudflare Workers Static Assets.
We use a heuristic to guess whether we're building for Cloudflare Pages or Workers based on the Wrangler configuration file settings, but even if there is no Wrangler configuration file, the build output is compatible with both platforms.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
  •  It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  •  This message body should clearly illustrate what problems it solves.
  •  Ideally, include a test that fails without this PR but passes with it.
Tests
  •  Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
Changesets
  •  If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.
Edits
  •  Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
@changeset-bot
changeset-botBot
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 49d28e8
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@sveltejs/adapter-cloudflareMajor
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@svelte-docs-bot
svelte-docs-botBot
commented
Mar 24, 2025

Copy link


Copy Markdown

Preview: https://svelte-dev-git-preview-kit-13634-svelte.vercel.app/
@teemingc
teemingc
requested a review
from benmccannMarch 24, 2025 10:42
benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/index.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment thread.changeset/kind-carrots-deliver.md
Outdated

@teemingcteemingc
mentioned this pull request
Mar 25, 2025
 Closed

6 tasks
dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/ambient.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/package.json
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/src/worker.js
Outdated

dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
@dario-piotrowiczdario-piotrowicz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I love seeing a single adapter that chooses workers or pages for you based on the config file! 🫶
Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Comment threadpackages/adapter-cloudflare/index.js
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

teemingcand others
added 2 commits
March 26, 2025 09:54
@teemingc@benmccann
Update packages/adapter-cloudflare/src/worker.js
5da476c
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Chew Tee Ming
changes according to feedback
3e1fb1b
@teemingc
teemingc
commented
Mar 26, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the feedback guys. I've updated the docs and also bumped the minimum Wrangler version to v4. I've also updated the fallback option to work with Cloudflare Workers if the user has configured the assets 404-handling option.
EDIT: I've also added some simple tests to check that the build output is successful and works with the pages/workers dev environment provided by wrangler.
@teemingc
teemingc
merged commit ebec1e9
into
mainApr 2, 2025
@teemingc
teemingc
deleted the

merge-cloudflare-adapters

branch
April 2, 2025 02:26
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 2, 2025
 Merged


This was referenced Apr 2, 2025
 Merged

 Closed

@WarningImHack3rWarningImHack3r
mentioned this pull request
May 10, 2025
 Merged

4 tasks
CopilotAI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
@teemingc@benmccann
feat: deprecate adapter-cloudflare-workers in favour of `adapter-cl…
942465c
…oudflare` (sveltejs#13634)
* merge adapters
* changeset
* it's valid to not specify a main entry if the user is only deploying static assets
* format
* adjust docs
* also use cf pages env var
* fix migration guide link
* try to fix doc build error
* Update index.d.ts
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update kind-carrots-deliver.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* validate assets key if main key is set
* delete adapter-cloudflare-workers
* adjust docs and workspace for removing cloudflare workers
* fix docs title
* clarify _routes.json belongs to cloudflare pages
* Update packages/adapter-cloudflare/src/worker.js
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* changes according to feedback
* revert type change
* fix lock file
* fixes
* tests
* fix lockfile
* format
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benmccannbenmccannbenmccann approved these changes

+1 more reviewer

@dario-piotrowiczdario-piotrowiczdario-piotrowicz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

pkg:adapter-cloudflare

Projects


None yet


Milestone


No milestone


3 participants

@teemingc@benmccann@dario-piotrowicz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare - #13634
Merged
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Apr 2, 2025
Merged
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare#13634
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Conversation
@teemingc
@teemingcteemingc
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

Member
an alternative that closes#13427
closes#13360
closes#13071
closes#13005
closes#12813
closes#13579
closes#10924
This PR adds a deprecation notice to the adapter-cloudflare-workers docs while adding support for Cloudflare Workers Static Assets by skipping Cloudflare Pages-specific build steps and respecting Wrangler configuration settings if building for Cloudflare Workers Static Assets.
We use a heuristic to guess whether we're building for Cloudflare Pages or Workers based on the Wrangler configuration file settings, but even if there is no Wrangler configuration file, the build output is compatible with both platforms.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
  •  It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  •  This message body should clearly illustrate what problems it solves.
  •  Ideally, include a test that fails without this PR but passes with it.
Tests
  •  Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
Changesets
  •  If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.
Edits
  •  Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
@changeset-bot
changeset-botBot
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 49d28e8
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@sveltejs/adapter-cloudflareMajor
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@svelte-docs-bot
svelte-docs-botBot
commented
Mar 24, 2025

Copy link


Copy Markdown

Preview: https://svelte-dev-git-preview-kit-13634-svelte.vercel.app/
@teemingc
teemingc
requested a review
from benmccannMarch 24, 2025 10:42
benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/index.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment thread.changeset/kind-carrots-deliver.md
Outdated

@teemingcteemingc
mentioned this pull request
Mar 25, 2025
 Closed

6 tasks
dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/ambient.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/package.json
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/src/worker.js
Outdated

dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
@dario-piotrowiczdario-piotrowicz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I love seeing a single adapter that chooses workers or pages for you based on the config file! 🫶
Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Comment threadpackages/adapter-cloudflare/index.js
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

teemingcand others
added 2 commits
March 26, 2025 09:54
@teemingc@benmccann
Update packages/adapter-cloudflare/src/worker.js
5da476c
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Chew Tee Ming
changes according to feedback
3e1fb1b
@teemingc
teemingc
commented
Mar 26, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the feedback guys. I've updated the docs and also bumped the minimum Wrangler version to v4. I've also updated the fallback option to work with Cloudflare Workers if the user has configured the assets 404-handling option.
EDIT: I've also added some simple tests to check that the build output is successful and works with the pages/workers dev environment provided by wrangler.
@teemingc
teemingc
merged commit ebec1e9
into
mainApr 2, 2025
@teemingc
teemingc
deleted the

merge-cloudflare-adapters

branch
April 2, 2025 02:26
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 2, 2025
 Merged


This was referenced Apr 2, 2025
 Merged

 Closed

@WarningImHack3rWarningImHack3r
mentioned this pull request
May 10, 2025
 Merged

4 tasks
CopilotAI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
@teemingc@benmccann
feat: deprecate adapter-cloudflare-workers in favour of `adapter-cl…
942465c
…oudflare` (sveltejs#13634)
* merge adapters
* changeset
* it's valid to not specify a main entry if the user is only deploying static assets
* format
* adjust docs
* also use cf pages env var
* fix migration guide link
* try to fix doc build error
* Update index.d.ts
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update kind-carrots-deliver.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* validate assets key if main key is set
* delete adapter-cloudflare-workers
* adjust docs and workspace for removing cloudflare workers
* fix docs title
* clarify _routes.json belongs to cloudflare pages
* Update packages/adapter-cloudflare/src/worker.js
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* changes according to feedback
* revert type change
* fix lock file
* fixes
* tests
* fix lockfile
* format
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benmccannbenmccannbenmccann approved these changes

+1 more reviewer

@dario-piotrowiczdario-piotrowiczdario-piotrowicz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

pkg:adapter-cloudflare

Projects


None yet


Milestone


No milestone


3 participants

@teemingc@benmccann@dario-piotrowicz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare - #13634
Merged
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Apr 2, 2025
Merged
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare#13634
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Conversation
@teemingc
@teemingcteemingc
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

Member
an alternative that closes#13427
closes#13360
closes#13071
closes#13005
closes#12813
closes#13579
closes#10924
This PR adds a deprecation notice to the adapter-cloudflare-workers docs while adding support for Cloudflare Workers Static Assets by skipping Cloudflare Pages-specific build steps and respecting Wrangler configuration settings if building for Cloudflare Workers Static Assets.
We use a heuristic to guess whether we're building for Cloudflare Pages or Workers based on the Wrangler configuration file settings, but even if there is no Wrangler configuration file, the build output is compatible with both platforms.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
  •  It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  •  This message body should clearly illustrate what problems it solves.
  •  Ideally, include a test that fails without this PR but passes with it.
Tests
  •  Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
Changesets
  •  If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.
Edits
  •  Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
@changeset-bot
changeset-botBot
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 49d28e8
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@sveltejs/adapter-cloudflareMajor
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@svelte-docs-bot
svelte-docs-botBot
commented
Mar 24, 2025

Copy link


Copy Markdown

Preview: https://svelte-dev-git-preview-kit-13634-svelte.vercel.app/
@teemingc
teemingc
requested a review
from benmccannMarch 24, 2025 10:42
benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/index.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment thread.changeset/kind-carrots-deliver.md
Outdated

@teemingcteemingc
mentioned this pull request
Mar 25, 2025
 Closed

6 tasks
dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/ambient.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/package.json
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/src/worker.js
Outdated

dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
@dario-piotrowiczdario-piotrowicz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I love seeing a single adapter that chooses workers or pages for you based on the config file! 🫶
Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Comment threadpackages/adapter-cloudflare/index.js
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

teemingcand others
added 2 commits
March 26, 2025 09:54
@teemingc@benmccann
Update packages/adapter-cloudflare/src/worker.js
5da476c
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Chew Tee Ming
changes according to feedback
3e1fb1b
@teemingc
teemingc
commented
Mar 26, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the feedback guys. I've updated the docs and also bumped the minimum Wrangler version to v4. I've also updated the fallback option to work with Cloudflare Workers if the user has configured the assets 404-handling option.
EDIT: I've also added some simple tests to check that the build output is successful and works with the pages/workers dev environment provided by wrangler.
@teemingc
teemingc
merged commit ebec1e9
into
mainApr 2, 2025
@teemingc
teemingc
deleted the

merge-cloudflare-adapters

branch
April 2, 2025 02:26
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 2, 2025
 Merged


This was referenced Apr 2, 2025
 Merged

 Closed

@WarningImHack3rWarningImHack3r
mentioned this pull request
May 10, 2025
 Merged

4 tasks
CopilotAI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
@teemingc@benmccann
feat: deprecate adapter-cloudflare-workers in favour of `adapter-cl…
942465c
…oudflare` (sveltejs#13634)
* merge adapters
* changeset
* it's valid to not specify a main entry if the user is only deploying static assets
* format
* adjust docs
* also use cf pages env var
* fix migration guide link
* try to fix doc build error
* Update index.d.ts
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update kind-carrots-deliver.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* validate assets key if main key is set
* delete adapter-cloudflare-workers
* adjust docs and workspace for removing cloudflare workers
* fix docs title
* clarify _routes.json belongs to cloudflare pages
* Update packages/adapter-cloudflare/src/worker.js
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* changes according to feedback
* revert type change
* fix lock file
* fixes
* tests
* fix lockfile
* format
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benmccannbenmccannbenmccann approved these changes

+1 more reviewer

@dario-piotrowiczdario-piotrowiczdario-piotrowicz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

pkg:adapter-cloudflare

Projects


None yet


Milestone


No milestone


3 participants

@teemingc@benmccann@dario-piotrowicz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare - #13634
Merged
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Apr 2, 2025
Merged
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare#13634
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Conversation
@teemingc
@teemingcteemingc
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

Member
an alternative that closes#13427
closes#13360
closes#13071
closes#13005
closes#12813
closes#13579
closes#10924
This PR adds a deprecation notice to the adapter-cloudflare-workers docs while adding support for Cloudflare Workers Static Assets by skipping Cloudflare Pages-specific build steps and respecting Wrangler configuration settings if building for Cloudflare Workers Static Assets.
We use a heuristic to guess whether we're building for Cloudflare Pages or Workers based on the Wrangler configuration file settings, but even if there is no Wrangler configuration file, the build output is compatible with both platforms.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
  •  It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  •  This message body should clearly illustrate what problems it solves.
  •  Ideally, include a test that fails without this PR but passes with it.
Tests
  •  Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
Changesets
  •  If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.
Edits
  •  Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
@changeset-bot
changeset-botBot
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 49d28e8
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@sveltejs/adapter-cloudflareMajor
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@svelte-docs-bot
svelte-docs-botBot
commented
Mar 24, 2025

Copy link


Copy Markdown

Preview: https://svelte-dev-git-preview-kit-13634-svelte.vercel.app/
@teemingc
teemingc
requested a review
from benmccannMarch 24, 2025 10:42
benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/index.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment thread.changeset/kind-carrots-deliver.md
Outdated

@teemingcteemingc
mentioned this pull request
Mar 25, 2025
 Closed

6 tasks
dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/ambient.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/package.json
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/src/worker.js
Outdated

dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
@dario-piotrowiczdario-piotrowicz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I love seeing a single adapter that chooses workers or pages for you based on the config file! 🫶
Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Comment threadpackages/adapter-cloudflare/index.js
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

teemingcand others
added 2 commits
March 26, 2025 09:54
@teemingc@benmccann
Update packages/adapter-cloudflare/src/worker.js
5da476c
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Chew Tee Ming
changes according to feedback
3e1fb1b
@teemingc
teemingc
commented
Mar 26, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the feedback guys. I've updated the docs and also bumped the minimum Wrangler version to v4. I've also updated the fallback option to work with Cloudflare Workers if the user has configured the assets 404-handling option.
EDIT: I've also added some simple tests to check that the build output is successful and works with the pages/workers dev environment provided by wrangler.
@teemingc
teemingc
merged commit ebec1e9
into
mainApr 2, 2025
@teemingc
teemingc
deleted the

merge-cloudflare-adapters

branch
April 2, 2025 02:26
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 2, 2025
 Merged


This was referenced Apr 2, 2025
 Merged

 Closed

@WarningImHack3rWarningImHack3r
mentioned this pull request
May 10, 2025
 Merged

4 tasks
CopilotAI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
@teemingc@benmccann
feat: deprecate adapter-cloudflare-workers in favour of `adapter-cl…
942465c
…oudflare` (sveltejs#13634)
* merge adapters
* changeset
* it's valid to not specify a main entry if the user is only deploying static assets
* format
* adjust docs
* also use cf pages env var
* fix migration guide link
* try to fix doc build error
* Update index.d.ts
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update kind-carrots-deliver.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* validate assets key if main key is set
* delete adapter-cloudflare-workers
* adjust docs and workspace for removing cloudflare workers
* fix docs title
* clarify _routes.json belongs to cloudflare pages
* Update packages/adapter-cloudflare/src/worker.js
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* changes according to feedback
* revert type change
* fix lock file
* fixes
* tests
* fix lockfile
* format
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benmccannbenmccannbenmccann approved these changes

+1 more reviewer

@dario-piotrowiczdario-piotrowiczdario-piotrowicz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

pkg:adapter-cloudflare

Projects


None yet


Milestone


No milestone


3 participants

@teemingc@benmccann@dario-piotrowicz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare - #13634
Merged
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Apr 2, 2025
Merged
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare#13634
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Conversation
@teemingc
@teemingcteemingc
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

Member
an alternative that closes#13427
closes#13360
closes#13071
closes#13005
closes#12813
closes#13579
closes#10924
This PR adds a deprecation notice to the adapter-cloudflare-workers docs while adding support for Cloudflare Workers Static Assets by skipping Cloudflare Pages-specific build steps and respecting Wrangler configuration settings if building for Cloudflare Workers Static Assets.
We use a heuristic to guess whether we're building for Cloudflare Pages or Workers based on the Wrangler configuration file settings, but even if there is no Wrangler configuration file, the build output is compatible with both platforms.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
  •  It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  •  This message body should clearly illustrate what problems it solves.
  •  Ideally, include a test that fails without this PR but passes with it.
Tests
  •  Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
Changesets
  •  If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.
Edits
  •  Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
@changeset-bot
changeset-botBot
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 49d28e8
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@sveltejs/adapter-cloudflareMajor
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@svelte-docs-bot
svelte-docs-botBot
commented
Mar 24, 2025

Copy link


Copy Markdown

Preview: https://svelte-dev-git-preview-kit-13634-svelte.vercel.app/
@teemingc
teemingc
requested a review
from benmccannMarch 24, 2025 10:42
benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/index.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment thread.changeset/kind-carrots-deliver.md
Outdated

@teemingcteemingc
mentioned this pull request
Mar 25, 2025
 Closed

6 tasks
dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/ambient.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/package.json
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/src/worker.js
Outdated

dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
@dario-piotrowiczdario-piotrowicz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I love seeing a single adapter that chooses workers or pages for you based on the config file! 🫶
Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Comment threadpackages/adapter-cloudflare/index.js
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

teemingcand others
added 2 commits
March 26, 2025 09:54
@teemingc@benmccann
Update packages/adapter-cloudflare/src/worker.js
5da476c
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Chew Tee Ming
changes according to feedback
3e1fb1b
@teemingc
teemingc
commented
Mar 26, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the feedback guys. I've updated the docs and also bumped the minimum Wrangler version to v4. I've also updated the fallback option to work with Cloudflare Workers if the user has configured the assets 404-handling option.
EDIT: I've also added some simple tests to check that the build output is successful and works with the pages/workers dev environment provided by wrangler.
@teemingc
teemingc
merged commit ebec1e9
into
mainApr 2, 2025
@teemingc
teemingc
deleted the

merge-cloudflare-adapters

branch
April 2, 2025 02:26
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 2, 2025
 Merged


This was referenced Apr 2, 2025
 Merged

 Closed

@WarningImHack3rWarningImHack3r
mentioned this pull request
May 10, 2025
 Merged

4 tasks
CopilotAI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
@teemingc@benmccann
feat: deprecate adapter-cloudflare-workers in favour of `adapter-cl…
942465c
…oudflare` (sveltejs#13634)
* merge adapters
* changeset
* it's valid to not specify a main entry if the user is only deploying static assets
* format
* adjust docs
* also use cf pages env var
* fix migration guide link
* try to fix doc build error
* Update index.d.ts
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update kind-carrots-deliver.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* validate assets key if main key is set
* delete adapter-cloudflare-workers
* adjust docs and workspace for removing cloudflare workers
* fix docs title
* clarify _routes.json belongs to cloudflare pages
* Update packages/adapter-cloudflare/src/worker.js
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* changes according to feedback
* revert type change
* fix lock file
* fixes
* tests
* fix lockfile
* format
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benmccannbenmccannbenmccann approved these changes

+1 more reviewer

@dario-piotrowiczdario-piotrowiczdario-piotrowicz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

pkg:adapter-cloudflare

Projects


None yet


Milestone


No milestone


3 participants

@teemingc@benmccann@dario-piotrowicz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare - #13634
Merged
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Apr 2, 2025
Merged
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare#13634
teemingc merged 24 commits into
mainfrom 
merge-cloudflare-adapters
Conversation
@teemingc
@teemingcteemingc
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

Member
an alternative that closes#13427
closes#13360
closes#13071
closes#13005
closes#12813
closes#13579
closes#10924
This PR adds a deprecation notice to the adapter-cloudflare-workers docs while adding support for Cloudflare Workers Static Assets by skipping Cloudflare Pages-specific build steps and respecting Wrangler configuration settings if building for Cloudflare Workers Static Assets.
We use a heuristic to guess whether we're building for Cloudflare Pages or Workers based on the Wrangler configuration file settings, but even if there is no Wrangler configuration file, the build output is compatible with both platforms.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
  •  It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  •  This message body should clearly illustrate what problems it solves.
  •  Ideally, include a test that fails without this PR but passes with it.
Tests
  •  Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
Changesets
  •  If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.
Edits
  •  Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
@changeset-bot
changeset-botBot
commented
Mar 24, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 49d28e8
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@sveltejs/adapter-cloudflareMajor
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@svelte-docs-bot
svelte-docs-botBot
commented
Mar 24, 2025

Copy link


Copy Markdown

Preview: https://svelte-dev-git-preview-kit-13634-svelte.vercel.app/
@teemingc
teemingc
requested a review
from benmccannMarch 24, 2025 10:42
benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/index.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 24, 2025
View reviewed changes
Comment thread.changeset/kind-carrots-deliver.md
Outdated

@teemingcteemingc
mentioned this pull request
Mar 25, 2025
 Closed

6 tasks
dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/ambient.d.ts
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/package.json
Outdated

benmccann
benmccann
reviewed
Mar 25, 2025
View reviewed changes
Comment threadpackages/adapter-cloudflare/src/worker.js
Outdated

dario-piotrowicz
dario-piotrowicz
reviewed
Mar 25, 2025
View reviewed changes
@dario-piotrowiczdario-piotrowicz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I love seeing a single adapter that chooses workers or pages for you based on the config file! 🫶
Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Comment threadpackages/adapter-cloudflare/index.js
Outdated

Comment threaddocumentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated

teemingcand others
added 2 commits
March 26, 2025 09:54
@teemingc@benmccann
Update packages/adapter-cloudflare/src/worker.js
5da476c
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Chew Tee Ming
changes according to feedback
3e1fb1b
@teemingc
teemingc
commented
Mar 26, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the feedback guys. I've updated the docs and also bumped the minimum Wrangler version to v4. I've also updated the fallback option to work with Cloudflare Workers if the user has configured the assets 404-handling option.
EDIT: I've also added some simple tests to check that the build output is successful and works with the pages/workers dev environment provided by wrangler.
@teemingc
teemingc
merged commit ebec1e9
into
mainApr 2, 2025
@teemingc
teemingc
deleted the

merge-cloudflare-adapters

branch
April 2, 2025 02:26
@github-actionsgithub-actionsBot
mentioned this pull request
Apr 2, 2025
 Merged


This was referenced Apr 2, 2025
 Merged

 Closed

@WarningImHack3rWarningImHack3r
mentioned this pull request
May 10, 2025
 Merged

4 tasks
CopilotAI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
@teemingc@benmccann
feat: deprecate adapter-cloudflare-workers in favour of `adapter-cl…
942465c
…oudflare` (sveltejs#13634)
* merge adapters
* changeset
* it's valid to not specify a main entry if the user is only deploying static assets
* format
* adjust docs
* also use cf pages env var
* fix migration guide link
* try to fix doc build error
* Update index.d.ts
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update kind-carrots-deliver.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* validate assets key if main key is set
* delete adapter-cloudflare-workers
* adjust docs and workspace for removing cloudflare workers
* fix docs title
* clarify _routes.json belongs to cloudflare pages
* Update packages/adapter-cloudflare/src/worker.js
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* changes according to feedback
* revert type change
* fix lock file
* fixes
* tests
* fix lockfile
* format
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@benmccannbenmccannbenmccann approved these changes

+1 more reviewer

@dario-piotrowiczdario-piotrowiczdario-piotrowicz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

pkg:adapter-cloudflare

Projects


None yet


Milestone


No milestone


3 participants

@teemingc@benmccann@dario-piotrowicz