[Java][okhttp-gson] Fix incorrect use of OkHttp interceptors by ngaya-ll · Pull Request #8053 · swagger-api/swagger-codegen

ngaya-ll · 2018-04-21T09:56:15Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger

Description of the PR

Currently, the generated Java okhttp-gson client adds an interceptor to the underlying OkHttpClient for each async call. The purpose of the interceptor is to wrap the response body to track download progress. This implementation doesn't work correctly, for multiple reasons:

The interceptor intercepts all requests to the client, not just the one it's trying to track.
Interceptors are never removed from the client, so each async request adds another layer of interception for all subsequent requests. Since the interceptor chain is invoked recursively, at some point all requests will start failing with a StackOverflowError.

With this code change, the client uses a single interceptor to decorate all async requests and send updates to the relevant listener only.

I also added a test case to demonstrate the issue, which fails on the current master and passes on this branch.

Fixes#7876, #8915

ngaya-ll · 2018-04-22T06:31:16Z

- result.put("pet", pet);
- }
+@Test
+ public void testCreateAndGetMultiplePetsAsync() throws Exception {


This is the new test mentioned in the description. I also modified the preceding async test.

ngaya-ll · 2018-04-22T06:34:30Z

 }

 @Test
+ @Ignore


This endpoint is deprecated on petstore.swagger.io and was returning a 500 status.

ngaya-ll · 2018-04-22T07:58:11Z

 */
 public ApiClient setHttpClient(OkHttpClient httpClient) {
 this.httpClient = httpClient;
+ addProgressInterceptor();


Note that if multiple ApiClients are created with the same underlying OkHttpClient this will create duplicate progress updates for each request. However, from reading the rest of the class (e.g. the setDebugging() method) I concluded that this is not a supported use case.

ngaya-ll · 2018-05-18T21:22:29Z

@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger Any update on this? This fixes a critical bug for users making async calls using okhttp-gson generated clients.

mattnworb · 2019-01-11T16:31:38Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

See swagger-api/swagger-codegen#8053

mtnourji · 2021-02-18T16:07:35Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

+1
Any update on this ?

See swagger-api/swagger-codegen#8053

ngaya-ll · 2018-04-21T09:56:15Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger

Description of the PR

Currently, the generated Java okhttp-gson client adds an interceptor to the underlying OkHttpClient for each async call. The purpose of the interceptor is to wrap the response body to track download progress. This implementation doesn't work correctly, for multiple reasons:

The interceptor intercepts all requests to the client, not just the one it's trying to track.
Interceptors are never removed from the client, so each async request adds another layer of interception for all subsequent requests. Since the interceptor chain is invoked recursively, at some point all requests will start failing with a StackOverflowError.

With this code change, the client uses a single interceptor to decorate all async requests and send updates to the relevant listener only.

I also added a test case to demonstrate the issue, which fails on the current master and passes on this branch.

Fixes#7876, #8915

ngaya-ll · 2018-04-22T06:31:16Z

- result.put("pet", pet);
- }
+@Test
+ public void testCreateAndGetMultiplePetsAsync() throws Exception {


This is the new test mentioned in the description. I also modified the preceding async test.

ngaya-ll · 2018-04-22T06:34:30Z

 }

 @Test
+ @Ignore


This endpoint is deprecated on petstore.swagger.io and was returning a 500 status.

ngaya-ll · 2018-04-22T07:58:11Z

 */
 public ApiClient setHttpClient(OkHttpClient httpClient) {
 this.httpClient = httpClient;
+ addProgressInterceptor();


Note that if multiple ApiClients are created with the same underlying OkHttpClient this will create duplicate progress updates for each request. However, from reading the rest of the class (e.g. the setDebugging() method) I concluded that this is not a supported use case.

ngaya-ll · 2018-05-18T21:22:29Z

@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger Any update on this? This fixes a critical bug for users making async calls using okhttp-gson generated clients.

mattnworb · 2019-01-11T16:31:38Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

See swagger-api/swagger-codegen#8053

mtnourji · 2021-02-18T16:07:35Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

+1
Any update on this ?

See swagger-api/swagger-codegen#8053

ngaya-ll · 2018-04-21T09:56:15Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger

Description of the PR

Currently, the generated Java okhttp-gson client adds an interceptor to the underlying OkHttpClient for each async call. The purpose of the interceptor is to wrap the response body to track download progress. This implementation doesn't work correctly, for multiple reasons:

The interceptor intercepts all requests to the client, not just the one it's trying to track.
Interceptors are never removed from the client, so each async request adds another layer of interception for all subsequent requests. Since the interceptor chain is invoked recursively, at some point all requests will start failing with a StackOverflowError.

With this code change, the client uses a single interceptor to decorate all async requests and send updates to the relevant listener only.

I also added a test case to demonstrate the issue, which fails on the current master and passes on this branch.

Fixes#7876, #8915

ngaya-ll · 2018-04-22T06:31:16Z

- result.put("pet", pet);
- }
+@Test
+ public void testCreateAndGetMultiplePetsAsync() throws Exception {


This is the new test mentioned in the description. I also modified the preceding async test.

ngaya-ll · 2018-04-22T06:34:30Z

 }

 @Test
+ @Ignore


This endpoint is deprecated on petstore.swagger.io and was returning a 500 status.

ngaya-ll · 2018-04-22T07:58:11Z

 */
 public ApiClient setHttpClient(OkHttpClient httpClient) {
 this.httpClient = httpClient;
+ addProgressInterceptor();


Note that if multiple ApiClients are created with the same underlying OkHttpClient this will create duplicate progress updates for each request. However, from reading the rest of the class (e.g. the setDebugging() method) I concluded that this is not a supported use case.

ngaya-ll · 2018-05-18T21:22:29Z

@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger Any update on this? This fixes a critical bug for users making async calls using okhttp-gson generated clients.

mattnworb · 2019-01-11T16:31:38Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

See swagger-api/swagger-codegen#8053

mtnourji · 2021-02-18T16:07:35Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

+1
Any update on this ?

See swagger-api/swagger-codegen#8053

ngaya-ll · 2018-04-21T09:56:15Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger

Description of the PR

Currently, the generated Java okhttp-gson client adds an interceptor to the underlying OkHttpClient for each async call. The purpose of the interceptor is to wrap the response body to track download progress. This implementation doesn't work correctly, for multiple reasons:

The interceptor intercepts all requests to the client, not just the one it's trying to track.
Interceptors are never removed from the client, so each async request adds another layer of interception for all subsequent requests. Since the interceptor chain is invoked recursively, at some point all requests will start failing with a StackOverflowError.

With this code change, the client uses a single interceptor to decorate all async requests and send updates to the relevant listener only.

I also added a test case to demonstrate the issue, which fails on the current master and passes on this branch.

Fixes#7876, #8915

ngaya-ll · 2018-04-22T06:31:16Z

- result.put("pet", pet);
- }
+@Test
+ public void testCreateAndGetMultiplePetsAsync() throws Exception {


This is the new test mentioned in the description. I also modified the preceding async test.

ngaya-ll · 2018-04-22T06:34:30Z

 }

 @Test
+ @Ignore


This endpoint is deprecated on petstore.swagger.io and was returning a 500 status.

ngaya-ll · 2018-04-22T07:58:11Z

 */
 public ApiClient setHttpClient(OkHttpClient httpClient) {
 this.httpClient = httpClient;
+ addProgressInterceptor();


Note that if multiple ApiClients are created with the same underlying OkHttpClient this will create duplicate progress updates for each request. However, from reading the rest of the class (e.g. the setDebugging() method) I concluded that this is not a supported use case.

ngaya-ll · 2018-05-18T21:22:29Z

@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger Any update on this? This fixes a critical bug for users making async calls using okhttp-gson generated clients.

mattnworb · 2019-01-11T16:31:38Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

See swagger-api/swagger-codegen#8053

mtnourji · 2021-02-18T16:07:35Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

+1
Any update on this ?

See swagger-api/swagger-codegen#8053

ngaya-ll · 2018-04-21T09:56:15Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger

Description of the PR

Currently, the generated Java okhttp-gson client adds an interceptor to the underlying OkHttpClient for each async call. The purpose of the interceptor is to wrap the response body to track download progress. This implementation doesn't work correctly, for multiple reasons:

The interceptor intercepts all requests to the client, not just the one it's trying to track.
Interceptors are never removed from the client, so each async request adds another layer of interception for all subsequent requests. Since the interceptor chain is invoked recursively, at some point all requests will start failing with a StackOverflowError.

With this code change, the client uses a single interceptor to decorate all async requests and send updates to the relevant listener only.

I also added a test case to demonstrate the issue, which fails on the current master and passes on this branch.

Fixes#7876, #8915

ngaya-ll · 2018-04-22T06:31:16Z

- result.put("pet", pet);
- }
+@Test
+ public void testCreateAndGetMultiplePetsAsync() throws Exception {


This is the new test mentioned in the description. I also modified the preceding async test.

ngaya-ll · 2018-04-22T06:34:30Z

 }

 @Test
+ @Ignore


This endpoint is deprecated on petstore.swagger.io and was returning a 500 status.

ngaya-ll · 2018-04-22T07:58:11Z

 */
 public ApiClient setHttpClient(OkHttpClient httpClient) {
 this.httpClient = httpClient;
+ addProgressInterceptor();


Note that if multiple ApiClients are created with the same underlying OkHttpClient this will create duplicate progress updates for each request. However, from reading the rest of the class (e.g. the setDebugging() method) I concluded that this is not a supported use case.

ngaya-ll · 2018-05-18T21:22:29Z

@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger Any update on this? This fixes a critical bug for users making async calls using okhttp-gson generated clients.

mattnworb · 2019-01-11T16:31:38Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

See swagger-api/swagger-codegen#8053

mtnourji · 2021-02-18T16:07:35Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

+1
Any update on this ?

See swagger-api/swagger-codegen#8053

ngaya-ll · 2018-04-21T09:56:15Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger

Description of the PR

Currently, the generated Java okhttp-gson client adds an interceptor to the underlying OkHttpClient for each async call. The purpose of the interceptor is to wrap the response body to track download progress. This implementation doesn't work correctly, for multiple reasons:

The interceptor intercepts all requests to the client, not just the one it's trying to track.
Interceptors are never removed from the client, so each async request adds another layer of interception for all subsequent requests. Since the interceptor chain is invoked recursively, at some point all requests will start failing with a StackOverflowError.

With this code change, the client uses a single interceptor to decorate all async requests and send updates to the relevant listener only.

I also added a test case to demonstrate the issue, which fails on the current master and passes on this branch.

Fixes#7876, #8915

ngaya-ll · 2018-04-22T06:31:16Z

- result.put("pet", pet);
- }
+@Test
+ public void testCreateAndGetMultiplePetsAsync() throws Exception {


This is the new test mentioned in the description. I also modified the preceding async test.

ngaya-ll · 2018-04-22T06:34:30Z

 }

 @Test
+ @Ignore


This endpoint is deprecated on petstore.swagger.io and was returning a 500 status.

ngaya-ll · 2018-04-22T07:58:11Z

 */
 public ApiClient setHttpClient(OkHttpClient httpClient) {
 this.httpClient = httpClient;
+ addProgressInterceptor();


Note that if multiple ApiClients are created with the same underlying OkHttpClient this will create duplicate progress updates for each request. However, from reading the rest of the class (e.g. the setDebugging() method) I concluded that this is not a supported use case.

ngaya-ll · 2018-05-18T21:22:29Z

@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger Any update on this? This fixes a critical bug for users making async calls using okhttp-gson generated clients.

mattnworb · 2019-01-11T16:31:38Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

See swagger-api/swagger-codegen#8053

mtnourji · 2021-02-18T16:07:35Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

+1
Any update on this ?

See swagger-api/swagger-codegen#8053

ngaya-ll · 2018-04-21T09:56:15Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger

Description of the PR

Currently, the generated Java okhttp-gson client adds an interceptor to the underlying OkHttpClient for each async call. The purpose of the interceptor is to wrap the response body to track download progress. This implementation doesn't work correctly, for multiple reasons:

The interceptor intercepts all requests to the client, not just the one it's trying to track.
Interceptors are never removed from the client, so each async request adds another layer of interception for all subsequent requests. Since the interceptor chain is invoked recursively, at some point all requests will start failing with a StackOverflowError.

With this code change, the client uses a single interceptor to decorate all async requests and send updates to the relevant listener only.

I also added a test case to demonstrate the issue, which fails on the current master and passes on this branch.

Fixes#7876, #8915

ngaya-ll · 2018-04-22T06:31:16Z

- result.put("pet", pet);
- }
+@Test
+ public void testCreateAndGetMultiplePetsAsync() throws Exception {


This is the new test mentioned in the description. I also modified the preceding async test.

ngaya-ll · 2018-04-22T06:34:30Z

 }

 @Test
+ @Ignore


This endpoint is deprecated on petstore.swagger.io and was returning a 500 status.

ngaya-ll · 2018-04-22T07:58:11Z

 */
 public ApiClient setHttpClient(OkHttpClient httpClient) {
 this.httpClient = httpClient;
+ addProgressInterceptor();


Note that if multiple ApiClients are created with the same underlying OkHttpClient this will create duplicate progress updates for each request. However, from reading the rest of the class (e.g. the setDebugging() method) I concluded that this is not a supported use case.

ngaya-ll · 2018-05-18T21:22:29Z

@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger Any update on this? This fixes a critical bug for users making async calls using okhttp-gson generated clients.

mattnworb · 2019-01-11T16:31:38Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

See swagger-api/swagger-codegen#8053

mtnourji · 2021-02-18T16:07:35Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

+1
Any update on this ?

See swagger-api/swagger-codegen#8053

ngaya-ll · 2018-04-21T09:56:15Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger

Description of the PR

Currently, the generated Java okhttp-gson client adds an interceptor to the underlying OkHttpClient for each async call. The purpose of the interceptor is to wrap the response body to track download progress. This implementation doesn't work correctly, for multiple reasons:

The interceptor intercepts all requests to the client, not just the one it's trying to track.
Interceptors are never removed from the client, so each async request adds another layer of interception for all subsequent requests. Since the interceptor chain is invoked recursively, at some point all requests will start failing with a StackOverflowError.

With this code change, the client uses a single interceptor to decorate all async requests and send updates to the relevant listener only.

I also added a test case to demonstrate the issue, which fails on the current master and passes on this branch.

Fixes#7876, #8915

ngaya-ll · 2018-04-22T06:31:16Z

- result.put("pet", pet);
- }
+@Test
+ public void testCreateAndGetMultiplePetsAsync() throws Exception {


This is the new test mentioned in the description. I also modified the preceding async test.

ngaya-ll · 2018-04-22T06:34:30Z

 }

 @Test
+ @Ignore


This endpoint is deprecated on petstore.swagger.io and was returning a 500 status.

ngaya-ll · 2018-04-22T07:58:11Z

 */
 public ApiClient setHttpClient(OkHttpClient httpClient) {
 this.httpClient = httpClient;
+ addProgressInterceptor();


Note that if multiple ApiClients are created with the same underlying OkHttpClient this will create duplicate progress updates for each request. However, from reading the rest of the class (e.g. the setDebugging() method) I concluded that this is not a supported use case.

ngaya-ll · 2018-05-18T21:22:29Z

@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger Any update on this? This fixes a critical bug for users making async calls using okhttp-gson generated clients.

mattnworb · 2019-01-11T16:31:38Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

See swagger-api/swagger-codegen#8053

mtnourji · 2021-02-18T16:07:35Z

It would be lovely to have this merged to fix #7876 as the current state renders it impossible to use any of the generated "async" methods in any sort of long-lived production server.

+1
Any update on this ?

See swagger-api/swagger-codegen#8053

ngaya-ll added 3 commits April 21, 2018 02:36

Update java-okhttp-gson tests
6419a36

Minor test refactoring
dd091d6

Add test case for async calls and upload/download progress
a35d4e0

ngaya-ll mentioned this pull request Apr 21, 2018
Progress recipe lysine-dev/okhttp#1526
Merged

ngaya-ll force-pushed the issue-7876 branch from cc39ad5 to c5b5d91Compare April 21, 2018 11:14

ngaya-ll commented Apr 22, 2018
View reviewed changes

ngaya-ll force-pushed the issue-7876 branch from c5b5d91 to 5b3aef0Compare April 22, 2018 06:33

ngaya-ll commented Apr 22, 2018
View reviewed changes

[Java][okhttp-gson] Fix incorrect use of OkHttp interceptors
5b64f04

ngaya-ll force-pushed the issue-7876 branch from 5b3aef0 to 5b64f04Compare April 22, 2018 07:05

Remove unnecessary ProgressListener interface
a83fa95

ngaya-ll commented Apr 22, 2018
View reviewed changes

frantuma added the Language: java label Jun 27, 2018

ngaya-ll mentioned this pull request Nov 21, 2018
[JAVA] Memory leak, stack overflow and incorrect callbacks with okhttp-gson #8915
Open

Merge branch 'master' into issue-7876
bba39db

ngaya-ll force-pushed the issue-7876 branch from ab81a7e to bba39dbCompare November 25, 2018 21:06

mattnworb mentioned this pull request Jan 11, 2019
Use of "async" calls eventually causes StackoverflowErrors due to unbounded growth of networkInterceptors in OkHttpClient kubernetes-client/java#482
Closed

GoldenGnu mentioned this pull request Mar 9, 2019
Moving to OkHttp burberius/eve-esi#82
Closed

burberius mentioned this pull request Mar 10, 2019
[Java][okhttp-gson] Fix incorrect use of OkHttp interceptors OpenAPITools/openapi-generator#2356
Merged
4 tasks

wing328 pushed a commit to OpenAPITools/openapi-generator that referenced this pull request Mar 12, 2019
Port of@ngaya-ll's pull request from swagger to openapi. (#2356)
fde3252
See swagger-api/swagger-codegen#8053

therve pushed a commit to DataDog/datadog-api-client-java that referenced this pull request Mar 23, 2021
Port of@ngaya-ll's pull request from swagger to openapi. (#2356)
5d9a421
See swagger-api/swagger-codegen#8053

api-clients-generation-pipelineBot pushed a commit to DataDog/datadog-api-client-java that referenced this pull request Sep 8, 2021
Port of@ngaya-ll's pull request from swagger to openapi. (#2356)
05a3443
See swagger-api/swagger-codegen#8053

lud mentioned this pull request Jan 6, 2022
Memory Leak via Swagger for async calls sendinblue/APIv3-java-library#26
Closed

frantuma force-pushed the master branch from 4ba5164 to 949f0e6Compare May 20, 2025 09:13