fix(1.10): correct the false claim left in the unit template comment - #579
Merged
Conversation
#578 corrected BACKLOG.md and backup.yml but not this comment, which still asserted 'Nothing is deleted today'. It would have been written into the deployed unit file, where anyone next touching retention would read it. forget --dry-run said otherwise before anything ran: primary keep 12 remove 17, cold-sec keep 27 remove 16, offsite keep 12 remove 17. The mistake was reasoning about the policy in the abstract rather than against these snapshots -- the primary held 29 only because each frozen path-set had private daily slots, so twenty-nine was the bug and not the baseline. The part that was right is preserved: the June 29 and July 31 monthlies still carry the VHDX and restic dedupes, so either pins the full 224.7 GiB and no space is reclaimed until they age out around Jan-Feb 2027. 'Nothing is deleted' and 'no space is freed yet' are different statements and the comment conflated them. Found because the phrase wraps across two lines, so a grep for it returned nothing -- the fourth pattern today that could not match what it was looking for.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#578 corrected BACKLOG.md and backup.yml but not this comment, which still asserted 'Nothing is deleted today'. It would have been written into the deployed unit file, where anyone next touching retention would read it.
forget --dry-run said otherwise before anything ran: primary keep 12 remove 17, cold-sec keep 27 remove 16, offsite keep 12 remove 17. The mistake was reasoning about the policy in the abstract rather than against these snapshots -- the primary held 29 only because each frozen path-set had private daily slots, so twenty-nine was the bug and not the baseline.
The part that was right is preserved: the June 29 and July 31 monthlies still carry the VHDX and restic dedupes, so either pins the full 224.7 GiB and no space is reclaimed until they age out around Jan-Feb 2027. 'Nothing is deleted' and 'no space is freed yet' are different statements and the comment conflated them.
Found because the phrase wraps across two lines, so a grep for it returned nothing -- the fourth pattern today that could not match what it was looking for.