Skip to content

Reapply "Fix JSClosure leak (#240)" - #242

Draft
kateinoigakukun wants to merge 1 commit into
mainfrom
reapply-closure-leak-fix
Draft

Reapply "Fix JSClosure leak (#240)"#242
kateinoigakukun wants to merge 1 commit into
mainfrom
reapply-closure-leak-fix

Conversation

@kateinoigakukun

@kateinoigakukunkateinoigakukun commented Apr 12, 2024

Copy link
Copy Markdown
Member

Seems like something wrong is happening in https://github.com/swiftwasm/JavaScriptKit/actions/runs/8659623850. I need stress test this before re-landing this.

This reverts commit 8780e5f.

@kateinoigakukun
kateinoigakukun marked this pull request as draft April 12, 2024 09:22
@github-actions

Copy link
Copy Markdown

Time Change: +114ms (1%)

Total Time: 9,319ms

Test nameDurationChange
Serialization/JavaScript function call through Wasm import19ms-4ms (19%)👏
View Unchanged
Test nameDurationChange
Serialization/JavaScript function call through Wasm import with int15ms-1ms
Serialization/JavaScript function call from Swift99ms+2ms (1%)
Serialization/Swift Int to JavaScript with assignment330ms+9ms (2%)
Serialization/Swift Int to JavaScript with call939ms+8ms (0%)
Serialization/JavaScript Number to Swift Int303ms-1ms
Serialization/Swift String to JavaScript with assignment383ms-0ms
Serialization/Swift String to JavaScript with call976ms-7ms (0%)
Serialization/JavaScript String to Swift String3,622ms+96ms (2%)
Object heap/Increment and decrement RC2,620ms+12ms (0%)
View Baselines
Test nameDuration
Serialization/Call JavaScript function directly3ms
Serialization/Assign JavaScript number directly2ms
Serialization/Call with JavaScript number directly3ms
Serialization/Write JavaScript string directly3ms
Serialization/Call with JavaScript string directly2ms

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kateinoigakukun