Uh oh!
There was an error while loading. Please reload this page.
fix(optimizer): fold function aliases using resolved names - #88
Open
yavon007 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported aliases could make constant folding execute the wrong string function. For example,
use function strtoupper as upper; upper('MiXeD')compiled to"mixed"instead of"MIXED". The same issue affected case-sensitive and case-insensitive string comparisons.Pass the resolved function name through constant-fold dispatch instead of reading the original AST alias. Add a PHPT covering both directions of case conversion and two-/three-argument comparison, including aliases that shadow another built-in name.
Validation on Linux ARM64 with PHP 8.5.10:
use-function-alias.phpt: 2 passed with native AOT compilation.FuncCallOptimizerTestandFuncCallOptimizerUnpackTest: 2 tests, 23 assertions passed.git diff --checkpassed.