Uh oh!
There was an error while loading. Please reload this page.
fix(compiler): preserve PHP switch comparison semantics - #89
Merged
Merged
Conversation
matyhtfforce-pushed
the
codex/fix-switch-type-comparisons
branch
from
September 7, 2026 09:24
e71f708 to
94cd9a1CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typed boolean switch subjects could take the wrong branch:
truedid not matchcase 2after lowering to a C++ switch. Integer subjects with floating-point case labels generated invalid C++ and failed to compile.Check all labels before lowering any case bodies. Keep the native switch path for integer labels whose comparisons agree with PHP, including boolean subjects with labels 0 and 1. Route other cases through the existing comparison path and convert labels to their PHP truth value when comparing a boolean subject.
Add separate PHPT regressions for boolean/numeric comparisons and integer subjects with floating-point labels.
Validation on Linux ARM64 with PHP 8.5.10:
tests/compiler/switch: 8/8 passed with native AOT compilation.LoopControlTest: 7 tests / 15 assertions passed.git diff --checkpassed.