Uh oh!
There was an error while loading. Please reload this page.
fix(compiler): avoid native object filename collisions - #91
Open
yavon007 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native sources with the same basename, such as
foo.candfoo.cpp, compiled to the samefoo.o. The second compilation overwrote the first object, and linking the repeated object path failed with duplicate symbol definitions even in a sequential build.Preserve source extensions in native object filenames (
foo.c.o,foo.cpp.o,foo.cc.o). Keep object names for generated TypePHP.ccfiles inside the build directory and PHPX misc cache files unchanged. Add a regression for distinct native object paths and update the cache-test fixture to use the compiler's object-path mapping.Validation on Linux ARM64 with PHP 8.5.10:
PreprocessorTestand the misc-cache tests inCompilerBaseApiTest: 37 tests / 98 assertions passed. PHP 8.5 reports existingReflectionProperty::setAccessible()/ReflectionMethod::setAccessible()deprecations in the test helpers.foo.candfoo.cppbuilds, links, and runs successfully;nmconfirms both native symbols are retained in separate objects.git diff --checkpassed.