Uh oh!
There was an error while loading. Please reload this page.
Fix callable handling and local object reassignment in compiler - #93
Open
Tinywan wants to merge 2 commits into
Open
Fix callable handling and local object reassignment in compiler#93Tinywan wants to merge 2 commits into
Tinywan wants to merge 2 commits into
Conversation
added 2 commits
September 6, 2026 21:13
PHP 8.1 `foo(...)` builds a Closure from a single VariadicPlaceholder argument instead of calling foo. Two paths mishandled it: - checkInternalFunctionArgCount() counted the placeholder as a real argument, so first-class callables of internal functions requiring 2+ parameters (e.g. `posix_kill(...)`) failed with a bogus "expects at least N arguments, 1 given". - The math-function return-type optimization read `$expr->args[0]->value` on callables such as `round(...)`, crashing on the undefined VariadicPlaceholder::$value property. Guard both with isFirstClassCallable() so the expression falls through to Closure (Type::OBJECT) resolution.
A local variable has no type declaration; its class is inferred from the first assignment. Re-assigning an unrelated concrete class in a mutually exclusive branch (e.g. ReflectionFunction in `if` and ReflectionMethod in `else`) is valid PHP, but was rejected with "Cannot re-assign typed object". Route both re-assignment sites through reassignInferredObjectVar(), which widens an inferred local to a generic dynamic object. Parameters, native objects, and explicitly declared object types keep the strict check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.