fix: send hardware payment proofs

[ben-kaufman]

This PR sends Paykit payment proofs for on-chain payment requests paid from a hardware wallet. It is stacked on #1178 so the proof-delivery changes remain isolated from the subscription work.

Description

• Prepares the payment proof immediately before hardware broadcast, after signing succeeds.
• Preserves the existing private Payment List consumption and request acceptance order.
• Completes the proof with the broadcast transaction ID before showing payment success.
• Keeps preparation idempotent across hardware broadcast retries.

Preview

N/A

QA Notes

Manual Tests

• 1. Incoming on-chain Payment Request → choose a hardware wallet → review → sign and broadcast: payment succeeds and the requester receives its transaction proof.
• 2.regression: hardware broadcast retry → retry the same signed transaction: the request is not accepted twice and the private Payment List is not consumed twice.

Automated Checks

• AppViewModelSendFlowTest.kt: verifies hardware proof preparation ordering and idempotency, plus proof completion with the broadcast transaction ID.
• ./gradlew testDevDebugUnitTest --tests 'to.bitkit.viewmodels.AppViewModelSendFlowTest'

[greptile-apps]

Greptile Summary

This PR extends incoming on-chain Paykit payment proofs to hardware-wallet sends while preserving preparation idempotency and the existing request-consumption order.

• Prepares the proof immediately before broadcasting a signed hardware transaction.
• Completes the proof with the resulting transaction ID before showing payment success.
• Adds focused tests for preparation ordering, retries, and proof completion.

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed hardware-send and payment-proof paths.

The hardware flow prepares the proof before broadcast, retains existing contact-payment preparation safeguards, completes the proof with the broadcast transaction ID, and handles repository failures without interrupting payment-success navigation.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt	Adds idempotent hardware proof preparation and transaction-ID-based proof completion without an accepted correctness issue.
app/src/main/java/to/bitkit/ui/sheets/SendSheet.kt	Completes the hardware payment proof before advancing the successful broadcast flow.
app/src/test/java/to/bitkit/viewmodels/AppViewModelSendFlowTest.kt	Verifies proof preparation ordering, repeated preparation behavior, and completion with the broadcast transaction ID.

Sequence Diagram

sequenceDiagram
participant U as User
participant H as Hardware send
participant A as AppViewModel
participant P as Paykit proof repository
participant W as Hardware wallet
U->>H: Confirm hardware payment
H->>W: Sign transaction
W-->>H: Signed transaction
H->>A: prepareHardwareContactPayment()
A->>P: Prepare payment proof
A->>A: Consume private list and accept request
A-->>H: Preparation succeeded
H->>H: Broadcast signed transaction
H-->>A: Transaction ID
A->>P: Complete proof with transaction ID
A->>A: Show payment success

Loading

_{Reviews (1): Last reviewed commit: "fix: send hardware payment proofs" | Re-trigger Greptile}

[ovitrif]

utACK

[ovitrif]

utACK

The base branch was changed.

[jvsena42]

Starting review

[ovitrif]

utACK

[ben-kaufman]

Follow-up: current signed head is 1769cb2. The first CI run compiled the production code and ran 2,290 tests; its only failure was the new assertion mixing one raw endpoint with Mockito matchers. That assertion now uses eq(endpoint), static analysis remains clean for all changed files, and fresh CI is running.

[ovitrif]

utACK

[ben-kaufman]

This PR sends Paykit payment proofs for on-chain payment requests paid from a hardware wallet. It is stacked on #1178 so the proof-delivery changes remain isolated from the subscription work.

Description

• Prepares the payment proof immediately before hardware broadcast, after signing succeeds.
• Preserves the existing private Payment List consumption and request acceptance order.
• Completes the proof with the broadcast transaction ID before showing payment success.
• Keeps preparation idempotent across hardware broadcast retries.

Preview

N/A

QA Notes

Manual Tests

• 1. Incoming on-chain Payment Request → choose a hardware wallet → review → sign and broadcast: payment succeeds and the requester receives its transaction proof.
• 2.regression: hardware broadcast retry → retry the same signed transaction: the request is not accepted twice and the private Payment List is not consumed twice.

Automated Checks

• AppViewModelSendFlowTest.kt: verifies hardware proof preparation ordering and idempotency, plus proof completion with the broadcast transaction ID.
• ./gradlew testDevDebugUnitTest --tests 'to.bitkit.viewmodels.AppViewModelSendFlowTest'

[greptile-apps]

Greptile Summary

This PR extends incoming on-chain Paykit payment proofs to hardware-wallet sends while preserving preparation idempotency and the existing request-consumption order.

• Prepares the proof immediately before broadcasting a signed hardware transaction.
• Completes the proof with the resulting transaction ID before showing payment success.
• Adds focused tests for preparation ordering, retries, and proof completion.

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed hardware-send and payment-proof paths.

The hardware flow prepares the proof before broadcast, retains existing contact-payment preparation safeguards, completes the proof with the broadcast transaction ID, and handles repository failures without interrupting payment-success navigation.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt	Adds idempotent hardware proof preparation and transaction-ID-based proof completion without an accepted correctness issue.
app/src/main/java/to/bitkit/ui/sheets/SendSheet.kt	Completes the hardware payment proof before advancing the successful broadcast flow.
app/src/test/java/to/bitkit/viewmodels/AppViewModelSendFlowTest.kt	Verifies proof preparation ordering, repeated preparation behavior, and completion with the broadcast transaction ID.

Sequence Diagram

sequenceDiagram
participant U as User
participant H as Hardware send
participant A as AppViewModel
participant P as Paykit proof repository
participant W as Hardware wallet
U->>H: Confirm hardware payment
H->>W: Sign transaction
W-->>H: Signed transaction
H->>A: prepareHardwareContactPayment()
A->>P: Prepare payment proof
A->>A: Consume private list and accept request
A-->>H: Preparation succeeded
H->>H: Broadcast signed transaction
H-->>A: Transaction ID
A->>P: Complete proof with transaction ID
A->>A: Show payment success

Loading

_{Reviews (1): Last reviewed commit: "fix: send hardware payment proofs" | Re-trigger Greptile}

[ovitrif]

utACK

[ovitrif]

utACK

The base branch was changed.

[jvsena42]

Starting review

[ovitrif]

utACK

[ben-kaufman]

Follow-up: current signed head is 1769cb2. The first CI run compiled the production code and ran 2,290 tests; its only failure was the new assertion mixing one raw endpoint with Mockito matchers. That assertion now uses eq(endpoint), static analysis remains clean for all changed files, and fresh CI is running.

[ovitrif]

utACK

[ben-kaufman]

This PR sends Paykit payment proofs for on-chain payment requests paid from a hardware wallet. It is stacked on #1178 so the proof-delivery changes remain isolated from the subscription work.

Description

• Prepares the payment proof immediately before hardware broadcast, after signing succeeds.
• Preserves the existing private Payment List consumption and request acceptance order.
• Completes the proof with the broadcast transaction ID before showing payment success.
• Keeps preparation idempotent across hardware broadcast retries.

Preview

N/A

QA Notes

Manual Tests

• 1. Incoming on-chain Payment Request → choose a hardware wallet → review → sign and broadcast: payment succeeds and the requester receives its transaction proof.
• 2.regression: hardware broadcast retry → retry the same signed transaction: the request is not accepted twice and the private Payment List is not consumed twice.

Automated Checks

• AppViewModelSendFlowTest.kt: verifies hardware proof preparation ordering and idempotency, plus proof completion with the broadcast transaction ID.
• ./gradlew testDevDebugUnitTest --tests 'to.bitkit.viewmodels.AppViewModelSendFlowTest'

[greptile-apps]

Greptile Summary

This PR extends incoming on-chain Paykit payment proofs to hardware-wallet sends while preserving preparation idempotency and the existing request-consumption order.

• Prepares the proof immediately before broadcasting a signed hardware transaction.
• Completes the proof with the resulting transaction ID before showing payment success.
• Adds focused tests for preparation ordering, retries, and proof completion.

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed hardware-send and payment-proof paths.

The hardware flow prepares the proof before broadcast, retains existing contact-payment preparation safeguards, completes the proof with the broadcast transaction ID, and handles repository failures without interrupting payment-success navigation.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt	Adds idempotent hardware proof preparation and transaction-ID-based proof completion without an accepted correctness issue.
app/src/main/java/to/bitkit/ui/sheets/SendSheet.kt	Completes the hardware payment proof before advancing the successful broadcast flow.
app/src/test/java/to/bitkit/viewmodels/AppViewModelSendFlowTest.kt	Verifies proof preparation ordering, repeated preparation behavior, and completion with the broadcast transaction ID.

Sequence Diagram

sequenceDiagram
participant U as User
participant H as Hardware send
participant A as AppViewModel
participant P as Paykit proof repository
participant W as Hardware wallet
U->>H: Confirm hardware payment
H->>W: Sign transaction
W-->>H: Signed transaction
H->>A: prepareHardwareContactPayment()
A->>P: Prepare payment proof
A->>A: Consume private list and accept request
A-->>H: Preparation succeeded
H->>H: Broadcast signed transaction
H-->>A: Transaction ID
A->>P: Complete proof with transaction ID
A->>A: Show payment success

Loading

_{Reviews (1): Last reviewed commit: "fix: send hardware payment proofs" | Re-trigger Greptile}

[ovitrif]

utACK

[ovitrif]

utACK

The base branch was changed.

[jvsena42]

Starting review

[ovitrif]

utACK

[ben-kaufman]

Follow-up: current signed head is 1769cb2. The first CI run compiled the production code and ran 2,290 tests; its only failure was the new assertion mixing one raw endpoint with Mockito matchers. That assertion now uses eq(endpoint), static analysis remains clean for all changed files, and fresh CI is running.

[ovitrif]

utACK

[ben-kaufman]

This PR sends Paykit payment proofs for on-chain payment requests paid from a hardware wallet. It is stacked on #1178 so the proof-delivery changes remain isolated from the subscription work.

Description

• Prepares the payment proof immediately before hardware broadcast, after signing succeeds.
• Preserves the existing private Payment List consumption and request acceptance order.
• Completes the proof with the broadcast transaction ID before showing payment success.
• Keeps preparation idempotent across hardware broadcast retries.

Preview

N/A

QA Notes

Manual Tests

• 1. Incoming on-chain Payment Request → choose a hardware wallet → review → sign and broadcast: payment succeeds and the requester receives its transaction proof.
• 2.regression: hardware broadcast retry → retry the same signed transaction: the request is not accepted twice and the private Payment List is not consumed twice.

Automated Checks

• AppViewModelSendFlowTest.kt: verifies hardware proof preparation ordering and idempotency, plus proof completion with the broadcast transaction ID.
• ./gradlew testDevDebugUnitTest --tests 'to.bitkit.viewmodels.AppViewModelSendFlowTest'

[greptile-apps]

Greptile Summary

This PR extends incoming on-chain Paykit payment proofs to hardware-wallet sends while preserving preparation idempotency and the existing request-consumption order.

• Prepares the proof immediately before broadcasting a signed hardware transaction.
• Completes the proof with the resulting transaction ID before showing payment success.
• Adds focused tests for preparation ordering, retries, and proof completion.

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed hardware-send and payment-proof paths.

The hardware flow prepares the proof before broadcast, retains existing contact-payment preparation safeguards, completes the proof with the broadcast transaction ID, and handles repository failures without interrupting payment-success navigation.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt	Adds idempotent hardware proof preparation and transaction-ID-based proof completion without an accepted correctness issue.
app/src/main/java/to/bitkit/ui/sheets/SendSheet.kt	Completes the hardware payment proof before advancing the successful broadcast flow.
app/src/test/java/to/bitkit/viewmodels/AppViewModelSendFlowTest.kt	Verifies proof preparation ordering, repeated preparation behavior, and completion with the broadcast transaction ID.

Sequence Diagram

sequenceDiagram
participant U as User
participant H as Hardware send
participant A as AppViewModel
participant P as Paykit proof repository
participant W as Hardware wallet
U->>H: Confirm hardware payment
H->>W: Sign transaction
W-->>H: Signed transaction
H->>A: prepareHardwareContactPayment()
A->>P: Prepare payment proof
A->>A: Consume private list and accept request
A-->>H: Preparation succeeded
H->>H: Broadcast signed transaction
H-->>A: Transaction ID
A->>P: Complete proof with transaction ID
A->>A: Show payment success

Loading

_{Reviews (1): Last reviewed commit: "fix: send hardware payment proofs" | Re-trigger Greptile}

[ovitrif]

utACK

[ovitrif]

utACK

The base branch was changed.

[jvsena42]

Starting review

[ovitrif]

utACK

[ben-kaufman]

Follow-up: current signed head is 1769cb2. The first CI run compiled the production code and ran 2,290 tests; its only failure was the new assertion mixing one raw endpoint with Mockito matchers. That assertion now uses eq(endpoint), static analysis remains clean for all changed files, and fresh CI is running.

[ovitrif]

utACK

[ben-kaufman]

This PR sends Paykit payment proofs for on-chain payment requests paid from a hardware wallet. It is stacked on #1178 so the proof-delivery changes remain isolated from the subscription work.

Description

• Prepares the payment proof immediately before hardware broadcast, after signing succeeds.
• Preserves the existing private Payment List consumption and request acceptance order.
• Completes the proof with the broadcast transaction ID before showing payment success.
• Keeps preparation idempotent across hardware broadcast retries.

Preview

N/A

QA Notes

Manual Tests

• 1. Incoming on-chain Payment Request → choose a hardware wallet → review → sign and broadcast: payment succeeds and the requester receives its transaction proof.
• 2.regression: hardware broadcast retry → retry the same signed transaction: the request is not accepted twice and the private Payment List is not consumed twice.

Automated Checks

• AppViewModelSendFlowTest.kt: verifies hardware proof preparation ordering and idempotency, plus proof completion with the broadcast transaction ID.
• ./gradlew testDevDebugUnitTest --tests 'to.bitkit.viewmodels.AppViewModelSendFlowTest'

[greptile-apps]

Greptile Summary

This PR extends incoming on-chain Paykit payment proofs to hardware-wallet sends while preserving preparation idempotency and the existing request-consumption order.

• Prepares the proof immediately before broadcasting a signed hardware transaction.
• Completes the proof with the resulting transaction ID before showing payment success.
• Adds focused tests for preparation ordering, retries, and proof completion.

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed hardware-send and payment-proof paths.

The hardware flow prepares the proof before broadcast, retains existing contact-payment preparation safeguards, completes the proof with the broadcast transaction ID, and handles repository failures without interrupting payment-success navigation.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt	Adds idempotent hardware proof preparation and transaction-ID-based proof completion without an accepted correctness issue.
app/src/main/java/to/bitkit/ui/sheets/SendSheet.kt	Completes the hardware payment proof before advancing the successful broadcast flow.
app/src/test/java/to/bitkit/viewmodels/AppViewModelSendFlowTest.kt	Verifies proof preparation ordering, repeated preparation behavior, and completion with the broadcast transaction ID.

Sequence Diagram

sequenceDiagram
participant U as User
participant H as Hardware send
participant A as AppViewModel
participant P as Paykit proof repository
participant W as Hardware wallet
U->>H: Confirm hardware payment
H->>W: Sign transaction
W-->>H: Signed transaction
H->>A: prepareHardwareContactPayment()
A->>P: Prepare payment proof
A->>A: Consume private list and accept request
A-->>H: Preparation succeeded
H->>H: Broadcast signed transaction
H-->>A: Transaction ID
A->>P: Complete proof with transaction ID
A->>A: Show payment success

Loading

_{Reviews (1): Last reviewed commit: "fix: send hardware payment proofs" | Re-trigger Greptile}

[ovitrif]

utACK

[ovitrif]

utACK

The base branch was changed.

[jvsena42]

Starting review

[ovitrif]

utACK

[ben-kaufman]

Follow-up: current signed head is 1769cb2. The first CI run compiled the production code and ran 2,290 tests; its only failure was the new assertion mixing one raw endpoint with Mockito matchers. That assertion now uses eq(endpoint), static analysis remains clean for all changed files, and fresh CI is running.

[ovitrif]

utACK

[ben-kaufman]

This PR sends Paykit payment proofs for on-chain payment requests paid from a hardware wallet. It is stacked on #1178 so the proof-delivery changes remain isolated from the subscription work.

Description

• Prepares the payment proof immediately before hardware broadcast, after signing succeeds.
• Preserves the existing private Payment List consumption and request acceptance order.
• Completes the proof with the broadcast transaction ID before showing payment success.
• Keeps preparation idempotent across hardware broadcast retries.

Preview

N/A

QA Notes

Manual Tests

• 1. Incoming on-chain Payment Request → choose a hardware wallet → review → sign and broadcast: payment succeeds and the requester receives its transaction proof.
• 2.regression: hardware broadcast retry → retry the same signed transaction: the request is not accepted twice and the private Payment List is not consumed twice.

Automated Checks

• AppViewModelSendFlowTest.kt: verifies hardware proof preparation ordering and idempotency, plus proof completion with the broadcast transaction ID.
• ./gradlew testDevDebugUnitTest --tests 'to.bitkit.viewmodels.AppViewModelSendFlowTest'

[greptile-apps]

Greptile Summary

This PR extends incoming on-chain Paykit payment proofs to hardware-wallet sends while preserving preparation idempotency and the existing request-consumption order.

• Prepares the proof immediately before broadcasting a signed hardware transaction.
• Completes the proof with the resulting transaction ID before showing payment success.
• Adds focused tests for preparation ordering, retries, and proof completion.

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed hardware-send and payment-proof paths.

The hardware flow prepares the proof before broadcast, retains existing contact-payment preparation safeguards, completes the proof with the broadcast transaction ID, and handles repository failures without interrupting payment-success navigation.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt	Adds idempotent hardware proof preparation and transaction-ID-based proof completion without an accepted correctness issue.
app/src/main/java/to/bitkit/ui/sheets/SendSheet.kt	Completes the hardware payment proof before advancing the successful broadcast flow.
app/src/test/java/to/bitkit/viewmodels/AppViewModelSendFlowTest.kt	Verifies proof preparation ordering, repeated preparation behavior, and completion with the broadcast transaction ID.

Sequence Diagram

sequenceDiagram
participant U as User
participant H as Hardware send
participant A as AppViewModel
participant P as Paykit proof repository
participant W as Hardware wallet
U->>H: Confirm hardware payment
H->>W: Sign transaction
W-->>H: Signed transaction
H->>A: prepareHardwareContactPayment()
A->>P: Prepare payment proof
A->>A: Consume private list and accept request
A-->>H: Preparation succeeded
H->>H: Broadcast signed transaction
H-->>A: Transaction ID
A->>P: Complete proof with transaction ID
A->>A: Show payment success

Loading

_{Reviews (1): Last reviewed commit: "fix: send hardware payment proofs" | Re-trigger Greptile}

[ovitrif]

utACK

[ovitrif]

utACK

The base branch was changed.

[jvsena42]

Starting review

[ovitrif]

utACK

[ben-kaufman]

Follow-up: current signed head is 1769cb2. The first CI run compiled the production code and ran 2,290 tests; its only failure was the new assertion mixing one raw endpoint with Mockito matchers. That assertion now uses eq(endpoint), static analysis remains clean for all changed files, and fresh CI is running.

[ovitrif]

utACK

[ben-kaufman]

This PR sends Paykit payment proofs for on-chain payment requests paid from a hardware wallet. It is stacked on #1178 so the proof-delivery changes remain isolated from the subscription work.

Description

• Prepares the payment proof immediately before hardware broadcast, after signing succeeds.
• Preserves the existing private Payment List consumption and request acceptance order.
• Completes the proof with the broadcast transaction ID before showing payment success.
• Keeps preparation idempotent across hardware broadcast retries.

Preview

N/A

QA Notes

Manual Tests

• 1. Incoming on-chain Payment Request → choose a hardware wallet → review → sign and broadcast: payment succeeds and the requester receives its transaction proof.
• 2.regression: hardware broadcast retry → retry the same signed transaction: the request is not accepted twice and the private Payment List is not consumed twice.

Automated Checks

• AppViewModelSendFlowTest.kt: verifies hardware proof preparation ordering and idempotency, plus proof completion with the broadcast transaction ID.
• ./gradlew testDevDebugUnitTest --tests 'to.bitkit.viewmodels.AppViewModelSendFlowTest'

[greptile-apps]

Greptile Summary

This PR extends incoming on-chain Paykit payment proofs to hardware-wallet sends while preserving preparation idempotency and the existing request-consumption order.

• Prepares the proof immediately before broadcasting a signed hardware transaction.
• Completes the proof with the resulting transaction ID before showing payment success.
• Adds focused tests for preparation ordering, retries, and proof completion.

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed hardware-send and payment-proof paths.

The hardware flow prepares the proof before broadcast, retains existing contact-payment preparation safeguards, completes the proof with the broadcast transaction ID, and handles repository failures without interrupting payment-success navigation.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt	Adds idempotent hardware proof preparation and transaction-ID-based proof completion without an accepted correctness issue.
app/src/main/java/to/bitkit/ui/sheets/SendSheet.kt	Completes the hardware payment proof before advancing the successful broadcast flow.
app/src/test/java/to/bitkit/viewmodels/AppViewModelSendFlowTest.kt	Verifies proof preparation ordering, repeated preparation behavior, and completion with the broadcast transaction ID.

Sequence Diagram

sequenceDiagram
participant U as User
participant H as Hardware send
participant A as AppViewModel
participant P as Paykit proof repository
participant W as Hardware wallet
U->>H: Confirm hardware payment
H->>W: Sign transaction
W-->>H: Signed transaction
H->>A: prepareHardwareContactPayment()
A->>P: Prepare payment proof
A->>A: Consume private list and accept request
A-->>H: Preparation succeeded
H->>H: Broadcast signed transaction
H-->>A: Transaction ID
A->>P: Complete proof with transaction ID
A->>A: Show payment success

Loading

_{Reviews (1): Last reviewed commit: "fix: send hardware payment proofs" | Re-trigger Greptile}

[ovitrif]

utACK

[ovitrif]

utACK

The base branch was changed.

[jvsena42]

Starting review

[ovitrif]

utACK

[ben-kaufman]

Follow-up: current signed head is 1769cb2. The first CI run compiled the production code and ran 2,290 tests; its only failure was the new assertion mixing one raw endpoint with Mockito matchers. That assertion now uses eq(endpoint), static analysis remains clean for all changed files, and fresh CI is running.

[ovitrif]

utACK

[ben-kaufman]

This PR sends Paykit payment proofs for on-chain payment requests paid from a hardware wallet. It is stacked on #1178 so the proof-delivery changes remain isolated from the subscription work.

Description

• Prepares the payment proof immediately before hardware broadcast, after signing succeeds.
• Preserves the existing private Payment List consumption and request acceptance order.
• Completes the proof with the broadcast transaction ID before showing payment success.
• Keeps preparation idempotent across hardware broadcast retries.

Preview

N/A

QA Notes

Manual Tests

• 1. Incoming on-chain Payment Request → choose a hardware wallet → review → sign and broadcast: payment succeeds and the requester receives its transaction proof.
• 2.regression: hardware broadcast retry → retry the same signed transaction: the request is not accepted twice and the private Payment List is not consumed twice.

Automated Checks

• AppViewModelSendFlowTest.kt: verifies hardware proof preparation ordering and idempotency, plus proof completion with the broadcast transaction ID.
• ./gradlew testDevDebugUnitTest --tests 'to.bitkit.viewmodels.AppViewModelSendFlowTest'

[greptile-apps]

Greptile Summary

This PR extends incoming on-chain Paykit payment proofs to hardware-wallet sends while preserving preparation idempotency and the existing request-consumption order.

• Prepares the proof immediately before broadcasting a signed hardware transaction.
• Completes the proof with the resulting transaction ID before showing payment success.
• Adds focused tests for preparation ordering, retries, and proof completion.

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed hardware-send and payment-proof paths.

The hardware flow prepares the proof before broadcast, retains existing contact-payment preparation safeguards, completes the proof with the broadcast transaction ID, and handles repository failures without interrupting payment-success navigation.

Important Files Changed

Filename	Overview
app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt	Adds idempotent hardware proof preparation and transaction-ID-based proof completion without an accepted correctness issue.
app/src/main/java/to/bitkit/ui/sheets/SendSheet.kt	Completes the hardware payment proof before advancing the successful broadcast flow.
app/src/test/java/to/bitkit/viewmodels/AppViewModelSendFlowTest.kt	Verifies proof preparation ordering, repeated preparation behavior, and completion with the broadcast transaction ID.

Sequence Diagram

sequenceDiagram
participant U as User
participant H as Hardware send
participant A as AppViewModel
participant P as Paykit proof repository
participant W as Hardware wallet
U->>H: Confirm hardware payment
H->>W: Sign transaction
W-->>H: Signed transaction
H->>A: prepareHardwareContactPayment()
A->>P: Prepare payment proof
A->>A: Consume private list and accept request
A-->>H: Preparation succeeded
H->>H: Broadcast signed transaction
H-->>A: Transaction ID
A->>P: Complete proof with transaction ID
A->>A: Show payment success

Loading

_{Reviews (1): Last reviewed commit: "fix: send hardware payment proofs" | Re-trigger Greptile}

[ovitrif]

utACK

[ovitrif]

utACK

The base branch was changed.

[jvsena42]

Starting review

[ovitrif]

utACK

[ben-kaufman]

Follow-up: current signed head is 1769cb2. The first CI run compiled the production code and ran 2,290 tests; its only failure was the new assertion mixing one raw endpoint with Mockito matchers. That assertion now uses eq(endpoint), static analysis remains clean for all changed files, and fresh CI is running.

[ovitrif]

utACK