Uh oh!
There was an error while loading. Please reload this page.
fix: enable incoming onchain request swipe - #1221
Conversation
Greptile SummaryThis PR enables confirmation for validated, affordable incoming on-chain Paykit payment requests.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt | Marks the fixed incoming-request amount valid only after the existing validation and affordability checks succeed. |
| app/src/test/java/to/bitkit/viewmodels/AppViewModelSendFlowTest.kt | Adds focused coverage for successful on-chain confirmation state and rejection of an unaffordable request. |
| changelog.d/next/1221.fixed.md | Documents that affordable incoming on-chain payment requests can now be confirmed. |
Reviews (3): Last reviewed commit: "fix: enable onchain request swipe (#1218..." | Re-trigger Greptile
ovitrif
commented
Sep 2, 2026
I am closing this PR as superseded by #1178. I created it from the live disabled-swipe defect observed on the then-current master; it supplied a one-line fix, focused regression coverage, and successful marketplace end-to-end evidence. The then-open #1178 already contained the production-equivalent fix e041150 and later merged it, together with positive regression 10ff0df, into master at 9698dea. My initial overlap check did not catch the matching change inside that open PR. This PR therefore no longer has an independent product deliverable, and retaining a conflicting branch only for incremental negative coverage is not warranted. No product behavior or validation evidence is lost. |
ovitrif
commented
Sep 2, 2026
Re-closing after task automation reopened this PR while producing a local APK. The supersession decision above remains unchanged: merged #1178 owns the production fix and regression coverage, so this PR stays closed without merge. |
Fixes#1218
This PR persists successful amount validation for incoming on-chain Paykit Payment Requests, enabling the confirmation swipe only after the existing request validation and affordability checks pass.
Description
Preview
QA Notes
Manual Tests
confirmed/1, completed Locks, and returned HTTP200for the guarded resource.Automated Checks
AppViewModelSendFlowTest.kt: covers the payable resolved on-chain state, fixed request amount, endpoint, private contact context, and unaffordable block.just compile: passes.just test: passes all 2,267 tests.just lint: passes with existing baseline findings outside this change../gradlew assembleDevDebug: passes.sdk_gphone64_arm64regtest emulator: passes withMainActivityresumed and no fatal or ANR logs.