feat: add profile and contacts fetching from pubky - #824

Merged
ovitrif merged 62 commits into
masterfrom
feat/pubky-profile
Apr 22, 2026
Merged

feat: add profile and contacts fetching from pubky#824
ovitrif merged 62 commits into
masterfrom
feat/pubky-profile

Conversation

@ben-kaufman

@ben-kaufmanben-kaufman commented Mar 5, 2026•
edited by ovitrif
Loading

Copy link
Copy Markdown
Contributor

Integrates Pubky decentralized identity into Bitkit, allowing users to create a Bitkit-managed profile or connect via Pubky Ring authentication. Once connected, the user's profile name and avatar appear on the home screen header, a full profile page shows their bio, links, tags, and shareable QR code, and a contacts section lists people they follow on the Pubky network.

Description

  • Dual profile creation flow — create a new profile from BIP39 seed derivation, or import via Pubky Ring deep links (pubkyauth://)
  • Profile restore — when creating a profile, if one already exists on the network for the derived keys, it is detected and pre-populated (name, bio, links, tags preserved)
  • Ring auth import flow — after Ring authentication, discover existing profile and contacts from pubky.app, present import overview with "Import all" or "Select" options, then proceed to Pay Contacts
    onboarding
  • Pay Contacts onboarding — new step after both create and Ring import flows, with toggle for sharing payment data
  • Profile page displaying name, bio, links, tags, and a QR code with the profile picture overlaid
  • Profile editing — edit name, bio, avatar, links, and tags with suggestion sheets
  • Contacts list with search, add button, and flat "Contacts" section header
  • Contact detail page showing name, truncated public key, bio, links, tags, and copy/share/edit/delete actions
  • Contact import — overview screen showing found profile & contacts count with avatar stack, selection screen with select all/none, batch import
  • Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
  • Edit contact — edit name, bio, links, tags with delete option
  • Home screen integration showing the authenticated user's name and avatar in the header
  • Session restoration — automatic re-sign-in using stored secret key when session import fails (Bitkit-managed); session preserved on failure for retry on next launch (Ring-managed); toast notification when
    restoration fails
  • PubkyAuth approval — handles pubkyauth:// URLs from QR scans and deep links, biometric auth before approval, three-state sheet (authorize → authorizing → success)
  • PubkyService — service layer wrapping bitkit-core (auth relay, PKDNS file fetching, key derivation, homeserver operations) and paykit (session management)
  • PubkyRepo — manages auth state, session lifecycle, key derivation, profile creation/editing, contact CRUD, homeserver file operations, and auth approval
  • PubkyProfileData backward-compatible decoding — tags field defaults to empty array when missing from JSON (older profiles, other clients)
  • Suggestion card auto-dismiss when user is already authenticated
  • Bumped bitkit-core to v0.1.56 — adds key derivation, homeserver session operations, auth approval FFI functions

Key new files

FilePurpose
services/PubkyService.ktFFI bridge to bitkit-core and paykit
repositories/PubkyRepo.ktAuth state, session persistence, key derivation, profile/contact CRUD
models/PubkyProfile.ktProfile/contact data models with backward-compatible JSON decoding
models/PubkyAuthRequest.ktAuth request capability parsing
ui/components/CenteredProfileHeader.ktReusable centered profile header (avatar, name, key, bio)
ui/components/ProfileEditForm.ktReusable form for profile/contact editing
ui/components/AddLinkSheet.ktAdd link bottom sheet with suggestions
ui/components/AddTagSheet.ktAdd tag bottom sheet with suggestions
ui/screens/profile/PubkyChoiceScreen.ktCreate vs Ring import choice
ui/screens/profile/CreateProfileScreen.ktProfile creation with restore detection
ui/screens/profile/EditProfileScreen.ktProfile editing with avatar upload
ui/screens/profile/PayContactsScreen.ktPay Contacts onboarding step
ui/screens/profile/PubkyAuthApprovalSheet.ktAuth approval as authenticator
ui/screens/contacts/AddContactScreen.ktAdd contact by public key or QR
ui/screens/contacts/EditContactScreen.ktEdit contact details
ui/screens/contacts/ContactImportOverviewScreen.ktImport overview (profile + contacts summary)
ui/screens/contacts/ContactImportSelectScreen.ktSelectable contact list for import
tests/PubkyProfileDataTest.ktJSON encode/decode and backward compatibility tests
tests/PubkyAuthRequestTest.ktCapability parsing tests

QA Notes

  • Fresh install: tap Profile in drawer → shows intro → continue → choice screen (Create / Import with Ring)
  • Create flow: Create Profile → enter name, pick avatar → Continue → Pay Contacts → Profile page
  • Create restore: If profile already exists for derived keys, name is pre-populated and title shows "Restore Profile"
  • Ring flow: Import with Ring → opens Pubky Ring → approve → returns to Bitkit → Import Overview → Import All or Select → Pay Contacts → Profile page
  • Ring flow (no contacts): If no remote contacts found, skip import and go to Pay Contacts
  • Import select: Can select all, select none, or pick individual contacts
  • Profile page shows name, bio, links, tags, QR code with profile picture overlay
  • Edit profile: tap edit → modify name/bio/links/tags → save → updated
  • Home header shows profile name and avatar after authentication
  • Kill and relaunch app → session restored, profile/contacts shown without re-auth
  • Kill and relaunch with no network → session preserved, toast shown, next launch with network restores
  • Sign out from profile page → returns to unauthenticated state, contacts cleared
  • Contacts list shows "My Profile" row, contacts section, search, and add button
  • Add contact by public key → fetches profile → shows preview with privacy notice → save
  • Add contact via QR scan → opens scanner → scans pubky → navigates to add contact
  • Edit contact → modify details → save → changes reflected in detail view
  • Delete contact from edit screen → confirmation → removed
  • Inline tag add/remove on contact detail → persists immediately
  • Scan pubkyauth:// QR code → shows approval sheet with permissions → biometric → authorize → success
  • Receive pubkyauth:// deep link → same approval flow
  • Suggestion sheets for links and tags show lightbulb icon and predefined suggestions

claude[bot]
claudeBot reviewed Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt Outdated
claude[bot]
claudeBot reviewed Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt Outdated
claude[bot]
claudeBot reviewed Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt Outdated
claude[bot]
claudeBot reviewed Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot reviewed Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyChoiceViewModel.kt
claude[bot]
claudeBot reviewed Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt Outdated
@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot reviewed Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt Outdated
claude[bot]
claudeBot reviewed Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt Outdated
claude[bot]
claudeBot reviewed Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt Outdated
claude[bot]
claudeBot reviewed Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt Outdated
claude[bot]
claudeBot reviewed Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt Outdated
github-advanced-security[bot]
github-advanced-securityAI found potential problems Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt Fixed
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt Fixed
claude[bot]

This comment was marked as outdated.

Sign in to view

@jvsena42

This comment was marked as outdated.

Sign in to view
@ovitrifovitrif added this to the 2.2.0 milestone Mar 9, 2026
@piotr-iohk

piotr-iohk commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Create Profile flow testing

  • Create Profile
  • Edit / Delete Profile
  • Add / Edit / Delete Contacts

1. Create profile - OK.

2. Edit / Delete profile

  • "Disconnect" - should not be there (by Figma)
Screenshot 2026-04-10 at 10 48 27
  • "Delete profile" - says profile will be deleted permanently - but when you create profile again - it is the same pubky (not sure if that is expected).
Screen.Recording.2026-04-10.at.10.54.33.mov
  • After adding link we get back to edit profile and the keyboard becomes active - seems unnecesary.
Screen.Recording.2026-04-10.at.11.05.22.mov
  • Keyboard can cover the edit field.
Screen.Recording.2026-04-10.at.11.07.26.mov

3. Add contact

  • Empty contact list should show profile and "Add contact" button (Figma)
  • you can add yourself as contact - should not be possible. (both iOS and Android)
Screen.Recording.2026-04-10.at.11.34.19.mov
  • Adding new contact:
    • note: Input length looks unbounded; worth defining and enforcing a sensible maximum.
    • whoops! contact added on fake pubky:
Screen.Recording.2026-04-10.at.12.00.12.mov

4. Edit / Delete contact

  • edit contact shows "Your Pubky" - should show "Pubky" (both iOS and Android)
Screenshot 2026-04-10 at 11 41 55
  • "Please note..." sentence needs to be updated.
  • Cannot edit / update avatar - probably should be possible.

@ben-kaufman

ben-kaufman commented Apr 10, 2026

Copy link
Copy Markdown
ContributorAuthor

Same pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.

@piotr-iohk

piotr-iohk commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

ame pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.

I suppose this needs to be updated then:

Screenshot 2026-04-10 at 12 23 50

@ben-kaufman

ben-kaufman commented Apr 10, 2026

Copy link
Copy Markdown
ContributorAuthor

No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"

@piotr-iohk

piotr-iohk commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"

Hm, it's also not like the profile is entirely deleted. From what I see only profile details (bio, links, tags) are deleted but the contacts are preserved.

@ben-kaufman@claude
fix: address pr review and claude.md compliance
a9489ca
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-advanced-security[bot]
github-advanced-securityBot found potential problems Apr 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt Fixed
ben-kaufmanand others added 2 commits April 10, 2026 15:12
@ben-kaufman@claude
fix: suppress large class detekt warning
2051774
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman@claude
fix: delete contacts on profile deletion
1e38929
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman

ben-kaufman commented Apr 10, 2026

Copy link
Copy Markdown
ContributorAuthor

@piotr-iohk ah yes I missed that, fixed

@piotr-iohk

piotr-iohk commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Additional observation (on 1e38929):

1.

  • create wallet -> create profile -> make backup -> reset wallet -> restore wallet.

Expected:

  • profile should be there after restoration

Actual:

  • profile is "disconnected"

2. It would be great if we could have same behavior on pubky validation when adding contacts (currently differs on iOS - validation on pubky input vs Android - validation after taping add, on Android also subsequent Retry button does not work). It would make things consistent + easier for e2e tests. 🙏

@ben-kaufman

ben-kaufman commented Apr 10, 2026

Copy link
Copy Markdown
ContributorAuthor

About 1, agree it makes sense, but backup and restore should ideally be done in a separate PR since this is already too large and they are a separate area of work.

Not sure I understood what you refer to in 2, can you please explain?

@piotr-iohk

piotr-iohk commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Sorry - I've added video on iOS for 2nd point: synonymdev/bitkit-ios#476 (comment)

piotr-iohk
piotr-iohk previously approved these changes Apr 20, 2026
View reviewed changes

@piotr-iohkpiotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly good functionally. There are some UI / Figma mismatches that we can clean up in a follow-up. We still need more testing before we call the feature done, but LGTM to merge this branch.

@piotr-iohkpiotr-iohk mentioned this pull request Apr 20, 2026
Merged
@jvsena42

This comment was marked as duplicate.

Sign in to view
@jvsena42

jvsena42 commented Apr 20, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard

Failed testing this scenario

Edit: As far as I can see, it is not implemented, could be addressed to other PR

Screen_recording_20260420_135248.webm

jvsena42
jvsena42 approved these changes Apr 20, 2026
View reviewed changes

@jvsena42jvsena42 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Sign-in with Pubky ring
✅ Copy contact key
✅ Pubky app data imported successfully
✅ Add contact from drawer option

⚠️ Nits for addressing in the next PRs:

  • Couldn't test create account by Bitkit (home gate endpoint not available)
  • Reset wallet -> restore -> Is not restoring the profile
  • Expected copy the profile key on QR code click
  • Expected decode the profile key when pasting in home

@ben-kaufman

ben-kaufman commented Apr 21, 2026

Copy link
Copy Markdown
ContributorAuthor

Restore will be handled in a following PR.

Expected copy the profile key on QR code key
Expected decode the profile key when pasting in home

Can you please explain what you meant in these?

@jvsena42

jvsena42 commented Apr 21, 2026

Copy link
Copy Markdown
Member

Restore will be handled in a following PR.

Expected copy the profile key on QR code key
Expected decode the profile key when pasting in home

Can you please explain what you meant in these?

  1. Expected copy the profile key on QR code click, like in payment sheet
Screen_recording_20260421_064459.webm
  1. Expected decode the profile key when pasting in home, like when opening a channel

#824 (comment)

ovitrif
ovitrif approved these changes Apr 22, 2026
View reviewed changes

@ovitrifovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ovitrif
ovitrif merged commit bad9821 into masterApr 22, 2026
18 checks passed
@ovitrif
ovitrif deleted the feat/pubky-profile branch April 22, 2026 08:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@ovitrifovitrifovitrif approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@piotr-iohkpiotr-iohkpiotr-iohk left review comments
+1 more reviewer
@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ben-kaufmanben-kaufman

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ben-kaufman@jvsena42@piotr-iohk@ovitrif@github-advanced-security@pwltr
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: add profile and contacts fetching from pubky - #824
Merged
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Apr 22, 2026
Merged
feat: add profile and contacts fetching from pubky#824
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Mar 5, 2026•

edited by ovitrif

Loading

Copy link


Copy Markdown

Contributor
Integrates Pubky decentralized identity into Bitkit, allowing users to create a Bitkit-managed profile or connect via Pubky Ring authentication. Once connected, the user's profile name and avatar appear on the home screen header, a full profile page shows their bio, links, tags, and shareable QR code, and a contacts section lists people they follow on the Pubky network.
Description
  • Dual profile creation flow — create a new profile from BIP39 seed derivation, or import via Pubky Ring deep links (pubkyauth://)
  • Profile restore — when creating a profile, if one already exists on the network for the derived keys, it is detected and pre-populated (name, bio, links, tags preserved)
  • Ring auth import flow — after Ring authentication, discover existing profile and contacts from pubky.app, present import overview with "Import all" or "Select" options, then proceed to Pay Contacts
    
onboarding
  • Pay Contacts onboarding — new step after both create and Ring import flows, with toggle for sharing payment data
  • Profile page displaying name, bio, links, tags, and a QR code with the profile picture overlaid
  • Profile editing — edit name, bio, avatar, links, and tags with suggestion sheets
  • Contacts list with search, add button, and flat "Contacts" section header
  • Contact detail page showing name, truncated public key, bio, links, tags, and copy/share/edit/delete actions
  • Contact import — overview screen showing found profile & contacts count with avatar stack, selection screen with select all/none, batch import
  • Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
  • Edit contact — edit name, bio, links, tags with delete option
  • Home screen integration showing the authenticated user's name and avatar in the header
  • Session restoration — automatic re-sign-in using stored secret key when session import fails (Bitkit-managed); session preserved on failure for retry on next launch (Ring-managed); toast notification when
    
restoration fails
  • PubkyAuth approval — handles pubkyauth:// URLs from QR scans and deep links, biometric auth before approval, three-state sheet (authorize → authorizing → success)
  • PubkyService — service layer wrapping bitkit-core (auth relay, PKDNS file fetching, key derivation, homeserver operations) and paykit (session management)
  • PubkyRepo — manages auth state, session lifecycle, key derivation, profile creation/editing, contact CRUD, homeserver file operations, and auth approval
  • PubkyProfileData backward-compatible decoding — tags field defaults to empty array when missing from JSON (older profiles, other clients)
  • Suggestion card auto-dismiss when user is already authenticated
  • Bumped bitkit-core to v0.1.56 — adds key derivation, homeserver session operations, auth approval FFI functions
Key new files
FilePurpose
services/PubkyService.ktFFI bridge to bitkit-core and paykit
repositories/PubkyRepo.ktAuth state, session persistence, key derivation, profile/contact CRUD
models/PubkyProfile.ktProfile/contact data models with backward-compatible JSON decoding
models/PubkyAuthRequest.ktAuth request capability parsing
ui/components/CenteredProfileHeader.ktReusable centered profile header (avatar, name, key, bio)
ui/components/ProfileEditForm.ktReusable form for profile/contact editing
ui/components/AddLinkSheet.ktAdd link bottom sheet with suggestions
ui/components/AddTagSheet.ktAdd tag bottom sheet with suggestions
ui/screens/profile/PubkyChoiceScreen.ktCreate vs Ring import choice
ui/screens/profile/CreateProfileScreen.ktProfile creation with restore detection
ui/screens/profile/EditProfileScreen.ktProfile editing with avatar upload
ui/screens/profile/PayContactsScreen.ktPay Contacts onboarding step
ui/screens/profile/PubkyAuthApprovalSheet.ktAuth approval as authenticator
ui/screens/contacts/AddContactScreen.ktAdd contact by public key or QR
ui/screens/contacts/EditContactScreen.ktEdit contact details
ui/screens/contacts/ContactImportOverviewScreen.ktImport overview (profile + contacts summary)
ui/screens/contacts/ContactImportSelectScreen.ktSelectable contact list for import
tests/PubkyProfileDataTest.ktJSON encode/decode and backward compatibility tests
tests/PubkyAuthRequestTest.ktCapability parsing tests
QA Notes
  •  Fresh install: tap Profile in drawer → shows intro → continue → choice screen (Create / Import with Ring)
  • Create flow: Create Profile → enter name, pick avatar → Continue → Pay Contacts → Profile page
  • Create restore: If profile already exists for derived keys, name is pre-populated and title shows "Restore Profile"
  • Ring flow: Import with Ring → opens Pubky Ring → approve → returns to Bitkit → Import Overview → Import All or Select → Pay Contacts → Profile page
  • Ring flow (no contacts): If no remote contacts found, skip import and go to Pay Contacts
  • Import select: Can select all, select none, or pick individual contacts
  •  Profile page shows name, bio, links, tags, QR code with profile picture overlay
  •  Edit profile: tap edit → modify name/bio/links/tags → save → updated
  •  Home header shows profile name and avatar after authentication
  •  Kill and relaunch app → session restored, profile/contacts shown without re-auth
  •  Kill and relaunch with no network → session preserved, toast shown, next launch with network restores
  •  Sign out from profile page → returns to unauthenticated state, contacts cleared
  •  Contacts list shows "My Profile" row, contacts section, search, and add button
  •  Add contact by public key → fetches profile → shows preview with privacy notice → save
  •  Add contact via QR scan → opens scanner → scans pubky → navigates to add contact
  •  Edit contact → modify details → save → changes reflected in detail view
  •  Delete contact from edit screen → confirmation → removed
  •  Inline tag add/remove on contact detail → persists immediately
  •  Scan pubkyauth:// QR code → shows approval sheet with permissions → biometric → authorize → success
  •  Receive pubkyauth:// deep link → same approval flow
  •  Suggestion sheets for links and tags show lightbulb icon and predefined suggestions
claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyChoiceViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt
Outdated

github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

claude[bot]

This comment was marked as outdated.

Sign in to view
@jvsena42

This comment was marked as outdated.

Sign in to view
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 9, 2026
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Create Profile flow testing
  • Create Profile
  • Edit / Delete Profile
  • Add / Edit / Delete Contacts
1. Create profile - OK.
2. Edit / Delete profile
  • "Disconnect" - should not be there (by Figma)
Screenshot 2026-04-10 at 10 48 27
  • "Delete profile" - says profile will be deleted permanently - but when you create profile again - it is the same pubky (not sure if that is expected).
Screen.Recording.2026-04-10.at.10.54.33.mov
  • After adding link we get back to edit profile and the keyboard becomes active - seems unnecesary.
Screen.Recording.2026-04-10.at.11.05.22.mov
  • Keyboard can cover the edit field.
Screen.Recording.2026-04-10.at.11.07.26.mov
3. Add contact
  • Empty contact list should show profile and "Add contact" button (Figma)
  • you can add yourself as contact - should not be possible. (both iOS and Android)
Screen.Recording.2026-04-10.at.11.34.19.mov
  • Adding new contact:

    • note: Input length looks unbounded; worth defining and enforcing a sensible maximum.
    • whoops! contact added on fake pubky:
Screen.Recording.2026-04-10.at.12.00.12.mov
4. Edit / Delete contact
  • edit contact shows "Your Pubky" - should show "Pubky" (both iOS and Android)
Screenshot 2026-04-10 at 11 41 55
  • "Please note..." sentence needs to be updated.
  • Cannot edit / update avatar - probably should be possible.
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
Same pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
ame pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
I suppose this needs to be updated then:
Screenshot 2026-04-10 at 12 23 50
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
Hm, it's also not like the profile is entirely deleted. From what I see only profile details (bio, links, tags) are deleted but the contacts are preserved.
@ben-kaufman@claude
fix: address pr review and claude.md compliance
a9489ca
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Apr 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

ben-kaufmanand others
added 2 commits
April 10, 2026 15:12
@ben-kaufman@claude
fix: suppress large class detekt warning
2051774
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman@claude
fix: delete contacts on profile deletion
1e38929
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@piotr-iohk ah yes I missed that, fixed
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Additional observation (on 1e38929):
1.
  • create wallet -> create profile -> make backup -> reset wallet -> restore wallet.
Expected:
  • profile should be there after restoration
Actual:
  • profile is "disconnected"
2. It would be great if we could have same behavior on pubky validation when adding contacts (currently differs on iOS - validation on pubky input vs Android - validation after taping add, on Android also subsequent Retry button does not work). It would make things consistent + easier for e2e tests. 🙏
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
About 1, agree it makes sense, but backup and restore should ideally be done in a separate PR since this is already too large and they are a separate area of work.
Not sure I understood what you refer to in 2, can you please explain?
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Sorry - I've added video on iOS for 2nd point: synonymdev/bitkit-ios#476 (comment)
piotr-iohk
piotr-iohk
previously approved these changes
Apr 20, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly good functionally. There are some UI / Figma mismatches that we can clean up in a follow-up. We still need more testing before we call the feature done, but LGTM to merge this branch.
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 20, 2026
 Merged

@jvsena42

This comment was marked as duplicate.

Sign in to view
@jvsena42
jvsena42
commented
Apr 20, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
Failed testing this scenario
Edit: As far as I can see, it is not implemented, could be addressed to other PR
Screen_recording_20260420_135248.webm
jvsena42
jvsena42
approved these changes
Apr 20, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Sign-in with Pubky ring

✅ Copy contact key

✅ Pubky app data imported successfully

✅ Add contact from drawer option
⚠️ Nits for addressing in the next PRs:
  • Couldn't test create account by Bitkit (home gate endpoint not available)
  • Reset wallet -> restore -> Is not restoring the profile
  • Expected copy the profile key on QR code click
  • Expected decode the profile key when pasting in home
@ben-kaufman
ben-kaufman
commented
Apr 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
@jvsena42
jvsena42
commented
Apr 21, 2026

Copy link


Copy Markdown

Member
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
  1. Expected copy the profile key on QR code click, like in payment sheet
Screen_recording_20260421_064459.webm
  1. Expected decode the profile key when pasting in home, like when opening a channel
#824 (comment)
ovitrif
ovitrif
approved these changes
Apr 22, 2026
View reviewed changes
@ovitrifovitrif
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@ovitrif
ovitrif
merged commit bad9821
into
masterApr 22, 2026

18 checks passed

@ovitrif
ovitrif
deleted the

feat/pubky-profile

branch
April 22, 2026 08:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@ovitrifovitrifovitrif approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@piotr-iohkpiotr-iohkpiotr-iohk left review comments

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ben-kaufman@jvsena42@piotr-iohk@ovitrif@github-advanced-security@pwltr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: add profile and contacts fetching from pubky - #824
Merged
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Apr 22, 2026
Merged
feat: add profile and contacts fetching from pubky#824
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Mar 5, 2026•

edited by ovitrif

Loading

Copy link


Copy Markdown

Contributor
Integrates Pubky decentralized identity into Bitkit, allowing users to create a Bitkit-managed profile or connect via Pubky Ring authentication. Once connected, the user's profile name and avatar appear on the home screen header, a full profile page shows their bio, links, tags, and shareable QR code, and a contacts section lists people they follow on the Pubky network.
Description
  • Dual profile creation flow — create a new profile from BIP39 seed derivation, or import via Pubky Ring deep links (pubkyauth://)
  • Profile restore — when creating a profile, if one already exists on the network for the derived keys, it is detected and pre-populated (name, bio, links, tags preserved)
  • Ring auth import flow — after Ring authentication, discover existing profile and contacts from pubky.app, present import overview with "Import all" or "Select" options, then proceed to Pay Contacts
    
onboarding
  • Pay Contacts onboarding — new step after both create and Ring import flows, with toggle for sharing payment data
  • Profile page displaying name, bio, links, tags, and a QR code with the profile picture overlaid
  • Profile editing — edit name, bio, avatar, links, and tags with suggestion sheets
  • Contacts list with search, add button, and flat "Contacts" section header
  • Contact detail page showing name, truncated public key, bio, links, tags, and copy/share/edit/delete actions
  • Contact import — overview screen showing found profile & contacts count with avatar stack, selection screen with select all/none, batch import
  • Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
  • Edit contact — edit name, bio, links, tags with delete option
  • Home screen integration showing the authenticated user's name and avatar in the header
  • Session restoration — automatic re-sign-in using stored secret key when session import fails (Bitkit-managed); session preserved on failure for retry on next launch (Ring-managed); toast notification when
    
restoration fails
  • PubkyAuth approval — handles pubkyauth:// URLs from QR scans and deep links, biometric auth before approval, three-state sheet (authorize → authorizing → success)
  • PubkyService — service layer wrapping bitkit-core (auth relay, PKDNS file fetching, key derivation, homeserver operations) and paykit (session management)
  • PubkyRepo — manages auth state, session lifecycle, key derivation, profile creation/editing, contact CRUD, homeserver file operations, and auth approval
  • PubkyProfileData backward-compatible decoding — tags field defaults to empty array when missing from JSON (older profiles, other clients)
  • Suggestion card auto-dismiss when user is already authenticated
  • Bumped bitkit-core to v0.1.56 — adds key derivation, homeserver session operations, auth approval FFI functions
Key new files
FilePurpose
services/PubkyService.ktFFI bridge to bitkit-core and paykit
repositories/PubkyRepo.ktAuth state, session persistence, key derivation, profile/contact CRUD
models/PubkyProfile.ktProfile/contact data models with backward-compatible JSON decoding
models/PubkyAuthRequest.ktAuth request capability parsing
ui/components/CenteredProfileHeader.ktReusable centered profile header (avatar, name, key, bio)
ui/components/ProfileEditForm.ktReusable form for profile/contact editing
ui/components/AddLinkSheet.ktAdd link bottom sheet with suggestions
ui/components/AddTagSheet.ktAdd tag bottom sheet with suggestions
ui/screens/profile/PubkyChoiceScreen.ktCreate vs Ring import choice
ui/screens/profile/CreateProfileScreen.ktProfile creation with restore detection
ui/screens/profile/EditProfileScreen.ktProfile editing with avatar upload
ui/screens/profile/PayContactsScreen.ktPay Contacts onboarding step
ui/screens/profile/PubkyAuthApprovalSheet.ktAuth approval as authenticator
ui/screens/contacts/AddContactScreen.ktAdd contact by public key or QR
ui/screens/contacts/EditContactScreen.ktEdit contact details
ui/screens/contacts/ContactImportOverviewScreen.ktImport overview (profile + contacts summary)
ui/screens/contacts/ContactImportSelectScreen.ktSelectable contact list for import
tests/PubkyProfileDataTest.ktJSON encode/decode and backward compatibility tests
tests/PubkyAuthRequestTest.ktCapability parsing tests
QA Notes
  •  Fresh install: tap Profile in drawer → shows intro → continue → choice screen (Create / Import with Ring)
  • Create flow: Create Profile → enter name, pick avatar → Continue → Pay Contacts → Profile page
  • Create restore: If profile already exists for derived keys, name is pre-populated and title shows "Restore Profile"
  • Ring flow: Import with Ring → opens Pubky Ring → approve → returns to Bitkit → Import Overview → Import All or Select → Pay Contacts → Profile page
  • Ring flow (no contacts): If no remote contacts found, skip import and go to Pay Contacts
  • Import select: Can select all, select none, or pick individual contacts
  •  Profile page shows name, bio, links, tags, QR code with profile picture overlay
  •  Edit profile: tap edit → modify name/bio/links/tags → save → updated
  •  Home header shows profile name and avatar after authentication
  •  Kill and relaunch app → session restored, profile/contacts shown without re-auth
  •  Kill and relaunch with no network → session preserved, toast shown, next launch with network restores
  •  Sign out from profile page → returns to unauthenticated state, contacts cleared
  •  Contacts list shows "My Profile" row, contacts section, search, and add button
  •  Add contact by public key → fetches profile → shows preview with privacy notice → save
  •  Add contact via QR scan → opens scanner → scans pubky → navigates to add contact
  •  Edit contact → modify details → save → changes reflected in detail view
  •  Delete contact from edit screen → confirmation → removed
  •  Inline tag add/remove on contact detail → persists immediately
  •  Scan pubkyauth:// QR code → shows approval sheet with permissions → biometric → authorize → success
  •  Receive pubkyauth:// deep link → same approval flow
  •  Suggestion sheets for links and tags show lightbulb icon and predefined suggestions
claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyChoiceViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt
Outdated

github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

claude[bot]

This comment was marked as outdated.

Sign in to view
@jvsena42

This comment was marked as outdated.

Sign in to view
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 9, 2026
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Create Profile flow testing
  • Create Profile
  • Edit / Delete Profile
  • Add / Edit / Delete Contacts
1. Create profile - OK.
2. Edit / Delete profile
  • "Disconnect" - should not be there (by Figma)
Screenshot 2026-04-10 at 10 48 27
  • "Delete profile" - says profile will be deleted permanently - but when you create profile again - it is the same pubky (not sure if that is expected).
Screen.Recording.2026-04-10.at.10.54.33.mov
  • After adding link we get back to edit profile and the keyboard becomes active - seems unnecesary.
Screen.Recording.2026-04-10.at.11.05.22.mov
  • Keyboard can cover the edit field.
Screen.Recording.2026-04-10.at.11.07.26.mov
3. Add contact
  • Empty contact list should show profile and "Add contact" button (Figma)
  • you can add yourself as contact - should not be possible. (both iOS and Android)
Screen.Recording.2026-04-10.at.11.34.19.mov
  • Adding new contact:

    • note: Input length looks unbounded; worth defining and enforcing a sensible maximum.
    • whoops! contact added on fake pubky:
Screen.Recording.2026-04-10.at.12.00.12.mov
4. Edit / Delete contact
  • edit contact shows "Your Pubky" - should show "Pubky" (both iOS and Android)
Screenshot 2026-04-10 at 11 41 55
  • "Please note..." sentence needs to be updated.
  • Cannot edit / update avatar - probably should be possible.
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
Same pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
ame pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
I suppose this needs to be updated then:
Screenshot 2026-04-10 at 12 23 50
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
Hm, it's also not like the profile is entirely deleted. From what I see only profile details (bio, links, tags) are deleted but the contacts are preserved.
@ben-kaufman@claude
fix: address pr review and claude.md compliance
a9489ca
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Apr 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

ben-kaufmanand others
added 2 commits
April 10, 2026 15:12
@ben-kaufman@claude
fix: suppress large class detekt warning
2051774
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman@claude
fix: delete contacts on profile deletion
1e38929
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@piotr-iohk ah yes I missed that, fixed
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Additional observation (on 1e38929):
1.
  • create wallet -> create profile -> make backup -> reset wallet -> restore wallet.
Expected:
  • profile should be there after restoration
Actual:
  • profile is "disconnected"
2. It would be great if we could have same behavior on pubky validation when adding contacts (currently differs on iOS - validation on pubky input vs Android - validation after taping add, on Android also subsequent Retry button does not work). It would make things consistent + easier for e2e tests. 🙏
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
About 1, agree it makes sense, but backup and restore should ideally be done in a separate PR since this is already too large and they are a separate area of work.
Not sure I understood what you refer to in 2, can you please explain?
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Sorry - I've added video on iOS for 2nd point: synonymdev/bitkit-ios#476 (comment)
piotr-iohk
piotr-iohk
previously approved these changes
Apr 20, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly good functionally. There are some UI / Figma mismatches that we can clean up in a follow-up. We still need more testing before we call the feature done, but LGTM to merge this branch.
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 20, 2026
 Merged

@jvsena42

This comment was marked as duplicate.

Sign in to view
@jvsena42
jvsena42
commented
Apr 20, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
Failed testing this scenario
Edit: As far as I can see, it is not implemented, could be addressed to other PR
Screen_recording_20260420_135248.webm
jvsena42
jvsena42
approved these changes
Apr 20, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Sign-in with Pubky ring

✅ Copy contact key

✅ Pubky app data imported successfully

✅ Add contact from drawer option
⚠️ Nits for addressing in the next PRs:
  • Couldn't test create account by Bitkit (home gate endpoint not available)
  • Reset wallet -> restore -> Is not restoring the profile
  • Expected copy the profile key on QR code click
  • Expected decode the profile key when pasting in home
@ben-kaufman
ben-kaufman
commented
Apr 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
@jvsena42
jvsena42
commented
Apr 21, 2026

Copy link


Copy Markdown

Member
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
  1. Expected copy the profile key on QR code click, like in payment sheet
Screen_recording_20260421_064459.webm
  1. Expected decode the profile key when pasting in home, like when opening a channel
#824 (comment)
ovitrif
ovitrif
approved these changes
Apr 22, 2026
View reviewed changes
@ovitrifovitrif
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@ovitrif
ovitrif
merged commit bad9821
into
masterApr 22, 2026

18 checks passed

@ovitrif
ovitrif
deleted the

feat/pubky-profile

branch
April 22, 2026 08:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@ovitrifovitrifovitrif approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@piotr-iohkpiotr-iohkpiotr-iohk left review comments

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ben-kaufman@jvsena42@piotr-iohk@ovitrif@github-advanced-security@pwltr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: add profile and contacts fetching from pubky - #824
Merged
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Apr 22, 2026
Merged
feat: add profile and contacts fetching from pubky#824
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Mar 5, 2026•

edited by ovitrif

Loading

Copy link


Copy Markdown

Contributor
Integrates Pubky decentralized identity into Bitkit, allowing users to create a Bitkit-managed profile or connect via Pubky Ring authentication. Once connected, the user's profile name and avatar appear on the home screen header, a full profile page shows their bio, links, tags, and shareable QR code, and a contacts section lists people they follow on the Pubky network.
Description
  • Dual profile creation flow — create a new profile from BIP39 seed derivation, or import via Pubky Ring deep links (pubkyauth://)
  • Profile restore — when creating a profile, if one already exists on the network for the derived keys, it is detected and pre-populated (name, bio, links, tags preserved)
  • Ring auth import flow — after Ring authentication, discover existing profile and contacts from pubky.app, present import overview with "Import all" or "Select" options, then proceed to Pay Contacts
    
onboarding
  • Pay Contacts onboarding — new step after both create and Ring import flows, with toggle for sharing payment data
  • Profile page displaying name, bio, links, tags, and a QR code with the profile picture overlaid
  • Profile editing — edit name, bio, avatar, links, and tags with suggestion sheets
  • Contacts list with search, add button, and flat "Contacts" section header
  • Contact detail page showing name, truncated public key, bio, links, tags, and copy/share/edit/delete actions
  • Contact import — overview screen showing found profile & contacts count with avatar stack, selection screen with select all/none, batch import
  • Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
  • Edit contact — edit name, bio, links, tags with delete option
  • Home screen integration showing the authenticated user's name and avatar in the header
  • Session restoration — automatic re-sign-in using stored secret key when session import fails (Bitkit-managed); session preserved on failure for retry on next launch (Ring-managed); toast notification when
    
restoration fails
  • PubkyAuth approval — handles pubkyauth:// URLs from QR scans and deep links, biometric auth before approval, three-state sheet (authorize → authorizing → success)
  • PubkyService — service layer wrapping bitkit-core (auth relay, PKDNS file fetching, key derivation, homeserver operations) and paykit (session management)
  • PubkyRepo — manages auth state, session lifecycle, key derivation, profile creation/editing, contact CRUD, homeserver file operations, and auth approval
  • PubkyProfileData backward-compatible decoding — tags field defaults to empty array when missing from JSON (older profiles, other clients)
  • Suggestion card auto-dismiss when user is already authenticated
  • Bumped bitkit-core to v0.1.56 — adds key derivation, homeserver session operations, auth approval FFI functions
Key new files
FilePurpose
services/PubkyService.ktFFI bridge to bitkit-core and paykit
repositories/PubkyRepo.ktAuth state, session persistence, key derivation, profile/contact CRUD
models/PubkyProfile.ktProfile/contact data models with backward-compatible JSON decoding
models/PubkyAuthRequest.ktAuth request capability parsing
ui/components/CenteredProfileHeader.ktReusable centered profile header (avatar, name, key, bio)
ui/components/ProfileEditForm.ktReusable form for profile/contact editing
ui/components/AddLinkSheet.ktAdd link bottom sheet with suggestions
ui/components/AddTagSheet.ktAdd tag bottom sheet with suggestions
ui/screens/profile/PubkyChoiceScreen.ktCreate vs Ring import choice
ui/screens/profile/CreateProfileScreen.ktProfile creation with restore detection
ui/screens/profile/EditProfileScreen.ktProfile editing with avatar upload
ui/screens/profile/PayContactsScreen.ktPay Contacts onboarding step
ui/screens/profile/PubkyAuthApprovalSheet.ktAuth approval as authenticator
ui/screens/contacts/AddContactScreen.ktAdd contact by public key or QR
ui/screens/contacts/EditContactScreen.ktEdit contact details
ui/screens/contacts/ContactImportOverviewScreen.ktImport overview (profile + contacts summary)
ui/screens/contacts/ContactImportSelectScreen.ktSelectable contact list for import
tests/PubkyProfileDataTest.ktJSON encode/decode and backward compatibility tests
tests/PubkyAuthRequestTest.ktCapability parsing tests
QA Notes
  •  Fresh install: tap Profile in drawer → shows intro → continue → choice screen (Create / Import with Ring)
  • Create flow: Create Profile → enter name, pick avatar → Continue → Pay Contacts → Profile page
  • Create restore: If profile already exists for derived keys, name is pre-populated and title shows "Restore Profile"
  • Ring flow: Import with Ring → opens Pubky Ring → approve → returns to Bitkit → Import Overview → Import All or Select → Pay Contacts → Profile page
  • Ring flow (no contacts): If no remote contacts found, skip import and go to Pay Contacts
  • Import select: Can select all, select none, or pick individual contacts
  •  Profile page shows name, bio, links, tags, QR code with profile picture overlay
  •  Edit profile: tap edit → modify name/bio/links/tags → save → updated
  •  Home header shows profile name and avatar after authentication
  •  Kill and relaunch app → session restored, profile/contacts shown without re-auth
  •  Kill and relaunch with no network → session preserved, toast shown, next launch with network restores
  •  Sign out from profile page → returns to unauthenticated state, contacts cleared
  •  Contacts list shows "My Profile" row, contacts section, search, and add button
  •  Add contact by public key → fetches profile → shows preview with privacy notice → save
  •  Add contact via QR scan → opens scanner → scans pubky → navigates to add contact
  •  Edit contact → modify details → save → changes reflected in detail view
  •  Delete contact from edit screen → confirmation → removed
  •  Inline tag add/remove on contact detail → persists immediately
  •  Scan pubkyauth:// QR code → shows approval sheet with permissions → biometric → authorize → success
  •  Receive pubkyauth:// deep link → same approval flow
  •  Suggestion sheets for links and tags show lightbulb icon and predefined suggestions
claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyChoiceViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt
Outdated

github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

claude[bot]

This comment was marked as outdated.

Sign in to view
@jvsena42

This comment was marked as outdated.

Sign in to view
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 9, 2026
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Create Profile flow testing
  • Create Profile
  • Edit / Delete Profile
  • Add / Edit / Delete Contacts
1. Create profile - OK.
2. Edit / Delete profile
  • "Disconnect" - should not be there (by Figma)
Screenshot 2026-04-10 at 10 48 27
  • "Delete profile" - says profile will be deleted permanently - but when you create profile again - it is the same pubky (not sure if that is expected).
Screen.Recording.2026-04-10.at.10.54.33.mov
  • After adding link we get back to edit profile and the keyboard becomes active - seems unnecesary.
Screen.Recording.2026-04-10.at.11.05.22.mov
  • Keyboard can cover the edit field.
Screen.Recording.2026-04-10.at.11.07.26.mov
3. Add contact
  • Empty contact list should show profile and "Add contact" button (Figma)
  • you can add yourself as contact - should not be possible. (both iOS and Android)
Screen.Recording.2026-04-10.at.11.34.19.mov
  • Adding new contact:

    • note: Input length looks unbounded; worth defining and enforcing a sensible maximum.
    • whoops! contact added on fake pubky:
Screen.Recording.2026-04-10.at.12.00.12.mov
4. Edit / Delete contact
  • edit contact shows "Your Pubky" - should show "Pubky" (both iOS and Android)
Screenshot 2026-04-10 at 11 41 55
  • "Please note..." sentence needs to be updated.
  • Cannot edit / update avatar - probably should be possible.
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
Same pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
ame pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
I suppose this needs to be updated then:
Screenshot 2026-04-10 at 12 23 50
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
Hm, it's also not like the profile is entirely deleted. From what I see only profile details (bio, links, tags) are deleted but the contacts are preserved.
@ben-kaufman@claude
fix: address pr review and claude.md compliance
a9489ca
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Apr 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

ben-kaufmanand others
added 2 commits
April 10, 2026 15:12
@ben-kaufman@claude
fix: suppress large class detekt warning
2051774
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman@claude
fix: delete contacts on profile deletion
1e38929
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@piotr-iohk ah yes I missed that, fixed
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Additional observation (on 1e38929):
1.
  • create wallet -> create profile -> make backup -> reset wallet -> restore wallet.
Expected:
  • profile should be there after restoration
Actual:
  • profile is "disconnected"
2. It would be great if we could have same behavior on pubky validation when adding contacts (currently differs on iOS - validation on pubky input vs Android - validation after taping add, on Android also subsequent Retry button does not work). It would make things consistent + easier for e2e tests. 🙏
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
About 1, agree it makes sense, but backup and restore should ideally be done in a separate PR since this is already too large and they are a separate area of work.
Not sure I understood what you refer to in 2, can you please explain?
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Sorry - I've added video on iOS for 2nd point: synonymdev/bitkit-ios#476 (comment)
piotr-iohk
piotr-iohk
previously approved these changes
Apr 20, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly good functionally. There are some UI / Figma mismatches that we can clean up in a follow-up. We still need more testing before we call the feature done, but LGTM to merge this branch.
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 20, 2026
 Merged

@jvsena42

This comment was marked as duplicate.

Sign in to view
@jvsena42
jvsena42
commented
Apr 20, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
Failed testing this scenario
Edit: As far as I can see, it is not implemented, could be addressed to other PR
Screen_recording_20260420_135248.webm
jvsena42
jvsena42
approved these changes
Apr 20, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Sign-in with Pubky ring

✅ Copy contact key

✅ Pubky app data imported successfully

✅ Add contact from drawer option
⚠️ Nits for addressing in the next PRs:
  • Couldn't test create account by Bitkit (home gate endpoint not available)
  • Reset wallet -> restore -> Is not restoring the profile
  • Expected copy the profile key on QR code click
  • Expected decode the profile key when pasting in home
@ben-kaufman
ben-kaufman
commented
Apr 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
@jvsena42
jvsena42
commented
Apr 21, 2026

Copy link


Copy Markdown

Member
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
  1. Expected copy the profile key on QR code click, like in payment sheet
Screen_recording_20260421_064459.webm
  1. Expected decode the profile key when pasting in home, like when opening a channel
#824 (comment)
ovitrif
ovitrif
approved these changes
Apr 22, 2026
View reviewed changes
@ovitrifovitrif
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@ovitrif
ovitrif
merged commit bad9821
into
masterApr 22, 2026

18 checks passed

@ovitrif
ovitrif
deleted the

feat/pubky-profile

branch
April 22, 2026 08:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@ovitrifovitrifovitrif approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@piotr-iohkpiotr-iohkpiotr-iohk left review comments

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ben-kaufman@jvsena42@piotr-iohk@ovitrif@github-advanced-security@pwltr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: add profile and contacts fetching from pubky - #824
Merged
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Apr 22, 2026
Merged
feat: add profile and contacts fetching from pubky#824
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Mar 5, 2026•

edited by ovitrif

Loading

Copy link


Copy Markdown

Contributor
Integrates Pubky decentralized identity into Bitkit, allowing users to create a Bitkit-managed profile or connect via Pubky Ring authentication. Once connected, the user's profile name and avatar appear on the home screen header, a full profile page shows their bio, links, tags, and shareable QR code, and a contacts section lists people they follow on the Pubky network.
Description
  • Dual profile creation flow — create a new profile from BIP39 seed derivation, or import via Pubky Ring deep links (pubkyauth://)
  • Profile restore — when creating a profile, if one already exists on the network for the derived keys, it is detected and pre-populated (name, bio, links, tags preserved)
  • Ring auth import flow — after Ring authentication, discover existing profile and contacts from pubky.app, present import overview with "Import all" or "Select" options, then proceed to Pay Contacts
    
onboarding
  • Pay Contacts onboarding — new step after both create and Ring import flows, with toggle for sharing payment data
  • Profile page displaying name, bio, links, tags, and a QR code with the profile picture overlaid
  • Profile editing — edit name, bio, avatar, links, and tags with suggestion sheets
  • Contacts list with search, add button, and flat "Contacts" section header
  • Contact detail page showing name, truncated public key, bio, links, tags, and copy/share/edit/delete actions
  • Contact import — overview screen showing found profile & contacts count with avatar stack, selection screen with select all/none, batch import
  • Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
  • Edit contact — edit name, bio, links, tags with delete option
  • Home screen integration showing the authenticated user's name and avatar in the header
  • Session restoration — automatic re-sign-in using stored secret key when session import fails (Bitkit-managed); session preserved on failure for retry on next launch (Ring-managed); toast notification when
    
restoration fails
  • PubkyAuth approval — handles pubkyauth:// URLs from QR scans and deep links, biometric auth before approval, three-state sheet (authorize → authorizing → success)
  • PubkyService — service layer wrapping bitkit-core (auth relay, PKDNS file fetching, key derivation, homeserver operations) and paykit (session management)
  • PubkyRepo — manages auth state, session lifecycle, key derivation, profile creation/editing, contact CRUD, homeserver file operations, and auth approval
  • PubkyProfileData backward-compatible decoding — tags field defaults to empty array when missing from JSON (older profiles, other clients)
  • Suggestion card auto-dismiss when user is already authenticated
  • Bumped bitkit-core to v0.1.56 — adds key derivation, homeserver session operations, auth approval FFI functions
Key new files
FilePurpose
services/PubkyService.ktFFI bridge to bitkit-core and paykit
repositories/PubkyRepo.ktAuth state, session persistence, key derivation, profile/contact CRUD
models/PubkyProfile.ktProfile/contact data models with backward-compatible JSON decoding
models/PubkyAuthRequest.ktAuth request capability parsing
ui/components/CenteredProfileHeader.ktReusable centered profile header (avatar, name, key, bio)
ui/components/ProfileEditForm.ktReusable form for profile/contact editing
ui/components/AddLinkSheet.ktAdd link bottom sheet with suggestions
ui/components/AddTagSheet.ktAdd tag bottom sheet with suggestions
ui/screens/profile/PubkyChoiceScreen.ktCreate vs Ring import choice
ui/screens/profile/CreateProfileScreen.ktProfile creation with restore detection
ui/screens/profile/EditProfileScreen.ktProfile editing with avatar upload
ui/screens/profile/PayContactsScreen.ktPay Contacts onboarding step
ui/screens/profile/PubkyAuthApprovalSheet.ktAuth approval as authenticator
ui/screens/contacts/AddContactScreen.ktAdd contact by public key or QR
ui/screens/contacts/EditContactScreen.ktEdit contact details
ui/screens/contacts/ContactImportOverviewScreen.ktImport overview (profile + contacts summary)
ui/screens/contacts/ContactImportSelectScreen.ktSelectable contact list for import
tests/PubkyProfileDataTest.ktJSON encode/decode and backward compatibility tests
tests/PubkyAuthRequestTest.ktCapability parsing tests
QA Notes
  •  Fresh install: tap Profile in drawer → shows intro → continue → choice screen (Create / Import with Ring)
  • Create flow: Create Profile → enter name, pick avatar → Continue → Pay Contacts → Profile page
  • Create restore: If profile already exists for derived keys, name is pre-populated and title shows "Restore Profile"
  • Ring flow: Import with Ring → opens Pubky Ring → approve → returns to Bitkit → Import Overview → Import All or Select → Pay Contacts → Profile page
  • Ring flow (no contacts): If no remote contacts found, skip import and go to Pay Contacts
  • Import select: Can select all, select none, or pick individual contacts
  •  Profile page shows name, bio, links, tags, QR code with profile picture overlay
  •  Edit profile: tap edit → modify name/bio/links/tags → save → updated
  •  Home header shows profile name and avatar after authentication
  •  Kill and relaunch app → session restored, profile/contacts shown without re-auth
  •  Kill and relaunch with no network → session preserved, toast shown, next launch with network restores
  •  Sign out from profile page → returns to unauthenticated state, contacts cleared
  •  Contacts list shows "My Profile" row, contacts section, search, and add button
  •  Add contact by public key → fetches profile → shows preview with privacy notice → save
  •  Add contact via QR scan → opens scanner → scans pubky → navigates to add contact
  •  Edit contact → modify details → save → changes reflected in detail view
  •  Delete contact from edit screen → confirmation → removed
  •  Inline tag add/remove on contact detail → persists immediately
  •  Scan pubkyauth:// QR code → shows approval sheet with permissions → biometric → authorize → success
  •  Receive pubkyauth:// deep link → same approval flow
  •  Suggestion sheets for links and tags show lightbulb icon and predefined suggestions
claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyChoiceViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt
Outdated

github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

claude[bot]

This comment was marked as outdated.

Sign in to view
@jvsena42

This comment was marked as outdated.

Sign in to view
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 9, 2026
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Create Profile flow testing
  • Create Profile
  • Edit / Delete Profile
  • Add / Edit / Delete Contacts
1. Create profile - OK.
2. Edit / Delete profile
  • "Disconnect" - should not be there (by Figma)
Screenshot 2026-04-10 at 10 48 27
  • "Delete profile" - says profile will be deleted permanently - but when you create profile again - it is the same pubky (not sure if that is expected).
Screen.Recording.2026-04-10.at.10.54.33.mov
  • After adding link we get back to edit profile and the keyboard becomes active - seems unnecesary.
Screen.Recording.2026-04-10.at.11.05.22.mov
  • Keyboard can cover the edit field.
Screen.Recording.2026-04-10.at.11.07.26.mov
3. Add contact
  • Empty contact list should show profile and "Add contact" button (Figma)
  • you can add yourself as contact - should not be possible. (both iOS and Android)
Screen.Recording.2026-04-10.at.11.34.19.mov
  • Adding new contact:

    • note: Input length looks unbounded; worth defining and enforcing a sensible maximum.
    • whoops! contact added on fake pubky:
Screen.Recording.2026-04-10.at.12.00.12.mov
4. Edit / Delete contact
  • edit contact shows "Your Pubky" - should show "Pubky" (both iOS and Android)
Screenshot 2026-04-10 at 11 41 55
  • "Please note..." sentence needs to be updated.
  • Cannot edit / update avatar - probably should be possible.
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
Same pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
ame pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
I suppose this needs to be updated then:
Screenshot 2026-04-10 at 12 23 50
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
Hm, it's also not like the profile is entirely deleted. From what I see only profile details (bio, links, tags) are deleted but the contacts are preserved.
@ben-kaufman@claude
fix: address pr review and claude.md compliance
a9489ca
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Apr 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

ben-kaufmanand others
added 2 commits
April 10, 2026 15:12
@ben-kaufman@claude
fix: suppress large class detekt warning
2051774
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman@claude
fix: delete contacts on profile deletion
1e38929
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@piotr-iohk ah yes I missed that, fixed
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Additional observation (on 1e38929):
1.
  • create wallet -> create profile -> make backup -> reset wallet -> restore wallet.
Expected:
  • profile should be there after restoration
Actual:
  • profile is "disconnected"
2. It would be great if we could have same behavior on pubky validation when adding contacts (currently differs on iOS - validation on pubky input vs Android - validation after taping add, on Android also subsequent Retry button does not work). It would make things consistent + easier for e2e tests. 🙏
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
About 1, agree it makes sense, but backup and restore should ideally be done in a separate PR since this is already too large and they are a separate area of work.
Not sure I understood what you refer to in 2, can you please explain?
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Sorry - I've added video on iOS for 2nd point: synonymdev/bitkit-ios#476 (comment)
piotr-iohk
piotr-iohk
previously approved these changes
Apr 20, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly good functionally. There are some UI / Figma mismatches that we can clean up in a follow-up. We still need more testing before we call the feature done, but LGTM to merge this branch.
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 20, 2026
 Merged

@jvsena42

This comment was marked as duplicate.

Sign in to view
@jvsena42
jvsena42
commented
Apr 20, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
Failed testing this scenario
Edit: As far as I can see, it is not implemented, could be addressed to other PR
Screen_recording_20260420_135248.webm
jvsena42
jvsena42
approved these changes
Apr 20, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Sign-in with Pubky ring

✅ Copy contact key

✅ Pubky app data imported successfully

✅ Add contact from drawer option
⚠️ Nits for addressing in the next PRs:
  • Couldn't test create account by Bitkit (home gate endpoint not available)
  • Reset wallet -> restore -> Is not restoring the profile
  • Expected copy the profile key on QR code click
  • Expected decode the profile key when pasting in home
@ben-kaufman
ben-kaufman
commented
Apr 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
@jvsena42
jvsena42
commented
Apr 21, 2026

Copy link


Copy Markdown

Member
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
  1. Expected copy the profile key on QR code click, like in payment sheet
Screen_recording_20260421_064459.webm
  1. Expected decode the profile key when pasting in home, like when opening a channel
#824 (comment)
ovitrif
ovitrif
approved these changes
Apr 22, 2026
View reviewed changes
@ovitrifovitrif
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@ovitrif
ovitrif
merged commit bad9821
into
masterApr 22, 2026

18 checks passed

@ovitrif
ovitrif
deleted the

feat/pubky-profile

branch
April 22, 2026 08:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@ovitrifovitrifovitrif approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@piotr-iohkpiotr-iohkpiotr-iohk left review comments

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ben-kaufman@jvsena42@piotr-iohk@ovitrif@github-advanced-security@pwltr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: add profile and contacts fetching from pubky - #824
Merged
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Apr 22, 2026
Merged
feat: add profile and contacts fetching from pubky#824
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Mar 5, 2026•

edited by ovitrif

Loading

Copy link


Copy Markdown

Contributor
Integrates Pubky decentralized identity into Bitkit, allowing users to create a Bitkit-managed profile or connect via Pubky Ring authentication. Once connected, the user's profile name and avatar appear on the home screen header, a full profile page shows their bio, links, tags, and shareable QR code, and a contacts section lists people they follow on the Pubky network.
Description
  • Dual profile creation flow — create a new profile from BIP39 seed derivation, or import via Pubky Ring deep links (pubkyauth://)
  • Profile restore — when creating a profile, if one already exists on the network for the derived keys, it is detected and pre-populated (name, bio, links, tags preserved)
  • Ring auth import flow — after Ring authentication, discover existing profile and contacts from pubky.app, present import overview with "Import all" or "Select" options, then proceed to Pay Contacts
    
onboarding
  • Pay Contacts onboarding — new step after both create and Ring import flows, with toggle for sharing payment data
  • Profile page displaying name, bio, links, tags, and a QR code with the profile picture overlaid
  • Profile editing — edit name, bio, avatar, links, and tags with suggestion sheets
  • Contacts list with search, add button, and flat "Contacts" section header
  • Contact detail page showing name, truncated public key, bio, links, tags, and copy/share/edit/delete actions
  • Contact import — overview screen showing found profile & contacts count with avatar stack, selection screen with select all/none, batch import
  • Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
  • Edit contact — edit name, bio, links, tags with delete option
  • Home screen integration showing the authenticated user's name and avatar in the header
  • Session restoration — automatic re-sign-in using stored secret key when session import fails (Bitkit-managed); session preserved on failure for retry on next launch (Ring-managed); toast notification when
    
restoration fails
  • PubkyAuth approval — handles pubkyauth:// URLs from QR scans and deep links, biometric auth before approval, three-state sheet (authorize → authorizing → success)
  • PubkyService — service layer wrapping bitkit-core (auth relay, PKDNS file fetching, key derivation, homeserver operations) and paykit (session management)
  • PubkyRepo — manages auth state, session lifecycle, key derivation, profile creation/editing, contact CRUD, homeserver file operations, and auth approval
  • PubkyProfileData backward-compatible decoding — tags field defaults to empty array when missing from JSON (older profiles, other clients)
  • Suggestion card auto-dismiss when user is already authenticated
  • Bumped bitkit-core to v0.1.56 — adds key derivation, homeserver session operations, auth approval FFI functions
Key new files
FilePurpose
services/PubkyService.ktFFI bridge to bitkit-core and paykit
repositories/PubkyRepo.ktAuth state, session persistence, key derivation, profile/contact CRUD
models/PubkyProfile.ktProfile/contact data models with backward-compatible JSON decoding
models/PubkyAuthRequest.ktAuth request capability parsing
ui/components/CenteredProfileHeader.ktReusable centered profile header (avatar, name, key, bio)
ui/components/ProfileEditForm.ktReusable form for profile/contact editing
ui/components/AddLinkSheet.ktAdd link bottom sheet with suggestions
ui/components/AddTagSheet.ktAdd tag bottom sheet with suggestions
ui/screens/profile/PubkyChoiceScreen.ktCreate vs Ring import choice
ui/screens/profile/CreateProfileScreen.ktProfile creation with restore detection
ui/screens/profile/EditProfileScreen.ktProfile editing with avatar upload
ui/screens/profile/PayContactsScreen.ktPay Contacts onboarding step
ui/screens/profile/PubkyAuthApprovalSheet.ktAuth approval as authenticator
ui/screens/contacts/AddContactScreen.ktAdd contact by public key or QR
ui/screens/contacts/EditContactScreen.ktEdit contact details
ui/screens/contacts/ContactImportOverviewScreen.ktImport overview (profile + contacts summary)
ui/screens/contacts/ContactImportSelectScreen.ktSelectable contact list for import
tests/PubkyProfileDataTest.ktJSON encode/decode and backward compatibility tests
tests/PubkyAuthRequestTest.ktCapability parsing tests
QA Notes
  •  Fresh install: tap Profile in drawer → shows intro → continue → choice screen (Create / Import with Ring)
  • Create flow: Create Profile → enter name, pick avatar → Continue → Pay Contacts → Profile page
  • Create restore: If profile already exists for derived keys, name is pre-populated and title shows "Restore Profile"
  • Ring flow: Import with Ring → opens Pubky Ring → approve → returns to Bitkit → Import Overview → Import All or Select → Pay Contacts → Profile page
  • Ring flow (no contacts): If no remote contacts found, skip import and go to Pay Contacts
  • Import select: Can select all, select none, or pick individual contacts
  •  Profile page shows name, bio, links, tags, QR code with profile picture overlay
  •  Edit profile: tap edit → modify name/bio/links/tags → save → updated
  •  Home header shows profile name and avatar after authentication
  •  Kill and relaunch app → session restored, profile/contacts shown without re-auth
  •  Kill and relaunch with no network → session preserved, toast shown, next launch with network restores
  •  Sign out from profile page → returns to unauthenticated state, contacts cleared
  •  Contacts list shows "My Profile" row, contacts section, search, and add button
  •  Add contact by public key → fetches profile → shows preview with privacy notice → save
  •  Add contact via QR scan → opens scanner → scans pubky → navigates to add contact
  •  Edit contact → modify details → save → changes reflected in detail view
  •  Delete contact from edit screen → confirmation → removed
  •  Inline tag add/remove on contact detail → persists immediately
  •  Scan pubkyauth:// QR code → shows approval sheet with permissions → biometric → authorize → success
  •  Receive pubkyauth:// deep link → same approval flow
  •  Suggestion sheets for links and tags show lightbulb icon and predefined suggestions
claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyChoiceViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt
Outdated

github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

claude[bot]

This comment was marked as outdated.

Sign in to view
@jvsena42

This comment was marked as outdated.

Sign in to view
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 9, 2026
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Create Profile flow testing
  • Create Profile
  • Edit / Delete Profile
  • Add / Edit / Delete Contacts
1. Create profile - OK.
2. Edit / Delete profile
  • "Disconnect" - should not be there (by Figma)
Screenshot 2026-04-10 at 10 48 27
  • "Delete profile" - says profile will be deleted permanently - but when you create profile again - it is the same pubky (not sure if that is expected).
Screen.Recording.2026-04-10.at.10.54.33.mov
  • After adding link we get back to edit profile and the keyboard becomes active - seems unnecesary.
Screen.Recording.2026-04-10.at.11.05.22.mov
  • Keyboard can cover the edit field.
Screen.Recording.2026-04-10.at.11.07.26.mov
3. Add contact
  • Empty contact list should show profile and "Add contact" button (Figma)
  • you can add yourself as contact - should not be possible. (both iOS and Android)
Screen.Recording.2026-04-10.at.11.34.19.mov
  • Adding new contact:

    • note: Input length looks unbounded; worth defining and enforcing a sensible maximum.
    • whoops! contact added on fake pubky:
Screen.Recording.2026-04-10.at.12.00.12.mov
4. Edit / Delete contact
  • edit contact shows "Your Pubky" - should show "Pubky" (both iOS and Android)
Screenshot 2026-04-10 at 11 41 55
  • "Please note..." sentence needs to be updated.
  • Cannot edit / update avatar - probably should be possible.
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
Same pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
ame pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
I suppose this needs to be updated then:
Screenshot 2026-04-10 at 12 23 50
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
Hm, it's also not like the profile is entirely deleted. From what I see only profile details (bio, links, tags) are deleted but the contacts are preserved.
@ben-kaufman@claude
fix: address pr review and claude.md compliance
a9489ca
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Apr 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

ben-kaufmanand others
added 2 commits
April 10, 2026 15:12
@ben-kaufman@claude
fix: suppress large class detekt warning
2051774
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman@claude
fix: delete contacts on profile deletion
1e38929
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@piotr-iohk ah yes I missed that, fixed
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Additional observation (on 1e38929):
1.
  • create wallet -> create profile -> make backup -> reset wallet -> restore wallet.
Expected:
  • profile should be there after restoration
Actual:
  • profile is "disconnected"
2. It would be great if we could have same behavior on pubky validation when adding contacts (currently differs on iOS - validation on pubky input vs Android - validation after taping add, on Android also subsequent Retry button does not work). It would make things consistent + easier for e2e tests. 🙏
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
About 1, agree it makes sense, but backup and restore should ideally be done in a separate PR since this is already too large and they are a separate area of work.
Not sure I understood what you refer to in 2, can you please explain?
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Sorry - I've added video on iOS for 2nd point: synonymdev/bitkit-ios#476 (comment)
piotr-iohk
piotr-iohk
previously approved these changes
Apr 20, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly good functionally. There are some UI / Figma mismatches that we can clean up in a follow-up. We still need more testing before we call the feature done, but LGTM to merge this branch.
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 20, 2026
 Merged

@jvsena42

This comment was marked as duplicate.

Sign in to view
@jvsena42
jvsena42
commented
Apr 20, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
Failed testing this scenario
Edit: As far as I can see, it is not implemented, could be addressed to other PR
Screen_recording_20260420_135248.webm
jvsena42
jvsena42
approved these changes
Apr 20, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Sign-in with Pubky ring

✅ Copy contact key

✅ Pubky app data imported successfully

✅ Add contact from drawer option
⚠️ Nits for addressing in the next PRs:
  • Couldn't test create account by Bitkit (home gate endpoint not available)
  • Reset wallet -> restore -> Is not restoring the profile
  • Expected copy the profile key on QR code click
  • Expected decode the profile key when pasting in home
@ben-kaufman
ben-kaufman
commented
Apr 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
@jvsena42
jvsena42
commented
Apr 21, 2026

Copy link


Copy Markdown

Member
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
  1. Expected copy the profile key on QR code click, like in payment sheet
Screen_recording_20260421_064459.webm
  1. Expected decode the profile key when pasting in home, like when opening a channel
#824 (comment)
ovitrif
ovitrif
approved these changes
Apr 22, 2026
View reviewed changes
@ovitrifovitrif
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@ovitrif
ovitrif
merged commit bad9821
into
masterApr 22, 2026

18 checks passed

@ovitrif
ovitrif
deleted the

feat/pubky-profile

branch
April 22, 2026 08:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@ovitrifovitrifovitrif approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@piotr-iohkpiotr-iohkpiotr-iohk left review comments

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ben-kaufman@jvsena42@piotr-iohk@ovitrif@github-advanced-security@pwltr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: add profile and contacts fetching from pubky - #824
Merged
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Apr 22, 2026
Merged
feat: add profile and contacts fetching from pubky#824
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Mar 5, 2026•

edited by ovitrif

Loading

Copy link


Copy Markdown

Contributor
Integrates Pubky decentralized identity into Bitkit, allowing users to create a Bitkit-managed profile or connect via Pubky Ring authentication. Once connected, the user's profile name and avatar appear on the home screen header, a full profile page shows their bio, links, tags, and shareable QR code, and a contacts section lists people they follow on the Pubky network.
Description
  • Dual profile creation flow — create a new profile from BIP39 seed derivation, or import via Pubky Ring deep links (pubkyauth://)
  • Profile restore — when creating a profile, if one already exists on the network for the derived keys, it is detected and pre-populated (name, bio, links, tags preserved)
  • Ring auth import flow — after Ring authentication, discover existing profile and contacts from pubky.app, present import overview with "Import all" or "Select" options, then proceed to Pay Contacts
    
onboarding
  • Pay Contacts onboarding — new step after both create and Ring import flows, with toggle for sharing payment data
  • Profile page displaying name, bio, links, tags, and a QR code with the profile picture overlaid
  • Profile editing — edit name, bio, avatar, links, and tags with suggestion sheets
  • Contacts list with search, add button, and flat "Contacts" section header
  • Contact detail page showing name, truncated public key, bio, links, tags, and copy/share/edit/delete actions
  • Contact import — overview screen showing found profile & contacts count with avatar stack, selection screen with select all/none, batch import
  • Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
  • Edit contact — edit name, bio, links, tags with delete option
  • Home screen integration showing the authenticated user's name and avatar in the header
  • Session restoration — automatic re-sign-in using stored secret key when session import fails (Bitkit-managed); session preserved on failure for retry on next launch (Ring-managed); toast notification when
    
restoration fails
  • PubkyAuth approval — handles pubkyauth:// URLs from QR scans and deep links, biometric auth before approval, three-state sheet (authorize → authorizing → success)
  • PubkyService — service layer wrapping bitkit-core (auth relay, PKDNS file fetching, key derivation, homeserver operations) and paykit (session management)
  • PubkyRepo — manages auth state, session lifecycle, key derivation, profile creation/editing, contact CRUD, homeserver file operations, and auth approval
  • PubkyProfileData backward-compatible decoding — tags field defaults to empty array when missing from JSON (older profiles, other clients)
  • Suggestion card auto-dismiss when user is already authenticated
  • Bumped bitkit-core to v0.1.56 — adds key derivation, homeserver session operations, auth approval FFI functions
Key new files
FilePurpose
services/PubkyService.ktFFI bridge to bitkit-core and paykit
repositories/PubkyRepo.ktAuth state, session persistence, key derivation, profile/contact CRUD
models/PubkyProfile.ktProfile/contact data models with backward-compatible JSON decoding
models/PubkyAuthRequest.ktAuth request capability parsing
ui/components/CenteredProfileHeader.ktReusable centered profile header (avatar, name, key, bio)
ui/components/ProfileEditForm.ktReusable form for profile/contact editing
ui/components/AddLinkSheet.ktAdd link bottom sheet with suggestions
ui/components/AddTagSheet.ktAdd tag bottom sheet with suggestions
ui/screens/profile/PubkyChoiceScreen.ktCreate vs Ring import choice
ui/screens/profile/CreateProfileScreen.ktProfile creation with restore detection
ui/screens/profile/EditProfileScreen.ktProfile editing with avatar upload
ui/screens/profile/PayContactsScreen.ktPay Contacts onboarding step
ui/screens/profile/PubkyAuthApprovalSheet.ktAuth approval as authenticator
ui/screens/contacts/AddContactScreen.ktAdd contact by public key or QR
ui/screens/contacts/EditContactScreen.ktEdit contact details
ui/screens/contacts/ContactImportOverviewScreen.ktImport overview (profile + contacts summary)
ui/screens/contacts/ContactImportSelectScreen.ktSelectable contact list for import
tests/PubkyProfileDataTest.ktJSON encode/decode and backward compatibility tests
tests/PubkyAuthRequestTest.ktCapability parsing tests
QA Notes
  •  Fresh install: tap Profile in drawer → shows intro → continue → choice screen (Create / Import with Ring)
  • Create flow: Create Profile → enter name, pick avatar → Continue → Pay Contacts → Profile page
  • Create restore: If profile already exists for derived keys, name is pre-populated and title shows "Restore Profile"
  • Ring flow: Import with Ring → opens Pubky Ring → approve → returns to Bitkit → Import Overview → Import All or Select → Pay Contacts → Profile page
  • Ring flow (no contacts): If no remote contacts found, skip import and go to Pay Contacts
  • Import select: Can select all, select none, or pick individual contacts
  •  Profile page shows name, bio, links, tags, QR code with profile picture overlay
  •  Edit profile: tap edit → modify name/bio/links/tags → save → updated
  •  Home header shows profile name and avatar after authentication
  •  Kill and relaunch app → session restored, profile/contacts shown without re-auth
  •  Kill and relaunch with no network → session preserved, toast shown, next launch with network restores
  •  Sign out from profile page → returns to unauthenticated state, contacts cleared
  •  Contacts list shows "My Profile" row, contacts section, search, and add button
  •  Add contact by public key → fetches profile → shows preview with privacy notice → save
  •  Add contact via QR scan → opens scanner → scans pubky → navigates to add contact
  •  Edit contact → modify details → save → changes reflected in detail view
  •  Delete contact from edit screen → confirmation → removed
  •  Inline tag add/remove on contact detail → persists immediately
  •  Scan pubkyauth:// QR code → shows approval sheet with permissions → biometric → authorize → success
  •  Receive pubkyauth:// deep link → same approval flow
  •  Suggestion sheets for links and tags show lightbulb icon and predefined suggestions
claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyChoiceViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt
Outdated

github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

claude[bot]

This comment was marked as outdated.

Sign in to view
@jvsena42

This comment was marked as outdated.

Sign in to view
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 9, 2026
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Create Profile flow testing
  • Create Profile
  • Edit / Delete Profile
  • Add / Edit / Delete Contacts
1. Create profile - OK.
2. Edit / Delete profile
  • "Disconnect" - should not be there (by Figma)
Screenshot 2026-04-10 at 10 48 27
  • "Delete profile" - says profile will be deleted permanently - but when you create profile again - it is the same pubky (not sure if that is expected).
Screen.Recording.2026-04-10.at.10.54.33.mov
  • After adding link we get back to edit profile and the keyboard becomes active - seems unnecesary.
Screen.Recording.2026-04-10.at.11.05.22.mov
  • Keyboard can cover the edit field.
Screen.Recording.2026-04-10.at.11.07.26.mov
3. Add contact
  • Empty contact list should show profile and "Add contact" button (Figma)
  • you can add yourself as contact - should not be possible. (both iOS and Android)
Screen.Recording.2026-04-10.at.11.34.19.mov
  • Adding new contact:

    • note: Input length looks unbounded; worth defining and enforcing a sensible maximum.
    • whoops! contact added on fake pubky:
Screen.Recording.2026-04-10.at.12.00.12.mov
4. Edit / Delete contact
  • edit contact shows "Your Pubky" - should show "Pubky" (both iOS and Android)
Screenshot 2026-04-10 at 11 41 55
  • "Please note..." sentence needs to be updated.
  • Cannot edit / update avatar - probably should be possible.
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
Same pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
ame pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
I suppose this needs to be updated then:
Screenshot 2026-04-10 at 12 23 50
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
Hm, it's also not like the profile is entirely deleted. From what I see only profile details (bio, links, tags) are deleted but the contacts are preserved.
@ben-kaufman@claude
fix: address pr review and claude.md compliance
a9489ca
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Apr 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

ben-kaufmanand others
added 2 commits
April 10, 2026 15:12
@ben-kaufman@claude
fix: suppress large class detekt warning
2051774
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman@claude
fix: delete contacts on profile deletion
1e38929
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@piotr-iohk ah yes I missed that, fixed
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Additional observation (on 1e38929):
1.
  • create wallet -> create profile -> make backup -> reset wallet -> restore wallet.
Expected:
  • profile should be there after restoration
Actual:
  • profile is "disconnected"
2. It would be great if we could have same behavior on pubky validation when adding contacts (currently differs on iOS - validation on pubky input vs Android - validation after taping add, on Android also subsequent Retry button does not work). It would make things consistent + easier for e2e tests. 🙏
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
About 1, agree it makes sense, but backup and restore should ideally be done in a separate PR since this is already too large and they are a separate area of work.
Not sure I understood what you refer to in 2, can you please explain?
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Sorry - I've added video on iOS for 2nd point: synonymdev/bitkit-ios#476 (comment)
piotr-iohk
piotr-iohk
previously approved these changes
Apr 20, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly good functionally. There are some UI / Figma mismatches that we can clean up in a follow-up. We still need more testing before we call the feature done, but LGTM to merge this branch.
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 20, 2026
 Merged

@jvsena42

This comment was marked as duplicate.

Sign in to view
@jvsena42
jvsena42
commented
Apr 20, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
Failed testing this scenario
Edit: As far as I can see, it is not implemented, could be addressed to other PR
Screen_recording_20260420_135248.webm
jvsena42
jvsena42
approved these changes
Apr 20, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Sign-in with Pubky ring

✅ Copy contact key

✅ Pubky app data imported successfully

✅ Add contact from drawer option
⚠️ Nits for addressing in the next PRs:
  • Couldn't test create account by Bitkit (home gate endpoint not available)
  • Reset wallet -> restore -> Is not restoring the profile
  • Expected copy the profile key on QR code click
  • Expected decode the profile key when pasting in home
@ben-kaufman
ben-kaufman
commented
Apr 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
@jvsena42
jvsena42
commented
Apr 21, 2026

Copy link


Copy Markdown

Member
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
  1. Expected copy the profile key on QR code click, like in payment sheet
Screen_recording_20260421_064459.webm
  1. Expected decode the profile key when pasting in home, like when opening a channel
#824 (comment)
ovitrif
ovitrif
approved these changes
Apr 22, 2026
View reviewed changes
@ovitrifovitrif
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@ovitrif
ovitrif
merged commit bad9821
into
masterApr 22, 2026

18 checks passed

@ovitrif
ovitrif
deleted the

feat/pubky-profile

branch
April 22, 2026 08:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@ovitrifovitrifovitrif approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@piotr-iohkpiotr-iohkpiotr-iohk left review comments

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ben-kaufman@jvsena42@piotr-iohk@ovitrif@github-advanced-security@pwltr

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: add profile and contacts fetching from pubky - #824
Merged
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Apr 22, 2026
Merged
feat: add profile and contacts fetching from pubky#824
ovitrif merged 62 commits into
masterfrom 
feat/pubky-profile
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Mar 5, 2026•

edited by ovitrif

Loading

Copy link


Copy Markdown

Contributor
Integrates Pubky decentralized identity into Bitkit, allowing users to create a Bitkit-managed profile or connect via Pubky Ring authentication. Once connected, the user's profile name and avatar appear on the home screen header, a full profile page shows their bio, links, tags, and shareable QR code, and a contacts section lists people they follow on the Pubky network.
Description
  • Dual profile creation flow — create a new profile from BIP39 seed derivation, or import via Pubky Ring deep links (pubkyauth://)
  • Profile restore — when creating a profile, if one already exists on the network for the derived keys, it is detected and pre-populated (name, bio, links, tags preserved)
  • Ring auth import flow — after Ring authentication, discover existing profile and contacts from pubky.app, present import overview with "Import all" or "Select" options, then proceed to Pay Contacts
    
onboarding
  • Pay Contacts onboarding — new step after both create and Ring import flows, with toggle for sharing payment data
  • Profile page displaying name, bio, links, tags, and a QR code with the profile picture overlaid
  • Profile editing — edit name, bio, avatar, links, and tags with suggestion sheets
  • Contacts list with search, add button, and flat "Contacts" section header
  • Contact detail page showing name, truncated public key, bio, links, tags, and copy/share/edit/delete actions
  • Contact import — overview screen showing found profile & contacts count with avatar stack, selection screen with select all/none, batch import
  • Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
  • Edit contact — edit name, bio, links, tags with delete option
  • Home screen integration showing the authenticated user's name and avatar in the header
  • Session restoration — automatic re-sign-in using stored secret key when session import fails (Bitkit-managed); session preserved on failure for retry on next launch (Ring-managed); toast notification when
    
restoration fails
  • PubkyAuth approval — handles pubkyauth:// URLs from QR scans and deep links, biometric auth before approval, three-state sheet (authorize → authorizing → success)
  • PubkyService — service layer wrapping bitkit-core (auth relay, PKDNS file fetching, key derivation, homeserver operations) and paykit (session management)
  • PubkyRepo — manages auth state, session lifecycle, key derivation, profile creation/editing, contact CRUD, homeserver file operations, and auth approval
  • PubkyProfileData backward-compatible decoding — tags field defaults to empty array when missing from JSON (older profiles, other clients)
  • Suggestion card auto-dismiss when user is already authenticated
  • Bumped bitkit-core to v0.1.56 — adds key derivation, homeserver session operations, auth approval FFI functions
Key new files
FilePurpose
services/PubkyService.ktFFI bridge to bitkit-core and paykit
repositories/PubkyRepo.ktAuth state, session persistence, key derivation, profile/contact CRUD
models/PubkyProfile.ktProfile/contact data models with backward-compatible JSON decoding
models/PubkyAuthRequest.ktAuth request capability parsing
ui/components/CenteredProfileHeader.ktReusable centered profile header (avatar, name, key, bio)
ui/components/ProfileEditForm.ktReusable form for profile/contact editing
ui/components/AddLinkSheet.ktAdd link bottom sheet with suggestions
ui/components/AddTagSheet.ktAdd tag bottom sheet with suggestions
ui/screens/profile/PubkyChoiceScreen.ktCreate vs Ring import choice
ui/screens/profile/CreateProfileScreen.ktProfile creation with restore detection
ui/screens/profile/EditProfileScreen.ktProfile editing with avatar upload
ui/screens/profile/PayContactsScreen.ktPay Contacts onboarding step
ui/screens/profile/PubkyAuthApprovalSheet.ktAuth approval as authenticator
ui/screens/contacts/AddContactScreen.ktAdd contact by public key or QR
ui/screens/contacts/EditContactScreen.ktEdit contact details
ui/screens/contacts/ContactImportOverviewScreen.ktImport overview (profile + contacts summary)
ui/screens/contacts/ContactImportSelectScreen.ktSelectable contact list for import
tests/PubkyProfileDataTest.ktJSON encode/decode and backward compatibility tests
tests/PubkyAuthRequestTest.ktCapability parsing tests
QA Notes
  •  Fresh install: tap Profile in drawer → shows intro → continue → choice screen (Create / Import with Ring)
  • Create flow: Create Profile → enter name, pick avatar → Continue → Pay Contacts → Profile page
  • Create restore: If profile already exists for derived keys, name is pre-populated and title shows "Restore Profile"
  • Ring flow: Import with Ring → opens Pubky Ring → approve → returns to Bitkit → Import Overview → Import All or Select → Pay Contacts → Profile page
  • Ring flow (no contacts): If no remote contacts found, skip import and go to Pay Contacts
  • Import select: Can select all, select none, or pick individual contacts
  •  Profile page shows name, bio, links, tags, QR code with profile picture overlay
  •  Edit profile: tap edit → modify name/bio/links/tags → save → updated
  •  Home header shows profile name and avatar after authentication
  •  Kill and relaunch app → session restored, profile/contacts shown without re-auth
  •  Kill and relaunch with no network → session preserved, toast shown, next launch with network restores
  •  Sign out from profile page → returns to unauthenticated state, contacts cleared
  •  Contacts list shows "My Profile" row, contacts section, search, and add button
  •  Add contact by public key → fetches profile → shows preview with privacy notice → save
  •  Add contact via QR scan → opens scanner → scans pubky → navigates to add contact
  •  Edit contact → modify details → save → changes reflected in detail view
  •  Delete contact from edit screen → confirmation → removed
  •  Inline tag add/remove on contact detail → persists immediately
  •  Scan pubkyauth:// QR code → shows approval sheet with permissions → biometric → authorize → success
  •  Receive pubkyauth:// deep link → same approval flow
  •  Suggestion sheets for links and tags show lightbulb icon and predefined suggestions
claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 5, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyChoiceViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/PubkyImage.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt
Outdated

github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Mar 6, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

claude[bot]

This comment was marked as outdated.

Sign in to view
@jvsena42

This comment was marked as outdated.

Sign in to view
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 9, 2026
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Create Profile flow testing
  • Create Profile
  • Edit / Delete Profile
  • Add / Edit / Delete Contacts
1. Create profile - OK.
2. Edit / Delete profile
  • "Disconnect" - should not be there (by Figma)
Screenshot 2026-04-10 at 10 48 27
  • "Delete profile" - says profile will be deleted permanently - but when you create profile again - it is the same pubky (not sure if that is expected).
Screen.Recording.2026-04-10.at.10.54.33.mov
  • After adding link we get back to edit profile and the keyboard becomes active - seems unnecesary.
Screen.Recording.2026-04-10.at.11.05.22.mov
  • Keyboard can cover the edit field.
Screen.Recording.2026-04-10.at.11.07.26.mov
3. Add contact
  • Empty contact list should show profile and "Add contact" button (Figma)
  • you can add yourself as contact - should not be possible. (both iOS and Android)
Screen.Recording.2026-04-10.at.11.34.19.mov
  • Adding new contact:

    • note: Input length looks unbounded; worth defining and enforcing a sensible maximum.
    • whoops! contact added on fake pubky:
Screen.Recording.2026-04-10.at.12.00.12.mov
4. Edit / Delete contact
  • edit contact shows "Your Pubky" - should show "Pubky" (both iOS and Android)
Screenshot 2026-04-10 at 11 41 55
  • "Please note..." sentence needs to be updated.
  • Cannot edit / update avatar - probably should be possible.
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
Same pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
ame pubky after delete is expected since we use deterministic derivation based on the seed. So that's the expected behavior there.
I suppose this needs to be updated then:
Screenshot 2026-04-10 at 12 23 50
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
No I think the warning makes sense, it deletes the profile, but not the key to it, maybe can remove the word "permenantly"
Hm, it's also not like the profile is entirely deleted. From what I see only profile details (bio, links, tags) are deleted but the contacts are preserved.
@ben-kaufman@claude
fix: address pr review and claude.md compliance
a9489ca
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Apr 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Fixed

ben-kaufmanand others
added 2 commits
April 10, 2026 15:12
@ben-kaufman@claude
fix: suppress large class detekt warning
2051774
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman@claude
fix: delete contacts on profile deletion
1e38929
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
@piotr-iohk ah yes I missed that, fixed
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Additional observation (on 1e38929):
1.
  • create wallet -> create profile -> make backup -> reset wallet -> restore wallet.
Expected:
  • profile should be there after restoration
Actual:
  • profile is "disconnected"
2. It would be great if we could have same behavior on pubky validation when adding contacts (currently differs on iOS - validation on pubky input vs Android - validation after taping add, on Android also subsequent Retry button does not work). It would make things consistent + easier for e2e tests. 🙏
@ben-kaufman
ben-kaufman
commented
Apr 10, 2026

Copy link


Copy Markdown

ContributorAuthor
About 1, agree it makes sense, but backup and restore should ideally be done in a separate PR since this is already too large and they are a separate area of work.
Not sure I understood what you refer to in 2, can you please explain?
@piotr-iohk
piotr-iohk
commented
Apr 10, 2026

Copy link


Copy Markdown

Collaborator
Sorry - I've added video on iOS for 2nd point: synonymdev/bitkit-ios#476 (comment)
piotr-iohk
piotr-iohk
previously approved these changes
Apr 20, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly good functionally. There are some UI / Figma mismatches that we can clean up in a follow-up. We still need more testing before we call the feature done, but LGTM to merge this branch.
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 20, 2026
 Merged

@jvsena42

This comment was marked as duplicate.

Sign in to view
@jvsena42
jvsena42
commented
Apr 20, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Add contact — bottom sheet with pubky input or QR scan, loading animation with rotating ellipses, profile preview with privacy notice, save/discard
Failed testing this scenario
Edit: As far as I can see, it is not implemented, could be addressed to other PR
Screen_recording_20260420_135248.webm
jvsena42
jvsena42
approved these changes
Apr 20, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Sign-in with Pubky ring

✅ Copy contact key

✅ Pubky app data imported successfully

✅ Add contact from drawer option
⚠️ Nits for addressing in the next PRs:
  • Couldn't test create account by Bitkit (home gate endpoint not available)
  • Reset wallet -> restore -> Is not restoring the profile
  • Expected copy the profile key on QR code click
  • Expected decode the profile key when pasting in home
@ben-kaufman
ben-kaufman
commented
Apr 21, 2026

Copy link


Copy Markdown

ContributorAuthor
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
@jvsena42
jvsena42
commented
Apr 21, 2026

Copy link


Copy Markdown

Member
Restore will be handled in a following PR.
Expected copy the profile key on QR code key

Expected decode the profile key when pasting in home
Can you please explain what you meant in these?
  1. Expected copy the profile key on QR code click, like in payment sheet
Screen_recording_20260421_064459.webm
  1. Expected decode the profile key when pasting in home, like when opening a channel
#824 (comment)
ovitrif
ovitrif
approved these changes
Apr 22, 2026
View reviewed changes
@ovitrifovitrif
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@ovitrif
ovitrif
merged commit bad9821
into
masterApr 22, 2026

18 checks passed

@ovitrif
ovitrif
deleted the

feat/pubky-profile

branch
April 22, 2026 08:28
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@ovitrifovitrifovitrif approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@piotr-iohkpiotr-iohkpiotr-iohk left review comments

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ben-kaufman@jvsena42@piotr-iohk@ovitrif@github-advanced-security@pwltr