Skip to content

fix: channel detail black screen - #838

Merged
jvsena42 merged 11 commits into
masterfrom
fix/channel-screen-nav-668
Mar 12, 2026
Merged

fix: channel detail black screen#838
jvsena42 merged 11 commits into
masterfrom
fix/channel-screen-nav-668

Conversation

@ovitrif

@ovitrifovitrif commented Mar 10, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Fixes#668

This PR:

  1. Fixes the channel detail screen black screen caused by shared ViewModel state loss during navigation
  2. Fixes predictive back gesture animations
  3. Fixes wallet screens (savings & spending) transition animations
  4. Refactor: extracts ChannelDetailViewModel and CloseConnectionViewModel from the monolithic LightningConnectionsViewModel

Description

The channel detail and close connection screens previously depended on a shared parent ViewModel (LightningConnectionsViewModel) to hold the selected channel state. This caused black screens when navigating back and forth, since the shared state could be lost during back-stack restoration or recomposition.

The fix converts Routes.ChannelDetail and Routes.CloseConnection from data object to data class with a channelId parameter, making each screen self-contained. Each screen now has its own ViewModel that loads channel data independently using the passed ID.

Additional improvements:

  • Added a loading state with spinner while channel data loads
  • Added handling with toast and automatic back navigation for the "not found" cases

Preview

BeforeAfter
before_1.75x.mp4
after_1.75x.mp4

QA Notes

Tests

  1. Verify intermittent bug of "black channel details screen" is fixed[Bug]: Black screen on "Lightning Connection" screen #668
  2. Try to break back nav gesture as seen in 1st video → should be impossible now
  3. Activity Detail (LN transfer) → Connection button → should land on ChannelDetail → back → should return to Activity Detail

Regression Tests (pick a few randomly)

  • Settings → Lightning Connections → tap channel → should still open
  • ChannelDetail → back → returns to connections list
  • ChannelDetail → Close Connection → should still work
  • Pull-to-refresh on channel detail

github-actionsBotand others added 4 commits March 10, 2026 21:09
@github-actions@ovitrif
fix: resolve channel detail black screen and navigation issues
bf4e9c4
- Change Routes.ChannelDetail to accept channelId parameter
- Update ChannelDetailScreen to fetch channel on initialization
- Replace early return with loading state when channel is null
- Navigate directly to detail screen with channelId
- Remove intermediate navigation through list screen
- Fix predictive back gesture by eliminating blank composable state
Fixes#668
Co-authored-by: Ovi Trif <ovitrif@users.noreply.github.com>
@ovitrif
chore: add compose preview for channel loading
bef2790
@ovitrif
refactor: extract channel details vm
40019ff
@ovitrif
refactor: extract close channel vm
f0f217a
claude[bot]
claudeBot reviewed Mar 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt Outdated
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
@ovitrifovitrif changed the title fix: resolve channel detail black screenfix: channel detail black screenMar 11, 2026
@ovitrif@claude
fix: wallet screen navigation transition
20eb8f5
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrifforce-pushed the fix/channel-screen-nav-668 branch from a7fe03a to 20eb8f5CompareMarch 11, 2026 01:27
claude[bot]
claudeBot reviewed Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt Outdated
claude[bot]
claudeBot reviewed Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt Outdated
claude[bot]
claudeBot reviewed Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt Outdated
claude[bot]
claudeBot reviewed Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt Outdated
claude[bot]
claudeBot reviewed Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsViewModel.kt Outdated
@ovitrif@claude
fix: address pr review feedback
2685e88
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif

ovitrif commented Mar 11, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@claude Summarize the changes for reviewers.

@ovitrifovitrif added this to the 2.2.0 milestone Mar 11, 2026
@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot reviewed Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt Outdated
claude[bot]
claudeBot reviewed Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
claude[bot]
claudeBot reviewed Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
@ovitrifovitrif mentioned this pull request Mar 11, 2026
Closed
@ovitrif@claude
fix: address pr review round 2
5b64e1a
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claude[bot]
claudeBot reviewed Mar 11, 2026
View reviewed changes

@claudeclaudeBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Found 1 issue. Checked for bugs and CLAUDE.md compliance.

Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
ovitrifand others added 2 commits March 12, 2026 11:14
@ovitrif@claude
fix: guard pending orders from not-found
ddd78bb
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif@claude
fix: address claude.md rule violations
659e634
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
piotr-iohk
piotr-iohk approved these changes Mar 12, 2026
View reviewed changes

@piotr-iohkpiotr-iohk left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on sim, LGTM.

jvsena42
jvsena42 approved these changes Mar 12, 2026
View reviewed changes

@jvsena42jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@jvsena42
jvsena42 merged commit 7c7f54b into masterMar 12, 2026
19 checks passed
@jvsena42
jvsena42 deleted the fix/channel-screen-nav-668 branch March 12, 2026 15:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Black screen on "Lightning Connection" screen

3 participants

@ovitrif@piotr-iohk@jvsena42
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix: channel detail black screen by ovitrif · Pull Request #838 · synonymdev/bitkit-android · GitHub
Skip to content
fix: channel detail black screen - #838
Merged
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Mar 12, 2026
Merged
fix: channel detail black screen#838
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Conversation
@ovitrif
@ovitrifovitrif
commented
Mar 10, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Fixes#668
This PR:
  1. Fixes the channel detail screen black screen caused by shared ViewModel state loss during navigation
  2. Fixes predictive back gesture animations
  3. Fixes wallet screens (savings & spending) transition animations
  4. Refactor: extracts ChannelDetailViewModel and CloseConnectionViewModel from the monolithic LightningConnectionsViewModel
Description
The channel detail and close connection screens previously depended on a shared parent ViewModel (LightningConnectionsViewModel) to hold the selected channel state. This caused black screens when navigating back and forth, since the shared state could be lost during back-stack restoration or recomposition.
The fix converts Routes.ChannelDetail and Routes.CloseConnection from data object to data class with a channelId parameter, making each screen self-contained. Each screen now has its own ViewModel that loads channel data independently using the passed ID.
Additional improvements:
  • Added a loading state with spinner while channel data loads
  • Added handling with toast and automatic back navigation for the "not found" cases
Preview
BeforeAfter
before_1.75x.mp4
after_1.75x.mp4
QA Notes
Tests
  1. Verify intermittent bug of "black channel details screen" is fixed[Bug]: Black screen on "Lightning Connection" screen #668
  2. Try to break back nav gesture as seen in 1st video → should be impossible now
  3. Activity Detail (LN transfer) → Connection button → should land on ChannelDetail → back → should return to Activity Detail
Regression Tests (pick a few randomly)
  • Settings → Lightning Connections → tap channel → should still open
  • ChannelDetail → back → returns to connections list
  • ChannelDetail → Close Connection → should still work
  • Pull-to-refresh on channel detail
github-actionsBotand others
added 4 commits
March 10, 2026 21:09
@github-actions@ovitrif
fix: resolve channel detail black screen and navigation issues
bf4e9c4
- Change Routes.ChannelDetail to accept channelId parameter
- Update ChannelDetailScreen to fetch channel on initialization
- Replace early return with loading state when channel is null
- Navigate directly to detail screen with channelId
- Remove intermediate navigation through list screen
- Fix predictive back gesture by eliminating blank composable state
Fixes#668
Co-authored-by: Ovi Trif <ovitrif@users.noreply.github.com>
@ovitrif
chore: add compose preview for channel loading
bef2790
@ovitrif
refactor: extract channel details vm
40019ff
@ovitrif
refactor: extract close channel vm
f0f217a
claude[bot]
claudeBot
reviewed
Mar 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
@ovitrifovitrif
changed the title
fix: resolve channel detail black screenfix: channel detail black screenMar 11, 2026
@ovitrif@claude
fix: wallet screen navigation transition
20eb8f5
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrifforce-pushed
the
fix/channel-screen-nav-668
branch
from
a7fe03a to
20eb8f5CompareMarch 11, 2026 01:27
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsViewModel.kt
Outdated

@ovitrif@claude
fix: address pr review feedback
2685e88
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrif
commented
Mar 11, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@claude Summarize the changes for reviewers.
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 11, 2026
@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
@ovitrifovitrif
mentioned this pull request
Mar 11, 2026
 Closed

@ovitrif@claude
fix: address pr review round 2
5b64e1a
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
@claudeclaudeBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
Found 1 issue. Checked for bugs and CLAUDE.md compliance.
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
ovitrifand others
added 2 commits
March 12, 2026 11:14
@ovitrif@claude
fix: guard pending orders from not-found
ddd78bb
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif@claude
fix: address claude.md rule violations
659e634
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
piotr-iohk
piotr-iohk
approved these changes
Mar 12, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment
•

edited

Loading

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on sim, LGTM.
jvsena42
jvsena42
approved these changes
Mar 12, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@jvsena42
jvsena42
merged commit 7c7f54b
into
masterMar 12, 2026

19 checks passed

@jvsena42
jvsena42
deleted the

fix/channel-screen-nav-668

branch
March 12, 2026 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Black screen on "Lightning Connection" screen


3 participants

@ovitrif@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: channel detail black screen by ovitrif · Pull Request #838 · synonymdev/bitkit-android · GitHub
Skip to content
fix: channel detail black screen - #838
Merged
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Mar 12, 2026
Merged
fix: channel detail black screen#838
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Conversation
@ovitrif
@ovitrifovitrif
commented
Mar 10, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Fixes#668
This PR:
  1. Fixes the channel detail screen black screen caused by shared ViewModel state loss during navigation
  2. Fixes predictive back gesture animations
  3. Fixes wallet screens (savings & spending) transition animations
  4. Refactor: extracts ChannelDetailViewModel and CloseConnectionViewModel from the monolithic LightningConnectionsViewModel
Description
The channel detail and close connection screens previously depended on a shared parent ViewModel (LightningConnectionsViewModel) to hold the selected channel state. This caused black screens when navigating back and forth, since the shared state could be lost during back-stack restoration or recomposition.
The fix converts Routes.ChannelDetail and Routes.CloseConnection from data object to data class with a channelId parameter, making each screen self-contained. Each screen now has its own ViewModel that loads channel data independently using the passed ID.
Additional improvements:
  • Added a loading state with spinner while channel data loads
  • Added handling with toast and automatic back navigation for the "not found" cases
Preview
BeforeAfter
before_1.75x.mp4
after_1.75x.mp4
QA Notes
Tests
  1. Verify intermittent bug of "black channel details screen" is fixed[Bug]: Black screen on "Lightning Connection" screen #668
  2. Try to break back nav gesture as seen in 1st video → should be impossible now
  3. Activity Detail (LN transfer) → Connection button → should land on ChannelDetail → back → should return to Activity Detail
Regression Tests (pick a few randomly)
  • Settings → Lightning Connections → tap channel → should still open
  • ChannelDetail → back → returns to connections list
  • ChannelDetail → Close Connection → should still work
  • Pull-to-refresh on channel detail
github-actionsBotand others
added 4 commits
March 10, 2026 21:09
@github-actions@ovitrif
fix: resolve channel detail black screen and navigation issues
bf4e9c4
- Change Routes.ChannelDetail to accept channelId parameter
- Update ChannelDetailScreen to fetch channel on initialization
- Replace early return with loading state when channel is null
- Navigate directly to detail screen with channelId
- Remove intermediate navigation through list screen
- Fix predictive back gesture by eliminating blank composable state
Fixes#668
Co-authored-by: Ovi Trif <ovitrif@users.noreply.github.com>
@ovitrif
chore: add compose preview for channel loading
bef2790
@ovitrif
refactor: extract channel details vm
40019ff
@ovitrif
refactor: extract close channel vm
f0f217a
claude[bot]
claudeBot
reviewed
Mar 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
@ovitrifovitrif
changed the title
fix: resolve channel detail black screenfix: channel detail black screenMar 11, 2026
@ovitrif@claude
fix: wallet screen navigation transition
20eb8f5
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrifforce-pushed
the
fix/channel-screen-nav-668
branch
from
a7fe03a to
20eb8f5CompareMarch 11, 2026 01:27
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsViewModel.kt
Outdated

@ovitrif@claude
fix: address pr review feedback
2685e88
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrif
commented
Mar 11, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@claude Summarize the changes for reviewers.
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 11, 2026
@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
@ovitrifovitrif
mentioned this pull request
Mar 11, 2026
 Closed

@ovitrif@claude
fix: address pr review round 2
5b64e1a
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
@claudeclaudeBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
Found 1 issue. Checked for bugs and CLAUDE.md compliance.
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
ovitrifand others
added 2 commits
March 12, 2026 11:14
@ovitrif@claude
fix: guard pending orders from not-found
ddd78bb
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif@claude
fix: address claude.md rule violations
659e634
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
piotr-iohk
piotr-iohk
approved these changes
Mar 12, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment
•

edited

Loading

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on sim, LGTM.
jvsena42
jvsena42
approved these changes
Mar 12, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@jvsena42
jvsena42
merged commit 7c7f54b
into
masterMar 12, 2026

19 checks passed

@jvsena42
jvsena42
deleted the

fix/channel-screen-nav-668

branch
March 12, 2026 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Black screen on "Lightning Connection" screen


3 participants

@ovitrif@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: channel detail black screen by ovitrif · Pull Request #838 · synonymdev/bitkit-android · GitHub
Skip to content
fix: channel detail black screen - #838
Merged
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Mar 12, 2026
Merged
fix: channel detail black screen#838
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Conversation
@ovitrif
@ovitrifovitrif
commented
Mar 10, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Fixes#668
This PR:
  1. Fixes the channel detail screen black screen caused by shared ViewModel state loss during navigation
  2. Fixes predictive back gesture animations
  3. Fixes wallet screens (savings & spending) transition animations
  4. Refactor: extracts ChannelDetailViewModel and CloseConnectionViewModel from the monolithic LightningConnectionsViewModel
Description
The channel detail and close connection screens previously depended on a shared parent ViewModel (LightningConnectionsViewModel) to hold the selected channel state. This caused black screens when navigating back and forth, since the shared state could be lost during back-stack restoration or recomposition.
The fix converts Routes.ChannelDetail and Routes.CloseConnection from data object to data class with a channelId parameter, making each screen self-contained. Each screen now has its own ViewModel that loads channel data independently using the passed ID.
Additional improvements:
  • Added a loading state with spinner while channel data loads
  • Added handling with toast and automatic back navigation for the "not found" cases
Preview
BeforeAfter
before_1.75x.mp4
after_1.75x.mp4
QA Notes
Tests
  1. Verify intermittent bug of "black channel details screen" is fixed[Bug]: Black screen on "Lightning Connection" screen #668
  2. Try to break back nav gesture as seen in 1st video → should be impossible now
  3. Activity Detail (LN transfer) → Connection button → should land on ChannelDetail → back → should return to Activity Detail
Regression Tests (pick a few randomly)
  • Settings → Lightning Connections → tap channel → should still open
  • ChannelDetail → back → returns to connections list
  • ChannelDetail → Close Connection → should still work
  • Pull-to-refresh on channel detail
github-actionsBotand others
added 4 commits
March 10, 2026 21:09
@github-actions@ovitrif
fix: resolve channel detail black screen and navigation issues
bf4e9c4
- Change Routes.ChannelDetail to accept channelId parameter
- Update ChannelDetailScreen to fetch channel on initialization
- Replace early return with loading state when channel is null
- Navigate directly to detail screen with channelId
- Remove intermediate navigation through list screen
- Fix predictive back gesture by eliminating blank composable state
Fixes#668
Co-authored-by: Ovi Trif <ovitrif@users.noreply.github.com>
@ovitrif
chore: add compose preview for channel loading
bef2790
@ovitrif
refactor: extract channel details vm
40019ff
@ovitrif
refactor: extract close channel vm
f0f217a
claude[bot]
claudeBot
reviewed
Mar 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
@ovitrifovitrif
changed the title
fix: resolve channel detail black screenfix: channel detail black screenMar 11, 2026
@ovitrif@claude
fix: wallet screen navigation transition
20eb8f5
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrifforce-pushed
the
fix/channel-screen-nav-668
branch
from
a7fe03a to
20eb8f5CompareMarch 11, 2026 01:27
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsViewModel.kt
Outdated

@ovitrif@claude
fix: address pr review feedback
2685e88
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrif
commented
Mar 11, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@claude Summarize the changes for reviewers.
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 11, 2026
@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
@ovitrifovitrif
mentioned this pull request
Mar 11, 2026
 Closed

@ovitrif@claude
fix: address pr review round 2
5b64e1a
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
@claudeclaudeBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
Found 1 issue. Checked for bugs and CLAUDE.md compliance.
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
ovitrifand others
added 2 commits
March 12, 2026 11:14
@ovitrif@claude
fix: guard pending orders from not-found
ddd78bb
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif@claude
fix: address claude.md rule violations
659e634
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
piotr-iohk
piotr-iohk
approved these changes
Mar 12, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment
•

edited

Loading

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on sim, LGTM.
jvsena42
jvsena42
approved these changes
Mar 12, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@jvsena42
jvsena42
merged commit 7c7f54b
into
masterMar 12, 2026

19 checks passed

@jvsena42
jvsena42
deleted the

fix/channel-screen-nav-668

branch
March 12, 2026 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Black screen on "Lightning Connection" screen


3 participants

@ovitrif@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix: channel detail black screen by ovitrif · Pull Request #838 · synonymdev/bitkit-android · GitHub
Skip to content
fix: channel detail black screen - #838
Merged
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Mar 12, 2026
Merged
fix: channel detail black screen#838
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Conversation
@ovitrif
@ovitrifovitrif
commented
Mar 10, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Fixes#668
This PR:
  1. Fixes the channel detail screen black screen caused by shared ViewModel state loss during navigation
  2. Fixes predictive back gesture animations
  3. Fixes wallet screens (savings & spending) transition animations
  4. Refactor: extracts ChannelDetailViewModel and CloseConnectionViewModel from the monolithic LightningConnectionsViewModel
Description
The channel detail and close connection screens previously depended on a shared parent ViewModel (LightningConnectionsViewModel) to hold the selected channel state. This caused black screens when navigating back and forth, since the shared state could be lost during back-stack restoration or recomposition.
The fix converts Routes.ChannelDetail and Routes.CloseConnection from data object to data class with a channelId parameter, making each screen self-contained. Each screen now has its own ViewModel that loads channel data independently using the passed ID.
Additional improvements:
  • Added a loading state with spinner while channel data loads
  • Added handling with toast and automatic back navigation for the "not found" cases
Preview
BeforeAfter
before_1.75x.mp4
after_1.75x.mp4
QA Notes
Tests
  1. Verify intermittent bug of "black channel details screen" is fixed[Bug]: Black screen on "Lightning Connection" screen #668
  2. Try to break back nav gesture as seen in 1st video → should be impossible now
  3. Activity Detail (LN transfer) → Connection button → should land on ChannelDetail → back → should return to Activity Detail
Regression Tests (pick a few randomly)
  • Settings → Lightning Connections → tap channel → should still open
  • ChannelDetail → back → returns to connections list
  • ChannelDetail → Close Connection → should still work
  • Pull-to-refresh on channel detail
github-actionsBotand others
added 4 commits
March 10, 2026 21:09
@github-actions@ovitrif
fix: resolve channel detail black screen and navigation issues
bf4e9c4
- Change Routes.ChannelDetail to accept channelId parameter
- Update ChannelDetailScreen to fetch channel on initialization
- Replace early return with loading state when channel is null
- Navigate directly to detail screen with channelId
- Remove intermediate navigation through list screen
- Fix predictive back gesture by eliminating blank composable state
Fixes#668
Co-authored-by: Ovi Trif <ovitrif@users.noreply.github.com>
@ovitrif
chore: add compose preview for channel loading
bef2790
@ovitrif
refactor: extract channel details vm
40019ff
@ovitrif
refactor: extract close channel vm
f0f217a
claude[bot]
claudeBot
reviewed
Mar 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
@ovitrifovitrif
changed the title
fix: resolve channel detail black screenfix: channel detail black screenMar 11, 2026
@ovitrif@claude
fix: wallet screen navigation transition
20eb8f5
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrifforce-pushed
the
fix/channel-screen-nav-668
branch
from
a7fe03a to
20eb8f5CompareMarch 11, 2026 01:27
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsViewModel.kt
Outdated

@ovitrif@claude
fix: address pr review feedback
2685e88
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrif
commented
Mar 11, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@claude Summarize the changes for reviewers.
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 11, 2026
@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
@ovitrifovitrif
mentioned this pull request
Mar 11, 2026
 Closed

@ovitrif@claude
fix: address pr review round 2
5b64e1a
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
@claudeclaudeBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
Found 1 issue. Checked for bugs and CLAUDE.md compliance.
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
ovitrifand others
added 2 commits
March 12, 2026 11:14
@ovitrif@claude
fix: guard pending orders from not-found
ddd78bb
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif@claude
fix: address claude.md rule violations
659e634
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
piotr-iohk
piotr-iohk
approved these changes
Mar 12, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment
•

edited

Loading

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on sim, LGTM.
jvsena42
jvsena42
approved these changes
Mar 12, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@jvsena42
jvsena42
merged commit 7c7f54b
into
masterMar 12, 2026

19 checks passed

@jvsena42
jvsena42
deleted the

fix/channel-screen-nav-668

branch
March 12, 2026 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Black screen on "Lightning Connection" screen


3 participants

@ovitrif@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: channel detail black screen by ovitrif · Pull Request #838 · synonymdev/bitkit-android · GitHub
Skip to content
fix: channel detail black screen - #838
Merged
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Mar 12, 2026
Merged
fix: channel detail black screen#838
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Conversation
@ovitrif
@ovitrifovitrif
commented
Mar 10, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Fixes#668
This PR:
  1. Fixes the channel detail screen black screen caused by shared ViewModel state loss during navigation
  2. Fixes predictive back gesture animations
  3. Fixes wallet screens (savings & spending) transition animations
  4. Refactor: extracts ChannelDetailViewModel and CloseConnectionViewModel from the monolithic LightningConnectionsViewModel
Description
The channel detail and close connection screens previously depended on a shared parent ViewModel (LightningConnectionsViewModel) to hold the selected channel state. This caused black screens when navigating back and forth, since the shared state could be lost during back-stack restoration or recomposition.
The fix converts Routes.ChannelDetail and Routes.CloseConnection from data object to data class with a channelId parameter, making each screen self-contained. Each screen now has its own ViewModel that loads channel data independently using the passed ID.
Additional improvements:
  • Added a loading state with spinner while channel data loads
  • Added handling with toast and automatic back navigation for the "not found" cases
Preview
BeforeAfter
before_1.75x.mp4
after_1.75x.mp4
QA Notes
Tests
  1. Verify intermittent bug of "black channel details screen" is fixed[Bug]: Black screen on "Lightning Connection" screen #668
  2. Try to break back nav gesture as seen in 1st video → should be impossible now
  3. Activity Detail (LN transfer) → Connection button → should land on ChannelDetail → back → should return to Activity Detail
Regression Tests (pick a few randomly)
  • Settings → Lightning Connections → tap channel → should still open
  • ChannelDetail → back → returns to connections list
  • ChannelDetail → Close Connection → should still work
  • Pull-to-refresh on channel detail
github-actionsBotand others
added 4 commits
March 10, 2026 21:09
@github-actions@ovitrif
fix: resolve channel detail black screen and navigation issues
bf4e9c4
- Change Routes.ChannelDetail to accept channelId parameter
- Update ChannelDetailScreen to fetch channel on initialization
- Replace early return with loading state when channel is null
- Navigate directly to detail screen with channelId
- Remove intermediate navigation through list screen
- Fix predictive back gesture by eliminating blank composable state
Fixes#668
Co-authored-by: Ovi Trif <ovitrif@users.noreply.github.com>
@ovitrif
chore: add compose preview for channel loading
bef2790
@ovitrif
refactor: extract channel details vm
40019ff
@ovitrif
refactor: extract close channel vm
f0f217a
claude[bot]
claudeBot
reviewed
Mar 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
@ovitrifovitrif
changed the title
fix: resolve channel detail black screenfix: channel detail black screenMar 11, 2026
@ovitrif@claude
fix: wallet screen navigation transition
20eb8f5
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrifforce-pushed
the
fix/channel-screen-nav-668
branch
from
a7fe03a to
20eb8f5CompareMarch 11, 2026 01:27
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsViewModel.kt
Outdated

@ovitrif@claude
fix: address pr review feedback
2685e88
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrif
commented
Mar 11, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@claude Summarize the changes for reviewers.
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 11, 2026
@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
@ovitrifovitrif
mentioned this pull request
Mar 11, 2026
 Closed

@ovitrif@claude
fix: address pr review round 2
5b64e1a
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
@claudeclaudeBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
Found 1 issue. Checked for bugs and CLAUDE.md compliance.
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
ovitrifand others
added 2 commits
March 12, 2026 11:14
@ovitrif@claude
fix: guard pending orders from not-found
ddd78bb
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif@claude
fix: address claude.md rule violations
659e634
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
piotr-iohk
piotr-iohk
approved these changes
Mar 12, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment
•

edited

Loading

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on sim, LGTM.
jvsena42
jvsena42
approved these changes
Mar 12, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@jvsena42
jvsena42
merged commit 7c7f54b
into
masterMar 12, 2026

19 checks passed

@jvsena42
jvsena42
deleted the

fix/channel-screen-nav-668

branch
March 12, 2026 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Black screen on "Lightning Connection" screen


3 participants

@ovitrif@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: channel detail black screen by ovitrif · Pull Request #838 · synonymdev/bitkit-android · GitHub
Skip to content
fix: channel detail black screen - #838
Merged
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Mar 12, 2026
Merged
fix: channel detail black screen#838
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Conversation
@ovitrif
@ovitrifovitrif
commented
Mar 10, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Fixes#668
This PR:
  1. Fixes the channel detail screen black screen caused by shared ViewModel state loss during navigation
  2. Fixes predictive back gesture animations
  3. Fixes wallet screens (savings & spending) transition animations
  4. Refactor: extracts ChannelDetailViewModel and CloseConnectionViewModel from the monolithic LightningConnectionsViewModel
Description
The channel detail and close connection screens previously depended on a shared parent ViewModel (LightningConnectionsViewModel) to hold the selected channel state. This caused black screens when navigating back and forth, since the shared state could be lost during back-stack restoration or recomposition.
The fix converts Routes.ChannelDetail and Routes.CloseConnection from data object to data class with a channelId parameter, making each screen self-contained. Each screen now has its own ViewModel that loads channel data independently using the passed ID.
Additional improvements:
  • Added a loading state with spinner while channel data loads
  • Added handling with toast and automatic back navigation for the "not found" cases
Preview
BeforeAfter
before_1.75x.mp4
after_1.75x.mp4
QA Notes
Tests
  1. Verify intermittent bug of "black channel details screen" is fixed[Bug]: Black screen on "Lightning Connection" screen #668
  2. Try to break back nav gesture as seen in 1st video → should be impossible now
  3. Activity Detail (LN transfer) → Connection button → should land on ChannelDetail → back → should return to Activity Detail
Regression Tests (pick a few randomly)
  • Settings → Lightning Connections → tap channel → should still open
  • ChannelDetail → back → returns to connections list
  • ChannelDetail → Close Connection → should still work
  • Pull-to-refresh on channel detail
github-actionsBotand others
added 4 commits
March 10, 2026 21:09
@github-actions@ovitrif
fix: resolve channel detail black screen and navigation issues
bf4e9c4
- Change Routes.ChannelDetail to accept channelId parameter
- Update ChannelDetailScreen to fetch channel on initialization
- Replace early return with loading state when channel is null
- Navigate directly to detail screen with channelId
- Remove intermediate navigation through list screen
- Fix predictive back gesture by eliminating blank composable state
Fixes#668
Co-authored-by: Ovi Trif <ovitrif@users.noreply.github.com>
@ovitrif
chore: add compose preview for channel loading
bef2790
@ovitrif
refactor: extract channel details vm
40019ff
@ovitrif
refactor: extract close channel vm
f0f217a
claude[bot]
claudeBot
reviewed
Mar 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
@ovitrifovitrif
changed the title
fix: resolve channel detail black screenfix: channel detail black screenMar 11, 2026
@ovitrif@claude
fix: wallet screen navigation transition
20eb8f5
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrifforce-pushed
the
fix/channel-screen-nav-668
branch
from
a7fe03a to
20eb8f5CompareMarch 11, 2026 01:27
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsViewModel.kt
Outdated

@ovitrif@claude
fix: address pr review feedback
2685e88
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrif
commented
Mar 11, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@claude Summarize the changes for reviewers.
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 11, 2026
@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
@ovitrifovitrif
mentioned this pull request
Mar 11, 2026
 Closed

@ovitrif@claude
fix: address pr review round 2
5b64e1a
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
@claudeclaudeBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
Found 1 issue. Checked for bugs and CLAUDE.md compliance.
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
ovitrifand others
added 2 commits
March 12, 2026 11:14
@ovitrif@claude
fix: guard pending orders from not-found
ddd78bb
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif@claude
fix: address claude.md rule violations
659e634
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
piotr-iohk
piotr-iohk
approved these changes
Mar 12, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment
•

edited

Loading

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on sim, LGTM.
jvsena42
jvsena42
approved these changes
Mar 12, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@jvsena42
jvsena42
merged commit 7c7f54b
into
masterMar 12, 2026

19 checks passed

@jvsena42
jvsena42
deleted the

fix/channel-screen-nav-668

branch
March 12, 2026 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Black screen on "Lightning Connection" screen


3 participants

@ovitrif@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix: channel detail black screen by ovitrif · Pull Request #838 · synonymdev/bitkit-android · GitHub
Skip to content
fix: channel detail black screen - #838
Merged
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Mar 12, 2026
Merged
fix: channel detail black screen#838
jvsena42 merged 11 commits into
masterfrom 
fix/channel-screen-nav-668
Conversation
@ovitrif
@ovitrifovitrif
commented
Mar 10, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Fixes#668
This PR:
  1. Fixes the channel detail screen black screen caused by shared ViewModel state loss during navigation
  2. Fixes predictive back gesture animations
  3. Fixes wallet screens (savings & spending) transition animations
  4. Refactor: extracts ChannelDetailViewModel and CloseConnectionViewModel from the monolithic LightningConnectionsViewModel
Description
The channel detail and close connection screens previously depended on a shared parent ViewModel (LightningConnectionsViewModel) to hold the selected channel state. This caused black screens when navigating back and forth, since the shared state could be lost during back-stack restoration or recomposition.
The fix converts Routes.ChannelDetail and Routes.CloseConnection from data object to data class with a channelId parameter, making each screen self-contained. Each screen now has its own ViewModel that loads channel data independently using the passed ID.
Additional improvements:
  • Added a loading state with spinner while channel data loads
  • Added handling with toast and automatic back navigation for the "not found" cases
Preview
BeforeAfter
before_1.75x.mp4
after_1.75x.mp4
QA Notes
Tests
  1. Verify intermittent bug of "black channel details screen" is fixed[Bug]: Black screen on "Lightning Connection" screen #668
  2. Try to break back nav gesture as seen in 1st video → should be impossible now
  3. Activity Detail (LN transfer) → Connection button → should land on ChannelDetail → back → should return to Activity Detail
Regression Tests (pick a few randomly)
  • Settings → Lightning Connections → tap channel → should still open
  • ChannelDetail → back → returns to connections list
  • ChannelDetail → Close Connection → should still work
  • Pull-to-refresh on channel detail
github-actionsBotand others
added 4 commits
March 10, 2026 21:09
@github-actions@ovitrif
fix: resolve channel detail black screen and navigation issues
bf4e9c4
- Change Routes.ChannelDetail to accept channelId parameter
- Update ChannelDetailScreen to fetch channel on initialization
- Replace early return with loading state when channel is null
- Navigate directly to detail screen with channelId
- Remove intermediate navigation through list screen
- Fix predictive back gesture by eliminating blank composable state
Fixes#668
Co-authored-by: Ovi Trif <ovitrif@users.noreply.github.com>
@ovitrif
chore: add compose preview for channel loading
bef2790
@ovitrif
refactor: extract channel details vm
40019ff
@ovitrif
refactor: extract close channel vm
f0f217a
claude[bot]
claudeBot
reviewed
Mar 10, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
@ovitrifovitrif
changed the title
fix: resolve channel detail black screenfix: channel detail black screenMar 11, 2026
@ovitrif@claude
fix: wallet screen navigation transition
20eb8f5
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrifforce-pushed
the
fix/channel-screen-nav-668
branch
from
a7fe03a to
20eb8f5CompareMarch 11, 2026 01:27
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/CloseConnectionViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/LightningConnectionsViewModel.kt
Outdated

@ovitrif@claude
fix: address pr review feedback
2685e88
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif
ovitrif
commented
Mar 11, 2026

Copy link


Copy Markdown

CollaboratorAuthor
@claude Summarize the changes for reviewers.
@ovitrifovitrif
added this to the 2.2.0 milestone
Mar 11, 2026
@claude

This comment has been minimized.

Sign in to view
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailScreen.kt
@ovitrifovitrif
mentioned this pull request
Mar 11, 2026
 Closed

@ovitrif@claude
fix: address pr review round 2
5b64e1a
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claude[bot]
claudeBot
reviewed
Mar 11, 2026
View reviewed changes
@claudeclaudeBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
Found 1 issue. Checked for bugs and CLAUDE.md compliance.
Comment threadapp/src/main/java/to/bitkit/ui/settings/lightning/ChannelDetailViewModel.kt
ovitrifand others
added 2 commits
March 12, 2026 11:14
@ovitrif@claude
fix: guard pending orders from not-found
ddd78bb
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ovitrif@claude
fix: address claude.md rule violations
659e634
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
piotr-iohk
piotr-iohk
approved these changes
Mar 12, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment
•

edited

Loading

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on sim, LGTM.
jvsena42
jvsena42
approved these changes
Mar 12, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck
@jvsena42
jvsena42
merged commit 7c7f54b
into
masterMar 12, 2026

19 checks passed

@jvsena42
jvsena42
deleted the

fix/channel-screen-nav-668

branch
March 12, 2026 15:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Black screen on "Lightning Connection" screen


3 participants

@ovitrif@piotr-iohk@jvsena42