Resolve android pubky parity issues from #902 - #905

Merged
ben-kaufman merged 21 commits into
masterfrom
codex-pubky-902-android
Apr 28, 2026
Merged

Resolve android pubky parity issues from #902#905
ben-kaufman merged 21 commits into
masterfrom
codex-pubky-902-android

Conversation

@ben-kaufman

@ben-kaufmanben-kaufman commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

resolves#902

Description

  • restore pubky sessions from wallet backups and reinitialize pubky after wallet restore
  • align Android profile and contacts flows with the iOS parity work where applicable
  • improve pubky routing from clipboard and scanner input
  • polish profile/contact edit flows, delete flows, and related copy
  • add unit coverage for pubky restore, delete recovery, and contact import routing

Preview

  • N/A

QA Notes

  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt
  • installed and launched to.bitkit.dev on connected device 2409BRN2CA

@ben-kaufman
ben-kaufman marked this pull request as ready for review April 23, 2026 12:58
@ben-kaufmanben-kaufman changed the title [codex] resolve android pubky parity issues from #902Resolve android pubky parity issues from #902Apr 23, 2026
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt Outdated
piotr-iohk
piotr-iohk reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/res/values/strings.xml Outdated
Comment threadapp/src/main/res/values/strings.xml Outdated
Comment threadapp/src/main/res/values/strings.xml Outdated
@piotr-iohkpiotr-iohk mentioned this pull request Apr 23, 2026
Merged
@piotr-iohk

This comment was marked as resolved.

Sign in to view
ben-kaufmanand others added 4 commits April 23, 2026 10:06
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
48b29f6
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
efdbf06
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
2e2706b
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman
fix: truncate pubky contact names
a787832
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/Tag.kt Outdated
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt Outdated
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/WalletViewModelTest.kt Outdated
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/screens/contacts/ContactImportFlowTest.kt Outdated
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadCHANGELOG.md Outdated
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt Outdated
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/AppViewModel.kt Outdated
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt Outdated
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt Outdated
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt Outdated
claude[bot]
claudeBot reviewed Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt Outdated
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt Outdated
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt Outdated
Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt Outdated
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt Outdated
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt Outdated
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/PubkyRouteResolver.kt Outdated
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt Outdated
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt Outdated
claude[bot]
claudeBot reviewed Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt Outdated
@claude

This comment has been minimized.

Sign in to view
@ben-kaufman

ben-kaufman commented Apr 24, 2026

Copy link
Copy Markdown
ContributorAuthor

@jvsena42 everything should be resolved now, please recheck

@piotr-iohk

piotr-iohk commented Apr 25, 2026

Copy link
Copy Markdown
Collaborator

There's few things around contacts addition (I guess could be addressed later, but did not mention it in any tickets)

  • duplicate contacts addition seems there's no validation on adding contact that already exists. (Could be the same as in case of invalid pubky, or self add)
Screen.Recording.2026-04-25.at.17.06.22.mov
  • retry button does nothing on adding contact on qr code scan
Screen.Recording.2026-04-25.at.17.05.12.mov

@piotr-iohkpiotr-iohk mentioned this pull request Apr 25, 2026
Merged
jvsena42
jvsena42 requested changes Apr 27, 2026
View reviewed changes

@jvsena42jvsena42 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add contact from Contacts screen is not validating if a contact was already added

Screen_recording_20260427_082659.webm

@claude

claudeBot commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

piotr-iohk
piotr-iohk approved these changes Apr 28, 2026
View reviewed changes

@piotr-iohkpiotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to merge this.

Outstanding inconsistencies around contact addition/validation can be addressed separately, added to the ticket: #909 (comment)

jvsena42
jvsena42 requested changes Apr 28, 2026
View reviewed changes

@jvsena42jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still see a divergence when trying to add an existent contact from home and from contacts

Screen_recording_20260428_070658.webm

@piotr-iohk

piotr-iohk commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Still see a divergence when trying to add an existent contact from home and from contacts

@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍

@jvsena42

jvsena42 commented Apr 28, 2026

Copy link
Copy Markdown
Member

Still see a divergence when trying to add an existent contact from home and from contacts

@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍

Agreed, this one has 31 modified files already. I'll keep testing

jvsena42
jvsena42 approved these changes Apr 28, 2026
View reviewed changes

@jvsena42jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • Login with pubky-ring
  • Add contact from home scanner
  • Try to add self key -> blocked
  • Reset -> restore -> profile restored
  • Add contact from home
  • Add contact from contact screen

Some points to fix in the next PR: #909

@ben-kaufman
ben-kaufman merged commit 93b36b5 into masterApr 28, 2026
20 checks passed
@ben-kaufman
ben-kaufman deleted the codex-pubky-902-android branch April 28, 2026 12:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes

Assignees

@ben-kaufmanben-kaufman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pubky profile & contacts — outstanding work (Android + iOS)

3 participants

@ben-kaufman@piotr-iohk@jvsena42
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Resolve android pubky parity issues from #902 - #905
Merged
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Apr 28, 2026
Merged
Resolve android pubky parity issues from #902#905
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Apr 23, 2026

Copy link


Copy Markdown

Contributor
resolves#902
Description
  • restore pubky sessions from wallet backups and reinitialize pubky after wallet restore
  • align Android profile and contacts flows with the iOS parity work where applicable
  • improve pubky routing from clipboard and scanner input
  • polish profile/contact edit flows, delete flows, and related copy
  • add unit coverage for pubky restore, delete recovery, and contact import routing
Preview
  • N/A
QA Notes
  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt
  • installed and launched to.bitkit.dev on connected device 2409BRN2CA
@ben-kaufman
ben-kaufman
marked this pull request as ready for review
April 23, 2026 12:58
@ben-kaufmanben-kaufman
changed the title
[codex] resolve android pubky parity issues from #902Resolve android pubky parity issues from #902Apr 23, 2026
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

piotr-iohk
piotr-iohk
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 23, 2026
 Merged

@piotr-iohk

This comment was marked as resolved.

Sign in to view
ben-kaufmanand others
added 4 commits
April 23, 2026 10:06
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
48b29f6
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
efdbf06
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
2e2706b
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman
fix: truncate pubky contact names
a787832
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/Tag.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/WalletViewModelTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/screens/contacts/ContactImportFlowTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadCHANGELOG.md
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/PubkyRouteResolver.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
@ben-kaufman
ben-kaufman
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@jvsena42 everything should be resolved now, please recheck
@piotr-iohk
piotr-iohk
commented
Apr 25, 2026

Copy link


Copy Markdown

Collaborator
There's few things around contacts addition (I guess could be addressed later, but did not mention it in any tickets)
  • duplicate contacts addition seems there's no validation on adding contact that already exists. (Could be the same as in case of invalid pubky, or self add)
Screen.Recording.2026-04-25.at.17.06.22.mov
  • retry button does nothing on adding contact on qr code scan
Screen.Recording.2026-04-25.at.17.05.12.mov
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 25, 2026
 Merged

jvsena42
jvsena42
requested changes
Apr 27, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add contact from Contacts screen is not validating if a contact was already added
Screen_recording_20260427_082659.webm
@claude
claudeBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
piotr-iohk
piotr-iohk
approved these changes
Apr 28, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to merge this.
Outstanding inconsistencies around contact addition/validation can be addressed separately, added to the ticket: #909 (comment)
jvsena42
jvsena42
requested changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still see a divergence when trying to add an existent contact from home and from contacts
Screen_recording_20260428_070658.webm
@piotr-iohk
piotr-iohk
commented
Apr 28, 2026

Copy link


Copy Markdown

Collaborator
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
@jvsena42
jvsena42
commented
Apr 28, 2026

Copy link


Copy Markdown

Member
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
Agreed, this one has 31 modified files already. I'll keep testing
jvsena42
jvsena42
approved these changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • Login with pubky-ring
  • Add contact from home scanner
  • Try to add self key -> blocked
  • Reset -> restore -> profile restored
  • Add contact from home
  • Add contact from contact screen
Some points to fix in the next PR: #909
@ben-kaufman
ben-kaufman
merged commit 93b36b5
into
masterApr 28, 2026

20 checks passed

@ben-kaufman
ben-kaufman
deleted the

codex-pubky-902-android

branch
April 28, 2026 12:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Pubky profile & contacts — outstanding work (Android + iOS)


3 participants

@ben-kaufman@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolve android pubky parity issues from #902 - #905
Merged
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Apr 28, 2026
Merged
Resolve android pubky parity issues from #902#905
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Apr 23, 2026

Copy link


Copy Markdown

Contributor
resolves#902
Description
  • restore pubky sessions from wallet backups and reinitialize pubky after wallet restore
  • align Android profile and contacts flows with the iOS parity work where applicable
  • improve pubky routing from clipboard and scanner input
  • polish profile/contact edit flows, delete flows, and related copy
  • add unit coverage for pubky restore, delete recovery, and contact import routing
Preview
  • N/A
QA Notes
  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt
  • installed and launched to.bitkit.dev on connected device 2409BRN2CA
@ben-kaufman
ben-kaufman
marked this pull request as ready for review
April 23, 2026 12:58
@ben-kaufmanben-kaufman
changed the title
[codex] resolve android pubky parity issues from #902Resolve android pubky parity issues from #902Apr 23, 2026
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

piotr-iohk
piotr-iohk
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 23, 2026
 Merged

@piotr-iohk

This comment was marked as resolved.

Sign in to view
ben-kaufmanand others
added 4 commits
April 23, 2026 10:06
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
48b29f6
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
efdbf06
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
2e2706b
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman
fix: truncate pubky contact names
a787832
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/Tag.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/WalletViewModelTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/screens/contacts/ContactImportFlowTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadCHANGELOG.md
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/PubkyRouteResolver.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
@ben-kaufman
ben-kaufman
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@jvsena42 everything should be resolved now, please recheck
@piotr-iohk
piotr-iohk
commented
Apr 25, 2026

Copy link


Copy Markdown

Collaborator
There's few things around contacts addition (I guess could be addressed later, but did not mention it in any tickets)
  • duplicate contacts addition seems there's no validation on adding contact that already exists. (Could be the same as in case of invalid pubky, or self add)
Screen.Recording.2026-04-25.at.17.06.22.mov
  • retry button does nothing on adding contact on qr code scan
Screen.Recording.2026-04-25.at.17.05.12.mov
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 25, 2026
 Merged

jvsena42
jvsena42
requested changes
Apr 27, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add contact from Contacts screen is not validating if a contact was already added
Screen_recording_20260427_082659.webm
@claude
claudeBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
piotr-iohk
piotr-iohk
approved these changes
Apr 28, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to merge this.
Outstanding inconsistencies around contact addition/validation can be addressed separately, added to the ticket: #909 (comment)
jvsena42
jvsena42
requested changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still see a divergence when trying to add an existent contact from home and from contacts
Screen_recording_20260428_070658.webm
@piotr-iohk
piotr-iohk
commented
Apr 28, 2026

Copy link


Copy Markdown

Collaborator
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
@jvsena42
jvsena42
commented
Apr 28, 2026

Copy link


Copy Markdown

Member
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
Agreed, this one has 31 modified files already. I'll keep testing
jvsena42
jvsena42
approved these changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • Login with pubky-ring
  • Add contact from home scanner
  • Try to add self key -> blocked
  • Reset -> restore -> profile restored
  • Add contact from home
  • Add contact from contact screen
Some points to fix in the next PR: #909
@ben-kaufman
ben-kaufman
merged commit 93b36b5
into
masterApr 28, 2026

20 checks passed

@ben-kaufman
ben-kaufman
deleted the

codex-pubky-902-android

branch
April 28, 2026 12:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Pubky profile & contacts — outstanding work (Android + iOS)


3 participants

@ben-kaufman@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolve android pubky parity issues from #902 - #905
Merged
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Apr 28, 2026
Merged
Resolve android pubky parity issues from #902#905
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Apr 23, 2026

Copy link


Copy Markdown

Contributor
resolves#902
Description
  • restore pubky sessions from wallet backups and reinitialize pubky after wallet restore
  • align Android profile and contacts flows with the iOS parity work where applicable
  • improve pubky routing from clipboard and scanner input
  • polish profile/contact edit flows, delete flows, and related copy
  • add unit coverage for pubky restore, delete recovery, and contact import routing
Preview
  • N/A
QA Notes
  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt
  • installed and launched to.bitkit.dev on connected device 2409BRN2CA
@ben-kaufman
ben-kaufman
marked this pull request as ready for review
April 23, 2026 12:58
@ben-kaufmanben-kaufman
changed the title
[codex] resolve android pubky parity issues from #902Resolve android pubky parity issues from #902Apr 23, 2026
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

piotr-iohk
piotr-iohk
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 23, 2026
 Merged

@piotr-iohk

This comment was marked as resolved.

Sign in to view
ben-kaufmanand others
added 4 commits
April 23, 2026 10:06
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
48b29f6
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
efdbf06
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
2e2706b
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman
fix: truncate pubky contact names
a787832
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/Tag.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/WalletViewModelTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/screens/contacts/ContactImportFlowTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadCHANGELOG.md
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/PubkyRouteResolver.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
@ben-kaufman
ben-kaufman
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@jvsena42 everything should be resolved now, please recheck
@piotr-iohk
piotr-iohk
commented
Apr 25, 2026

Copy link


Copy Markdown

Collaborator
There's few things around contacts addition (I guess could be addressed later, but did not mention it in any tickets)
  • duplicate contacts addition seems there's no validation on adding contact that already exists. (Could be the same as in case of invalid pubky, or self add)
Screen.Recording.2026-04-25.at.17.06.22.mov
  • retry button does nothing on adding contact on qr code scan
Screen.Recording.2026-04-25.at.17.05.12.mov
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 25, 2026
 Merged

jvsena42
jvsena42
requested changes
Apr 27, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add contact from Contacts screen is not validating if a contact was already added
Screen_recording_20260427_082659.webm
@claude
claudeBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
piotr-iohk
piotr-iohk
approved these changes
Apr 28, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to merge this.
Outstanding inconsistencies around contact addition/validation can be addressed separately, added to the ticket: #909 (comment)
jvsena42
jvsena42
requested changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still see a divergence when trying to add an existent contact from home and from contacts
Screen_recording_20260428_070658.webm
@piotr-iohk
piotr-iohk
commented
Apr 28, 2026

Copy link


Copy Markdown

Collaborator
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
@jvsena42
jvsena42
commented
Apr 28, 2026

Copy link


Copy Markdown

Member
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
Agreed, this one has 31 modified files already. I'll keep testing
jvsena42
jvsena42
approved these changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • Login with pubky-ring
  • Add contact from home scanner
  • Try to add self key -> blocked
  • Reset -> restore -> profile restored
  • Add contact from home
  • Add contact from contact screen
Some points to fix in the next PR: #909
@ben-kaufman
ben-kaufman
merged commit 93b36b5
into
masterApr 28, 2026

20 checks passed

@ben-kaufman
ben-kaufman
deleted the

codex-pubky-902-android

branch
April 28, 2026 12:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Pubky profile & contacts — outstanding work (Android + iOS)


3 participants

@ben-kaufman@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Resolve android pubky parity issues from #902 - #905
Merged
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Apr 28, 2026
Merged
Resolve android pubky parity issues from #902#905
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Apr 23, 2026

Copy link


Copy Markdown

Contributor
resolves#902
Description
  • restore pubky sessions from wallet backups and reinitialize pubky after wallet restore
  • align Android profile and contacts flows with the iOS parity work where applicable
  • improve pubky routing from clipboard and scanner input
  • polish profile/contact edit flows, delete flows, and related copy
  • add unit coverage for pubky restore, delete recovery, and contact import routing
Preview
  • N/A
QA Notes
  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt
  • installed and launched to.bitkit.dev on connected device 2409BRN2CA
@ben-kaufman
ben-kaufman
marked this pull request as ready for review
April 23, 2026 12:58
@ben-kaufmanben-kaufman
changed the title
[codex] resolve android pubky parity issues from #902Resolve android pubky parity issues from #902Apr 23, 2026
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

piotr-iohk
piotr-iohk
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 23, 2026
 Merged

@piotr-iohk

This comment was marked as resolved.

Sign in to view
ben-kaufmanand others
added 4 commits
April 23, 2026 10:06
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
48b29f6
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
efdbf06
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
2e2706b
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman
fix: truncate pubky contact names
a787832
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/Tag.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/WalletViewModelTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/screens/contacts/ContactImportFlowTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadCHANGELOG.md
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/PubkyRouteResolver.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
@ben-kaufman
ben-kaufman
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@jvsena42 everything should be resolved now, please recheck
@piotr-iohk
piotr-iohk
commented
Apr 25, 2026

Copy link


Copy Markdown

Collaborator
There's few things around contacts addition (I guess could be addressed later, but did not mention it in any tickets)
  • duplicate contacts addition seems there's no validation on adding contact that already exists. (Could be the same as in case of invalid pubky, or self add)
Screen.Recording.2026-04-25.at.17.06.22.mov
  • retry button does nothing on adding contact on qr code scan
Screen.Recording.2026-04-25.at.17.05.12.mov
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 25, 2026
 Merged

jvsena42
jvsena42
requested changes
Apr 27, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add contact from Contacts screen is not validating if a contact was already added
Screen_recording_20260427_082659.webm
@claude
claudeBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
piotr-iohk
piotr-iohk
approved these changes
Apr 28, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to merge this.
Outstanding inconsistencies around contact addition/validation can be addressed separately, added to the ticket: #909 (comment)
jvsena42
jvsena42
requested changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still see a divergence when trying to add an existent contact from home and from contacts
Screen_recording_20260428_070658.webm
@piotr-iohk
piotr-iohk
commented
Apr 28, 2026

Copy link


Copy Markdown

Collaborator
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
@jvsena42
jvsena42
commented
Apr 28, 2026

Copy link


Copy Markdown

Member
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
Agreed, this one has 31 modified files already. I'll keep testing
jvsena42
jvsena42
approved these changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • Login with pubky-ring
  • Add contact from home scanner
  • Try to add self key -> blocked
  • Reset -> restore -> profile restored
  • Add contact from home
  • Add contact from contact screen
Some points to fix in the next PR: #909
@ben-kaufman
ben-kaufman
merged commit 93b36b5
into
masterApr 28, 2026

20 checks passed

@ben-kaufman
ben-kaufman
deleted the

codex-pubky-902-android

branch
April 28, 2026 12:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Pubky profile & contacts — outstanding work (Android + iOS)


3 participants

@ben-kaufman@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolve android pubky parity issues from #902 - #905
Merged
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Apr 28, 2026
Merged
Resolve android pubky parity issues from #902#905
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Apr 23, 2026

Copy link


Copy Markdown

Contributor
resolves#902
Description
  • restore pubky sessions from wallet backups and reinitialize pubky after wallet restore
  • align Android profile and contacts flows with the iOS parity work where applicable
  • improve pubky routing from clipboard and scanner input
  • polish profile/contact edit flows, delete flows, and related copy
  • add unit coverage for pubky restore, delete recovery, and contact import routing
Preview
  • N/A
QA Notes
  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt
  • installed and launched to.bitkit.dev on connected device 2409BRN2CA
@ben-kaufman
ben-kaufman
marked this pull request as ready for review
April 23, 2026 12:58
@ben-kaufmanben-kaufman
changed the title
[codex] resolve android pubky parity issues from #902Resolve android pubky parity issues from #902Apr 23, 2026
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

piotr-iohk
piotr-iohk
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 23, 2026
 Merged

@piotr-iohk

This comment was marked as resolved.

Sign in to view
ben-kaufmanand others
added 4 commits
April 23, 2026 10:06
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
48b29f6
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
efdbf06
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
2e2706b
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman
fix: truncate pubky contact names
a787832
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/Tag.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/WalletViewModelTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/screens/contacts/ContactImportFlowTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadCHANGELOG.md
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/PubkyRouteResolver.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
@ben-kaufman
ben-kaufman
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@jvsena42 everything should be resolved now, please recheck
@piotr-iohk
piotr-iohk
commented
Apr 25, 2026

Copy link


Copy Markdown

Collaborator
There's few things around contacts addition (I guess could be addressed later, but did not mention it in any tickets)
  • duplicate contacts addition seems there's no validation on adding contact that already exists. (Could be the same as in case of invalid pubky, or self add)
Screen.Recording.2026-04-25.at.17.06.22.mov
  • retry button does nothing on adding contact on qr code scan
Screen.Recording.2026-04-25.at.17.05.12.mov
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 25, 2026
 Merged

jvsena42
jvsena42
requested changes
Apr 27, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add contact from Contacts screen is not validating if a contact was already added
Screen_recording_20260427_082659.webm
@claude
claudeBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
piotr-iohk
piotr-iohk
approved these changes
Apr 28, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to merge this.
Outstanding inconsistencies around contact addition/validation can be addressed separately, added to the ticket: #909 (comment)
jvsena42
jvsena42
requested changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still see a divergence when trying to add an existent contact from home and from contacts
Screen_recording_20260428_070658.webm
@piotr-iohk
piotr-iohk
commented
Apr 28, 2026

Copy link


Copy Markdown

Collaborator
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
@jvsena42
jvsena42
commented
Apr 28, 2026

Copy link


Copy Markdown

Member
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
Agreed, this one has 31 modified files already. I'll keep testing
jvsena42
jvsena42
approved these changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • Login with pubky-ring
  • Add contact from home scanner
  • Try to add self key -> blocked
  • Reset -> restore -> profile restored
  • Add contact from home
  • Add contact from contact screen
Some points to fix in the next PR: #909
@ben-kaufman
ben-kaufman
merged commit 93b36b5
into
masterApr 28, 2026

20 checks passed

@ben-kaufman
ben-kaufman
deleted the

codex-pubky-902-android

branch
April 28, 2026 12:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Pubky profile & contacts — outstanding work (Android + iOS)


3 participants

@ben-kaufman@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Resolve android pubky parity issues from #902 - #905
Merged
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Apr 28, 2026
Merged
Resolve android pubky parity issues from #902#905
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Apr 23, 2026

Copy link


Copy Markdown

Contributor
resolves#902
Description
  • restore pubky sessions from wallet backups and reinitialize pubky after wallet restore
  • align Android profile and contacts flows with the iOS parity work where applicable
  • improve pubky routing from clipboard and scanner input
  • polish profile/contact edit flows, delete flows, and related copy
  • add unit coverage for pubky restore, delete recovery, and contact import routing
Preview
  • N/A
QA Notes
  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt
  • installed and launched to.bitkit.dev on connected device 2409BRN2CA
@ben-kaufman
ben-kaufman
marked this pull request as ready for review
April 23, 2026 12:58
@ben-kaufmanben-kaufman
changed the title
[codex] resolve android pubky parity issues from #902Resolve android pubky parity issues from #902Apr 23, 2026
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

piotr-iohk
piotr-iohk
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 23, 2026
 Merged

@piotr-iohk

This comment was marked as resolved.

Sign in to view
ben-kaufmanand others
added 4 commits
April 23, 2026 10:06
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
48b29f6
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
efdbf06
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
2e2706b
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman
fix: truncate pubky contact names
a787832
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/Tag.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/WalletViewModelTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/screens/contacts/ContactImportFlowTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadCHANGELOG.md
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/PubkyRouteResolver.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
@ben-kaufman
ben-kaufman
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@jvsena42 everything should be resolved now, please recheck
@piotr-iohk
piotr-iohk
commented
Apr 25, 2026

Copy link


Copy Markdown

Collaborator
There's few things around contacts addition (I guess could be addressed later, but did not mention it in any tickets)
  • duplicate contacts addition seems there's no validation on adding contact that already exists. (Could be the same as in case of invalid pubky, or self add)
Screen.Recording.2026-04-25.at.17.06.22.mov
  • retry button does nothing on adding contact on qr code scan
Screen.Recording.2026-04-25.at.17.05.12.mov
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 25, 2026
 Merged

jvsena42
jvsena42
requested changes
Apr 27, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add contact from Contacts screen is not validating if a contact was already added
Screen_recording_20260427_082659.webm
@claude
claudeBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
piotr-iohk
piotr-iohk
approved these changes
Apr 28, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to merge this.
Outstanding inconsistencies around contact addition/validation can be addressed separately, added to the ticket: #909 (comment)
jvsena42
jvsena42
requested changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still see a divergence when trying to add an existent contact from home and from contacts
Screen_recording_20260428_070658.webm
@piotr-iohk
piotr-iohk
commented
Apr 28, 2026

Copy link


Copy Markdown

Collaborator
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
@jvsena42
jvsena42
commented
Apr 28, 2026

Copy link


Copy Markdown

Member
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
Agreed, this one has 31 modified files already. I'll keep testing
jvsena42
jvsena42
approved these changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • Login with pubky-ring
  • Add contact from home scanner
  • Try to add self key -> blocked
  • Reset -> restore -> profile restored
  • Add contact from home
  • Add contact from contact screen
Some points to fix in the next PR: #909
@ben-kaufman
ben-kaufman
merged commit 93b36b5
into
masterApr 28, 2026

20 checks passed

@ben-kaufman
ben-kaufman
deleted the

codex-pubky-902-android

branch
April 28, 2026 12:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Pubky profile & contacts — outstanding work (Android + iOS)


3 participants

@ben-kaufman@piotr-iohk@jvsena42

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Resolve android pubky parity issues from #902 - #905
Merged
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Apr 28, 2026
Merged
Resolve android pubky parity issues from #902#905
ben-kaufman merged 21 commits into
masterfrom 
codex-pubky-902-android
Conversation
@ben-kaufman
@ben-kaufmanben-kaufman
commented
Apr 23, 2026

Copy link


Copy Markdown

Contributor
resolves#902
Description
  • restore pubky sessions from wallet backups and reinitialize pubky after wallet restore
  • align Android profile and contacts flows with the iOS parity work where applicable
  • improve pubky routing from clipboard and scanner input
  • polish profile/contact edit flows, delete flows, and related copy
  • add unit coverage for pubky restore, delete recovery, and contact import routing
Preview
  • N/A
QA Notes
  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt
  • installed and launched to.bitkit.dev on connected device 2409BRN2CA
@ben-kaufman
ben-kaufman
marked this pull request as ready for review
April 23, 2026 12:58
@ben-kaufmanben-kaufman
changed the title
[codex] resolve android pubky parity issues from #902Resolve android pubky parity issues from #902Apr 23, 2026
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

piotr-iohk
piotr-iohk
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

Comment threadapp/src/main/res/values/strings.xml
Outdated

@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 23, 2026
 Merged

@piotr-iohk

This comment was marked as resolved.

Sign in to view
ben-kaufmanand others
added 4 commits
April 23, 2026 10:06
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
48b29f6
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
efdbf06
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman@piotr-iohk
Update app/src/main/res/values/strings.xml
2e2706b
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman
fix: truncate pubky contact names
a787832
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/Tag.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/WalletViewModelTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/ui/screens/contacts/ContactImportFlowTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadCHANGELOG.md
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/BackupRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 23, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/contacts/AddContactScreen.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/test/java/to/bitkit/repositories/PubkyRepoTest.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/viewmodels/PubkyRouteResolver.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

claude[bot]
claudeBot
reviewed
Apr 24, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt
Outdated

@claude

This comment has been minimized.

Sign in to view
@ben-kaufman
ben-kaufman
commented
Apr 24, 2026

Copy link


Copy Markdown

ContributorAuthor
@jvsena42 everything should be resolved now, please recheck
@piotr-iohk
piotr-iohk
commented
Apr 25, 2026

Copy link


Copy Markdown

Collaborator
There's few things around contacts addition (I guess could be addressed later, but did not mention it in any tickets)
  • duplicate contacts addition seems there's no validation on adding contact that already exists. (Could be the same as in case of invalid pubky, or self add)
Screen.Recording.2026-04-25.at.17.06.22.mov
  • retry button does nothing on adding contact on qr code scan
Screen.Recording.2026-04-25.at.17.05.12.mov
@piotr-iohkpiotr-iohk
mentioned this pull request
Apr 25, 2026
 Merged

jvsena42
jvsena42
requested changes
Apr 27, 2026
View reviewed changes
@jvsena42jvsena42
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add contact from Contacts screen is not validating if a contact was already added
Screen_recording_20260427_082659.webm
@claude
claudeBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
piotr-iohk
piotr-iohk
approved these changes
Apr 28, 2026
View reviewed changes
@piotr-iohkpiotr-iohk
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to merge this.
Outstanding inconsistencies around contact addition/validation can be addressed separately, added to the ticket: #909 (comment)
jvsena42
jvsena42
requested changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still see a divergence when trying to add an existent contact from home and from contacts
Screen_recording_20260428_070658.webm
@piotr-iohk
piotr-iohk
commented
Apr 28, 2026

Copy link


Copy Markdown

Collaborator
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
@jvsena42
jvsena42
commented
Apr 28, 2026

Copy link


Copy Markdown

Member
Still see a divergence when trying to add an existent contact from home and from contacts
@jvsena42@ben-kaufman documented those in #909 (comment). I was thinking it could be handled in separate PR not to bloat this one - along with some other add/delete contact flow stuff (see: #909), but might as well be handled here. 👍
Agreed, this one has 31 modified files already. I'll keep testing
jvsena42
jvsena42
approved these changes
Apr 28, 2026
View reviewed changes
@jvsena42jvsena42
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • Login with pubky-ring
  • Add contact from home scanner
  • Try to add self key -> blocked
  • Reset -> restore -> profile restored
  • Add contact from home
  • Add contact from contact screen
Some points to fix in the next PR: #909
@ben-kaufman
ben-kaufman
merged commit 93b36b5
into
masterApr 28, 2026

20 checks passed

@ben-kaufman
ben-kaufman
deleted the

codex-pubky-902-android

branch
April 28, 2026 12:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments
@piotr-iohkpiotr-iohkpiotr-iohk approved these changes
@jvsena42jvsena42jvsena42 approved these changes

Assignees

@ben-kaufmanben-kaufman

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Pubky profile & contacts — outstanding work (Android + iOS)


3 participants

@ben-kaufman@piotr-iohk@jvsena42