Uh oh!
There was an error while loading. Please reload this page.
test: add calculator widget device tests - #944
Conversation
6058f50 to
4c965a8Compare4c965a8 to
60fe272Comparec167ac7 to
e8f05e7Compare60fe272 to
6607f90Comparee8f05e7 to
d4e542dCompare6607f90 to
566af19CompareThere was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:566af193b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
d4e542d to
3fa8959Compare566af19 to
836a65fCompare3fa8959 to
3c440c9Compare836a65f to
61cc72cCompare3c440c9 to
966c034Compare61cc72c to
2637a68Compare2637a68 to
b45eeb4Compare966c034 to
8f0dd84Compareb45eeb4 to
78253c8Compare8f0dd84 to
74056bdCompare78253c8 to
8f16bbcCompare74056bd to
3b82d78Compare3b82d78 to
618af1bCompare806a2d2 to
24d16bdCompare20b2b81 to
0bafb28Compare24d16bd to
91404e0CompareThere was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:91404e0952
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
91404e0 to
ac291f1CompareThere was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:ac291f1b75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
ac291f1 to
b8e579bCompareThere was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:b8e579bade
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
jvsena42
left a comment
There was a problem hiding this comment.
Ran the tests locally. approved with some comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Added separate lane |
Uh oh!
There was an error while loading. Please reload this page.
Closes: #950
Note
AI Dev Tests
This class of tests are intended to aid in development using AI agents, they should stay free of requirements to run them during QA gating. There shouldn't be any constraint wrt. time it takes to run these tests if ran together. Personally, I would be in favour of them covering all possible user-facing functionalities of the app in time.
Stacked on #943.
Description
DeviceIntegrationandDeviceUiIntegrationlanes from test: add android test lanes #943, and adds a focusedCalculatorWidgetlane for calculator-only device UI coverage.Preview
N/A
QA Notes
Manual Tests
N/A
Automated Checks
./gradlew compileDevDebugKotlin testDevDebugUnitTest compileDevDebugAndroidTestKotlin detekt./gradlew compileDevDebugAndroidTestKotlin./gradlew tasks --all --console=plain | rg 'connectedDevDebugCalculatorWidgetAndroidTest|CalculatorWidget'./gradlew connectedDevDebugDeviceUiIntegrationAndroidTest -m./gradlew connectedDevDebugDeviceUiIntegrationAndroidTestran 2 tests on Pixel 10 Pro - 16.Reviewer Note
Recommended merge order (! wait a few seconds for branch of merged PRs to be deleted):