fix: prevent sticky node crash - #987

Merged
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980
Jun 3, 2026
Merged

fix: prevent sticky node crash#987
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980

Conversation

@ovitrif

@ovitrifovitrif commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes#980
Fixes#981
Refs #986

Description

This PR:

  1. Guards LightningNodeService startup so Android does not promote the service from sticky/null restarts.
  2. Promotes the service with the explicit dataSync foreground-service type.
  3. Stops the foreground service immediately on Android timeout or notification stop before running async node cleanup.
  4. Adds regression coverage for foreground-service startup, restart, promotion-failure, stop, and timeout behavior.

Preview

N/A - service lifecycle crash fix, no UI changes.

QA Notes

Repro / Fix Evidence

  • Emulator/device setup: API 35+ with dev app to.bitkit.dev, target SDK 36, and shortened dataSync timeout:
    adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
    adb shell device_config get activity_manager data_sync_fgs_timeout_duration
  • Pre-fix repro: checkout v2.2.0, install dev build, apply a local-only stress patch that delays stopSelf() in LightningNodeService.onTimeout() after lightningRepo.stop(), start the app, press Home, and wait about 35s.
  • Pre-fix crash evidence: .ai/issue_980_prefix/logcat.txt line 1187 shows ForegroundServiceDidNotStopInTimeException after FGS (dataSync) timed out.
  • Post-fix verification: checkout this branch, install dev build, use the same 30s timeout, background the app with the node service running, and wait about 35s.
  • Post-fix clean timeout evidence: .ai/issue_980_postfix/logcat.txt line 2044 shows FGS (dataSync) timed out, followed by service timeout handling and onDestroy, with no FGS Crashed, no RemoteServiceException, and no process death.
  • Optional symmetric stress on the fix: delay async lightningRepo.stop() after stopForegroundService(startId) in onTimeout; the FGS is already stopped before the delay, so the process still does not crash.
  • Reset timeout override after QA:
    adb shell device_config delete activity_manager data_sync_fgs_timeout_duration

Manual Tests

  • 1.regression: Android 15+ or 16+ device → enable shortened dataSync FGS timeout → background Bitkit with node service running: service stops cleanly without ForegroundServiceDidNotStopInTimeException.
  • 2.regression: Bitkit with notifications enabled → start background node service → force sticky/null restart condition: service does not promote from onCreate() and does not crash with ForegroundServiceStartNotAllowedException.
  • 3.regression: Node notification → tap Stop: foreground service notification is removed and app/service stops cleanly.

Automated Checks

  • Unit tests added/updated: app/src/test/java/to/bitkit/androidServices/LightningNodeServiceTest.kt covers explicit start action, typed dataSync foreground promotion, null/unsupported restart intents, promotion failure, duplicate starts, stop action ordering, and API-35 timeout ordering.
  • Local checks passed:
    • ./gradlew testDevDebugUnitTest --tests to.bitkit.androidServices.LightningNodeServiceTest
    • just compile
    • just test
    • just lint
  • just lint exited successfully; it printed existing unrelated detekt findings in AppViewModel.kt and SupportScreen.kt.

@ovitrif
ovitrif requested a review from piotr-iohkJune 3, 2026 14:57
@ovitrifovitrif added this to the 2.3.0 milestone Jun 3, 2026
@ovitrif
ovitrif requested a review from jvsena42June 3, 2026 16:11
@piotr-iohk

Copy link
Copy Markdown
Collaborator

Emulator setup (once per session)

  • API 35+ (e.g. Pixel 8 API 37).
  • App: dev build → to.bitkit.dev.
  • Target SDK 36 → skip am compat enable (limits already on).

Shorten the dataSync FGS timeout (emulator only). On API 35+, LightningNodeService runs as a dataSync foreground service. In production the system allows about 6 hours per 24h, then calls onTimeout. Waiting that long is impractical for QA, so Android exposes a device config override to set how long the service may run in the background before timeout — here 30 seconds (30000 ms). That makes the repro repeatable: start node → Home → wait ~35s → FGS (dataSync) timed out. The setting applies to the emulator until changed or wiped; it does not ship with the app. See FGS timeout testing.

adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
adb shell device_config get activity_manager data_sync_fgs_timeout_duration

Step 1 — Repro on v2.2.0 (expect crash) ✅

Checkout

git checkout v2.2.0

Local-only patch (LightningNodeService.kt)

Do not commit. Simulates slow teardown on the broken code path.

Add import:

importkotlinx.coroutines.delay

Replace onTimeout body (v2.2.0 — stopSelf() after async stop):

 override fun onTimeout(startId: Int, fgsType: Int) {
Logger.warn("Foreground service timeout reached", context = TAG)
serviceScope.launch {
lightningRepo.stop()
+ delay(15_000)
stopSelf()
}
super.onTimeout(startId, fgsType)
}

Build & run

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Test

  1. Wallet onboarded, notifications allowed → node notification visible.
  2. Press Home (app in background).
  3. Wait ~35 s (30s FGS limit + margin).

Expected logcat

adb logcat -v time ActivityManager:E AndroidRuntime:E APP:W | grep -E "FGS|DidNotStop|timeout|FATAL|died"

Observed on v2.2.0 + patch (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
E ActivityManager: FGS Crashed: ... LightningNodeService ... # ~10s after timeout
I ActivityManager: Process to.bitkit.dev (pid ...) has died: prcp FGS

Optional full exception:

adb logcat -d | grep -E "DidNotStop|did not stop within its timeout|RemoteServiceException"

Discard patch

git checkout -- app/src/main/java/to/bitkit/androidServices/LightningNodeService.kt

Step 2 — Verify fix branch (expect no crash) ✅

git switch fix/fg-service-crash-980

Symmetric stress patch applied locally (see below) — FGS tears down first; slow LDK stop must not crash.

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Same test as Step 1.

Expected:FGS (dataSync) timed out then Stop FGS timeout within ~seconds, noFGS Crashed, noProcess … has died: prcp FGS. The node FGS stops by design (notification gone); app process may stay in background — that is not a crash.

Observed on fix branch + symmetric stress (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
D ActivityManager: Stop FGS timeout: ... LightningNodeService ...

(no FGS Crashed line)

Optional — symmetric stress on fix (still no crash)

Same delay import; in fix branch onTimeout:

 stopForegroundService(startId)
- serviceScope.launch { lightningRepo.stop() }+ serviceScope.launch {+ delay(15_000)+ lightningRepo.stop()+ }

FGS is already down before the delay → should not crash.

@piotr-iohkpiotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. see #987 (comment)

@ovitrifovitrif self-assigned this Jun 3, 2026
@ovitrif

ovitrif commented Jun 3, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Step 1 — Repro on v2.2.0 (expect crash) ✅
Step 2 — Verify fix branch (expect no crash) ✅

Incorporated into the PR QA Notes. No code changes were needed.

@ovitrif
ovitrif enabled auto-merge June 3, 2026 17:22
@ovitrif
ovitrif merged commit 4290a7c into masterJun 3, 2026
40 of 45 checks passed
@ovitrif
ovitrif deleted the fix/fg-service-crash-980 branch June 3, 2026 17:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@ovitrif@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix: prevent sticky node crash - #987

Merged
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980
Jun 3, 2026
Merged

fix: prevent sticky node crash#987
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980

Conversation

@ovitrif

@ovitrifovitrif commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes#980
Fixes#981
Refs #986

Description

This PR:

  1. Guards LightningNodeService startup so Android does not promote the service from sticky/null restarts.
  2. Promotes the service with the explicit dataSync foreground-service type.
  3. Stops the foreground service immediately on Android timeout or notification stop before running async node cleanup.
  4. Adds regression coverage for foreground-service startup, restart, promotion-failure, stop, and timeout behavior.

Preview

N/A - service lifecycle crash fix, no UI changes.

QA Notes

Repro / Fix Evidence

  • Emulator/device setup: API 35+ with dev app to.bitkit.dev, target SDK 36, and shortened dataSync timeout:
    adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
    adb shell device_config get activity_manager data_sync_fgs_timeout_duration
  • Pre-fix repro: checkout v2.2.0, install dev build, apply a local-only stress patch that delays stopSelf() in LightningNodeService.onTimeout() after lightningRepo.stop(), start the app, press Home, and wait about 35s.
  • Pre-fix crash evidence: .ai/issue_980_prefix/logcat.txt line 1187 shows ForegroundServiceDidNotStopInTimeException after FGS (dataSync) timed out.
  • Post-fix verification: checkout this branch, install dev build, use the same 30s timeout, background the app with the node service running, and wait about 35s.
  • Post-fix clean timeout evidence: .ai/issue_980_postfix/logcat.txt line 2044 shows FGS (dataSync) timed out, followed by service timeout handling and onDestroy, with no FGS Crashed, no RemoteServiceException, and no process death.
  • Optional symmetric stress on the fix: delay async lightningRepo.stop() after stopForegroundService(startId) in onTimeout; the FGS is already stopped before the delay, so the process still does not crash.
  • Reset timeout override after QA:
    adb shell device_config delete activity_manager data_sync_fgs_timeout_duration

Manual Tests

  • 1.regression: Android 15+ or 16+ device → enable shortened dataSync FGS timeout → background Bitkit with node service running: service stops cleanly without ForegroundServiceDidNotStopInTimeException.
  • 2.regression: Bitkit with notifications enabled → start background node service → force sticky/null restart condition: service does not promote from onCreate() and does not crash with ForegroundServiceStartNotAllowedException.
  • 3.regression: Node notification → tap Stop: foreground service notification is removed and app/service stops cleanly.

Automated Checks

  • Unit tests added/updated: app/src/test/java/to/bitkit/androidServices/LightningNodeServiceTest.kt covers explicit start action, typed dataSync foreground promotion, null/unsupported restart intents, promotion failure, duplicate starts, stop action ordering, and API-35 timeout ordering.
  • Local checks passed:
    • ./gradlew testDevDebugUnitTest --tests to.bitkit.androidServices.LightningNodeServiceTest
    • just compile
    • just test
    • just lint
  • just lint exited successfully; it printed existing unrelated detekt findings in AppViewModel.kt and SupportScreen.kt.

@ovitrif
ovitrif requested a review from piotr-iohkJune 3, 2026 14:57
@ovitrifovitrif added this to the 2.3.0 milestone Jun 3, 2026
@ovitrif
ovitrif requested a review from jvsena42June 3, 2026 16:11
@piotr-iohk

Copy link
Copy Markdown
Collaborator

Emulator setup (once per session)

  • API 35+ (e.g. Pixel 8 API 37).
  • App: dev build → to.bitkit.dev.
  • Target SDK 36 → skip am compat enable (limits already on).

Shorten the dataSync FGS timeout (emulator only). On API 35+, LightningNodeService runs as a dataSync foreground service. In production the system allows about 6 hours per 24h, then calls onTimeout. Waiting that long is impractical for QA, so Android exposes a device config override to set how long the service may run in the background before timeout — here 30 seconds (30000 ms). That makes the repro repeatable: start node → Home → wait ~35s → FGS (dataSync) timed out. The setting applies to the emulator until changed or wiped; it does not ship with the app. See FGS timeout testing.

adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
adb shell device_config get activity_manager data_sync_fgs_timeout_duration

Step 1 — Repro on v2.2.0 (expect crash) ✅

Checkout

git checkout v2.2.0

Local-only patch (LightningNodeService.kt)

Do not commit. Simulates slow teardown on the broken code path.

Add import:

importkotlinx.coroutines.delay

Replace onTimeout body (v2.2.0 — stopSelf() after async stop):

 override fun onTimeout(startId: Int, fgsType: Int) {
Logger.warn("Foreground service timeout reached", context = TAG)
serviceScope.launch {
lightningRepo.stop()
+ delay(15_000)
stopSelf()
}
super.onTimeout(startId, fgsType)
}

Build & run

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Test

  1. Wallet onboarded, notifications allowed → node notification visible.
  2. Press Home (app in background).
  3. Wait ~35 s (30s FGS limit + margin).

Expected logcat

adb logcat -v time ActivityManager:E AndroidRuntime:E APP:W | grep -E "FGS|DidNotStop|timeout|FATAL|died"

Observed on v2.2.0 + patch (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
E ActivityManager: FGS Crashed: ... LightningNodeService ... # ~10s after timeout
I ActivityManager: Process to.bitkit.dev (pid ...) has died: prcp FGS

Optional full exception:

adb logcat -d | grep -E "DidNotStop|did not stop within its timeout|RemoteServiceException"

Discard patch

git checkout -- app/src/main/java/to/bitkit/androidServices/LightningNodeService.kt

Step 2 — Verify fix branch (expect no crash) ✅

git switch fix/fg-service-crash-980

Symmetric stress patch applied locally (see below) — FGS tears down first; slow LDK stop must not crash.

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Same test as Step 1.

Expected:FGS (dataSync) timed out then Stop FGS timeout within ~seconds, noFGS Crashed, noProcess … has died: prcp FGS. The node FGS stops by design (notification gone); app process may stay in background — that is not a crash.

Observed on fix branch + symmetric stress (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
D ActivityManager: Stop FGS timeout: ... LightningNodeService ...

(no FGS Crashed line)

Optional — symmetric stress on fix (still no crash)

Same delay import; in fix branch onTimeout:

 stopForegroundService(startId)
- serviceScope.launch { lightningRepo.stop() }+ serviceScope.launch {+ delay(15_000)+ lightningRepo.stop()+ }

FGS is already down before the delay → should not crash.

@piotr-iohkpiotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. see #987 (comment)

@ovitrifovitrif self-assigned this Jun 3, 2026
@ovitrif

ovitrif commented Jun 3, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Step 1 — Repro on v2.2.0 (expect crash) ✅
Step 2 — Verify fix branch (expect no crash) ✅

Incorporated into the PR QA Notes. No code changes were needed.

@ovitrif
ovitrif enabled auto-merge June 3, 2026 17:22
@ovitrif
ovitrif merged commit 4290a7c into masterJun 3, 2026
40 of 45 checks passed
@ovitrif
ovitrif deleted the fix/fg-service-crash-980 branch June 3, 2026 17:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@ovitrif@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: prevent sticky node crash - #987

Merged
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980
Jun 3, 2026
Merged

fix: prevent sticky node crash#987
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980

Conversation

@ovitrif

@ovitrifovitrif commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes#980
Fixes#981
Refs #986

Description

This PR:

  1. Guards LightningNodeService startup so Android does not promote the service from sticky/null restarts.
  2. Promotes the service with the explicit dataSync foreground-service type.
  3. Stops the foreground service immediately on Android timeout or notification stop before running async node cleanup.
  4. Adds regression coverage for foreground-service startup, restart, promotion-failure, stop, and timeout behavior.

Preview

N/A - service lifecycle crash fix, no UI changes.

QA Notes

Repro / Fix Evidence

  • Emulator/device setup: API 35+ with dev app to.bitkit.dev, target SDK 36, and shortened dataSync timeout:
    adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
    adb shell device_config get activity_manager data_sync_fgs_timeout_duration
  • Pre-fix repro: checkout v2.2.0, install dev build, apply a local-only stress patch that delays stopSelf() in LightningNodeService.onTimeout() after lightningRepo.stop(), start the app, press Home, and wait about 35s.
  • Pre-fix crash evidence: .ai/issue_980_prefix/logcat.txt line 1187 shows ForegroundServiceDidNotStopInTimeException after FGS (dataSync) timed out.
  • Post-fix verification: checkout this branch, install dev build, use the same 30s timeout, background the app with the node service running, and wait about 35s.
  • Post-fix clean timeout evidence: .ai/issue_980_postfix/logcat.txt line 2044 shows FGS (dataSync) timed out, followed by service timeout handling and onDestroy, with no FGS Crashed, no RemoteServiceException, and no process death.
  • Optional symmetric stress on the fix: delay async lightningRepo.stop() after stopForegroundService(startId) in onTimeout; the FGS is already stopped before the delay, so the process still does not crash.
  • Reset timeout override after QA:
    adb shell device_config delete activity_manager data_sync_fgs_timeout_duration

Manual Tests

  • 1.regression: Android 15+ or 16+ device → enable shortened dataSync FGS timeout → background Bitkit with node service running: service stops cleanly without ForegroundServiceDidNotStopInTimeException.
  • 2.regression: Bitkit with notifications enabled → start background node service → force sticky/null restart condition: service does not promote from onCreate() and does not crash with ForegroundServiceStartNotAllowedException.
  • 3.regression: Node notification → tap Stop: foreground service notification is removed and app/service stops cleanly.

Automated Checks

  • Unit tests added/updated: app/src/test/java/to/bitkit/androidServices/LightningNodeServiceTest.kt covers explicit start action, typed dataSync foreground promotion, null/unsupported restart intents, promotion failure, duplicate starts, stop action ordering, and API-35 timeout ordering.
  • Local checks passed:
    • ./gradlew testDevDebugUnitTest --tests to.bitkit.androidServices.LightningNodeServiceTest
    • just compile
    • just test
    • just lint
  • just lint exited successfully; it printed existing unrelated detekt findings in AppViewModel.kt and SupportScreen.kt.

@ovitrif
ovitrif requested a review from piotr-iohkJune 3, 2026 14:57
@ovitrifovitrif added this to the 2.3.0 milestone Jun 3, 2026
@ovitrif
ovitrif requested a review from jvsena42June 3, 2026 16:11
@piotr-iohk

Copy link
Copy Markdown
Collaborator

Emulator setup (once per session)

  • API 35+ (e.g. Pixel 8 API 37).
  • App: dev build → to.bitkit.dev.
  • Target SDK 36 → skip am compat enable (limits already on).

Shorten the dataSync FGS timeout (emulator only). On API 35+, LightningNodeService runs as a dataSync foreground service. In production the system allows about 6 hours per 24h, then calls onTimeout. Waiting that long is impractical for QA, so Android exposes a device config override to set how long the service may run in the background before timeout — here 30 seconds (30000 ms). That makes the repro repeatable: start node → Home → wait ~35s → FGS (dataSync) timed out. The setting applies to the emulator until changed or wiped; it does not ship with the app. See FGS timeout testing.

adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
adb shell device_config get activity_manager data_sync_fgs_timeout_duration

Step 1 — Repro on v2.2.0 (expect crash) ✅

Checkout

git checkout v2.2.0

Local-only patch (LightningNodeService.kt)

Do not commit. Simulates slow teardown on the broken code path.

Add import:

importkotlinx.coroutines.delay

Replace onTimeout body (v2.2.0 — stopSelf() after async stop):

 override fun onTimeout(startId: Int, fgsType: Int) {
Logger.warn("Foreground service timeout reached", context = TAG)
serviceScope.launch {
lightningRepo.stop()
+ delay(15_000)
stopSelf()
}
super.onTimeout(startId, fgsType)
}

Build & run

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Test

  1. Wallet onboarded, notifications allowed → node notification visible.
  2. Press Home (app in background).
  3. Wait ~35 s (30s FGS limit + margin).

Expected logcat

adb logcat -v time ActivityManager:E AndroidRuntime:E APP:W | grep -E "FGS|DidNotStop|timeout|FATAL|died"

Observed on v2.2.0 + patch (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
E ActivityManager: FGS Crashed: ... LightningNodeService ... # ~10s after timeout
I ActivityManager: Process to.bitkit.dev (pid ...) has died: prcp FGS

Optional full exception:

adb logcat -d | grep -E "DidNotStop|did not stop within its timeout|RemoteServiceException"

Discard patch

git checkout -- app/src/main/java/to/bitkit/androidServices/LightningNodeService.kt

Step 2 — Verify fix branch (expect no crash) ✅

git switch fix/fg-service-crash-980

Symmetric stress patch applied locally (see below) — FGS tears down first; slow LDK stop must not crash.

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Same test as Step 1.

Expected:FGS (dataSync) timed out then Stop FGS timeout within ~seconds, noFGS Crashed, noProcess … has died: prcp FGS. The node FGS stops by design (notification gone); app process may stay in background — that is not a crash.

Observed on fix branch + symmetric stress (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
D ActivityManager: Stop FGS timeout: ... LightningNodeService ...

(no FGS Crashed line)

Optional — symmetric stress on fix (still no crash)

Same delay import; in fix branch onTimeout:

 stopForegroundService(startId)
- serviceScope.launch { lightningRepo.stop() }+ serviceScope.launch {+ delay(15_000)+ lightningRepo.stop()+ }

FGS is already down before the delay → should not crash.

@piotr-iohkpiotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. see #987 (comment)

@ovitrifovitrif self-assigned this Jun 3, 2026
@ovitrif

ovitrif commented Jun 3, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Step 1 — Repro on v2.2.0 (expect crash) ✅
Step 2 — Verify fix branch (expect no crash) ✅

Incorporated into the PR QA Notes. No code changes were needed.

@ovitrif
ovitrif enabled auto-merge June 3, 2026 17:22
@ovitrif
ovitrif merged commit 4290a7c into masterJun 3, 2026
40 of 45 checks passed
@ovitrif
ovitrif deleted the fix/fg-service-crash-980 branch June 3, 2026 17:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@ovitrif@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: prevent sticky node crash - #987

Merged
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980
Jun 3, 2026
Merged

fix: prevent sticky node crash#987
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980

Conversation

@ovitrif

@ovitrifovitrif commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes#980
Fixes#981
Refs #986

Description

This PR:

  1. Guards LightningNodeService startup so Android does not promote the service from sticky/null restarts.
  2. Promotes the service with the explicit dataSync foreground-service type.
  3. Stops the foreground service immediately on Android timeout or notification stop before running async node cleanup.
  4. Adds regression coverage for foreground-service startup, restart, promotion-failure, stop, and timeout behavior.

Preview

N/A - service lifecycle crash fix, no UI changes.

QA Notes

Repro / Fix Evidence

  • Emulator/device setup: API 35+ with dev app to.bitkit.dev, target SDK 36, and shortened dataSync timeout:
    adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
    adb shell device_config get activity_manager data_sync_fgs_timeout_duration
  • Pre-fix repro: checkout v2.2.0, install dev build, apply a local-only stress patch that delays stopSelf() in LightningNodeService.onTimeout() after lightningRepo.stop(), start the app, press Home, and wait about 35s.
  • Pre-fix crash evidence: .ai/issue_980_prefix/logcat.txt line 1187 shows ForegroundServiceDidNotStopInTimeException after FGS (dataSync) timed out.
  • Post-fix verification: checkout this branch, install dev build, use the same 30s timeout, background the app with the node service running, and wait about 35s.
  • Post-fix clean timeout evidence: .ai/issue_980_postfix/logcat.txt line 2044 shows FGS (dataSync) timed out, followed by service timeout handling and onDestroy, with no FGS Crashed, no RemoteServiceException, and no process death.
  • Optional symmetric stress on the fix: delay async lightningRepo.stop() after stopForegroundService(startId) in onTimeout; the FGS is already stopped before the delay, so the process still does not crash.
  • Reset timeout override after QA:
    adb shell device_config delete activity_manager data_sync_fgs_timeout_duration

Manual Tests

  • 1.regression: Android 15+ or 16+ device → enable shortened dataSync FGS timeout → background Bitkit with node service running: service stops cleanly without ForegroundServiceDidNotStopInTimeException.
  • 2.regression: Bitkit with notifications enabled → start background node service → force sticky/null restart condition: service does not promote from onCreate() and does not crash with ForegroundServiceStartNotAllowedException.
  • 3.regression: Node notification → tap Stop: foreground service notification is removed and app/service stops cleanly.

Automated Checks

  • Unit tests added/updated: app/src/test/java/to/bitkit/androidServices/LightningNodeServiceTest.kt covers explicit start action, typed dataSync foreground promotion, null/unsupported restart intents, promotion failure, duplicate starts, stop action ordering, and API-35 timeout ordering.
  • Local checks passed:
    • ./gradlew testDevDebugUnitTest --tests to.bitkit.androidServices.LightningNodeServiceTest
    • just compile
    • just test
    • just lint
  • just lint exited successfully; it printed existing unrelated detekt findings in AppViewModel.kt and SupportScreen.kt.

@ovitrif
ovitrif requested a review from piotr-iohkJune 3, 2026 14:57
@ovitrifovitrif added this to the 2.3.0 milestone Jun 3, 2026
@ovitrif
ovitrif requested a review from jvsena42June 3, 2026 16:11
@piotr-iohk

Copy link
Copy Markdown
Collaborator

Emulator setup (once per session)

  • API 35+ (e.g. Pixel 8 API 37).
  • App: dev build → to.bitkit.dev.
  • Target SDK 36 → skip am compat enable (limits already on).

Shorten the dataSync FGS timeout (emulator only). On API 35+, LightningNodeService runs as a dataSync foreground service. In production the system allows about 6 hours per 24h, then calls onTimeout. Waiting that long is impractical for QA, so Android exposes a device config override to set how long the service may run in the background before timeout — here 30 seconds (30000 ms). That makes the repro repeatable: start node → Home → wait ~35s → FGS (dataSync) timed out. The setting applies to the emulator until changed or wiped; it does not ship with the app. See FGS timeout testing.

adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
adb shell device_config get activity_manager data_sync_fgs_timeout_duration

Step 1 — Repro on v2.2.0 (expect crash) ✅

Checkout

git checkout v2.2.0

Local-only patch (LightningNodeService.kt)

Do not commit. Simulates slow teardown on the broken code path.

Add import:

importkotlinx.coroutines.delay

Replace onTimeout body (v2.2.0 — stopSelf() after async stop):

 override fun onTimeout(startId: Int, fgsType: Int) {
Logger.warn("Foreground service timeout reached", context = TAG)
serviceScope.launch {
lightningRepo.stop()
+ delay(15_000)
stopSelf()
}
super.onTimeout(startId, fgsType)
}

Build & run

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Test

  1. Wallet onboarded, notifications allowed → node notification visible.
  2. Press Home (app in background).
  3. Wait ~35 s (30s FGS limit + margin).

Expected logcat

adb logcat -v time ActivityManager:E AndroidRuntime:E APP:W | grep -E "FGS|DidNotStop|timeout|FATAL|died"

Observed on v2.2.0 + patch (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
E ActivityManager: FGS Crashed: ... LightningNodeService ... # ~10s after timeout
I ActivityManager: Process to.bitkit.dev (pid ...) has died: prcp FGS

Optional full exception:

adb logcat -d | grep -E "DidNotStop|did not stop within its timeout|RemoteServiceException"

Discard patch

git checkout -- app/src/main/java/to/bitkit/androidServices/LightningNodeService.kt

Step 2 — Verify fix branch (expect no crash) ✅

git switch fix/fg-service-crash-980

Symmetric stress patch applied locally (see below) — FGS tears down first; slow LDK stop must not crash.

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Same test as Step 1.

Expected:FGS (dataSync) timed out then Stop FGS timeout within ~seconds, noFGS Crashed, noProcess … has died: prcp FGS. The node FGS stops by design (notification gone); app process may stay in background — that is not a crash.

Observed on fix branch + symmetric stress (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
D ActivityManager: Stop FGS timeout: ... LightningNodeService ...

(no FGS Crashed line)

Optional — symmetric stress on fix (still no crash)

Same delay import; in fix branch onTimeout:

 stopForegroundService(startId)
- serviceScope.launch { lightningRepo.stop() }+ serviceScope.launch {+ delay(15_000)+ lightningRepo.stop()+ }

FGS is already down before the delay → should not crash.

@piotr-iohkpiotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. see #987 (comment)

@ovitrifovitrif self-assigned this Jun 3, 2026
@ovitrif

ovitrif commented Jun 3, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Step 1 — Repro on v2.2.0 (expect crash) ✅
Step 2 — Verify fix branch (expect no crash) ✅

Incorporated into the PR QA Notes. No code changes were needed.

@ovitrif
ovitrif enabled auto-merge June 3, 2026 17:22
@ovitrif
ovitrif merged commit 4290a7c into masterJun 3, 2026
40 of 45 checks passed
@ovitrif
ovitrif deleted the fix/fg-service-crash-980 branch June 3, 2026 17:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@ovitrif@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix: prevent sticky node crash - #987

Merged
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980
Jun 3, 2026
Merged

fix: prevent sticky node crash#987
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980

Conversation

@ovitrif

@ovitrifovitrif commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes#980
Fixes#981
Refs #986

Description

This PR:

  1. Guards LightningNodeService startup so Android does not promote the service from sticky/null restarts.
  2. Promotes the service with the explicit dataSync foreground-service type.
  3. Stops the foreground service immediately on Android timeout or notification stop before running async node cleanup.
  4. Adds regression coverage for foreground-service startup, restart, promotion-failure, stop, and timeout behavior.

Preview

N/A - service lifecycle crash fix, no UI changes.

QA Notes

Repro / Fix Evidence

  • Emulator/device setup: API 35+ with dev app to.bitkit.dev, target SDK 36, and shortened dataSync timeout:
    adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
    adb shell device_config get activity_manager data_sync_fgs_timeout_duration
  • Pre-fix repro: checkout v2.2.0, install dev build, apply a local-only stress patch that delays stopSelf() in LightningNodeService.onTimeout() after lightningRepo.stop(), start the app, press Home, and wait about 35s.
  • Pre-fix crash evidence: .ai/issue_980_prefix/logcat.txt line 1187 shows ForegroundServiceDidNotStopInTimeException after FGS (dataSync) timed out.
  • Post-fix verification: checkout this branch, install dev build, use the same 30s timeout, background the app with the node service running, and wait about 35s.
  • Post-fix clean timeout evidence: .ai/issue_980_postfix/logcat.txt line 2044 shows FGS (dataSync) timed out, followed by service timeout handling and onDestroy, with no FGS Crashed, no RemoteServiceException, and no process death.
  • Optional symmetric stress on the fix: delay async lightningRepo.stop() after stopForegroundService(startId) in onTimeout; the FGS is already stopped before the delay, so the process still does not crash.
  • Reset timeout override after QA:
    adb shell device_config delete activity_manager data_sync_fgs_timeout_duration

Manual Tests

  • 1.regression: Android 15+ or 16+ device → enable shortened dataSync FGS timeout → background Bitkit with node service running: service stops cleanly without ForegroundServiceDidNotStopInTimeException.
  • 2.regression: Bitkit with notifications enabled → start background node service → force sticky/null restart condition: service does not promote from onCreate() and does not crash with ForegroundServiceStartNotAllowedException.
  • 3.regression: Node notification → tap Stop: foreground service notification is removed and app/service stops cleanly.

Automated Checks

  • Unit tests added/updated: app/src/test/java/to/bitkit/androidServices/LightningNodeServiceTest.kt covers explicit start action, typed dataSync foreground promotion, null/unsupported restart intents, promotion failure, duplicate starts, stop action ordering, and API-35 timeout ordering.
  • Local checks passed:
    • ./gradlew testDevDebugUnitTest --tests to.bitkit.androidServices.LightningNodeServiceTest
    • just compile
    • just test
    • just lint
  • just lint exited successfully; it printed existing unrelated detekt findings in AppViewModel.kt and SupportScreen.kt.

@ovitrif
ovitrif requested a review from piotr-iohkJune 3, 2026 14:57
@ovitrifovitrif added this to the 2.3.0 milestone Jun 3, 2026
@ovitrif
ovitrif requested a review from jvsena42June 3, 2026 16:11
@piotr-iohk

Copy link
Copy Markdown
Collaborator

Emulator setup (once per session)

  • API 35+ (e.g. Pixel 8 API 37).
  • App: dev build → to.bitkit.dev.
  • Target SDK 36 → skip am compat enable (limits already on).

Shorten the dataSync FGS timeout (emulator only). On API 35+, LightningNodeService runs as a dataSync foreground service. In production the system allows about 6 hours per 24h, then calls onTimeout. Waiting that long is impractical for QA, so Android exposes a device config override to set how long the service may run in the background before timeout — here 30 seconds (30000 ms). That makes the repro repeatable: start node → Home → wait ~35s → FGS (dataSync) timed out. The setting applies to the emulator until changed or wiped; it does not ship with the app. See FGS timeout testing.

adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
adb shell device_config get activity_manager data_sync_fgs_timeout_duration

Step 1 — Repro on v2.2.0 (expect crash) ✅

Checkout

git checkout v2.2.0

Local-only patch (LightningNodeService.kt)

Do not commit. Simulates slow teardown on the broken code path.

Add import:

importkotlinx.coroutines.delay

Replace onTimeout body (v2.2.0 — stopSelf() after async stop):

 override fun onTimeout(startId: Int, fgsType: Int) {
Logger.warn("Foreground service timeout reached", context = TAG)
serviceScope.launch {
lightningRepo.stop()
+ delay(15_000)
stopSelf()
}
super.onTimeout(startId, fgsType)
}

Build & run

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Test

  1. Wallet onboarded, notifications allowed → node notification visible.
  2. Press Home (app in background).
  3. Wait ~35 s (30s FGS limit + margin).

Expected logcat

adb logcat -v time ActivityManager:E AndroidRuntime:E APP:W | grep -E "FGS|DidNotStop|timeout|FATAL|died"

Observed on v2.2.0 + patch (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
E ActivityManager: FGS Crashed: ... LightningNodeService ... # ~10s after timeout
I ActivityManager: Process to.bitkit.dev (pid ...) has died: prcp FGS

Optional full exception:

adb logcat -d | grep -E "DidNotStop|did not stop within its timeout|RemoteServiceException"

Discard patch

git checkout -- app/src/main/java/to/bitkit/androidServices/LightningNodeService.kt

Step 2 — Verify fix branch (expect no crash) ✅

git switch fix/fg-service-crash-980

Symmetric stress patch applied locally (see below) — FGS tears down first; slow LDK stop must not crash.

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Same test as Step 1.

Expected:FGS (dataSync) timed out then Stop FGS timeout within ~seconds, noFGS Crashed, noProcess … has died: prcp FGS. The node FGS stops by design (notification gone); app process may stay in background — that is not a crash.

Observed on fix branch + symmetric stress (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
D ActivityManager: Stop FGS timeout: ... LightningNodeService ...

(no FGS Crashed line)

Optional — symmetric stress on fix (still no crash)

Same delay import; in fix branch onTimeout:

 stopForegroundService(startId)
- serviceScope.launch { lightningRepo.stop() }+ serviceScope.launch {+ delay(15_000)+ lightningRepo.stop()+ }

FGS is already down before the delay → should not crash.

@piotr-iohkpiotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. see #987 (comment)

@ovitrifovitrif self-assigned this Jun 3, 2026
@ovitrif

ovitrif commented Jun 3, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Step 1 — Repro on v2.2.0 (expect crash) ✅
Step 2 — Verify fix branch (expect no crash) ✅

Incorporated into the PR QA Notes. No code changes were needed.

@ovitrif
ovitrif enabled auto-merge June 3, 2026 17:22
@ovitrif
ovitrif merged commit 4290a7c into masterJun 3, 2026
40 of 45 checks passed
@ovitrif
ovitrif deleted the fix/fg-service-crash-980 branch June 3, 2026 17:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@ovitrif@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: prevent sticky node crash - #987

Merged
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980
Jun 3, 2026
Merged

fix: prevent sticky node crash#987
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980

Conversation

@ovitrif

@ovitrifovitrif commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes#980
Fixes#981
Refs #986

Description

This PR:

  1. Guards LightningNodeService startup so Android does not promote the service from sticky/null restarts.
  2. Promotes the service with the explicit dataSync foreground-service type.
  3. Stops the foreground service immediately on Android timeout or notification stop before running async node cleanup.
  4. Adds regression coverage for foreground-service startup, restart, promotion-failure, stop, and timeout behavior.

Preview

N/A - service lifecycle crash fix, no UI changes.

QA Notes

Repro / Fix Evidence

  • Emulator/device setup: API 35+ with dev app to.bitkit.dev, target SDK 36, and shortened dataSync timeout:
    adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
    adb shell device_config get activity_manager data_sync_fgs_timeout_duration
  • Pre-fix repro: checkout v2.2.0, install dev build, apply a local-only stress patch that delays stopSelf() in LightningNodeService.onTimeout() after lightningRepo.stop(), start the app, press Home, and wait about 35s.
  • Pre-fix crash evidence: .ai/issue_980_prefix/logcat.txt line 1187 shows ForegroundServiceDidNotStopInTimeException after FGS (dataSync) timed out.
  • Post-fix verification: checkout this branch, install dev build, use the same 30s timeout, background the app with the node service running, and wait about 35s.
  • Post-fix clean timeout evidence: .ai/issue_980_postfix/logcat.txt line 2044 shows FGS (dataSync) timed out, followed by service timeout handling and onDestroy, with no FGS Crashed, no RemoteServiceException, and no process death.
  • Optional symmetric stress on the fix: delay async lightningRepo.stop() after stopForegroundService(startId) in onTimeout; the FGS is already stopped before the delay, so the process still does not crash.
  • Reset timeout override after QA:
    adb shell device_config delete activity_manager data_sync_fgs_timeout_duration

Manual Tests

  • 1.regression: Android 15+ or 16+ device → enable shortened dataSync FGS timeout → background Bitkit with node service running: service stops cleanly without ForegroundServiceDidNotStopInTimeException.
  • 2.regression: Bitkit with notifications enabled → start background node service → force sticky/null restart condition: service does not promote from onCreate() and does not crash with ForegroundServiceStartNotAllowedException.
  • 3.regression: Node notification → tap Stop: foreground service notification is removed and app/service stops cleanly.

Automated Checks

  • Unit tests added/updated: app/src/test/java/to/bitkit/androidServices/LightningNodeServiceTest.kt covers explicit start action, typed dataSync foreground promotion, null/unsupported restart intents, promotion failure, duplicate starts, stop action ordering, and API-35 timeout ordering.
  • Local checks passed:
    • ./gradlew testDevDebugUnitTest --tests to.bitkit.androidServices.LightningNodeServiceTest
    • just compile
    • just test
    • just lint
  • just lint exited successfully; it printed existing unrelated detekt findings in AppViewModel.kt and SupportScreen.kt.

@ovitrif
ovitrif requested a review from piotr-iohkJune 3, 2026 14:57
@ovitrifovitrif added this to the 2.3.0 milestone Jun 3, 2026
@ovitrif
ovitrif requested a review from jvsena42June 3, 2026 16:11
@piotr-iohk

Copy link
Copy Markdown
Collaborator

Emulator setup (once per session)

  • API 35+ (e.g. Pixel 8 API 37).
  • App: dev build → to.bitkit.dev.
  • Target SDK 36 → skip am compat enable (limits already on).

Shorten the dataSync FGS timeout (emulator only). On API 35+, LightningNodeService runs as a dataSync foreground service. In production the system allows about 6 hours per 24h, then calls onTimeout. Waiting that long is impractical for QA, so Android exposes a device config override to set how long the service may run in the background before timeout — here 30 seconds (30000 ms). That makes the repro repeatable: start node → Home → wait ~35s → FGS (dataSync) timed out. The setting applies to the emulator until changed or wiped; it does not ship with the app. See FGS timeout testing.

adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
adb shell device_config get activity_manager data_sync_fgs_timeout_duration

Step 1 — Repro on v2.2.0 (expect crash) ✅

Checkout

git checkout v2.2.0

Local-only patch (LightningNodeService.kt)

Do not commit. Simulates slow teardown on the broken code path.

Add import:

importkotlinx.coroutines.delay

Replace onTimeout body (v2.2.0 — stopSelf() after async stop):

 override fun onTimeout(startId: Int, fgsType: Int) {
Logger.warn("Foreground service timeout reached", context = TAG)
serviceScope.launch {
lightningRepo.stop()
+ delay(15_000)
stopSelf()
}
super.onTimeout(startId, fgsType)
}

Build & run

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Test

  1. Wallet onboarded, notifications allowed → node notification visible.
  2. Press Home (app in background).
  3. Wait ~35 s (30s FGS limit + margin).

Expected logcat

adb logcat -v time ActivityManager:E AndroidRuntime:E APP:W | grep -E "FGS|DidNotStop|timeout|FATAL|died"

Observed on v2.2.0 + patch (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
E ActivityManager: FGS Crashed: ... LightningNodeService ... # ~10s after timeout
I ActivityManager: Process to.bitkit.dev (pid ...) has died: prcp FGS

Optional full exception:

adb logcat -d | grep -E "DidNotStop|did not stop within its timeout|RemoteServiceException"

Discard patch

git checkout -- app/src/main/java/to/bitkit/androidServices/LightningNodeService.kt

Step 2 — Verify fix branch (expect no crash) ✅

git switch fix/fg-service-crash-980

Symmetric stress patch applied locally (see below) — FGS tears down first; slow LDK stop must not crash.

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Same test as Step 1.

Expected:FGS (dataSync) timed out then Stop FGS timeout within ~seconds, noFGS Crashed, noProcess … has died: prcp FGS. The node FGS stops by design (notification gone); app process may stay in background — that is not a crash.

Observed on fix branch + symmetric stress (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
D ActivityManager: Stop FGS timeout: ... LightningNodeService ...

(no FGS Crashed line)

Optional — symmetric stress on fix (still no crash)

Same delay import; in fix branch onTimeout:

 stopForegroundService(startId)
- serviceScope.launch { lightningRepo.stop() }+ serviceScope.launch {+ delay(15_000)+ lightningRepo.stop()+ }

FGS is already down before the delay → should not crash.

@piotr-iohkpiotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. see #987 (comment)

@ovitrifovitrif self-assigned this Jun 3, 2026
@ovitrif

ovitrif commented Jun 3, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Step 1 — Repro on v2.2.0 (expect crash) ✅
Step 2 — Verify fix branch (expect no crash) ✅

Incorporated into the PR QA Notes. No code changes were needed.

@ovitrif
ovitrif enabled auto-merge June 3, 2026 17:22
@ovitrif
ovitrif merged commit 4290a7c into masterJun 3, 2026
40 of 45 checks passed
@ovitrif
ovitrif deleted the fix/fg-service-crash-980 branch June 3, 2026 17:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@ovitrif@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: prevent sticky node crash - #987

Merged
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980
Jun 3, 2026
Merged

fix: prevent sticky node crash#987
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980

Conversation

@ovitrif

@ovitrifovitrif commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes#980
Fixes#981
Refs #986

Description

This PR:

  1. Guards LightningNodeService startup so Android does not promote the service from sticky/null restarts.
  2. Promotes the service with the explicit dataSync foreground-service type.
  3. Stops the foreground service immediately on Android timeout or notification stop before running async node cleanup.
  4. Adds regression coverage for foreground-service startup, restart, promotion-failure, stop, and timeout behavior.

Preview

N/A - service lifecycle crash fix, no UI changes.

QA Notes

Repro / Fix Evidence

  • Emulator/device setup: API 35+ with dev app to.bitkit.dev, target SDK 36, and shortened dataSync timeout:
    adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
    adb shell device_config get activity_manager data_sync_fgs_timeout_duration
  • Pre-fix repro: checkout v2.2.0, install dev build, apply a local-only stress patch that delays stopSelf() in LightningNodeService.onTimeout() after lightningRepo.stop(), start the app, press Home, and wait about 35s.
  • Pre-fix crash evidence: .ai/issue_980_prefix/logcat.txt line 1187 shows ForegroundServiceDidNotStopInTimeException after FGS (dataSync) timed out.
  • Post-fix verification: checkout this branch, install dev build, use the same 30s timeout, background the app with the node service running, and wait about 35s.
  • Post-fix clean timeout evidence: .ai/issue_980_postfix/logcat.txt line 2044 shows FGS (dataSync) timed out, followed by service timeout handling and onDestroy, with no FGS Crashed, no RemoteServiceException, and no process death.
  • Optional symmetric stress on the fix: delay async lightningRepo.stop() after stopForegroundService(startId) in onTimeout; the FGS is already stopped before the delay, so the process still does not crash.
  • Reset timeout override after QA:
    adb shell device_config delete activity_manager data_sync_fgs_timeout_duration

Manual Tests

  • 1.regression: Android 15+ or 16+ device → enable shortened dataSync FGS timeout → background Bitkit with node service running: service stops cleanly without ForegroundServiceDidNotStopInTimeException.
  • 2.regression: Bitkit with notifications enabled → start background node service → force sticky/null restart condition: service does not promote from onCreate() and does not crash with ForegroundServiceStartNotAllowedException.
  • 3.regression: Node notification → tap Stop: foreground service notification is removed and app/service stops cleanly.

Automated Checks

  • Unit tests added/updated: app/src/test/java/to/bitkit/androidServices/LightningNodeServiceTest.kt covers explicit start action, typed dataSync foreground promotion, null/unsupported restart intents, promotion failure, duplicate starts, stop action ordering, and API-35 timeout ordering.
  • Local checks passed:
    • ./gradlew testDevDebugUnitTest --tests to.bitkit.androidServices.LightningNodeServiceTest
    • just compile
    • just test
    • just lint
  • just lint exited successfully; it printed existing unrelated detekt findings in AppViewModel.kt and SupportScreen.kt.

@ovitrif
ovitrif requested a review from piotr-iohkJune 3, 2026 14:57
@ovitrifovitrif added this to the 2.3.0 milestone Jun 3, 2026
@ovitrif
ovitrif requested a review from jvsena42June 3, 2026 16:11
@piotr-iohk

Copy link
Copy Markdown
Collaborator

Emulator setup (once per session)

  • API 35+ (e.g. Pixel 8 API 37).
  • App: dev build → to.bitkit.dev.
  • Target SDK 36 → skip am compat enable (limits already on).

Shorten the dataSync FGS timeout (emulator only). On API 35+, LightningNodeService runs as a dataSync foreground service. In production the system allows about 6 hours per 24h, then calls onTimeout. Waiting that long is impractical for QA, so Android exposes a device config override to set how long the service may run in the background before timeout — here 30 seconds (30000 ms). That makes the repro repeatable: start node → Home → wait ~35s → FGS (dataSync) timed out. The setting applies to the emulator until changed or wiped; it does not ship with the app. See FGS timeout testing.

adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
adb shell device_config get activity_manager data_sync_fgs_timeout_duration

Step 1 — Repro on v2.2.0 (expect crash) ✅

Checkout

git checkout v2.2.0

Local-only patch (LightningNodeService.kt)

Do not commit. Simulates slow teardown on the broken code path.

Add import:

importkotlinx.coroutines.delay

Replace onTimeout body (v2.2.0 — stopSelf() after async stop):

 override fun onTimeout(startId: Int, fgsType: Int) {
Logger.warn("Foreground service timeout reached", context = TAG)
serviceScope.launch {
lightningRepo.stop()
+ delay(15_000)
stopSelf()
}
super.onTimeout(startId, fgsType)
}

Build & run

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Test

  1. Wallet onboarded, notifications allowed → node notification visible.
  2. Press Home (app in background).
  3. Wait ~35 s (30s FGS limit + margin).

Expected logcat

adb logcat -v time ActivityManager:E AndroidRuntime:E APP:W | grep -E "FGS|DidNotStop|timeout|FATAL|died"

Observed on v2.2.0 + patch (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
E ActivityManager: FGS Crashed: ... LightningNodeService ... # ~10s after timeout
I ActivityManager: Process to.bitkit.dev (pid ...) has died: prcp FGS

Optional full exception:

adb logcat -d | grep -E "DidNotStop|did not stop within its timeout|RemoteServiceException"

Discard patch

git checkout -- app/src/main/java/to/bitkit/androidServices/LightningNodeService.kt

Step 2 — Verify fix branch (expect no crash) ✅

git switch fix/fg-service-crash-980

Symmetric stress patch applied locally (see below) — FGS tears down first; slow LDK stop must not crash.

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Same test as Step 1.

Expected:FGS (dataSync) timed out then Stop FGS timeout within ~seconds, noFGS Crashed, noProcess … has died: prcp FGS. The node FGS stops by design (notification gone); app process may stay in background — that is not a crash.

Observed on fix branch + symmetric stress (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
D ActivityManager: Stop FGS timeout: ... LightningNodeService ...

(no FGS Crashed line)

Optional — symmetric stress on fix (still no crash)

Same delay import; in fix branch onTimeout:

 stopForegroundService(startId)
- serviceScope.launch { lightningRepo.stop() }+ serviceScope.launch {+ delay(15_000)+ lightningRepo.stop()+ }

FGS is already down before the delay → should not crash.

@piotr-iohkpiotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. see #987 (comment)

@ovitrifovitrif self-assigned this Jun 3, 2026
@ovitrif

ovitrif commented Jun 3, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Step 1 — Repro on v2.2.0 (expect crash) ✅
Step 2 — Verify fix branch (expect no crash) ✅

Incorporated into the PR QA Notes. No code changes were needed.

@ovitrif
ovitrif enabled auto-merge June 3, 2026 17:22
@ovitrif
ovitrif merged commit 4290a7c into masterJun 3, 2026
40 of 45 checks passed
@ovitrif
ovitrif deleted the fix/fg-service-crash-980 branch June 3, 2026 17:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@ovitrif@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix: prevent sticky node crash - #987

Merged
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980
Jun 3, 2026
Merged

fix: prevent sticky node crash#987
ovitrif merged 1 commit into
masterfrom
fix/fg-service-crash-980

Conversation

@ovitrif

@ovitrifovitrif commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes#980
Fixes#981
Refs #986

Description

This PR:

  1. Guards LightningNodeService startup so Android does not promote the service from sticky/null restarts.
  2. Promotes the service with the explicit dataSync foreground-service type.
  3. Stops the foreground service immediately on Android timeout or notification stop before running async node cleanup.
  4. Adds regression coverage for foreground-service startup, restart, promotion-failure, stop, and timeout behavior.

Preview

N/A - service lifecycle crash fix, no UI changes.

QA Notes

Repro / Fix Evidence

  • Emulator/device setup: API 35+ with dev app to.bitkit.dev, target SDK 36, and shortened dataSync timeout:
    adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
    adb shell device_config get activity_manager data_sync_fgs_timeout_duration
  • Pre-fix repro: checkout v2.2.0, install dev build, apply a local-only stress patch that delays stopSelf() in LightningNodeService.onTimeout() after lightningRepo.stop(), start the app, press Home, and wait about 35s.
  • Pre-fix crash evidence: .ai/issue_980_prefix/logcat.txt line 1187 shows ForegroundServiceDidNotStopInTimeException after FGS (dataSync) timed out.
  • Post-fix verification: checkout this branch, install dev build, use the same 30s timeout, background the app with the node service running, and wait about 35s.
  • Post-fix clean timeout evidence: .ai/issue_980_postfix/logcat.txt line 2044 shows FGS (dataSync) timed out, followed by service timeout handling and onDestroy, with no FGS Crashed, no RemoteServiceException, and no process death.
  • Optional symmetric stress on the fix: delay async lightningRepo.stop() after stopForegroundService(startId) in onTimeout; the FGS is already stopped before the delay, so the process still does not crash.
  • Reset timeout override after QA:
    adb shell device_config delete activity_manager data_sync_fgs_timeout_duration

Manual Tests

  • 1.regression: Android 15+ or 16+ device → enable shortened dataSync FGS timeout → background Bitkit with node service running: service stops cleanly without ForegroundServiceDidNotStopInTimeException.
  • 2.regression: Bitkit with notifications enabled → start background node service → force sticky/null restart condition: service does not promote from onCreate() and does not crash with ForegroundServiceStartNotAllowedException.
  • 3.regression: Node notification → tap Stop: foreground service notification is removed and app/service stops cleanly.

Automated Checks

  • Unit tests added/updated: app/src/test/java/to/bitkit/androidServices/LightningNodeServiceTest.kt covers explicit start action, typed dataSync foreground promotion, null/unsupported restart intents, promotion failure, duplicate starts, stop action ordering, and API-35 timeout ordering.
  • Local checks passed:
    • ./gradlew testDevDebugUnitTest --tests to.bitkit.androidServices.LightningNodeServiceTest
    • just compile
    • just test
    • just lint
  • just lint exited successfully; it printed existing unrelated detekt findings in AppViewModel.kt and SupportScreen.kt.

@ovitrif
ovitrif requested a review from piotr-iohkJune 3, 2026 14:57
@ovitrifovitrif added this to the 2.3.0 milestone Jun 3, 2026
@ovitrif
ovitrif requested a review from jvsena42June 3, 2026 16:11
@piotr-iohk

Copy link
Copy Markdown
Collaborator

Emulator setup (once per session)

  • API 35+ (e.g. Pixel 8 API 37).
  • App: dev build → to.bitkit.dev.
  • Target SDK 36 → skip am compat enable (limits already on).

Shorten the dataSync FGS timeout (emulator only). On API 35+, LightningNodeService runs as a dataSync foreground service. In production the system allows about 6 hours per 24h, then calls onTimeout. Waiting that long is impractical for QA, so Android exposes a device config override to set how long the service may run in the background before timeout — here 30 seconds (30000 ms). That makes the repro repeatable: start node → Home → wait ~35s → FGS (dataSync) timed out. The setting applies to the emulator until changed or wiped; it does not ship with the app. See FGS timeout testing.

adb shell device_config put activity_manager data_sync_fgs_timeout_duration 30000
adb shell device_config get activity_manager data_sync_fgs_timeout_duration

Step 1 — Repro on v2.2.0 (expect crash) ✅

Checkout

git checkout v2.2.0

Local-only patch (LightningNodeService.kt)

Do not commit. Simulates slow teardown on the broken code path.

Add import:

importkotlinx.coroutines.delay

Replace onTimeout body (v2.2.0 — stopSelf() after async stop):

 override fun onTimeout(startId: Int, fgsType: Int) {
Logger.warn("Foreground service timeout reached", context = TAG)
serviceScope.launch {
lightningRepo.stop()
+ delay(15_000)
stopSelf()
}
super.onTimeout(startId, fgsType)
}

Build & run

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Test

  1. Wallet onboarded, notifications allowed → node notification visible.
  2. Press Home (app in background).
  3. Wait ~35 s (30s FGS limit + margin).

Expected logcat

adb logcat -v time ActivityManager:E AndroidRuntime:E APP:W | grep -E "FGS|DidNotStop|timeout|FATAL|died"

Observed on v2.2.0 + patch (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
E ActivityManager: FGS Crashed: ... LightningNodeService ... # ~10s after timeout
I ActivityManager: Process to.bitkit.dev (pid ...) has died: prcp FGS

Optional full exception:

adb logcat -d | grep -E "DidNotStop|did not stop within its timeout|RemoteServiceException"

Discard patch

git checkout -- app/src/main/java/to/bitkit/androidServices/LightningNodeService.kt

Step 2 — Verify fix branch (expect no crash) ✅

git switch fix/fg-service-crash-980

Symmetric stress patch applied locally (see below) — FGS tears down first; slow LDK stop must not crash.

./gradlew installDevDebug
adb shell am start -n to.bitkit.dev/to.bitkit.ui.MainActivity

Same test as Step 1.

Expected:FGS (dataSync) timed out then Stop FGS timeout within ~seconds, noFGS Crashed, noProcess … has died: prcp FGS. The node FGS stops by design (notification gone); app process may stay in background — that is not a crash.

Observed on fix branch + symmetric stress (2026-06-03):

E ActivityManager: FGS (dataSync) timed out: ... LightningNodeService ...
D ActivityManager: Stop FGS timeout: ... LightningNodeService ...

(no FGS Crashed line)

Optional — symmetric stress on fix (still no crash)

Same delay import; in fix branch onTimeout:

 stopForegroundService(startId)
- serviceScope.launch { lightningRepo.stop() }+ serviceScope.launch {+ delay(15_000)+ lightningRepo.stop()+ }

FGS is already down before the delay → should not crash.

@piotr-iohkpiotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. see #987 (comment)

@ovitrifovitrif self-assigned this Jun 3, 2026
@ovitrif

ovitrif commented Jun 3, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Step 1 — Repro on v2.2.0 (expect crash) ✅
Step 2 — Verify fix branch (expect no crash) ✅

Incorporated into the PR QA Notes. No code changes were needed.

@ovitrif
ovitrif enabled auto-merge June 3, 2026 17:22
@ovitrif
ovitrif merged commit 4290a7c into masterJun 3, 2026
40 of 45 checks passed
@ovitrif
ovitrif deleted the fix/fg-service-crash-980 branch June 3, 2026 17:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

@ovitrif@piotr-iohk