fix: android consumer-rules by ovitrif · Pull Request #145 · synonymdev/bitkit-core

ovitrif · 2026-08-26T20:17:44Z

Follow-up to #139.

The Android AAR ships consumer keep rules for UniFFI/JNA so a minified app can resolve JNI names and lay out JNA structs.

Library publish packages proguard.txt in the AAR. Minified-app R8 belongs in the consuming app.

Description

Keeps com.sun.jna.* so libjnidispatch can resolve JNI names on Native, Structure, and CallbackReference.
Keeps classes that extend com.sun.jna.*, including com.sun.jna.ptr ByReference types used as UniFFI callback out-params.
Keeps com.sun.jna.Structure$FieldOrder and annotated com.synonym.bitkitcore struct classes, fields, and constructors.
Fails bundleReleaseAar when the AAR is missing a non-empty proguard.txt.
Fixes changelog by backfilling entries from releases.

Out of scope

Running R8 in this repo.

Preview

N/A — Android consumer keep rules only.

QA Notes

Validated by running a minified Bitkit devRelease on Pixel_10_Pro_XL (16KB) with this artifact served via mavenLocal: terms, skip intro, new wallet, home with savings and spending at ₿0. No JNI/JNA crash.
That build dropped the app keep for com.synonym.bitkitcore.** and the app-wide FieldOrder, Structure, and Callback keeps.
Release AAR contains a non-empty proguard.txt with those consumer keep rules.

Release

Release 0.5.11

@structure

R8 full mode stripped @structure.FieldOrder from UniFFI structs. Keep the annotation type and annotated classes so JNA can still lay out the structs.

Ship FieldOrder and com.sun.jna.* keeps in the AAR. Library publish only checks that proguard.txt is packaged; minified-app proof is the Bitkit release build.

This reverts commit 0ae27d5.

ovitrif · 2026-08-26T20:17:44Z

Fixes#140

Follow-up to #139.

The Android AAR ships consumer keep rules for UniFFI/JNA so a minified app can resolve JNI names and lay out JNA structs.

Library publish packages proguard.txt in the AAR. Minified-app R8 belongs in the consuming app.

Description

Keeps com.sun.jna.* so libjnidispatch can resolve JNI names on Native, Structure, and CallbackReference.
Keeps classes that extend com.sun.jna.*, including com.sun.jna.ptr ByReference types used as UniFFI callback out-params.
Keeps com.sun.jna.Structure$FieldOrder and annotated com.synonym.bitkitcore struct classes, fields, and constructors.
Fails bundleReleaseAar when the AAR is missing a non-empty proguard.txt.
Fixes changelog by backfilling entries from releases.

Out of scope

Running R8 in this repo.

Preview

N/A — Android consumer keep rules only.

QA Notes

Validated by running a minified Bitkit devRelease on Pixel_10_Pro_XL (16KB) with this artifact served via mavenLocal: terms, skip intro, new wallet, home with savings and spending at ₿0. No JNI/JNA crash.
That build dropped the app keep for com.synonym.bitkitcore.** and the app-wide FieldOrder, Structure, and Callback keeps.
Release AAR contains a non-empty proguard.txt with those consumer keep rules.

Release

Release 0.5.11

@structure

R8 full mode stripped @structure.FieldOrder from UniFFI structs. Keep the annotation type and annotated classes so JNA can still lay out the structs.

Ship FieldOrder and com.sun.jna.* keeps in the AAR. Library publish only checks that proguard.txt is packaged; minified-app proof is the Bitkit release build.

This reverts commit 0ae27d5.

ovitrif · 2026-08-26T20:17:44Z

Fixes#140

Follow-up to #139.

The Android AAR ships consumer keep rules for UniFFI/JNA so a minified app can resolve JNI names and lay out JNA structs.

Library publish packages proguard.txt in the AAR. Minified-app R8 belongs in the consuming app.

Description

Keeps com.sun.jna.* so libjnidispatch can resolve JNI names on Native, Structure, and CallbackReference.
Keeps classes that extend com.sun.jna.*, including com.sun.jna.ptr ByReference types used as UniFFI callback out-params.
Keeps com.sun.jna.Structure$FieldOrder and annotated com.synonym.bitkitcore struct classes, fields, and constructors.
Fails bundleReleaseAar when the AAR is missing a non-empty proguard.txt.
Fixes changelog by backfilling entries from releases.

Out of scope

Running R8 in this repo.

Preview

N/A — Android consumer keep rules only.

QA Notes

Validated by running a minified Bitkit devRelease on Pixel_10_Pro_XL (16KB) with this artifact served via mavenLocal: terms, skip intro, new wallet, home with savings and spending at ₿0. No JNI/JNA crash.
That build dropped the app keep for com.synonym.bitkitcore.** and the app-wide FieldOrder, Structure, and Callback keeps.
Release AAR contains a non-empty proguard.txt with those consumer keep rules.

Release

Release 0.5.11

@structure

R8 full mode stripped @structure.FieldOrder from UniFFI structs. Keep the annotation type and annotated classes so JNA can still lay out the structs.

Ship FieldOrder and com.sun.jna.* keeps in the AAR. Library publish only checks that proguard.txt is packaged; minified-app proof is the Bitkit release build.

This reverts commit 0ae27d5.

ovitrif · 2026-08-26T20:17:44Z

Fixes#140

Follow-up to #139.

The Android AAR ships consumer keep rules for UniFFI/JNA so a minified app can resolve JNI names and lay out JNA structs.

Library publish packages proguard.txt in the AAR. Minified-app R8 belongs in the consuming app.

Description

Keeps com.sun.jna.* so libjnidispatch can resolve JNI names on Native, Structure, and CallbackReference.
Keeps classes that extend com.sun.jna.*, including com.sun.jna.ptr ByReference types used as UniFFI callback out-params.
Keeps com.sun.jna.Structure$FieldOrder and annotated com.synonym.bitkitcore struct classes, fields, and constructors.
Fails bundleReleaseAar when the AAR is missing a non-empty proguard.txt.
Fixes changelog by backfilling entries from releases.

Out of scope

Running R8 in this repo.

Preview

N/A — Android consumer keep rules only.

QA Notes

Validated by running a minified Bitkit devRelease on Pixel_10_Pro_XL (16KB) with this artifact served via mavenLocal: terms, skip intro, new wallet, home with savings and spending at ₿0. No JNI/JNA crash.
That build dropped the app keep for com.synonym.bitkitcore.** and the app-wide FieldOrder, Structure, and Callback keeps.
Release AAR contains a non-empty proguard.txt with those consumer keep rules.

Release

Release 0.5.11

@structure

R8 full mode stripped @structure.FieldOrder from UniFFI structs. Keep the annotation type and annotated classes so JNA can still lay out the structs.

Ship FieldOrder and com.sun.jna.* keeps in the AAR. Library publish only checks that proguard.txt is packaged; minified-app proof is the Bitkit release build.

This reverts commit 0ae27d5.

ovitrif · 2026-08-26T20:17:44Z

Fixes#140

Follow-up to #139.

The Android AAR ships consumer keep rules for UniFFI/JNA so a minified app can resolve JNI names and lay out JNA structs.

Library publish packages proguard.txt in the AAR. Minified-app R8 belongs in the consuming app.

Description

Keeps com.sun.jna.* so libjnidispatch can resolve JNI names on Native, Structure, and CallbackReference.
Keeps classes that extend com.sun.jna.*, including com.sun.jna.ptr ByReference types used as UniFFI callback out-params.
Keeps com.sun.jna.Structure$FieldOrder and annotated com.synonym.bitkitcore struct classes, fields, and constructors.
Fails bundleReleaseAar when the AAR is missing a non-empty proguard.txt.
Fixes changelog by backfilling entries from releases.

Out of scope

Running R8 in this repo.

Preview

N/A — Android consumer keep rules only.

QA Notes

Validated by running a minified Bitkit devRelease on Pixel_10_Pro_XL (16KB) with this artifact served via mavenLocal: terms, skip intro, new wallet, home with savings and spending at ₿0. No JNI/JNA crash.
That build dropped the app keep for com.synonym.bitkitcore.** and the app-wide FieldOrder, Structure, and Callback keeps.
Release AAR contains a non-empty proguard.txt with those consumer keep rules.

Release

Release 0.5.11

@structure

R8 full mode stripped @structure.FieldOrder from UniFFI structs. Keep the annotation type and annotated classes so JNA can still lay out the structs.

Ship FieldOrder and com.sun.jna.* keeps in the AAR. Library publish only checks that proguard.txt is packaged; minified-app proof is the Bitkit release build.

This reverts commit 0ae27d5.

ovitrif · 2026-08-26T20:17:44Z

Fixes#140

Follow-up to #139.

The Android AAR ships consumer keep rules for UniFFI/JNA so a minified app can resolve JNI names and lay out JNA structs.

Library publish packages proguard.txt in the AAR. Minified-app R8 belongs in the consuming app.

Description

Keeps com.sun.jna.* so libjnidispatch can resolve JNI names on Native, Structure, and CallbackReference.
Keeps classes that extend com.sun.jna.*, including com.sun.jna.ptr ByReference types used as UniFFI callback out-params.
Keeps com.sun.jna.Structure$FieldOrder and annotated com.synonym.bitkitcore struct classes, fields, and constructors.
Fails bundleReleaseAar when the AAR is missing a non-empty proguard.txt.
Fixes changelog by backfilling entries from releases.

Out of scope

Running R8 in this repo.

Preview

N/A — Android consumer keep rules only.

QA Notes

Validated by running a minified Bitkit devRelease on Pixel_10_Pro_XL (16KB) with this artifact served via mavenLocal: terms, skip intro, new wallet, home with savings and spending at ₿0. No JNI/JNA crash.
That build dropped the app keep for com.synonym.bitkitcore.** and the app-wide FieldOrder, Structure, and Callback keeps.
Release AAR contains a non-empty proguard.txt with those consumer keep rules.

Release

Release 0.5.11

@structure

R8 full mode stripped @structure.FieldOrder from UniFFI structs. Keep the annotation type and annotated classes so JNA can still lay out the structs.

Ship FieldOrder and com.sun.jna.* keeps in the AAR. Library publish only checks that proguard.txt is packaged; minified-app proof is the Bitkit release build.

This reverts commit 0ae27d5.

ovitrif · 2026-08-26T20:17:44Z

Fixes#140

Follow-up to #139.

The Android AAR ships consumer keep rules for UniFFI/JNA so a minified app can resolve JNI names and lay out JNA structs.

Library publish packages proguard.txt in the AAR. Minified-app R8 belongs in the consuming app.

Description

Keeps com.sun.jna.* so libjnidispatch can resolve JNI names on Native, Structure, and CallbackReference.
Keeps classes that extend com.sun.jna.*, including com.sun.jna.ptr ByReference types used as UniFFI callback out-params.
Keeps com.sun.jna.Structure$FieldOrder and annotated com.synonym.bitkitcore struct classes, fields, and constructors.
Fails bundleReleaseAar when the AAR is missing a non-empty proguard.txt.
Fixes changelog by backfilling entries from releases.

Out of scope

Running R8 in this repo.

Preview

N/A — Android consumer keep rules only.

QA Notes

Validated by running a minified Bitkit devRelease on Pixel_10_Pro_XL (16KB) with this artifact served via mavenLocal: terms, skip intro, new wallet, home with savings and spending at ₿0. No JNI/JNA crash.
That build dropped the app keep for com.synonym.bitkitcore.** and the app-wide FieldOrder, Structure, and Callback keeps.
Release AAR contains a non-empty proguard.txt with those consumer keep rules.

Release

Release 0.5.11

@structure

R8 full mode stripped @structure.FieldOrder from UniFFI structs. Keep the annotation type and annotated classes so JNA can still lay out the structs.

Ship FieldOrder and com.sun.jna.* keeps in the AAR. Library publish only checks that proguard.txt is packaged; minified-app proof is the Bitkit release build.

This reverts commit 0ae27d5.

ovitrif · 2026-08-26T20:17:44Z

Fixes#140

Follow-up to #139.

The Android AAR ships consumer keep rules for UniFFI/JNA so a minified app can resolve JNI names and lay out JNA structs.

Library publish packages proguard.txt in the AAR. Minified-app R8 belongs in the consuming app.

Description

Keeps com.sun.jna.* so libjnidispatch can resolve JNI names on Native, Structure, and CallbackReference.
Keeps classes that extend com.sun.jna.*, including com.sun.jna.ptr ByReference types used as UniFFI callback out-params.
Keeps com.sun.jna.Structure$FieldOrder and annotated com.synonym.bitkitcore struct classes, fields, and constructors.
Fails bundleReleaseAar when the AAR is missing a non-empty proguard.txt.
Fixes changelog by backfilling entries from releases.

Out of scope

Running R8 in this repo.

Preview

N/A — Android consumer keep rules only.

QA Notes

Validated by running a minified Bitkit devRelease on Pixel_10_Pro_XL (16KB) with this artifact served via mavenLocal: terms, skip intro, new wallet, home with savings and spending at ₿0. No JNI/JNA crash.
That build dropped the app keep for com.synonym.bitkitcore.** and the app-wide FieldOrder, Structure, and Callback keeps.
Release AAR contains a non-empty proguard.txt with those consumer keep rules.

Release

Release 0.5.11

@structure

R8 full mode stripped @structure.FieldOrder from UniFFI structs. Keep the annotation type and annotated classes so JNA can still lay out the structs.

Ship FieldOrder and com.sun.jna.* keeps in the AAR. Library publish only checks that proguard.txt is packaged; minified-app proof is the Bitkit release build.

This reverts commit 0ae27d5.

ovitrif requested a review from ben-kaufman August 26, 2026 20:17

ben-kaufman reviewed Aug 26, 2026
View reviewed changes

Comment threadbindings/android/lib/consumer-rules.pro

ben-kaufman reviewed Aug 26, 2026
View reviewed changes

Comment threadbindings/android/lib/build.gradle.kts Outdated

ben-kaufman reviewed Aug 26, 2026
View reviewed changes

Comment threadbindings/android/lib/build.gradle.kts Outdated

ovitrif marked this pull request as draft August 26, 2026 20:39

ovitrif requested a review from ben-kaufman August 26, 2026 20:50

ovitrif changed the title ~~fix: keep JNA FieldOrder annotations under R8~~fix: keep JNA JNI symbols in Android consumer rulesAug 26, 2026

ovitrif changed the title ~~fix: keep JNA JNI symbols in Android consumer rules~~fix: android consumer-rulesAug 26, 2026

ovitrif marked this pull request as ready for review August 26, 2026 21:42

ben-kaufman reviewed Aug 26, 2026
View reviewed changes

Comment threadbindings/android/lib/consumer-rules.pro

ovitrif requested a review from ben-kaufman August 26, 2026 22:04

ovitrif self-assigned this Aug 26, 2026

This was referenced Aug 27, 2026
add android r8 consumer keep rules #140
Closed
fix: add android r8 rules #139
Merged

ovitrif requested a review from coreyphillips August 27, 2026 11:33

This comment was marked as resolved.
Sign in to view

ben-kaufman reviewed Aug 27, 2026
View reviewed changes

Comment threadbindings/android/gradle.properties Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md

This was referenced Aug 27, 2026
epic: align deps ndk synonymdev/bitkit-android#1190
Open
fix: align ndk with android app #148
Open

ovitrif added 11 commits August 27, 2026 19:41

fix: keep JNA FieldOrder annotations under R8
0970c26
R8 full mode stripped @structure.FieldOrder from UniFFI structs. Keep the annotation type and annotated classes so JNA can still lay out the structs.

fix: keep JNA core types in Android consumer rules
10c8189
Ship FieldOrder and com.sun.jna.* keeps in the AAR. Library publish only checks that proguard.txt is packaged; minified-app proof is the Bitkit release build.

docs: file changelog entries for 0.3.4 through 0.5.10
682c24e

fix: keep JNA subclasses in consumer rules
c23d739

docs: restore Passport changelog entry
c9ae415

docs: shorten 0.5.10 changelog entry
6b4afd9

docs: wording for 0.5.10 changelog entry
9534ba2

fix: keep JNA subpackages in consumer rules
44c70a7

Revert "fix: keep JNA subpackages in consumer rules"
25faa13
This reverts commit 0ae27d5.

fix: keep JNA subpackages in consumer rules
2e3acd6

fix: apply JNA Android FAQ keep rules
7fdf4f2

ovitrif added 2 commits August 27, 2026 19:41

docs: reconcile changelog with releases
84ceaf3

chore: bump to 0.5.11 and regenerate bindings
844fa90

ovitrif force-pushed the fix/r8-keep-fieldorder branch from 303a066 to 844fa90Compare August 27, 2026 17:43

ovitrif changed the base branch from master to feat/watcher-receive-addressAugust 27, 2026 17:43

ovitrif mentioned this pull request Aug 27, 2026
feat: expose watcher receive address #147
Merged

Base automatically changed from feat/watcher-receive-address to masterAugust 27, 2026 17:47

ovitrif requested a review from ben-kaufman August 27, 2026 17:51

Merge branch 'master' into fix/r8-keep-fieldorder
39753f9

ben-kaufman approved these changes Aug 28, 2026
View reviewed changes

ovitrif mentioned this pull request Aug 28, 2026
feat: add wallet-scoped activity tag reads (#136) #141
Merged

ovitrif merged commit e71221f into masterAug 28, 2026

ovitrif deleted the fix/r8-keep-fieldorder branch August 28, 2026 16:08

This was referenced Aug 28, 2026
fix: android consumer-rules pubky/paykit-rs#141
Merged
fix: android consumer-rules synonymdev/ldk-node#107
Merged
fix: android consumer-rules synonymdev/vss-rust-client-ffi#25
Merged