SIGABRT: owned tokio Runtime dropped from its own worker thread during chain sync teardown #94

Description

@jvsena42

Summary

On Android production (arm64-v8a, ldk-node-android 0.7.0-rc.52) we see a recurring SIGABRT caused by a tokio panic:

Cannot drop a runtime in a context where blocking is not allowed.
This happens when a runtime is dropped from within an asynchronous context.

Symbolication shows the owned tokio Runtime is dropped by an ldk-node chain-sync background task while that task is running on a worker thread of the very runtime being dropped. Release builds are panic = abort, so this terminates the app process with no catchable error.

Tracked downstream as synonymdev/bitkit-android#982 (top production crash cluster, mainnet 2.2.0 → 2.4.0).

Symbolicated stack

Symbolicated with the unstripped arm64-v8a/libldk_node.so from the native-debug-symbols artifact of com.synonym:ldk-node-android:0.7.0-rc.52 (.text vaddr 0x551980, size 0x7d16ec, matching the packaged library byte-for-byte).

#35 std::thread lifecycle → tokio-1.52.3 runtime/blocking/pool.rs:161 (tokio worker thread)
#28 tokio runtime/scheduler/multi_thread/worker.rs:503
#27 tokio runtime/scheduler/multi_thread/worker.rs:537 run
#23 tokio runtime/task/raw.rs:267 poll
#19 ldk_node::runtime::Runtime::spawn_background_task
<Node::spawn_chain_sync_task_with_receiver> src/runtime.rs:73
#18 async block src/lib.rs
#17 async fn src/chain/mod.rs:766
#16 async fn src/chain/mod.rs:913
#15 async fn src/chain/electrum.rs:307 (from :121)
#14 drop_slow<ldk_node::chain::electrum::ElectrumRuntimeClient> ← last Arc released here
#13 drop_in_place<ldk_node::runtime::Runtime / ldk_node::runtime::RuntimeMode>
#12 drop_in_place<tokio::runtime::Runtime → tokio::runtime::blocking::pool::BlockingPool>
#11 tokio runtime/blocking/shutdown.rs:51 wait → panic
#10 core::panicking::panic_fmt
#04 __rust_start_panic (panic_abort)
#03 __rust_abort → #02 std::process::abort → #01 abort_internal → SIGABRT

Line numbers are from the rc.52 build; the structure is unchanged on main.

Analysis

ldk_node::runtime::Runtime can own the tokio runtime outright (src/runtime.rs):

let mode = match tokio::runtime::Handle::try_current(){Ok(handle) => RuntimeMode::Handle(handle),Err(_) => {let rt = tokio::runtime::Builder::new_multi_thread().enable_all().build()?;RuntimeMode::Owned(rt)// <-- owned runtime},};

On Android the Node is built from a plain JNI/UniFFI thread with no ambient tokio context, so RuntimeMode::Owned is always the branch taken.

ElectrumRuntimeClient holds a strong reference to it (src/chain/electrum.rs:601):

structElectrumRuntimeClient{electrum_client:Arc<ElectrumClient>,bdk_electrum_client:Arc<BdkElectrumClient<Arc<ElectrumClient>>>,tx_sync:Arc<ElectrumSyncClient<Arc<Logger>>>,runtime:Arc<Runtime>,// <-- keeps the owned runtime aliveconfig:Arc<Config>,logger:Arc<Logger>,}

and sync paths take their own clone out of the status before awaiting (src/chain/electrum.rs:575):

fnclient(&self) -> Option<Arc<ElectrumRuntimeClient>>{matchself{Self::Started(client) => Some(Arc::clone(&client)),Self::Stopped{ .. } => None,}}

while teardown simply releases the status's own reference (src/chain/electrum.rs:571):

pub(super)fnstop(&mutself){*self = Self::new()}

That produces the race:

  1. The chain-sync background task, spawned via Runtime::spawn_background_task, is executing on a worker thread of the owned runtime and holds an Arc<ElectrumRuntimeClient> clone.
  2. Teardown (ElectrumRuntimeStatus::stop, or any other path releasing the status) drops the status's Arc, so the running task now holds the last reference.
  3. The task finishes; its clone drops → ElectrumRuntimeClient drops → its Arc<Runtime> is the last one → RuntimeMode::Owned(tokio::runtime::Runtime) drops.
  4. tokio::runtime::Runtime::dropBlockingPool::shutdown needs to block, detects it is inside a runtime context, and panics.
  5. panic = abortSIGABRT, whole process gone.

Nothing on the consumer side can prevent or catch this: the drop happens entirely inside ldk-node's own task on ldk-node's own runtime.

Impact

Suggested directions

  1. Never let an owned tokio Runtime be dropped by a task running on it. E.g. have RuntimeMode::Owned drop go through Runtime::shutdown_background() / shutdown_timeout(), or hand the runtime off to a dedicated non-runtime thread for teardown.
  2. Keep runtime ownership out of ElectrumRuntimeClient — hold a tokio::runtime::Handle (or a Weak<Runtime>) there instead of Arc<Runtime>, so a sync task can never own the last reference.
  3. Make teardown deterministic: have stop() await outstanding chain-sync tasks (background_tasks / cancellable_background_tasks are already tracked in JoinSets) before releasing the client, so the final drop happens on the caller's thread rather than a worker.

Environment

  • ldk-node-android0.7.0-rc.52 (also present on main / v0.7.0 by inspection), tokio 1.52.3
  • Android arm64-v8a, Android 13–16, release profile (panic = abort)
  • Consumer: Bitkit Android 2.4.0 (mainnet, to.bitkit)

Note on symbolication

Play cannot symbolicate any of this itself: the published libldk_node.so carries no GNU build-id, which is the key Play uses to pair an uploaded native debug symbol file with the crashing library. That is why the stack above had to be resolved by hand. Tracked separately in #95.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
     blocks
    (function() {
    function addCopyButtons() {
    document.querySelectorAll('pre code').forEach(function(codeBlock) {
    if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
    codeBlock.parentElement.setAttribute('data-copy-added', 'true');
    var btn = document.createElement('button');
    btn.textContent = 'Copy';
    btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
    btn.onmouseover = function() { this.style.opacity = '1'; };
    btn.onmouseout = function() { this.style.opacity = '0.7'; };
    btn.onclick = function() {
    navigator.clipboard.writeText(codeBlock.textContent).then(function() {
    btn.textContent = 'Copied!';
    setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
    });
    };
    codeBlock.parentElement.style.position = 'relative';
    codeBlock.parentElement.appendChild(btn);
    });
    }
    addCopyButtons();
    // Re-run on dynamic content
    var observer = new MutationObserver(addCopyButtons);
    observer.observe(document.body, { childList: true, subtree: true });
    })();
    }
    } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
    })();
    (function(){
    try {
    var __m = "github.com";
    var __re = new RegExp('^' + "github\\.com" + '
    
    Skip to content

    SIGABRT: owned tokio Runtime dropped from its own worker thread during chain sync teardown #94

    Description

    @jvsena42

    Summary

    On Android production (arm64-v8a, ldk-node-android 0.7.0-rc.52) we see a recurring SIGABRT caused by a tokio panic:

    Cannot drop a runtime in a context where blocking is not allowed.
    This happens when a runtime is dropped from within an asynchronous context.
    

    Symbolication shows the owned tokio Runtime is dropped by an ldk-node chain-sync background task while that task is running on a worker thread of the very runtime being dropped. Release builds are panic = abort, so this terminates the app process with no catchable error.

    Tracked downstream as synonymdev/bitkit-android#982 (top production crash cluster, mainnet 2.2.0 → 2.4.0).

    Symbolicated stack

    Symbolicated with the unstripped arm64-v8a/libldk_node.so from the native-debug-symbols artifact of com.synonym:ldk-node-android:0.7.0-rc.52 (.text vaddr 0x551980, size 0x7d16ec, matching the packaged library byte-for-byte).

    #35 std::thread lifecycle → tokio-1.52.3 runtime/blocking/pool.rs:161 (tokio worker thread)
    #28 tokio runtime/scheduler/multi_thread/worker.rs:503
    #27 tokio runtime/scheduler/multi_thread/worker.rs:537 run
    #23 tokio runtime/task/raw.rs:267 poll
    #19 ldk_node::runtime::Runtime::spawn_background_task
    <Node::spawn_chain_sync_task_with_receiver> src/runtime.rs:73
    #18 async block src/lib.rs
    #17 async fn src/chain/mod.rs:766
    #16 async fn src/chain/mod.rs:913
    #15 async fn src/chain/electrum.rs:307 (from :121)
    #14 drop_slow<ldk_node::chain::electrum::ElectrumRuntimeClient> ← last Arc released here
    #13 drop_in_place<ldk_node::runtime::Runtime / ldk_node::runtime::RuntimeMode>
    #12 drop_in_place<tokio::runtime::Runtime → tokio::runtime::blocking::pool::BlockingPool>
    #11 tokio runtime/blocking/shutdown.rs:51 wait → panic
    #10 core::panicking::panic_fmt
    #04 __rust_start_panic (panic_abort)
    #03 __rust_abort → #02 std::process::abort → #01 abort_internal → SIGABRT
    

    Line numbers are from the rc.52 build; the structure is unchanged on main.

    Analysis

    ldk_node::runtime::Runtime can own the tokio runtime outright (src/runtime.rs):

    let mode = match tokio::runtime::Handle::try_current(){Ok(handle) => RuntimeMode::Handle(handle),Err(_) => {let rt = tokio::runtime::Builder::new_multi_thread().enable_all().build()?;RuntimeMode::Owned(rt)// <-- owned runtime},};

    On Android the Node is built from a plain JNI/UniFFI thread with no ambient tokio context, so RuntimeMode::Owned is always the branch taken.

    ElectrumRuntimeClient holds a strong reference to it (src/chain/electrum.rs:601):

    structElectrumRuntimeClient{electrum_client:Arc<ElectrumClient>,bdk_electrum_client:Arc<BdkElectrumClient<Arc<ElectrumClient>>>,tx_sync:Arc<ElectrumSyncClient<Arc<Logger>>>,runtime:Arc<Runtime>,// <-- keeps the owned runtime aliveconfig:Arc<Config>,logger:Arc<Logger>,}

    and sync paths take their own clone out of the status before awaiting (src/chain/electrum.rs:575):

    fnclient(&self) -> Option<Arc<ElectrumRuntimeClient>>{matchself{Self::Started(client) => Some(Arc::clone(&client)),Self::Stopped{ .. } => None,}}

    while teardown simply releases the status's own reference (src/chain/electrum.rs:571):

    pub(super)fnstop(&mutself){*self = Self::new()}

    That produces the race:

    1. The chain-sync background task, spawned via Runtime::spawn_background_task, is executing on a worker thread of the owned runtime and holds an Arc<ElectrumRuntimeClient> clone.
    2. Teardown (ElectrumRuntimeStatus::stop, or any other path releasing the status) drops the status's Arc, so the running task now holds the last reference.
    3. The task finishes; its clone drops → ElectrumRuntimeClient drops → its Arc<Runtime> is the last one → RuntimeMode::Owned(tokio::runtime::Runtime) drops.
    4. tokio::runtime::Runtime::dropBlockingPool::shutdown needs to block, detects it is inside a runtime context, and panics.
    5. panic = abortSIGABRT, whole process gone.

    Nothing on the consumer side can prevent or catch this: the drop happens entirely inside ldk-node's own task on ldk-node's own runtime.

    Impact

    Suggested directions

    1. Never let an owned tokio Runtime be dropped by a task running on it. E.g. have RuntimeMode::Owned drop go through Runtime::shutdown_background() / shutdown_timeout(), or hand the runtime off to a dedicated non-runtime thread for teardown.
    2. Keep runtime ownership out of ElectrumRuntimeClient — hold a tokio::runtime::Handle (or a Weak<Runtime>) there instead of Arc<Runtime>, so a sync task can never own the last reference.
    3. Make teardown deterministic: have stop() await outstanding chain-sync tasks (background_tasks / cancellable_background_tasks are already tracked in JoinSets) before releasing the client, so the final drop happens on the caller's thread rather than a worker.

    Environment

    • ldk-node-android0.7.0-rc.52 (also present on main / v0.7.0 by inspection), tokio 1.52.3
    • Android arm64-v8a, Android 13–16, release profile (panic = abort)
    • Consumer: Bitkit Android 2.4.0 (mainnet, to.bitkit)

    Note on symbolication

    Play cannot symbolicate any of this itself: the published libldk_node.so carries no GNU build-id, which is the key Play uses to pair an uploaded native debug symbol file with the crashing library. That is why the stack above had to be resolved by hand. Tracked separately in #95.

    Metadata

    Metadata

    Assignees

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
      Skip to content

      SIGABRT: owned tokio Runtime dropped from its own worker thread during chain sync teardown #94

      Description

      @jvsena42

      Summary

      On Android production (arm64-v8a, ldk-node-android 0.7.0-rc.52) we see a recurring SIGABRT caused by a tokio panic:

      Cannot drop a runtime in a context where blocking is not allowed.
      This happens when a runtime is dropped from within an asynchronous context.
      

      Symbolication shows the owned tokio Runtime is dropped by an ldk-node chain-sync background task while that task is running on a worker thread of the very runtime being dropped. Release builds are panic = abort, so this terminates the app process with no catchable error.

      Tracked downstream as synonymdev/bitkit-android#982 (top production crash cluster, mainnet 2.2.0 → 2.4.0).

      Symbolicated stack

      Symbolicated with the unstripped arm64-v8a/libldk_node.so from the native-debug-symbols artifact of com.synonym:ldk-node-android:0.7.0-rc.52 (.text vaddr 0x551980, size 0x7d16ec, matching the packaged library byte-for-byte).

      #35 std::thread lifecycle → tokio-1.52.3 runtime/blocking/pool.rs:161 (tokio worker thread)
      #28 tokio runtime/scheduler/multi_thread/worker.rs:503
      #27 tokio runtime/scheduler/multi_thread/worker.rs:537 run
      #23 tokio runtime/task/raw.rs:267 poll
      #19 ldk_node::runtime::Runtime::spawn_background_task
      <Node::spawn_chain_sync_task_with_receiver> src/runtime.rs:73
      #18 async block src/lib.rs
      #17 async fn src/chain/mod.rs:766
      #16 async fn src/chain/mod.rs:913
      #15 async fn src/chain/electrum.rs:307 (from :121)
      #14 drop_slow<ldk_node::chain::electrum::ElectrumRuntimeClient> ← last Arc released here
      #13 drop_in_place<ldk_node::runtime::Runtime / ldk_node::runtime::RuntimeMode>
      #12 drop_in_place<tokio::runtime::Runtime → tokio::runtime::blocking::pool::BlockingPool>
      #11 tokio runtime/blocking/shutdown.rs:51 wait → panic
      #10 core::panicking::panic_fmt
      #04 __rust_start_panic (panic_abort)
      #03 __rust_abort → #02 std::process::abort → #01 abort_internal → SIGABRT
      

      Line numbers are from the rc.52 build; the structure is unchanged on main.

      Analysis

      ldk_node::runtime::Runtime can own the tokio runtime outright (src/runtime.rs):

      let mode = match tokio::runtime::Handle::try_current(){Ok(handle) => RuntimeMode::Handle(handle),Err(_) => {let rt = tokio::runtime::Builder::new_multi_thread().enable_all().build()?;RuntimeMode::Owned(rt)// <-- owned runtime},};

      On Android the Node is built from a plain JNI/UniFFI thread with no ambient tokio context, so RuntimeMode::Owned is always the branch taken.

      ElectrumRuntimeClient holds a strong reference to it (src/chain/electrum.rs:601):

      structElectrumRuntimeClient{electrum_client:Arc<ElectrumClient>,bdk_electrum_client:Arc<BdkElectrumClient<Arc<ElectrumClient>>>,tx_sync:Arc<ElectrumSyncClient<Arc<Logger>>>,runtime:Arc<Runtime>,// <-- keeps the owned runtime aliveconfig:Arc<Config>,logger:Arc<Logger>,}

      and sync paths take their own clone out of the status before awaiting (src/chain/electrum.rs:575):

      fnclient(&self) -> Option<Arc<ElectrumRuntimeClient>>{matchself{Self::Started(client) => Some(Arc::clone(&client)),Self::Stopped{ .. } => None,}}

      while teardown simply releases the status's own reference (src/chain/electrum.rs:571):

      pub(super)fnstop(&mutself){*self = Self::new()}

      That produces the race:

      1. The chain-sync background task, spawned via Runtime::spawn_background_task, is executing on a worker thread of the owned runtime and holds an Arc<ElectrumRuntimeClient> clone.
      2. Teardown (ElectrumRuntimeStatus::stop, or any other path releasing the status) drops the status's Arc, so the running task now holds the last reference.
      3. The task finishes; its clone drops → ElectrumRuntimeClient drops → its Arc<Runtime> is the last one → RuntimeMode::Owned(tokio::runtime::Runtime) drops.
      4. tokio::runtime::Runtime::dropBlockingPool::shutdown needs to block, detects it is inside a runtime context, and panics.
      5. panic = abortSIGABRT, whole process gone.

      Nothing on the consumer side can prevent or catch this: the drop happens entirely inside ldk-node's own task on ldk-node's own runtime.

      Impact

      Suggested directions

      1. Never let an owned tokio Runtime be dropped by a task running on it. E.g. have RuntimeMode::Owned drop go through Runtime::shutdown_background() / shutdown_timeout(), or hand the runtime off to a dedicated non-runtime thread for teardown.
      2. Keep runtime ownership out of ElectrumRuntimeClient — hold a tokio::runtime::Handle (or a Weak<Runtime>) there instead of Arc<Runtime>, so a sync task can never own the last reference.
      3. Make teardown deterministic: have stop() await outstanding chain-sync tasks (background_tasks / cancellable_background_tasks are already tracked in JoinSets) before releasing the client, so the final drop happens on the caller's thread rather than a worker.

      Environment

      • ldk-node-android0.7.0-rc.52 (also present on main / v0.7.0 by inspection), tokio 1.52.3
      • Android arm64-v8a, Android 13–16, release profile (panic = abort)
      • Consumer: Bitkit Android 2.4.0 (mainnet, to.bitkit)

      Note on symbolication

      Play cannot symbolicate any of this itself: the published libldk_node.so carries no GNU build-id, which is the key Play uses to pair an uploaded native debug symbol file with the crashing library. That is why the stack above had to be resolved by hand. Tracked separately in #95.

      Metadata

      Metadata

      Assignees

      Labels

      No labels
      No labels

      Type

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions

        , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
        Skip to content

        SIGABRT: owned tokio Runtime dropped from its own worker thread during chain sync teardown #94

        Description

        @jvsena42

        Summary

        On Android production (arm64-v8a, ldk-node-android 0.7.0-rc.52) we see a recurring SIGABRT caused by a tokio panic:

        Cannot drop a runtime in a context where blocking is not allowed.
        This happens when a runtime is dropped from within an asynchronous context.
        

        Symbolication shows the owned tokio Runtime is dropped by an ldk-node chain-sync background task while that task is running on a worker thread of the very runtime being dropped. Release builds are panic = abort, so this terminates the app process with no catchable error.

        Tracked downstream as synonymdev/bitkit-android#982 (top production crash cluster, mainnet 2.2.0 → 2.4.0).

        Symbolicated stack

        Symbolicated with the unstripped arm64-v8a/libldk_node.so from the native-debug-symbols artifact of com.synonym:ldk-node-android:0.7.0-rc.52 (.text vaddr 0x551980, size 0x7d16ec, matching the packaged library byte-for-byte).

        #35 std::thread lifecycle → tokio-1.52.3 runtime/blocking/pool.rs:161 (tokio worker thread)
        #28 tokio runtime/scheduler/multi_thread/worker.rs:503
        #27 tokio runtime/scheduler/multi_thread/worker.rs:537 run
        #23 tokio runtime/task/raw.rs:267 poll
        #19 ldk_node::runtime::Runtime::spawn_background_task
        <Node::spawn_chain_sync_task_with_receiver> src/runtime.rs:73
        #18 async block src/lib.rs
        #17 async fn src/chain/mod.rs:766
        #16 async fn src/chain/mod.rs:913
        #15 async fn src/chain/electrum.rs:307 (from :121)
        #14 drop_slow<ldk_node::chain::electrum::ElectrumRuntimeClient> ← last Arc released here
        #13 drop_in_place<ldk_node::runtime::Runtime / ldk_node::runtime::RuntimeMode>
        #12 drop_in_place<tokio::runtime::Runtime → tokio::runtime::blocking::pool::BlockingPool>
        #11 tokio runtime/blocking/shutdown.rs:51 wait → panic
        #10 core::panicking::panic_fmt
        #04 __rust_start_panic (panic_abort)
        #03 __rust_abort → #02 std::process::abort → #01 abort_internal → SIGABRT
        

        Line numbers are from the rc.52 build; the structure is unchanged on main.

        Analysis

        ldk_node::runtime::Runtime can own the tokio runtime outright (src/runtime.rs):

        let mode = match tokio::runtime::Handle::try_current(){Ok(handle) => RuntimeMode::Handle(handle),Err(_) => {let rt = tokio::runtime::Builder::new_multi_thread().enable_all().build()?;RuntimeMode::Owned(rt)// <-- owned runtime},};

        On Android the Node is built from a plain JNI/UniFFI thread with no ambient tokio context, so RuntimeMode::Owned is always the branch taken.

        ElectrumRuntimeClient holds a strong reference to it (src/chain/electrum.rs:601):

        structElectrumRuntimeClient{electrum_client:Arc<ElectrumClient>,bdk_electrum_client:Arc<BdkElectrumClient<Arc<ElectrumClient>>>,tx_sync:Arc<ElectrumSyncClient<Arc<Logger>>>,runtime:Arc<Runtime>,// <-- keeps the owned runtime aliveconfig:Arc<Config>,logger:Arc<Logger>,}

        and sync paths take their own clone out of the status before awaiting (src/chain/electrum.rs:575):

        fnclient(&self) -> Option<Arc<ElectrumRuntimeClient>>{matchself{Self::Started(client) => Some(Arc::clone(&client)),Self::Stopped{ .. } => None,}}

        while teardown simply releases the status's own reference (src/chain/electrum.rs:571):

        pub(super)fnstop(&mutself){*self = Self::new()}

        That produces the race:

        1. The chain-sync background task, spawned via Runtime::spawn_background_task, is executing on a worker thread of the owned runtime and holds an Arc<ElectrumRuntimeClient> clone.
        2. Teardown (ElectrumRuntimeStatus::stop, or any other path releasing the status) drops the status's Arc, so the running task now holds the last reference.
        3. The task finishes; its clone drops → ElectrumRuntimeClient drops → its Arc<Runtime> is the last one → RuntimeMode::Owned(tokio::runtime::Runtime) drops.
        4. tokio::runtime::Runtime::dropBlockingPool::shutdown needs to block, detects it is inside a runtime context, and panics.
        5. panic = abortSIGABRT, whole process gone.

        Nothing on the consumer side can prevent or catch this: the drop happens entirely inside ldk-node's own task on ldk-node's own runtime.

        Impact

        Suggested directions

        1. Never let an owned tokio Runtime be dropped by a task running on it. E.g. have RuntimeMode::Owned drop go through Runtime::shutdown_background() / shutdown_timeout(), or hand the runtime off to a dedicated non-runtime thread for teardown.
        2. Keep runtime ownership out of ElectrumRuntimeClient — hold a tokio::runtime::Handle (or a Weak<Runtime>) there instead of Arc<Runtime>, so a sync task can never own the last reference.
        3. Make teardown deterministic: have stop() await outstanding chain-sync tasks (background_tasks / cancellable_background_tasks are already tracked in JoinSets) before releasing the client, so the final drop happens on the caller's thread rather than a worker.

        Environment

        • ldk-node-android0.7.0-rc.52 (also present on main / v0.7.0 by inspection), tokio 1.52.3
        • Android arm64-v8a, Android 13–16, release profile (panic = abort)
        • Consumer: Bitkit Android 2.4.0 (mainnet, to.bitkit)

        Note on symbolication

        Play cannot symbolicate any of this itself: the published libldk_node.so carries no GNU build-id, which is the key Play uses to pair an uploaded native debug symbol file with the crashing library. That is why the stack above had to be resolved by hand. Tracked separately in #95.

        Metadata

        Metadata

        Assignees

        Labels

        No labels
        No labels

        Type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
          Skip to content

          SIGABRT: owned tokio Runtime dropped from its own worker thread during chain sync teardown #94

          Description

          @jvsena42

          Summary

          On Android production (arm64-v8a, ldk-node-android 0.7.0-rc.52) we see a recurring SIGABRT caused by a tokio panic:

          Cannot drop a runtime in a context where blocking is not allowed.
          This happens when a runtime is dropped from within an asynchronous context.
          

          Symbolication shows the owned tokio Runtime is dropped by an ldk-node chain-sync background task while that task is running on a worker thread of the very runtime being dropped. Release builds are panic = abort, so this terminates the app process with no catchable error.

          Tracked downstream as synonymdev/bitkit-android#982 (top production crash cluster, mainnet 2.2.0 → 2.4.0).

          Symbolicated stack

          Symbolicated with the unstripped arm64-v8a/libldk_node.so from the native-debug-symbols artifact of com.synonym:ldk-node-android:0.7.0-rc.52 (.text vaddr 0x551980, size 0x7d16ec, matching the packaged library byte-for-byte).

          #35 std::thread lifecycle → tokio-1.52.3 runtime/blocking/pool.rs:161 (tokio worker thread)
          #28 tokio runtime/scheduler/multi_thread/worker.rs:503
          #27 tokio runtime/scheduler/multi_thread/worker.rs:537 run
          #23 tokio runtime/task/raw.rs:267 poll
          #19 ldk_node::runtime::Runtime::spawn_background_task
          <Node::spawn_chain_sync_task_with_receiver> src/runtime.rs:73
          #18 async block src/lib.rs
          #17 async fn src/chain/mod.rs:766
          #16 async fn src/chain/mod.rs:913
          #15 async fn src/chain/electrum.rs:307 (from :121)
          #14 drop_slow<ldk_node::chain::electrum::ElectrumRuntimeClient> ← last Arc released here
          #13 drop_in_place<ldk_node::runtime::Runtime / ldk_node::runtime::RuntimeMode>
          #12 drop_in_place<tokio::runtime::Runtime → tokio::runtime::blocking::pool::BlockingPool>
          #11 tokio runtime/blocking/shutdown.rs:51 wait → panic
          #10 core::panicking::panic_fmt
          #04 __rust_start_panic (panic_abort)
          #03 __rust_abort → #02 std::process::abort → #01 abort_internal → SIGABRT
          

          Line numbers are from the rc.52 build; the structure is unchanged on main.

          Analysis

          ldk_node::runtime::Runtime can own the tokio runtime outright (src/runtime.rs):

          let mode = match tokio::runtime::Handle::try_current(){Ok(handle) => RuntimeMode::Handle(handle),Err(_) => {let rt = tokio::runtime::Builder::new_multi_thread().enable_all().build()?;RuntimeMode::Owned(rt)// <-- owned runtime},};

          On Android the Node is built from a plain JNI/UniFFI thread with no ambient tokio context, so RuntimeMode::Owned is always the branch taken.

          ElectrumRuntimeClient holds a strong reference to it (src/chain/electrum.rs:601):

          structElectrumRuntimeClient{electrum_client:Arc<ElectrumClient>,bdk_electrum_client:Arc<BdkElectrumClient<Arc<ElectrumClient>>>,tx_sync:Arc<ElectrumSyncClient<Arc<Logger>>>,runtime:Arc<Runtime>,// <-- keeps the owned runtime aliveconfig:Arc<Config>,logger:Arc<Logger>,}

          and sync paths take their own clone out of the status before awaiting (src/chain/electrum.rs:575):

          fnclient(&self) -> Option<Arc<ElectrumRuntimeClient>>{matchself{Self::Started(client) => Some(Arc::clone(&client)),Self::Stopped{ .. } => None,}}

          while teardown simply releases the status's own reference (src/chain/electrum.rs:571):

          pub(super)fnstop(&mutself){*self = Self::new()}

          That produces the race:

          1. The chain-sync background task, spawned via Runtime::spawn_background_task, is executing on a worker thread of the owned runtime and holds an Arc<ElectrumRuntimeClient> clone.
          2. Teardown (ElectrumRuntimeStatus::stop, or any other path releasing the status) drops the status's Arc, so the running task now holds the last reference.
          3. The task finishes; its clone drops → ElectrumRuntimeClient drops → its Arc<Runtime> is the last one → RuntimeMode::Owned(tokio::runtime::Runtime) drops.
          4. tokio::runtime::Runtime::dropBlockingPool::shutdown needs to block, detects it is inside a runtime context, and panics.
          5. panic = abortSIGABRT, whole process gone.

          Nothing on the consumer side can prevent or catch this: the drop happens entirely inside ldk-node's own task on ldk-node's own runtime.

          Impact

          Suggested directions

          1. Never let an owned tokio Runtime be dropped by a task running on it. E.g. have RuntimeMode::Owned drop go through Runtime::shutdown_background() / shutdown_timeout(), or hand the runtime off to a dedicated non-runtime thread for teardown.
          2. Keep runtime ownership out of ElectrumRuntimeClient — hold a tokio::runtime::Handle (or a Weak<Runtime>) there instead of Arc<Runtime>, so a sync task can never own the last reference.
          3. Make teardown deterministic: have stop() await outstanding chain-sync tasks (background_tasks / cancellable_background_tasks are already tracked in JoinSets) before releasing the client, so the final drop happens on the caller's thread rather than a worker.

          Environment

          • ldk-node-android0.7.0-rc.52 (also present on main / v0.7.0 by inspection), tokio 1.52.3
          • Android arm64-v8a, Android 13–16, release profile (panic = abort)
          • Consumer: Bitkit Android 2.4.0 (mainnet, to.bitkit)

          Note on symbolication

          Play cannot symbolicate any of this itself: the published libldk_node.so carries no GNU build-id, which is the key Play uses to pair an uploaded native debug symbol file with the crashing library. That is why the stack above had to be resolved by hand. Tracked separately in #95.

          Metadata

          Metadata

          Assignees

          Labels

          No labels
          No labels

          Type

          Projects

          No projects

            Milestone

            No milestone

            Relationships

            None yet

            Development

            No branches or pull requests

            Issue actions

            , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
            Skip to content

            SIGABRT: owned tokio Runtime dropped from its own worker thread during chain sync teardown #94

            Description

            @jvsena42

            Summary

            On Android production (arm64-v8a, ldk-node-android 0.7.0-rc.52) we see a recurring SIGABRT caused by a tokio panic:

            Cannot drop a runtime in a context where blocking is not allowed.
            This happens when a runtime is dropped from within an asynchronous context.
            

            Symbolication shows the owned tokio Runtime is dropped by an ldk-node chain-sync background task while that task is running on a worker thread of the very runtime being dropped. Release builds are panic = abort, so this terminates the app process with no catchable error.

            Tracked downstream as synonymdev/bitkit-android#982 (top production crash cluster, mainnet 2.2.0 → 2.4.0).

            Symbolicated stack

            Symbolicated with the unstripped arm64-v8a/libldk_node.so from the native-debug-symbols artifact of com.synonym:ldk-node-android:0.7.0-rc.52 (.text vaddr 0x551980, size 0x7d16ec, matching the packaged library byte-for-byte).

            #35 std::thread lifecycle → tokio-1.52.3 runtime/blocking/pool.rs:161 (tokio worker thread)
            #28 tokio runtime/scheduler/multi_thread/worker.rs:503
            #27 tokio runtime/scheduler/multi_thread/worker.rs:537 run
            #23 tokio runtime/task/raw.rs:267 poll
            #19 ldk_node::runtime::Runtime::spawn_background_task
            <Node::spawn_chain_sync_task_with_receiver> src/runtime.rs:73
            #18 async block src/lib.rs
            #17 async fn src/chain/mod.rs:766
            #16 async fn src/chain/mod.rs:913
            #15 async fn src/chain/electrum.rs:307 (from :121)
            #14 drop_slow<ldk_node::chain::electrum::ElectrumRuntimeClient> ← last Arc released here
            #13 drop_in_place<ldk_node::runtime::Runtime / ldk_node::runtime::RuntimeMode>
            #12 drop_in_place<tokio::runtime::Runtime → tokio::runtime::blocking::pool::BlockingPool>
            #11 tokio runtime/blocking/shutdown.rs:51 wait → panic
            #10 core::panicking::panic_fmt
            #04 __rust_start_panic (panic_abort)
            #03 __rust_abort → #02 std::process::abort → #01 abort_internal → SIGABRT
            

            Line numbers are from the rc.52 build; the structure is unchanged on main.

            Analysis

            ldk_node::runtime::Runtime can own the tokio runtime outright (src/runtime.rs):

            let mode = match tokio::runtime::Handle::try_current(){Ok(handle) => RuntimeMode::Handle(handle),Err(_) => {let rt = tokio::runtime::Builder::new_multi_thread().enable_all().build()?;RuntimeMode::Owned(rt)// <-- owned runtime},};

            On Android the Node is built from a plain JNI/UniFFI thread with no ambient tokio context, so RuntimeMode::Owned is always the branch taken.

            ElectrumRuntimeClient holds a strong reference to it (src/chain/electrum.rs:601):

            structElectrumRuntimeClient{electrum_client:Arc<ElectrumClient>,bdk_electrum_client:Arc<BdkElectrumClient<Arc<ElectrumClient>>>,tx_sync:Arc<ElectrumSyncClient<Arc<Logger>>>,runtime:Arc<Runtime>,// <-- keeps the owned runtime aliveconfig:Arc<Config>,logger:Arc<Logger>,}

            and sync paths take their own clone out of the status before awaiting (src/chain/electrum.rs:575):

            fnclient(&self) -> Option<Arc<ElectrumRuntimeClient>>{matchself{Self::Started(client) => Some(Arc::clone(&client)),Self::Stopped{ .. } => None,}}

            while teardown simply releases the status's own reference (src/chain/electrum.rs:571):

            pub(super)fnstop(&mutself){*self = Self::new()}

            That produces the race:

            1. The chain-sync background task, spawned via Runtime::spawn_background_task, is executing on a worker thread of the owned runtime and holds an Arc<ElectrumRuntimeClient> clone.
            2. Teardown (ElectrumRuntimeStatus::stop, or any other path releasing the status) drops the status's Arc, so the running task now holds the last reference.
            3. The task finishes; its clone drops → ElectrumRuntimeClient drops → its Arc<Runtime> is the last one → RuntimeMode::Owned(tokio::runtime::Runtime) drops.
            4. tokio::runtime::Runtime::dropBlockingPool::shutdown needs to block, detects it is inside a runtime context, and panics.
            5. panic = abortSIGABRT, whole process gone.

            Nothing on the consumer side can prevent or catch this: the drop happens entirely inside ldk-node's own task on ldk-node's own runtime.

            Impact

            Suggested directions

            1. Never let an owned tokio Runtime be dropped by a task running on it. E.g. have RuntimeMode::Owned drop go through Runtime::shutdown_background() / shutdown_timeout(), or hand the runtime off to a dedicated non-runtime thread for teardown.
            2. Keep runtime ownership out of ElectrumRuntimeClient — hold a tokio::runtime::Handle (or a Weak<Runtime>) there instead of Arc<Runtime>, so a sync task can never own the last reference.
            3. Make teardown deterministic: have stop() await outstanding chain-sync tasks (background_tasks / cancellable_background_tasks are already tracked in JoinSets) before releasing the client, so the final drop happens on the caller's thread rather than a worker.

            Environment

            • ldk-node-android0.7.0-rc.52 (also present on main / v0.7.0 by inspection), tokio 1.52.3
            • Android arm64-v8a, Android 13–16, release profile (panic = abort)
            • Consumer: Bitkit Android 2.4.0 (mainnet, to.bitkit)

            Note on symbolication

            Play cannot symbolicate any of this itself: the published libldk_node.so carries no GNU build-id, which is the key Play uses to pair an uploaded native debug symbol file with the crashing library. That is why the stack above had to be resolved by hand. Tracked separately in #95.

            Metadata

            Metadata

            Assignees

            Labels

            No labels
            No labels

            Type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              SIGABRT: owned tokio Runtime dropped from its own worker thread during chain sync teardown #94

              Description

              @jvsena42

              Summary

              On Android production (arm64-v8a, ldk-node-android 0.7.0-rc.52) we see a recurring SIGABRT caused by a tokio panic:

              Cannot drop a runtime in a context where blocking is not allowed.
              This happens when a runtime is dropped from within an asynchronous context.
              

              Symbolication shows the owned tokio Runtime is dropped by an ldk-node chain-sync background task while that task is running on a worker thread of the very runtime being dropped. Release builds are panic = abort, so this terminates the app process with no catchable error.

              Tracked downstream as synonymdev/bitkit-android#982 (top production crash cluster, mainnet 2.2.0 → 2.4.0).

              Symbolicated stack

              Symbolicated with the unstripped arm64-v8a/libldk_node.so from the native-debug-symbols artifact of com.synonym:ldk-node-android:0.7.0-rc.52 (.text vaddr 0x551980, size 0x7d16ec, matching the packaged library byte-for-byte).

              #35 std::thread lifecycle → tokio-1.52.3 runtime/blocking/pool.rs:161 (tokio worker thread)
              #28 tokio runtime/scheduler/multi_thread/worker.rs:503
              #27 tokio runtime/scheduler/multi_thread/worker.rs:537 run
              #23 tokio runtime/task/raw.rs:267 poll
              #19 ldk_node::runtime::Runtime::spawn_background_task
              <Node::spawn_chain_sync_task_with_receiver> src/runtime.rs:73
              #18 async block src/lib.rs
              #17 async fn src/chain/mod.rs:766
              #16 async fn src/chain/mod.rs:913
              #15 async fn src/chain/electrum.rs:307 (from :121)
              #14 drop_slow<ldk_node::chain::electrum::ElectrumRuntimeClient> ← last Arc released here
              #13 drop_in_place<ldk_node::runtime::Runtime / ldk_node::runtime::RuntimeMode>
              #12 drop_in_place<tokio::runtime::Runtime → tokio::runtime::blocking::pool::BlockingPool>
              #11 tokio runtime/blocking/shutdown.rs:51 wait → panic
              #10 core::panicking::panic_fmt
              #04 __rust_start_panic (panic_abort)
              #03 __rust_abort → #02 std::process::abort → #01 abort_internal → SIGABRT
              

              Line numbers are from the rc.52 build; the structure is unchanged on main.

              Analysis

              ldk_node::runtime::Runtime can own the tokio runtime outright (src/runtime.rs):

              let mode = match tokio::runtime::Handle::try_current(){Ok(handle) => RuntimeMode::Handle(handle),Err(_) => {let rt = tokio::runtime::Builder::new_multi_thread().enable_all().build()?;RuntimeMode::Owned(rt)// <-- owned runtime},};

              On Android the Node is built from a plain JNI/UniFFI thread with no ambient tokio context, so RuntimeMode::Owned is always the branch taken.

              ElectrumRuntimeClient holds a strong reference to it (src/chain/electrum.rs:601):

              structElectrumRuntimeClient{electrum_client:Arc<ElectrumClient>,bdk_electrum_client:Arc<BdkElectrumClient<Arc<ElectrumClient>>>,tx_sync:Arc<ElectrumSyncClient<Arc<Logger>>>,runtime:Arc<Runtime>,// <-- keeps the owned runtime aliveconfig:Arc<Config>,logger:Arc<Logger>,}

              and sync paths take their own clone out of the status before awaiting (src/chain/electrum.rs:575):

              fnclient(&self) -> Option<Arc<ElectrumRuntimeClient>>{matchself{Self::Started(client) => Some(Arc::clone(&client)),Self::Stopped{ .. } => None,}}

              while teardown simply releases the status's own reference (src/chain/electrum.rs:571):

              pub(super)fnstop(&mutself){*self = Self::new()}

              That produces the race:

              1. The chain-sync background task, spawned via Runtime::spawn_background_task, is executing on a worker thread of the owned runtime and holds an Arc<ElectrumRuntimeClient> clone.
              2. Teardown (ElectrumRuntimeStatus::stop, or any other path releasing the status) drops the status's Arc, so the running task now holds the last reference.
              3. The task finishes; its clone drops → ElectrumRuntimeClient drops → its Arc<Runtime> is the last one → RuntimeMode::Owned(tokio::runtime::Runtime) drops.
              4. tokio::runtime::Runtime::dropBlockingPool::shutdown needs to block, detects it is inside a runtime context, and panics.
              5. panic = abortSIGABRT, whole process gone.

              Nothing on the consumer side can prevent or catch this: the drop happens entirely inside ldk-node's own task on ldk-node's own runtime.

              Impact

              Suggested directions

              1. Never let an owned tokio Runtime be dropped by a task running on it. E.g. have RuntimeMode::Owned drop go through Runtime::shutdown_background() / shutdown_timeout(), or hand the runtime off to a dedicated non-runtime thread for teardown.
              2. Keep runtime ownership out of ElectrumRuntimeClient — hold a tokio::runtime::Handle (or a Weak<Runtime>) there instead of Arc<Runtime>, so a sync task can never own the last reference.
              3. Make teardown deterministic: have stop() await outstanding chain-sync tasks (background_tasks / cancellable_background_tasks are already tracked in JoinSets) before releasing the client, so the final drop happens on the caller's thread rather than a worker.

              Environment

              • ldk-node-android0.7.0-rc.52 (also present on main / v0.7.0 by inspection), tokio 1.52.3
              • Android arm64-v8a, Android 13–16, release profile (panic = abort)
              • Consumer: Bitkit Android 2.4.0 (mainnet, to.bitkit)

              Note on symbolication

              Play cannot symbolicate any of this itself: the published libldk_node.so carries no GNU build-id, which is the key Play uses to pair an uploaded native debug symbol file with the crashing library. That is why the stack above had to be resolved by hand. Tracked separately in #95.

              Metadata

              Metadata

              Assignees

              Labels

              No labels
              No labels

              Type

              Projects

              No projects

                Milestone

                No milestone

                Relationships

                None yet

                Development

                No branches or pull requests

                Issue actions

                , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                Skip to content

                SIGABRT: owned tokio Runtime dropped from its own worker thread during chain sync teardown #94

                Description

                @jvsena42

                Summary

                On Android production (arm64-v8a, ldk-node-android 0.7.0-rc.52) we see a recurring SIGABRT caused by a tokio panic:

                Cannot drop a runtime in a context where blocking is not allowed.
                This happens when a runtime is dropped from within an asynchronous context.
                

                Symbolication shows the owned tokio Runtime is dropped by an ldk-node chain-sync background task while that task is running on a worker thread of the very runtime being dropped. Release builds are panic = abort, so this terminates the app process with no catchable error.

                Tracked downstream as synonymdev/bitkit-android#982 (top production crash cluster, mainnet 2.2.0 → 2.4.0).

                Symbolicated stack

                Symbolicated with the unstripped arm64-v8a/libldk_node.so from the native-debug-symbols artifact of com.synonym:ldk-node-android:0.7.0-rc.52 (.text vaddr 0x551980, size 0x7d16ec, matching the packaged library byte-for-byte).

                #35 std::thread lifecycle → tokio-1.52.3 runtime/blocking/pool.rs:161 (tokio worker thread)
                #28 tokio runtime/scheduler/multi_thread/worker.rs:503
                #27 tokio runtime/scheduler/multi_thread/worker.rs:537 run
                #23 tokio runtime/task/raw.rs:267 poll
                #19 ldk_node::runtime::Runtime::spawn_background_task
                <Node::spawn_chain_sync_task_with_receiver> src/runtime.rs:73
                #18 async block src/lib.rs
                #17 async fn src/chain/mod.rs:766
                #16 async fn src/chain/mod.rs:913
                #15 async fn src/chain/electrum.rs:307 (from :121)
                #14 drop_slow<ldk_node::chain::electrum::ElectrumRuntimeClient> ← last Arc released here
                #13 drop_in_place<ldk_node::runtime::Runtime / ldk_node::runtime::RuntimeMode>
                #12 drop_in_place<tokio::runtime::Runtime → tokio::runtime::blocking::pool::BlockingPool>
                #11 tokio runtime/blocking/shutdown.rs:51 wait → panic
                #10 core::panicking::panic_fmt
                #04 __rust_start_panic (panic_abort)
                #03 __rust_abort → #02 std::process::abort → #01 abort_internal → SIGABRT
                

                Line numbers are from the rc.52 build; the structure is unchanged on main.

                Analysis

                ldk_node::runtime::Runtime can own the tokio runtime outright (src/runtime.rs):

                let mode = match tokio::runtime::Handle::try_current(){Ok(handle) => RuntimeMode::Handle(handle),Err(_) => {let rt = tokio::runtime::Builder::new_multi_thread().enable_all().build()?;RuntimeMode::Owned(rt)// <-- owned runtime},};

                On Android the Node is built from a plain JNI/UniFFI thread with no ambient tokio context, so RuntimeMode::Owned is always the branch taken.

                ElectrumRuntimeClient holds a strong reference to it (src/chain/electrum.rs:601):

                structElectrumRuntimeClient{electrum_client:Arc<ElectrumClient>,bdk_electrum_client:Arc<BdkElectrumClient<Arc<ElectrumClient>>>,tx_sync:Arc<ElectrumSyncClient<Arc<Logger>>>,runtime:Arc<Runtime>,// <-- keeps the owned runtime aliveconfig:Arc<Config>,logger:Arc<Logger>,}

                and sync paths take their own clone out of the status before awaiting (src/chain/electrum.rs:575):

                fnclient(&self) -> Option<Arc<ElectrumRuntimeClient>>{matchself{Self::Started(client) => Some(Arc::clone(&client)),Self::Stopped{ .. } => None,}}

                while teardown simply releases the status's own reference (src/chain/electrum.rs:571):

                pub(super)fnstop(&mutself){*self = Self::new()}

                That produces the race:

                1. The chain-sync background task, spawned via Runtime::spawn_background_task, is executing on a worker thread of the owned runtime and holds an Arc<ElectrumRuntimeClient> clone.
                2. Teardown (ElectrumRuntimeStatus::stop, or any other path releasing the status) drops the status's Arc, so the running task now holds the last reference.
                3. The task finishes; its clone drops → ElectrumRuntimeClient drops → its Arc<Runtime> is the last one → RuntimeMode::Owned(tokio::runtime::Runtime) drops.
                4. tokio::runtime::Runtime::dropBlockingPool::shutdown needs to block, detects it is inside a runtime context, and panics.
                5. panic = abortSIGABRT, whole process gone.

                Nothing on the consumer side can prevent or catch this: the drop happens entirely inside ldk-node's own task on ldk-node's own runtime.

                Impact

                Suggested directions

                1. Never let an owned tokio Runtime be dropped by a task running on it. E.g. have RuntimeMode::Owned drop go through Runtime::shutdown_background() / shutdown_timeout(), or hand the runtime off to a dedicated non-runtime thread for teardown.
                2. Keep runtime ownership out of ElectrumRuntimeClient — hold a tokio::runtime::Handle (or a Weak<Runtime>) there instead of Arc<Runtime>, so a sync task can never own the last reference.
                3. Make teardown deterministic: have stop() await outstanding chain-sync tasks (background_tasks / cancellable_background_tasks are already tracked in JoinSets) before releasing the client, so the final drop happens on the caller's thread rather than a worker.

                Environment

                • ldk-node-android0.7.0-rc.52 (also present on main / v0.7.0 by inspection), tokio 1.52.3
                • Android arm64-v8a, Android 13–16, release profile (panic = abort)
                • Consumer: Bitkit Android 2.4.0 (mainnet, to.bitkit)

                Note on symbolication

                Play cannot symbolicate any of this itself: the published libldk_node.so carries no GNU build-id, which is the key Play uses to pair an uploaded native debug symbol file with the crashing library. That is why the stack above had to be resolved by hand. Tracked separately in #95.

                Metadata

                Metadata

                Assignees

                Labels

                No labels
                No labels

                Type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions