fix: release peer lock before persistence

[ovitrif]

Fixes#99

Related to synonymdev/bitkit-android#986.
Addresses the Node.listPeers ANR tracked in synonymdev/bitkit-android#1036.

Summary

• Backport Fully switch to async KVStore persistence lightningdevkit/ldk-node#919's async KVStore peer-persistence design.
• Serialize peer mutations with a Tokio mutex, encode each snapshot under the peer RwLock, and release that lock before awaiting persistence.
• Preserve fork address updates, RGS recovery exclusion ordering, and retryable add, address-update, and removal failures.
• Make explicit disconnect succeed only after durable peer removal; persistence failures keep the peer connected and remain retryable.
• Bridge synchronous node APIs at the runtime boundary while async event and recovery paths await persistence directly.
• Prepare Rust and mobile binding artifacts as 0.7.0-rc.62.

Validation

• Local verification: cargo fmt --check, git diff --check, and cargo test --features uniffi --lib (94 passed).
• Binding verification: ./bindgen.sh completed for JVM Kotlin, Python, Swift, and Android; JVM Gradle, Swift framework assembly, Android three-ABI build-ID, 16 KiB alignment, debug-symbol, stripped-library, and AAR checks passed.
• Swift archive verification: SHA-256 40907bc5d61d85492a9f22722c1009791255ed0da40577765f49d486ebb41e9c matches Package.swift and the uploaded release asset.

QA Notes

• Originally stacked on fix: prevent electrum runtime self-drop #100 at 080b5f2.
• Synchronous peer reads remain available while async persistence is pending.
• Failed persistence restores the previous in-memory state so the mutation can be retried.
• Explicit disconnect returns a peer-removal persistence failure and keeps the live peer connected.

Release

• v0.7.0-rc.62

[ovitrif]

Follow-up after merge:

• This PR remained based on fix/94-sigabrt-runtime-drop after fix: prevent electrum runtime self-drop #100 merged into main. Its merge therefore advanced that already-merged branch rather than the default branch.
• I preserved the previous main tip 0533c40 at backup/main-before-pr-101-recovery-20260801.
• I preserved the stacked branch tip 60c4c4d at backup/pr-101-stack-before-main-recovery-20260801.
• I reconciled both histories into main with f929ec2 so the default branch now contains the exact tree shipped in v0.7.0-rc.62.
• Local verification: cargo test --features uniffi --lib passed all 94 tests, and the resulting tree matches the reviewed rc.62 tree exactly.
• The published v0.7.0-rc.62 release and annotated tag remain unchanged at 6fddf6f.
• I deleted the obsolete fix/94-sigabrt-runtime-drop branch after verifying both recovery refs and the new main.
• I manually enabled Automatically delete head branches in repository settings to prevent merged head branches from lingering.
• fix: release peer lock before persistence #99 is closed as completed now that the fix is present on main.

[ovitrif]

Fixes#99

Related to synonymdev/bitkit-android#986.
Addresses the Node.listPeers ANR tracked in synonymdev/bitkit-android#1036.

Summary

• Backport Fully switch to async KVStore persistence lightningdevkit/ldk-node#919's async KVStore peer-persistence design.
• Serialize peer mutations with a Tokio mutex, encode each snapshot under the peer RwLock, and release that lock before awaiting persistence.
• Preserve fork address updates, RGS recovery exclusion ordering, and retryable add, address-update, and removal failures.
• Make explicit disconnect succeed only after durable peer removal; persistence failures keep the peer connected and remain retryable.
• Bridge synchronous node APIs at the runtime boundary while async event and recovery paths await persistence directly.
• Prepare Rust and mobile binding artifacts as 0.7.0-rc.62.

Validation

• Local verification: cargo fmt --check, git diff --check, and cargo test --features uniffi --lib (94 passed).
• Binding verification: ./bindgen.sh completed for JVM Kotlin, Python, Swift, and Android; JVM Gradle, Swift framework assembly, Android three-ABI build-ID, 16 KiB alignment, debug-symbol, stripped-library, and AAR checks passed.
• Swift archive verification: SHA-256 40907bc5d61d85492a9f22722c1009791255ed0da40577765f49d486ebb41e9c matches Package.swift and the uploaded release asset.

QA Notes

• Originally stacked on fix: prevent electrum runtime self-drop #100 at 080b5f2.
• Synchronous peer reads remain available while async persistence is pending.
• Failed persistence restores the previous in-memory state so the mutation can be retried.
• Explicit disconnect returns a peer-removal persistence failure and keeps the live peer connected.

Release

• v0.7.0-rc.62

[ovitrif]

Follow-up after merge:

• This PR remained based on fix/94-sigabrt-runtime-drop after fix: prevent electrum runtime self-drop #100 merged into main. Its merge therefore advanced that already-merged branch rather than the default branch.
• I preserved the previous main tip 0533c40 at backup/main-before-pr-101-recovery-20260801.
• I preserved the stacked branch tip 60c4c4d at backup/pr-101-stack-before-main-recovery-20260801.
• I reconciled both histories into main with f929ec2 so the default branch now contains the exact tree shipped in v0.7.0-rc.62.
• Local verification: cargo test --features uniffi --lib passed all 94 tests, and the resulting tree matches the reviewed rc.62 tree exactly.
• The published v0.7.0-rc.62 release and annotated tag remain unchanged at 6fddf6f.
• I deleted the obsolete fix/94-sigabrt-runtime-drop branch after verifying both recovery refs and the new main.
• I manually enabled Automatically delete head branches in repository settings to prevent merged head branches from lingering.
• fix: release peer lock before persistence #99 is closed as completed now that the fix is present on main.

[ovitrif]

Fixes#99

Related to synonymdev/bitkit-android#986.
Addresses the Node.listPeers ANR tracked in synonymdev/bitkit-android#1036.

Summary

• Backport Fully switch to async KVStore persistence lightningdevkit/ldk-node#919's async KVStore peer-persistence design.
• Serialize peer mutations with a Tokio mutex, encode each snapshot under the peer RwLock, and release that lock before awaiting persistence.
• Preserve fork address updates, RGS recovery exclusion ordering, and retryable add, address-update, and removal failures.
• Make explicit disconnect succeed only after durable peer removal; persistence failures keep the peer connected and remain retryable.
• Bridge synchronous node APIs at the runtime boundary while async event and recovery paths await persistence directly.
• Prepare Rust and mobile binding artifacts as 0.7.0-rc.62.

Validation

• Local verification: cargo fmt --check, git diff --check, and cargo test --features uniffi --lib (94 passed).
• Binding verification: ./bindgen.sh completed for JVM Kotlin, Python, Swift, and Android; JVM Gradle, Swift framework assembly, Android three-ABI build-ID, 16 KiB alignment, debug-symbol, stripped-library, and AAR checks passed.
• Swift archive verification: SHA-256 40907bc5d61d85492a9f22722c1009791255ed0da40577765f49d486ebb41e9c matches Package.swift and the uploaded release asset.

QA Notes

• Originally stacked on fix: prevent electrum runtime self-drop #100 at 080b5f2.
• Synchronous peer reads remain available while async persistence is pending.
• Failed persistence restores the previous in-memory state so the mutation can be retried.
• Explicit disconnect returns a peer-removal persistence failure and keeps the live peer connected.

Release

• v0.7.0-rc.62

[ovitrif]

Follow-up after merge:

• This PR remained based on fix/94-sigabrt-runtime-drop after fix: prevent electrum runtime self-drop #100 merged into main. Its merge therefore advanced that already-merged branch rather than the default branch.
• I preserved the previous main tip 0533c40 at backup/main-before-pr-101-recovery-20260801.
• I preserved the stacked branch tip 60c4c4d at backup/pr-101-stack-before-main-recovery-20260801.
• I reconciled both histories into main with f929ec2 so the default branch now contains the exact tree shipped in v0.7.0-rc.62.
• Local verification: cargo test --features uniffi --lib passed all 94 tests, and the resulting tree matches the reviewed rc.62 tree exactly.
• The published v0.7.0-rc.62 release and annotated tag remain unchanged at 6fddf6f.
• I deleted the obsolete fix/94-sigabrt-runtime-drop branch after verifying both recovery refs and the new main.
• I manually enabled Automatically delete head branches in repository settings to prevent merged head branches from lingering.
• fix: release peer lock before persistence #99 is closed as completed now that the fix is present on main.

[ovitrif]

Fixes#99

Related to synonymdev/bitkit-android#986.
Addresses the Node.listPeers ANR tracked in synonymdev/bitkit-android#1036.

Summary

• Backport Fully switch to async KVStore persistence lightningdevkit/ldk-node#919's async KVStore peer-persistence design.
• Serialize peer mutations with a Tokio mutex, encode each snapshot under the peer RwLock, and release that lock before awaiting persistence.
• Preserve fork address updates, RGS recovery exclusion ordering, and retryable add, address-update, and removal failures.
• Make explicit disconnect succeed only after durable peer removal; persistence failures keep the peer connected and remain retryable.
• Bridge synchronous node APIs at the runtime boundary while async event and recovery paths await persistence directly.
• Prepare Rust and mobile binding artifacts as 0.7.0-rc.62.

Validation

• Local verification: cargo fmt --check, git diff --check, and cargo test --features uniffi --lib (94 passed).
• Binding verification: ./bindgen.sh completed for JVM Kotlin, Python, Swift, and Android; JVM Gradle, Swift framework assembly, Android three-ABI build-ID, 16 KiB alignment, debug-symbol, stripped-library, and AAR checks passed.
• Swift archive verification: SHA-256 40907bc5d61d85492a9f22722c1009791255ed0da40577765f49d486ebb41e9c matches Package.swift and the uploaded release asset.

QA Notes

• Originally stacked on fix: prevent electrum runtime self-drop #100 at 080b5f2.
• Synchronous peer reads remain available while async persistence is pending.
• Failed persistence restores the previous in-memory state so the mutation can be retried.
• Explicit disconnect returns a peer-removal persistence failure and keeps the live peer connected.

Release

• v0.7.0-rc.62

[ovitrif]

Follow-up after merge:

• This PR remained based on fix/94-sigabrt-runtime-drop after fix: prevent electrum runtime self-drop #100 merged into main. Its merge therefore advanced that already-merged branch rather than the default branch.
• I preserved the previous main tip 0533c40 at backup/main-before-pr-101-recovery-20260801.
• I preserved the stacked branch tip 60c4c4d at backup/pr-101-stack-before-main-recovery-20260801.
• I reconciled both histories into main with f929ec2 so the default branch now contains the exact tree shipped in v0.7.0-rc.62.
• Local verification: cargo test --features uniffi --lib passed all 94 tests, and the resulting tree matches the reviewed rc.62 tree exactly.
• The published v0.7.0-rc.62 release and annotated tag remain unchanged at 6fddf6f.
• I deleted the obsolete fix/94-sigabrt-runtime-drop branch after verifying both recovery refs and the new main.
• I manually enabled Automatically delete head branches in repository settings to prevent merged head branches from lingering.
• fix: release peer lock before persistence #99 is closed as completed now that the fix is present on main.

[ovitrif]

Fixes#99

Related to synonymdev/bitkit-android#986.
Addresses the Node.listPeers ANR tracked in synonymdev/bitkit-android#1036.

Summary

• Backport Fully switch to async KVStore persistence lightningdevkit/ldk-node#919's async KVStore peer-persistence design.
• Serialize peer mutations with a Tokio mutex, encode each snapshot under the peer RwLock, and release that lock before awaiting persistence.
• Preserve fork address updates, RGS recovery exclusion ordering, and retryable add, address-update, and removal failures.
• Make explicit disconnect succeed only after durable peer removal; persistence failures keep the peer connected and remain retryable.
• Bridge synchronous node APIs at the runtime boundary while async event and recovery paths await persistence directly.
• Prepare Rust and mobile binding artifacts as 0.7.0-rc.62.

Validation

• Local verification: cargo fmt --check, git diff --check, and cargo test --features uniffi --lib (94 passed).
• Binding verification: ./bindgen.sh completed for JVM Kotlin, Python, Swift, and Android; JVM Gradle, Swift framework assembly, Android three-ABI build-ID, 16 KiB alignment, debug-symbol, stripped-library, and AAR checks passed.
• Swift archive verification: SHA-256 40907bc5d61d85492a9f22722c1009791255ed0da40577765f49d486ebb41e9c matches Package.swift and the uploaded release asset.

QA Notes

• Originally stacked on fix: prevent electrum runtime self-drop #100 at 080b5f2.
• Synchronous peer reads remain available while async persistence is pending.
• Failed persistence restores the previous in-memory state so the mutation can be retried.
• Explicit disconnect returns a peer-removal persistence failure and keeps the live peer connected.

Release

• v0.7.0-rc.62

[ovitrif]

Follow-up after merge:

• This PR remained based on fix/94-sigabrt-runtime-drop after fix: prevent electrum runtime self-drop #100 merged into main. Its merge therefore advanced that already-merged branch rather than the default branch.
• I preserved the previous main tip 0533c40 at backup/main-before-pr-101-recovery-20260801.
• I preserved the stacked branch tip 60c4c4d at backup/pr-101-stack-before-main-recovery-20260801.
• I reconciled both histories into main with f929ec2 so the default branch now contains the exact tree shipped in v0.7.0-rc.62.
• Local verification: cargo test --features uniffi --lib passed all 94 tests, and the resulting tree matches the reviewed rc.62 tree exactly.
• The published v0.7.0-rc.62 release and annotated tag remain unchanged at 6fddf6f.
• I deleted the obsolete fix/94-sigabrt-runtime-drop branch after verifying both recovery refs and the new main.
• I manually enabled Automatically delete head branches in repository settings to prevent merged head branches from lingering.
• fix: release peer lock before persistence #99 is closed as completed now that the fix is present on main.

[ovitrif]

Fixes#99

Related to synonymdev/bitkit-android#986.
Addresses the Node.listPeers ANR tracked in synonymdev/bitkit-android#1036.

Summary

• Backport Fully switch to async KVStore persistence lightningdevkit/ldk-node#919's async KVStore peer-persistence design.
• Serialize peer mutations with a Tokio mutex, encode each snapshot under the peer RwLock, and release that lock before awaiting persistence.
• Preserve fork address updates, RGS recovery exclusion ordering, and retryable add, address-update, and removal failures.
• Make explicit disconnect succeed only after durable peer removal; persistence failures keep the peer connected and remain retryable.
• Bridge synchronous node APIs at the runtime boundary while async event and recovery paths await persistence directly.
• Prepare Rust and mobile binding artifacts as 0.7.0-rc.62.

Validation

• Local verification: cargo fmt --check, git diff --check, and cargo test --features uniffi --lib (94 passed).
• Binding verification: ./bindgen.sh completed for JVM Kotlin, Python, Swift, and Android; JVM Gradle, Swift framework assembly, Android three-ABI build-ID, 16 KiB alignment, debug-symbol, stripped-library, and AAR checks passed.
• Swift archive verification: SHA-256 40907bc5d61d85492a9f22722c1009791255ed0da40577765f49d486ebb41e9c matches Package.swift and the uploaded release asset.

QA Notes

• Originally stacked on fix: prevent electrum runtime self-drop #100 at 080b5f2.
• Synchronous peer reads remain available while async persistence is pending.
• Failed persistence restores the previous in-memory state so the mutation can be retried.
• Explicit disconnect returns a peer-removal persistence failure and keeps the live peer connected.

Release

• v0.7.0-rc.62

[ovitrif]

Follow-up after merge:

• This PR remained based on fix/94-sigabrt-runtime-drop after fix: prevent electrum runtime self-drop #100 merged into main. Its merge therefore advanced that already-merged branch rather than the default branch.
• I preserved the previous main tip 0533c40 at backup/main-before-pr-101-recovery-20260801.
• I preserved the stacked branch tip 60c4c4d at backup/pr-101-stack-before-main-recovery-20260801.
• I reconciled both histories into main with f929ec2 so the default branch now contains the exact tree shipped in v0.7.0-rc.62.
• Local verification: cargo test --features uniffi --lib passed all 94 tests, and the resulting tree matches the reviewed rc.62 tree exactly.
• The published v0.7.0-rc.62 release and annotated tag remain unchanged at 6fddf6f.
• I deleted the obsolete fix/94-sigabrt-runtime-drop branch after verifying both recovery refs and the new main.
• I manually enabled Automatically delete head branches in repository settings to prevent merged head branches from lingering.
• fix: release peer lock before persistence #99 is closed as completed now that the fix is present on main.

[ovitrif]

Fixes#99

Related to synonymdev/bitkit-android#986.
Addresses the Node.listPeers ANR tracked in synonymdev/bitkit-android#1036.

Summary

• Backport Fully switch to async KVStore persistence lightningdevkit/ldk-node#919's async KVStore peer-persistence design.
• Serialize peer mutations with a Tokio mutex, encode each snapshot under the peer RwLock, and release that lock before awaiting persistence.
• Preserve fork address updates, RGS recovery exclusion ordering, and retryable add, address-update, and removal failures.
• Make explicit disconnect succeed only after durable peer removal; persistence failures keep the peer connected and remain retryable.
• Bridge synchronous node APIs at the runtime boundary while async event and recovery paths await persistence directly.
• Prepare Rust and mobile binding artifacts as 0.7.0-rc.62.

Validation

• Local verification: cargo fmt --check, git diff --check, and cargo test --features uniffi --lib (94 passed).
• Binding verification: ./bindgen.sh completed for JVM Kotlin, Python, Swift, and Android; JVM Gradle, Swift framework assembly, Android three-ABI build-ID, 16 KiB alignment, debug-symbol, stripped-library, and AAR checks passed.
• Swift archive verification: SHA-256 40907bc5d61d85492a9f22722c1009791255ed0da40577765f49d486ebb41e9c matches Package.swift and the uploaded release asset.

QA Notes

• Originally stacked on fix: prevent electrum runtime self-drop #100 at 080b5f2.
• Synchronous peer reads remain available while async persistence is pending.
• Failed persistence restores the previous in-memory state so the mutation can be retried.
• Explicit disconnect returns a peer-removal persistence failure and keeps the live peer connected.

Release

• v0.7.0-rc.62

[ovitrif]

Follow-up after merge:

• This PR remained based on fix/94-sigabrt-runtime-drop after fix: prevent electrum runtime self-drop #100 merged into main. Its merge therefore advanced that already-merged branch rather than the default branch.
• I preserved the previous main tip 0533c40 at backup/main-before-pr-101-recovery-20260801.
• I preserved the stacked branch tip 60c4c4d at backup/pr-101-stack-before-main-recovery-20260801.
• I reconciled both histories into main with f929ec2 so the default branch now contains the exact tree shipped in v0.7.0-rc.62.
• Local verification: cargo test --features uniffi --lib passed all 94 tests, and the resulting tree matches the reviewed rc.62 tree exactly.
• The published v0.7.0-rc.62 release and annotated tag remain unchanged at 6fddf6f.
• I deleted the obsolete fix/94-sigabrt-runtime-drop branch after verifying both recovery refs and the new main.
• I manually enabled Automatically delete head branches in repository settings to prevent merged head branches from lingering.
• fix: release peer lock before persistence #99 is closed as completed now that the fix is present on main.

[ovitrif]

Fixes#99

Related to synonymdev/bitkit-android#986.
Addresses the Node.listPeers ANR tracked in synonymdev/bitkit-android#1036.

Summary

• Backport Fully switch to async KVStore persistence lightningdevkit/ldk-node#919's async KVStore peer-persistence design.
• Serialize peer mutations with a Tokio mutex, encode each snapshot under the peer RwLock, and release that lock before awaiting persistence.
• Preserve fork address updates, RGS recovery exclusion ordering, and retryable add, address-update, and removal failures.
• Make explicit disconnect succeed only after durable peer removal; persistence failures keep the peer connected and remain retryable.
• Bridge synchronous node APIs at the runtime boundary while async event and recovery paths await persistence directly.
• Prepare Rust and mobile binding artifacts as 0.7.0-rc.62.

Validation

• Local verification: cargo fmt --check, git diff --check, and cargo test --features uniffi --lib (94 passed).
• Binding verification: ./bindgen.sh completed for JVM Kotlin, Python, Swift, and Android; JVM Gradle, Swift framework assembly, Android three-ABI build-ID, 16 KiB alignment, debug-symbol, stripped-library, and AAR checks passed.
• Swift archive verification: SHA-256 40907bc5d61d85492a9f22722c1009791255ed0da40577765f49d486ebb41e9c matches Package.swift and the uploaded release asset.

QA Notes

• Originally stacked on fix: prevent electrum runtime self-drop #100 at 080b5f2.
• Synchronous peer reads remain available while async persistence is pending.
• Failed persistence restores the previous in-memory state so the mutation can be retried.
• Explicit disconnect returns a peer-removal persistence failure and keeps the live peer connected.

Release

• v0.7.0-rc.62

[ovitrif]

Follow-up after merge:

• This PR remained based on fix/94-sigabrt-runtime-drop after fix: prevent electrum runtime self-drop #100 merged into main. Its merge therefore advanced that already-merged branch rather than the default branch.
• I preserved the previous main tip 0533c40 at backup/main-before-pr-101-recovery-20260801.
• I preserved the stacked branch tip 60c4c4d at backup/pr-101-stack-before-main-recovery-20260801.
• I reconciled both histories into main with f929ec2 so the default branch now contains the exact tree shipped in v0.7.0-rc.62.
• Local verification: cargo test --features uniffi --lib passed all 94 tests, and the resulting tree matches the reviewed rc.62 tree exactly.
• The published v0.7.0-rc.62 release and annotated tag remain unchanged at 6fddf6f.
• I deleted the obsolete fix/94-sigabrt-runtime-drop branch after verifying both recovery refs and the new main.
• I manually enabled Automatically delete head branches in repository settings to prevent merged head branches from lingering.
• fix: release peer lock before persistence #99 is closed as completed now that the fix is present on main.