fix: prevent channel data overwrite in FS→KV migration#74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovitrif merged 14 commits into from
Mar 16, 2026
Merged

fix: prevent channel data overwrite in FS→KV migration #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e48948f
fix: prevent channel monitor migration from overwriting newer state
ovitrif Mar 9, 2026
7d2ed46
docs: rewrite testing section with correct syntax and setup requirements
ovitrif Mar 9, 2026
530f449
chore: bump version to 0.7.0-rc.33
ovitrif Mar 9, 2026
fdab2be
chore: regenerate bindings for v0.7.0-rc.33
ovitrif Mar 9, 2026
2df9b0a
fix: fail-closed on migration read/deserialize errors
ovitrif Mar 10, 2026
e998973
chore: regenerate bindings for v0.7.0-rc.33
ovitrif Mar 10, 2026
d96e813
fix: regenerate android bindings with correct gobley v0.2.0
ovitrif Mar 10, 2026
630b364
test: add unit tests for channel monitor migration logic
ovitrif Mar 11, 2026
cde6037
fix: skip redundant monitor write when update_id is equal
ovitrif Mar 11, 2026
4f91c8c
fix: guard channel manager migration against overwriting newer state
ovitrif Mar 11, 2026
dc087fb
fix: clarify channel manager migration guard rationale and add corrup…
ovitrif Mar 11, 2026
ad5d519
Merge branch 'main' into fix/channel-monitor-migration
ovitrif Mar 12, 2026
1531af7
chore: reword changelog and regenerate bindings for v0.7.0-rc.33
ovitrif Mar 12, 2026
ffc0ec5
fix: simplify channel manager migration comment
ovitrif Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 45 additions & 8 deletions AGENTS.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,20 +21,56 @@ cargo build --profile=release-smaller
```

### Testing

#### Unit tests (no external infrastructure needed)
```bash
cargo test --lib
```

#### Standard integration tests
Uses the `electrsd` crate to auto-download and spawn `bitcoind` + `electrs` binaries.
To use pre-downloaded binaries, set `BITCOIND_EXE` and `ELECTRS_EXE` env vars.

On macOS, the default file descriptor limit (256) is too low for spawning `bitcoind` +
`electrs`. Raise it before running integration tests:

Test files: `tests/integration_tests_rust.rs`, `tests/reorg_test.rs`,
`tests/multi_address_types_tests.rs`

```bash
# Run all tests
cargo test
ulimit -n 10240 && cargo test
```

# Run a specific test
#### Run a specific test
```bash
cargo test test_name
```

# Run tests with specific features
#### Run tests with UniFFI bindings feature
```bash
cargo test --features "uniffi"
```

#### CLN integration tests
Requires Docker and `socat` for RPC socket forwarding.
```bash
docker compose -f docker-compose-cln.yml up -d
RUSTFLAGS="--cfg cln_test" cargo test --test integration_tests_cln
```

# Integration tests with specific backends
cargo test --cfg cln_test # Core Lightning tests
cargo test --cfg lnd_test # LND tests
cargo test --cfg vss_test # VSS (Versioned Storage Service) tests
#### LND integration tests
Requires Docker and CMake (>=3.5, <4.0) for `lnd_grpc_rust`.
Set `LND_DATA_DIR`, `LND_CERT_PATH`, and `LND_MACAROON_PATH` env vars.
```bash
docker compose -f docker-compose-lnd.yml up -d
RUSTFLAGS="--cfg lnd_test" cargo test --test integration_tests_lnd
```

#### VSS integration tests
Requires PostgreSQL and a running VSS server (from `lightningdevkit/vss-server`).
Set `TEST_VSS_BASE_URL` env var.
```bash
RUSTFLAGS="--cfg vss_test" cargo test --test integration_tests_vss
```

### Code Quality
Expand DownExpand Up@@ -200,6 +236,7 @@ marked as skipped for CI), you must fix it before declaring success.
- NEVER suggest manually adding @Serializable annotations to generated Kotlin bindings
- ALWAYS run `cargo fmt` before committing to ensure consistent code formatting
- ALWAYS move imports to the top of the file when applicable (no inline imports in functions)
- ALWAYS add unit tests for new business logic — untested code will be flagged in review
- Run `./bindgen.sh` in the background when bindings need regeneration (it is long-running)

## Bindings Generation Command
Expand Down
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,10 @@
- Switched from forked rust-lightning (`ovitrif/rust-lightning#0.2-electrum-fix`) back to official
upstream crates.io releases. The Electrum sync fix (PR #4341) is now in upstream
`lightning-transaction-sync` v0.2.1. Also picks up `lightning` v0.2.2 fixes.
- Fixed FS→KV channel data migration blindly overwriting newer state. The migration now skips
writing a channel monitor when the KV store already holds one with a newer or equal `update_id`,
and skips the channel manager when one already exists. Read or deserialization failures fail-closed
to prevent silent data loss.

## Synonym Fork Additions

Expand All@@ -36,7 +40,6 @@
255 and a warning is logged.
**Breaking change:** existing struct-literal construction of `ElectrumSyncConfig` must add the
new field or switch to `ElectrumSyncConfig { .., ..Default::default() }`.

- Added `OnchainPayment::calculate_send_all_fee()` to preview the fee for a drain / send-all
transaction before broadcasting (fee-calculation counterpart of `send_all_to_address`)
- Added runtime APIs for dynamic address type management:
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix: prevent channel data overwrite in FS→KV migration#74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ovitrif
merged 14 commits into

from

Mar 16, 2026
 Merged


fix: prevent channel data overwrite in FS→KV migration
#74
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
e48948f

fix: prevent channel monitor migration from overwriting newer state


ovitrif Mar 9, 2026
7d2ed46

docs: rewrite testing section with correct syntax and setup requirements


ovitrif Mar 9, 2026
530f449

chore: bump version to 0.7.0-rc.33


ovitrif Mar 9, 2026
fdab2be

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 9, 2026
2df9b0a

fix: fail-closed on migration read/deserialize errors


ovitrif Mar 10, 2026
e998973

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 10, 2026
d96e813

fix: regenerate android bindings with correct gobley v0.2.0


ovitrif Mar 10, 2026
630b364

test: add unit tests for channel monitor migration logic


ovitrif Mar 11, 2026
cde6037

fix: skip redundant monitor write when update_id is equal


ovitrif Mar 11, 2026
4f91c8c

fix: guard channel manager migration against overwriting newer state


ovitrif Mar 11, 2026
dc087fb

fix: clarify channel manager migration guard rationale and add corrup…


ovitrif Mar 11, 2026
ad5d519

Merge branch 'main' into fix/channel-monitor-migration


ovitrif Mar 12, 2026
1531af7

chore: reword changelog and regenerate bindings for v0.7.0-rc.33


ovitrif Mar 12, 2026
ffc0ec5

fix: simplify channel manager migration comment


ovitrif Mar 16, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 45 additions & 8 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,20 +21,56 @@ cargo build --profile=release-smaller
```

### Testing

#### Unit tests (no external infrastructure needed)
```bash
cargo test --lib
```

#### Standard integration tests
Uses the `electrsd` crate to auto-download and spawn `bitcoind` + `electrs` binaries.
To use pre-downloaded binaries, set `BITCOIND_EXE` and `ELECTRS_EXE` env vars.

On macOS, the default file descriptor limit (256) is too low for spawning `bitcoind` +
`electrs`. Raise it before running integration tests:

Test files: `tests/integration_tests_rust.rs`, `tests/reorg_test.rs`,
`tests/multi_address_types_tests.rs`

```bash
# Run all tests
cargo test
ulimit -n 10240 && cargo test
```

# Run a specific test
#### Run a specific test
```bash
cargo test test_name
```

# Run tests with specific features
#### Run tests with UniFFI bindings feature
```bash
cargo test --features "uniffi"
```

#### CLN integration tests
Requires Docker and `socat` for RPC socket forwarding.
```bash
docker compose -f docker-compose-cln.yml up -d
RUSTFLAGS="--cfg cln_test" cargo test --test integration_tests_cln
```

# Integration tests with specific backends
cargo test --cfg cln_test # Core Lightning tests
cargo test --cfg lnd_test # LND tests
cargo test --cfg vss_test # VSS (Versioned Storage Service) tests
#### LND integration tests
Requires Docker and CMake (>=3.5, <4.0) for `lnd_grpc_rust`.
Set `LND_DATA_DIR`, `LND_CERT_PATH`, and `LND_MACAROON_PATH` env vars.
```bash
docker compose -f docker-compose-lnd.yml up -d
RUSTFLAGS="--cfg lnd_test" cargo test --test integration_tests_lnd
```

#### VSS integration tests
Requires PostgreSQL and a running VSS server (from `lightningdevkit/vss-server`).
Set `TEST_VSS_BASE_URL` env var.
```bash
RUSTFLAGS="--cfg vss_test" cargo test --test integration_tests_vss
```

### Code Quality
Expand DownExpand Up@@ -200,6 +236,7 @@ marked as skipped for CI), you must fix it before declaring success.
- NEVER suggest manually adding @Serializable annotations to generated Kotlin bindings
- ALWAYS run `cargo fmt` before committing to ensure consistent code formatting
- ALWAYS move imports to the top of the file when applicable (no inline imports in functions)
- ALWAYS add unit tests for new business logic — untested code will be flagged in review
- Run `./bindgen.sh` in the background when bindings need regeneration (it is long-running)

## Bindings Generation Command
Expand Down

5 changes: 4 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,10 @@
- Switched from forked rust-lightning (`ovitrif/rust-lightning#0.2-electrum-fix`) back to official
 upstream crates.io releases. The Electrum sync fix (PR #4341) is now in upstream
 `lightning-transaction-sync` v0.2.1. Also picks up `lightning` v0.2.2 fixes.
- Fixed FS→KV channel data migration blindly overwriting newer state. The migration now skips
 writing a channel monitor when the KV store already holds one with a newer or equal `update_id`,
 and skips the channel manager when one already exists. Read or deserialization failures fail-closed
 to prevent silent data loss.

## Synonym Fork Additions

Expand All@@ -36,7 +40,6 @@
 255 and a warning is logged.
 **Breaking change:** existing struct-literal construction of `ElectrumSyncConfig` must add the
 new field or switch to `ElectrumSyncConfig { .., ..Default::default() }`.

- Added `OnchainPayment::calculate_send_all_fee()` to preview the fee for a drain / send-all
 transaction before broadcasting (fee-calculation counterpart of `send_all_to_address`)
- Added runtime APIs for dynamic address type management:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: prevent channel data overwrite in FS→KV migration#74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ovitrif
merged 14 commits into

from

Mar 16, 2026
 Merged


fix: prevent channel data overwrite in FS→KV migration
#74
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
e48948f

fix: prevent channel monitor migration from overwriting newer state


ovitrif Mar 9, 2026
7d2ed46

docs: rewrite testing section with correct syntax and setup requirements


ovitrif Mar 9, 2026
530f449

chore: bump version to 0.7.0-rc.33


ovitrif Mar 9, 2026
fdab2be

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 9, 2026
2df9b0a

fix: fail-closed on migration read/deserialize errors


ovitrif Mar 10, 2026
e998973

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 10, 2026
d96e813

fix: regenerate android bindings with correct gobley v0.2.0


ovitrif Mar 10, 2026
630b364

test: add unit tests for channel monitor migration logic


ovitrif Mar 11, 2026
cde6037

fix: skip redundant monitor write when update_id is equal


ovitrif Mar 11, 2026
4f91c8c

fix: guard channel manager migration against overwriting newer state


ovitrif Mar 11, 2026
dc087fb

fix: clarify channel manager migration guard rationale and add corrup…


ovitrif Mar 11, 2026
ad5d519

Merge branch 'main' into fix/channel-monitor-migration


ovitrif Mar 12, 2026
1531af7

chore: reword changelog and regenerate bindings for v0.7.0-rc.33


ovitrif Mar 12, 2026
ffc0ec5

fix: simplify channel manager migration comment


ovitrif Mar 16, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 45 additions & 8 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,20 +21,56 @@ cargo build --profile=release-smaller
```

### Testing

#### Unit tests (no external infrastructure needed)
```bash
cargo test --lib
```

#### Standard integration tests
Uses the `electrsd` crate to auto-download and spawn `bitcoind` + `electrs` binaries.
To use pre-downloaded binaries, set `BITCOIND_EXE` and `ELECTRS_EXE` env vars.

On macOS, the default file descriptor limit (256) is too low for spawning `bitcoind` +
`electrs`. Raise it before running integration tests:

Test files: `tests/integration_tests_rust.rs`, `tests/reorg_test.rs`,
`tests/multi_address_types_tests.rs`

```bash
# Run all tests
cargo test
ulimit -n 10240 && cargo test
```

# Run a specific test
#### Run a specific test
```bash
cargo test test_name
```

# Run tests with specific features
#### Run tests with UniFFI bindings feature
```bash
cargo test --features "uniffi"
```

#### CLN integration tests
Requires Docker and `socat` for RPC socket forwarding.
```bash
docker compose -f docker-compose-cln.yml up -d
RUSTFLAGS="--cfg cln_test" cargo test --test integration_tests_cln
```

# Integration tests with specific backends
cargo test --cfg cln_test # Core Lightning tests
cargo test --cfg lnd_test # LND tests
cargo test --cfg vss_test # VSS (Versioned Storage Service) tests
#### LND integration tests
Requires Docker and CMake (>=3.5, <4.0) for `lnd_grpc_rust`.
Set `LND_DATA_DIR`, `LND_CERT_PATH`, and `LND_MACAROON_PATH` env vars.
```bash
docker compose -f docker-compose-lnd.yml up -d
RUSTFLAGS="--cfg lnd_test" cargo test --test integration_tests_lnd
```

#### VSS integration tests
Requires PostgreSQL and a running VSS server (from `lightningdevkit/vss-server`).
Set `TEST_VSS_BASE_URL` env var.
```bash
RUSTFLAGS="--cfg vss_test" cargo test --test integration_tests_vss
```

### Code Quality
Expand DownExpand Up@@ -200,6 +236,7 @@ marked as skipped for CI), you must fix it before declaring success.
- NEVER suggest manually adding @Serializable annotations to generated Kotlin bindings
- ALWAYS run `cargo fmt` before committing to ensure consistent code formatting
- ALWAYS move imports to the top of the file when applicable (no inline imports in functions)
- ALWAYS add unit tests for new business logic — untested code will be flagged in review
- Run `./bindgen.sh` in the background when bindings need regeneration (it is long-running)

## Bindings Generation Command
Expand Down

5 changes: 4 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,10 @@
- Switched from forked rust-lightning (`ovitrif/rust-lightning#0.2-electrum-fix`) back to official
 upstream crates.io releases. The Electrum sync fix (PR #4341) is now in upstream
 `lightning-transaction-sync` v0.2.1. Also picks up `lightning` v0.2.2 fixes.
- Fixed FS→KV channel data migration blindly overwriting newer state. The migration now skips
 writing a channel monitor when the KV store already holds one with a newer or equal `update_id`,
 and skips the channel manager when one already exists. Read or deserialization failures fail-closed
 to prevent silent data loss.

## Synonym Fork Additions

Expand All@@ -36,7 +40,6 @@
 255 and a warning is logged.
 **Breaking change:** existing struct-literal construction of `ElectrumSyncConfig` must add the
 new field or switch to `ElectrumSyncConfig { .., ..Default::default() }`.

- Added `OnchainPayment::calculate_send_all_fee()` to preview the fee for a drain / send-all
 transaction before broadcasting (fee-calculation counterpart of `send_all_to_address`)
- Added runtime APIs for dynamic address type management:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: prevent channel data overwrite in FS→KV migration#74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ovitrif
merged 14 commits into

from

Mar 16, 2026
 Merged


fix: prevent channel data overwrite in FS→KV migration
#74
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
e48948f

fix: prevent channel monitor migration from overwriting newer state


ovitrif Mar 9, 2026
7d2ed46

docs: rewrite testing section with correct syntax and setup requirements


ovitrif Mar 9, 2026
530f449

chore: bump version to 0.7.0-rc.33


ovitrif Mar 9, 2026
fdab2be

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 9, 2026
2df9b0a

fix: fail-closed on migration read/deserialize errors


ovitrif Mar 10, 2026
e998973

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 10, 2026
d96e813

fix: regenerate android bindings with correct gobley v0.2.0


ovitrif Mar 10, 2026
630b364

test: add unit tests for channel monitor migration logic


ovitrif Mar 11, 2026
cde6037

fix: skip redundant monitor write when update_id is equal


ovitrif Mar 11, 2026
4f91c8c

fix: guard channel manager migration against overwriting newer state


ovitrif Mar 11, 2026
dc087fb

fix: clarify channel manager migration guard rationale and add corrup…


ovitrif Mar 11, 2026
ad5d519

Merge branch 'main' into fix/channel-monitor-migration


ovitrif Mar 12, 2026
1531af7

chore: reword changelog and regenerate bindings for v0.7.0-rc.33


ovitrif Mar 12, 2026
ffc0ec5

fix: simplify channel manager migration comment


ovitrif Mar 16, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 45 additions & 8 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,20 +21,56 @@ cargo build --profile=release-smaller
```

### Testing

#### Unit tests (no external infrastructure needed)
```bash
cargo test --lib
```

#### Standard integration tests
Uses the `electrsd` crate to auto-download and spawn `bitcoind` + `electrs` binaries.
To use pre-downloaded binaries, set `BITCOIND_EXE` and `ELECTRS_EXE` env vars.

On macOS, the default file descriptor limit (256) is too low for spawning `bitcoind` +
`electrs`. Raise it before running integration tests:

Test files: `tests/integration_tests_rust.rs`, `tests/reorg_test.rs`,
`tests/multi_address_types_tests.rs`

```bash
# Run all tests
cargo test
ulimit -n 10240 && cargo test
```

# Run a specific test
#### Run a specific test
```bash
cargo test test_name
```

# Run tests with specific features
#### Run tests with UniFFI bindings feature
```bash
cargo test --features "uniffi"
```

#### CLN integration tests
Requires Docker and `socat` for RPC socket forwarding.
```bash
docker compose -f docker-compose-cln.yml up -d
RUSTFLAGS="--cfg cln_test" cargo test --test integration_tests_cln
```

# Integration tests with specific backends
cargo test --cfg cln_test # Core Lightning tests
cargo test --cfg lnd_test # LND tests
cargo test --cfg vss_test # VSS (Versioned Storage Service) tests
#### LND integration tests
Requires Docker and CMake (>=3.5, <4.0) for `lnd_grpc_rust`.
Set `LND_DATA_DIR`, `LND_CERT_PATH`, and `LND_MACAROON_PATH` env vars.
```bash
docker compose -f docker-compose-lnd.yml up -d
RUSTFLAGS="--cfg lnd_test" cargo test --test integration_tests_lnd
```

#### VSS integration tests
Requires PostgreSQL and a running VSS server (from `lightningdevkit/vss-server`).
Set `TEST_VSS_BASE_URL` env var.
```bash
RUSTFLAGS="--cfg vss_test" cargo test --test integration_tests_vss
```

### Code Quality
Expand DownExpand Up@@ -200,6 +236,7 @@ marked as skipped for CI), you must fix it before declaring success.
- NEVER suggest manually adding @Serializable annotations to generated Kotlin bindings
- ALWAYS run `cargo fmt` before committing to ensure consistent code formatting
- ALWAYS move imports to the top of the file when applicable (no inline imports in functions)
- ALWAYS add unit tests for new business logic — untested code will be flagged in review
- Run `./bindgen.sh` in the background when bindings need regeneration (it is long-running)

## Bindings Generation Command
Expand Down

5 changes: 4 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,10 @@
- Switched from forked rust-lightning (`ovitrif/rust-lightning#0.2-electrum-fix`) back to official
 upstream crates.io releases. The Electrum sync fix (PR #4341) is now in upstream
 `lightning-transaction-sync` v0.2.1. Also picks up `lightning` v0.2.2 fixes.
- Fixed FS→KV channel data migration blindly overwriting newer state. The migration now skips
 writing a channel monitor when the KV store already holds one with a newer or equal `update_id`,
 and skips the channel manager when one already exists. Read or deserialization failures fail-closed
 to prevent silent data loss.

## Synonym Fork Additions

Expand All@@ -36,7 +40,6 @@
 255 and a warning is logged.
 **Breaking change:** existing struct-literal construction of `ElectrumSyncConfig` must add the
 new field or switch to `ElectrumSyncConfig { .., ..Default::default() }`.

- Added `OnchainPayment::calculate_send_all_fee()` to preview the fee for a drain / send-all
 transaction before broadcasting (fee-calculation counterpart of `send_all_to_address`)
- Added runtime APIs for dynamic address type management:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix: prevent channel data overwrite in FS→KV migration#74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ovitrif
merged 14 commits into

from

Mar 16, 2026
 Merged


fix: prevent channel data overwrite in FS→KV migration
#74
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
e48948f

fix: prevent channel monitor migration from overwriting newer state


ovitrif Mar 9, 2026
7d2ed46

docs: rewrite testing section with correct syntax and setup requirements


ovitrif Mar 9, 2026
530f449

chore: bump version to 0.7.0-rc.33


ovitrif Mar 9, 2026
fdab2be

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 9, 2026
2df9b0a

fix: fail-closed on migration read/deserialize errors


ovitrif Mar 10, 2026
e998973

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 10, 2026
d96e813

fix: regenerate android bindings with correct gobley v0.2.0


ovitrif Mar 10, 2026
630b364

test: add unit tests for channel monitor migration logic


ovitrif Mar 11, 2026
cde6037

fix: skip redundant monitor write when update_id is equal


ovitrif Mar 11, 2026
4f91c8c

fix: guard channel manager migration against overwriting newer state


ovitrif Mar 11, 2026
dc087fb

fix: clarify channel manager migration guard rationale and add corrup…


ovitrif Mar 11, 2026
ad5d519

Merge branch 'main' into fix/channel-monitor-migration


ovitrif Mar 12, 2026
1531af7

chore: reword changelog and regenerate bindings for v0.7.0-rc.33


ovitrif Mar 12, 2026
ffc0ec5

fix: simplify channel manager migration comment


ovitrif Mar 16, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 45 additions & 8 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,20 +21,56 @@ cargo build --profile=release-smaller
```

### Testing

#### Unit tests (no external infrastructure needed)
```bash
cargo test --lib
```

#### Standard integration tests
Uses the `electrsd` crate to auto-download and spawn `bitcoind` + `electrs` binaries.
To use pre-downloaded binaries, set `BITCOIND_EXE` and `ELECTRS_EXE` env vars.

On macOS, the default file descriptor limit (256) is too low for spawning `bitcoind` +
`electrs`. Raise it before running integration tests:

Test files: `tests/integration_tests_rust.rs`, `tests/reorg_test.rs`,
`tests/multi_address_types_tests.rs`

```bash
# Run all tests
cargo test
ulimit -n 10240 && cargo test
```

# Run a specific test
#### Run a specific test
```bash
cargo test test_name
```

# Run tests with specific features
#### Run tests with UniFFI bindings feature
```bash
cargo test --features "uniffi"
```

#### CLN integration tests
Requires Docker and `socat` for RPC socket forwarding.
```bash
docker compose -f docker-compose-cln.yml up -d
RUSTFLAGS="--cfg cln_test" cargo test --test integration_tests_cln
```

# Integration tests with specific backends
cargo test --cfg cln_test # Core Lightning tests
cargo test --cfg lnd_test # LND tests
cargo test --cfg vss_test # VSS (Versioned Storage Service) tests
#### LND integration tests
Requires Docker and CMake (>=3.5, <4.0) for `lnd_grpc_rust`.
Set `LND_DATA_DIR`, `LND_CERT_PATH`, and `LND_MACAROON_PATH` env vars.
```bash
docker compose -f docker-compose-lnd.yml up -d
RUSTFLAGS="--cfg lnd_test" cargo test --test integration_tests_lnd
```

#### VSS integration tests
Requires PostgreSQL and a running VSS server (from `lightningdevkit/vss-server`).
Set `TEST_VSS_BASE_URL` env var.
```bash
RUSTFLAGS="--cfg vss_test" cargo test --test integration_tests_vss
```

### Code Quality
Expand DownExpand Up@@ -200,6 +236,7 @@ marked as skipped for CI), you must fix it before declaring success.
- NEVER suggest manually adding @Serializable annotations to generated Kotlin bindings
- ALWAYS run `cargo fmt` before committing to ensure consistent code formatting
- ALWAYS move imports to the top of the file when applicable (no inline imports in functions)
- ALWAYS add unit tests for new business logic — untested code will be flagged in review
- Run `./bindgen.sh` in the background when bindings need regeneration (it is long-running)

## Bindings Generation Command
Expand Down

5 changes: 4 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,10 @@
- Switched from forked rust-lightning (`ovitrif/rust-lightning#0.2-electrum-fix`) back to official
 upstream crates.io releases. The Electrum sync fix (PR #4341) is now in upstream
 `lightning-transaction-sync` v0.2.1. Also picks up `lightning` v0.2.2 fixes.
- Fixed FS→KV channel data migration blindly overwriting newer state. The migration now skips
 writing a channel monitor when the KV store already holds one with a newer or equal `update_id`,
 and skips the channel manager when one already exists. Read or deserialization failures fail-closed
 to prevent silent data loss.

## Synonym Fork Additions

Expand All@@ -36,7 +40,6 @@
 255 and a warning is logged.
 **Breaking change:** existing struct-literal construction of `ElectrumSyncConfig` must add the
 new field or switch to `ElectrumSyncConfig { .., ..Default::default() }`.

- Added `OnchainPayment::calculate_send_all_fee()` to preview the fee for a drain / send-all
 transaction before broadcasting (fee-calculation counterpart of `send_all_to_address`)
- Added runtime APIs for dynamic address type management:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: prevent channel data overwrite in FS→KV migration#74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ovitrif
merged 14 commits into

from

Mar 16, 2026
 Merged


fix: prevent channel data overwrite in FS→KV migration
#74
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
e48948f

fix: prevent channel monitor migration from overwriting newer state


ovitrif Mar 9, 2026
7d2ed46

docs: rewrite testing section with correct syntax and setup requirements


ovitrif Mar 9, 2026
530f449

chore: bump version to 0.7.0-rc.33


ovitrif Mar 9, 2026
fdab2be

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 9, 2026
2df9b0a

fix: fail-closed on migration read/deserialize errors


ovitrif Mar 10, 2026
e998973

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 10, 2026
d96e813

fix: regenerate android bindings with correct gobley v0.2.0


ovitrif Mar 10, 2026
630b364

test: add unit tests for channel monitor migration logic


ovitrif Mar 11, 2026
cde6037

fix: skip redundant monitor write when update_id is equal


ovitrif Mar 11, 2026
4f91c8c

fix: guard channel manager migration against overwriting newer state


ovitrif Mar 11, 2026
dc087fb

fix: clarify channel manager migration guard rationale and add corrup…


ovitrif Mar 11, 2026
ad5d519

Merge branch 'main' into fix/channel-monitor-migration


ovitrif Mar 12, 2026
1531af7

chore: reword changelog and regenerate bindings for v0.7.0-rc.33


ovitrif Mar 12, 2026
ffc0ec5

fix: simplify channel manager migration comment


ovitrif Mar 16, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 45 additions & 8 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,20 +21,56 @@ cargo build --profile=release-smaller
```

### Testing

#### Unit tests (no external infrastructure needed)
```bash
cargo test --lib
```

#### Standard integration tests
Uses the `electrsd` crate to auto-download and spawn `bitcoind` + `electrs` binaries.
To use pre-downloaded binaries, set `BITCOIND_EXE` and `ELECTRS_EXE` env vars.

On macOS, the default file descriptor limit (256) is too low for spawning `bitcoind` +
`electrs`. Raise it before running integration tests:

Test files: `tests/integration_tests_rust.rs`, `tests/reorg_test.rs`,
`tests/multi_address_types_tests.rs`

```bash
# Run all tests
cargo test
ulimit -n 10240 && cargo test
```

# Run a specific test
#### Run a specific test
```bash
cargo test test_name
```

# Run tests with specific features
#### Run tests with UniFFI bindings feature
```bash
cargo test --features "uniffi"
```

#### CLN integration tests
Requires Docker and `socat` for RPC socket forwarding.
```bash
docker compose -f docker-compose-cln.yml up -d
RUSTFLAGS="--cfg cln_test" cargo test --test integration_tests_cln
```

# Integration tests with specific backends
cargo test --cfg cln_test # Core Lightning tests
cargo test --cfg lnd_test # LND tests
cargo test --cfg vss_test # VSS (Versioned Storage Service) tests
#### LND integration tests
Requires Docker and CMake (>=3.5, <4.0) for `lnd_grpc_rust`.
Set `LND_DATA_DIR`, `LND_CERT_PATH`, and `LND_MACAROON_PATH` env vars.
```bash
docker compose -f docker-compose-lnd.yml up -d
RUSTFLAGS="--cfg lnd_test" cargo test --test integration_tests_lnd
```

#### VSS integration tests
Requires PostgreSQL and a running VSS server (from `lightningdevkit/vss-server`).
Set `TEST_VSS_BASE_URL` env var.
```bash
RUSTFLAGS="--cfg vss_test" cargo test --test integration_tests_vss
```

### Code Quality
Expand DownExpand Up@@ -200,6 +236,7 @@ marked as skipped for CI), you must fix it before declaring success.
- NEVER suggest manually adding @Serializable annotations to generated Kotlin bindings
- ALWAYS run `cargo fmt` before committing to ensure consistent code formatting
- ALWAYS move imports to the top of the file when applicable (no inline imports in functions)
- ALWAYS add unit tests for new business logic — untested code will be flagged in review
- Run `./bindgen.sh` in the background when bindings need regeneration (it is long-running)

## Bindings Generation Command
Expand Down

5 changes: 4 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,10 @@
- Switched from forked rust-lightning (`ovitrif/rust-lightning#0.2-electrum-fix`) back to official
 upstream crates.io releases. The Electrum sync fix (PR #4341) is now in upstream
 `lightning-transaction-sync` v0.2.1. Also picks up `lightning` v0.2.2 fixes.
- Fixed FS→KV channel data migration blindly overwriting newer state. The migration now skips
 writing a channel monitor when the KV store already holds one with a newer or equal `update_id`,
 and skips the channel manager when one already exists. Read or deserialization failures fail-closed
 to prevent silent data loss.

## Synonym Fork Additions

Expand All@@ -36,7 +40,6 @@
 255 and a warning is logged.
 **Breaking change:** existing struct-literal construction of `ElectrumSyncConfig` must add the
 new field or switch to `ElectrumSyncConfig { .., ..Default::default() }`.

- Added `OnchainPayment::calculate_send_all_fee()` to preview the fee for a drain / send-all
 transaction before broadcasting (fee-calculation counterpart of `send_all_to_address`)
- Added runtime APIs for dynamic address type management:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: prevent channel data overwrite in FS→KV migration#74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ovitrif
merged 14 commits into

from

Mar 16, 2026
 Merged


fix: prevent channel data overwrite in FS→KV migration
#74
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
e48948f

fix: prevent channel monitor migration from overwriting newer state


ovitrif Mar 9, 2026
7d2ed46

docs: rewrite testing section with correct syntax and setup requirements


ovitrif Mar 9, 2026
530f449

chore: bump version to 0.7.0-rc.33


ovitrif Mar 9, 2026
fdab2be

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 9, 2026
2df9b0a

fix: fail-closed on migration read/deserialize errors


ovitrif Mar 10, 2026
e998973

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 10, 2026
d96e813

fix: regenerate android bindings with correct gobley v0.2.0


ovitrif Mar 10, 2026
630b364

test: add unit tests for channel monitor migration logic


ovitrif Mar 11, 2026
cde6037

fix: skip redundant monitor write when update_id is equal


ovitrif Mar 11, 2026
4f91c8c

fix: guard channel manager migration against overwriting newer state


ovitrif Mar 11, 2026
dc087fb

fix: clarify channel manager migration guard rationale and add corrup…


ovitrif Mar 11, 2026
ad5d519

Merge branch 'main' into fix/channel-monitor-migration


ovitrif Mar 12, 2026
1531af7

chore: reword changelog and regenerate bindings for v0.7.0-rc.33


ovitrif Mar 12, 2026
ffc0ec5

fix: simplify channel manager migration comment


ovitrif Mar 16, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 45 additions & 8 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,20 +21,56 @@ cargo build --profile=release-smaller
```

### Testing

#### Unit tests (no external infrastructure needed)
```bash
cargo test --lib
```

#### Standard integration tests
Uses the `electrsd` crate to auto-download and spawn `bitcoind` + `electrs` binaries.
To use pre-downloaded binaries, set `BITCOIND_EXE` and `ELECTRS_EXE` env vars.

On macOS, the default file descriptor limit (256) is too low for spawning `bitcoind` +
`electrs`. Raise it before running integration tests:

Test files: `tests/integration_tests_rust.rs`, `tests/reorg_test.rs`,
`tests/multi_address_types_tests.rs`

```bash
# Run all tests
cargo test
ulimit -n 10240 && cargo test
```

# Run a specific test
#### Run a specific test
```bash
cargo test test_name
```

# Run tests with specific features
#### Run tests with UniFFI bindings feature
```bash
cargo test --features "uniffi"
```

#### CLN integration tests
Requires Docker and `socat` for RPC socket forwarding.
```bash
docker compose -f docker-compose-cln.yml up -d
RUSTFLAGS="--cfg cln_test" cargo test --test integration_tests_cln
```

# Integration tests with specific backends
cargo test --cfg cln_test # Core Lightning tests
cargo test --cfg lnd_test # LND tests
cargo test --cfg vss_test # VSS (Versioned Storage Service) tests
#### LND integration tests
Requires Docker and CMake (>=3.5, <4.0) for `lnd_grpc_rust`.
Set `LND_DATA_DIR`, `LND_CERT_PATH`, and `LND_MACAROON_PATH` env vars.
```bash
docker compose -f docker-compose-lnd.yml up -d
RUSTFLAGS="--cfg lnd_test" cargo test --test integration_tests_lnd
```

#### VSS integration tests
Requires PostgreSQL and a running VSS server (from `lightningdevkit/vss-server`).
Set `TEST_VSS_BASE_URL` env var.
```bash
RUSTFLAGS="--cfg vss_test" cargo test --test integration_tests_vss
```

### Code Quality
Expand DownExpand Up@@ -200,6 +236,7 @@ marked as skipped for CI), you must fix it before declaring success.
- NEVER suggest manually adding @Serializable annotations to generated Kotlin bindings
- ALWAYS run `cargo fmt` before committing to ensure consistent code formatting
- ALWAYS move imports to the top of the file when applicable (no inline imports in functions)
- ALWAYS add unit tests for new business logic — untested code will be flagged in review
- Run `./bindgen.sh` in the background when bindings need regeneration (it is long-running)

## Bindings Generation Command
Expand Down

5 changes: 4 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,10 @@
- Switched from forked rust-lightning (`ovitrif/rust-lightning#0.2-electrum-fix`) back to official
 upstream crates.io releases. The Electrum sync fix (PR #4341) is now in upstream
 `lightning-transaction-sync` v0.2.1. Also picks up `lightning` v0.2.2 fixes.
- Fixed FS→KV channel data migration blindly overwriting newer state. The migration now skips
 writing a channel monitor when the KV store already holds one with a newer or equal `update_id`,
 and skips the channel manager when one already exists. Read or deserialization failures fail-closed
 to prevent silent data loss.

## Synonym Fork Additions

Expand All@@ -36,7 +40,6 @@
 255 and a warning is logged.
 **Breaking change:** existing struct-literal construction of `ElectrumSyncConfig` must add the
 new field or switch to `ElectrumSyncConfig { .., ..Default::default() }`.

- Added `OnchainPayment::calculate_send_all_fee()` to preview the fee for a drain / send-all
 transaction before broadcasting (fee-calculation counterpart of `send_all_to_address`)
- Added runtime APIs for dynamic address type management:
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix: prevent channel data overwrite in FS→KV migration#74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ovitrif
merged 14 commits into

from

Mar 16, 2026
 Merged


fix: prevent channel data overwrite in FS→KV migration
#74
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
e48948f

fix: prevent channel monitor migration from overwriting newer state


ovitrif Mar 9, 2026
7d2ed46

docs: rewrite testing section with correct syntax and setup requirements


ovitrif Mar 9, 2026
530f449

chore: bump version to 0.7.0-rc.33


ovitrif Mar 9, 2026
fdab2be

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 9, 2026
2df9b0a

fix: fail-closed on migration read/deserialize errors


ovitrif Mar 10, 2026
e998973

chore: regenerate bindings for v0.7.0-rc.33


ovitrif Mar 10, 2026
d96e813

fix: regenerate android bindings with correct gobley v0.2.0


ovitrif Mar 10, 2026
630b364

test: add unit tests for channel monitor migration logic


ovitrif Mar 11, 2026
cde6037

fix: skip redundant monitor write when update_id is equal


ovitrif Mar 11, 2026
4f91c8c

fix: guard channel manager migration against overwriting newer state


ovitrif Mar 11, 2026
dc087fb

fix: clarify channel manager migration guard rationale and add corrup…


ovitrif Mar 11, 2026
ad5d519

Merge branch 'main' into fix/channel-monitor-migration


ovitrif Mar 12, 2026
1531af7

chore: reword changelog and regenerate bindings for v0.7.0-rc.33


ovitrif Mar 12, 2026
ffc0ec5

fix: simplify channel manager migration comment


ovitrif Mar 16, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 45 additions & 8 deletions
AGENTS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,20 +21,56 @@ cargo build --profile=release-smaller
```

### Testing

#### Unit tests (no external infrastructure needed)
```bash
cargo test --lib
```

#### Standard integration tests
Uses the `electrsd` crate to auto-download and spawn `bitcoind` + `electrs` binaries.
To use pre-downloaded binaries, set `BITCOIND_EXE` and `ELECTRS_EXE` env vars.

On macOS, the default file descriptor limit (256) is too low for spawning `bitcoind` +
`electrs`. Raise it before running integration tests:

Test files: `tests/integration_tests_rust.rs`, `tests/reorg_test.rs`,
`tests/multi_address_types_tests.rs`

```bash
# Run all tests
cargo test
ulimit -n 10240 && cargo test
```

# Run a specific test
#### Run a specific test
```bash
cargo test test_name
```

# Run tests with specific features
#### Run tests with UniFFI bindings feature
```bash
cargo test --features "uniffi"
```

#### CLN integration tests
Requires Docker and `socat` for RPC socket forwarding.
```bash
docker compose -f docker-compose-cln.yml up -d
RUSTFLAGS="--cfg cln_test" cargo test --test integration_tests_cln
```

# Integration tests with specific backends
cargo test --cfg cln_test # Core Lightning tests
cargo test --cfg lnd_test # LND tests
cargo test --cfg vss_test # VSS (Versioned Storage Service) tests
#### LND integration tests
Requires Docker and CMake (>=3.5, <4.0) for `lnd_grpc_rust`.
Set `LND_DATA_DIR`, `LND_CERT_PATH`, and `LND_MACAROON_PATH` env vars.
```bash
docker compose -f docker-compose-lnd.yml up -d
RUSTFLAGS="--cfg lnd_test" cargo test --test integration_tests_lnd
```

#### VSS integration tests
Requires PostgreSQL and a running VSS server (from `lightningdevkit/vss-server`).
Set `TEST_VSS_BASE_URL` env var.
```bash
RUSTFLAGS="--cfg vss_test" cargo test --test integration_tests_vss
```

### Code Quality
Expand DownExpand Up@@ -200,6 +236,7 @@ marked as skipped for CI), you must fix it before declaring success.
- NEVER suggest manually adding @Serializable annotations to generated Kotlin bindings
- ALWAYS run `cargo fmt` before committing to ensure consistent code formatting
- ALWAYS move imports to the top of the file when applicable (no inline imports in functions)
- ALWAYS add unit tests for new business logic — untested code will be flagged in review
- Run `./bindgen.sh` in the background when bindings need regeneration (it is long-running)

## Bindings Generation Command
Expand Down

5 changes: 4 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,10 @@
- Switched from forked rust-lightning (`ovitrif/rust-lightning#0.2-electrum-fix`) back to official
 upstream crates.io releases. The Electrum sync fix (PR #4341) is now in upstream
 `lightning-transaction-sync` v0.2.1. Also picks up `lightning` v0.2.2 fixes.
- Fixed FS→KV channel data migration blindly overwriting newer state. The migration now skips
 writing a channel monitor when the KV store already holds one with a newer or equal `update_id`,
 and skips the channel manager when one already exists. Read or deserialization failures fail-closed
 to prevent silent data loss.

## Synonym Fork Additions

Expand All@@ -36,7 +40,6 @@
 255 and a warning is logged.
 **Breaking change:** existing struct-literal construction of `ElectrumSyncConfig` must add the
 new field or switch to `ElectrumSyncConfig { .., ..Default::default() }`.

- Added `OnchainPayment::calculate_send_all_fee()` to preview the fee for a drain / send-all
 transaction before broadcasting (fee-calculation counterpart of `send_all_to_address`)
- Added runtime APIs for dynamic address type management:
Expand Down
Loading
Loading