Skip to content

Migrate to SvelteKit 2.0 - #1458

Merged
stolinski merged 5 commits into
mainfrom
svelte-2
Jan 11, 2024
Merged

Migrate to SvelteKit 2.0#1458
stolinski merged 5 commits into
mainfrom
svelte-2

Conversation

@wesbos

@wesboswesbos commented Dec 14, 2023

Copy link
Copy Markdown
Collaborator

need to see if this builds, but seems pretty smooth.

@vercel

vercelBot commented Dec 14, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
syntax-website✅ Ready (Inspect)Visit PreviewJan 11, 2024 7:59pm

@wesboswesbos mentioned this pull request Dec 14, 2023
Closed
@wesbos

wesbos commented Dec 14, 2023•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Build is breaking - I think related to the Sentry integration / moving to Vite 5

/node_modules/@sentry/node/esm/transports/http.js". at error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/parseAst.js:337:30) at Module.error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:12753:16) at Module.traceVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:13190:29) at ModuleScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:11607:39) at FunctionScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at FunctionBodyScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at Identifier.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:7193:40) at NewExpression.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at ReturnStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at BlockStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4635:28) ELIFECYCLE Command failed with exit code 1.ERROR: "build:svelte" exited with 1. ELIFECYCLE Command failed with exit code 1.Error: Command "pnpm build" exited with 1

will ping @AbhiPrasad as he made the issue on sentry-javascript

getsentry/sentry-javascript#9851

@Lms24

Lms24 commented Dec 15, 2023•
edited
Loading

Copy link
Copy Markdown

Hey @wesbos I'm currently trying to get the SDK to work with Kit 2.0. To debug, I cloned this repo and checked out your PR.

I think I've identified a fix for the problem but I'm not entirely sure because I don't get the exact same error and some other weird stuff is going on. The error I'm getting is pretty similar though to the one from CI.

Could you test something for me:
Add this exports property in node_modules/@sentry/sveltekit/package.json:

"exports": {
"browser": "./esm/index.client.js",
"node": "./cjs/index.server.js"
},

For me, adding these conditional exports resolved the build error.
If possible, I'd like to confirm this fixes things for you, too, before publishing the fix in the next SDK version.

some other weird stuff is going on

To expand on this: for some reason hydration seems to break in dev mode for me. For a split second, I can see the SSR html in the browser but then I get an error 500 page (no console output though). However, this still happens, even if I remove all Sentry SDK usage. Not sure if this is a kit bug or has something to do with the env variables I (didn't) set.

@Lms24Lms24 mentioned this pull request Dec 15, 2023
Merged
@stolinski

stolinski commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

Would love to get this merged. Might dive in an confirm we are gtg here. Would love to get on Node 20.

@AbhiPrasad

AbhiPrasad commented Jan 10, 2024

Copy link
Copy Markdown

Latest version of the SDK should have SvelteKit 2.0 support - it was specifically released with https://github.com/getsentry/sentry-javascript/releases/tag/7.89.0

SDK is also tests with latest Node 20/21, so you should be good to go there!

@stolinski

stolinski commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

@AbhiPrasad it seems like this error is still happening in Sentry/SvelteKit 7.93. I'll try removing the Sentry code and diving in further.

@stolinski

stolinski commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

As you suspected @AbhiPrasad the issue is not with Sentry. Very difficult to get a handle on where the problem actually is though.

@stolinski

stolinski commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

Found it! SearchResults.svelte importing the type Tree without import type. 🥴

@stolinski

stolinski commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

Ok sorry for the spam, going to re-add the Sentry code. Test more and get this pushed up and merged.

@AbhiPrasad

AbhiPrasad commented Jan 11, 2024

Copy link
Copy Markdown

SearchResults.svelte importing the type Tree without import type

Very tricky. Looking at your tsconfig I do see "importsNotUsedAsValues": "preserve", which should mean you don't have to switch to import type. importsNotUsedAsValues is deprecated though, and replaced with new verbatimModuleSyntax TS option in the latest TS versions.

https://github.com/syntaxfm/website/blob/f2d24d98400e4c1a29ac9ceed70d8f5c57d0b96d/tsconfig.json#L13C3-L13C40

In Sveltekit 2.0 the generated tsconfig in ./.svelte-kit/tsconfig.json now sets verbatimModuleSyntax, which overrides importsNotUsedAsValues and makes you now require import type. I would keep the change as explicit type imports is way better for bundler/TypeScript, but I'm surprised that svelte-migrate codemod didn't catch this and that the error was hard to debug.

@stolinski
stolinski merged commit c7516fc into mainJan 11, 2024
@stolinski
stolinski deleted the svelte-2 branch April 5, 2024 18:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wesbos@Lms24@stolinski@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Migrate to SvelteKit 2.0 by wesbos · Pull Request #1458 · syntaxfm/website · GitHub
Skip to content
Migrate to SvelteKit 2.0 - #1458
Merged
stolinski merged 5 commits into
mainfrom 
svelte-2
Jan 11, 2024
Merged
Migrate to SvelteKit 2.0#1458
stolinski merged 5 commits into
mainfrom 
svelte-2
Conversation
@wesbos
@wesboswesbos
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
need to see if this builds, but seems pretty smooth.
@vercel
vercelBot
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewUpdated (UTC)
syntax-website✅ Ready (Inspect)Visit PreviewJan 11, 2024 7:59pm
@wesboswesbos
mentioned this pull request
Dec 14, 2023

Closed

@wesbos
wesbos
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Build is breaking - I think related to the Sentry integration / moving to Vite 5
/node_modules/@sentry/node/esm/transports/http.js". at error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/parseAst.js:337:30) at Module.error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:12753:16) at Module.traceVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:13190:29) at ModuleScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:11607:39) at FunctionScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at FunctionBodyScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at Identifier.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:7193:40) at NewExpression.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at ReturnStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at BlockStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4635:28) ELIFECYCLE Command failed with exit code 1.ERROR: "build:svelte" exited with 1. ELIFECYCLE Command failed with exit code 1.Error: Command "pnpm build" exited with 1
will ping @AbhiPrasad as he made the issue on sentry-javascript
getsentry/sentry-javascript#9851
@Lms24
Lms24
commented
Dec 15, 2023•

edited

Loading

Copy link


Copy Markdown

Hey @wesbos I'm currently trying to get the SDK to work with Kit 2.0. To debug, I cloned this repo and checked out your PR.
I think I've identified a fix for the problem but I'm not entirely sure because I don't get the exact same error and some other weird stuff is going on. The error I'm getting is pretty similar though to the one from CI.
Could you test something for me:

Add this exports property in node_modules/@sentry/sveltekit/package.json:
"exports": {
"browser": "./esm/index.client.js",
"node": "./cjs/index.server.js"
},
For me, adding these conditional exports resolved the build error.

If possible, I'd like to confirm this fixes things for you, too, before publishing the fix in the next SDK version.
some other weird stuff is going on
To expand on this: for some reason hydration seems to break in dev mode for me. For a split second, I can see the SSR html in the browser but then I get an error 500 page (no console output though). However, this still happens, even if I remove all Sentry SDK usage. Not sure if this is a kit bug or has something to do with the env variables I (didn't) set.
@Lms24Lms24
mentioned this pull request
Dec 15, 2023
 Merged

@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Would love to get this merged. Might dive in an confirm we are gtg here. Would love to get on Node 20.
@AbhiPrasad
AbhiPrasad
commented
Jan 10, 2024

Copy link


Copy Markdown

Latest version of the SDK should have SvelteKit 2.0 support - it was specifically released with https://github.com/getsentry/sentry-javascript/releases/tag/7.89.0
SDK is also tests with latest Node 20/21, so you should be good to go there!
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
@AbhiPrasad it seems like this error is still happening in Sentry/SvelteKit 7.93. I'll try removing the Sentry code and diving in further.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
As you suspected @AbhiPrasad the issue is not with Sentry. Very difficult to get a handle on where the problem actually is though.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Found it! SearchResults.svelte importing the type Tree without import type. 🥴
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Ok sorry for the spam, going to re-add the Sentry code. Test more and get this pushed up and merged.
@AbhiPrasad
AbhiPrasad
commented
Jan 11, 2024

Copy link


Copy Markdown

SearchResults.svelte importing the type Tree without import type
Very tricky. Looking at your tsconfig I do see "importsNotUsedAsValues": "preserve", which should mean you don't have to switch to import type. importsNotUsedAsValues is deprecated though, and replaced with new verbatimModuleSyntax TS option in the latest TS versions.
https://github.com/syntaxfm/website/blob/f2d24d98400e4c1a29ac9ceed70d8f5c57d0b96d/tsconfig.json#L13C3-L13C40
In Sveltekit 2.0 the generated tsconfig in ./.svelte-kit/tsconfig.json now sets verbatimModuleSyntax, which overrides importsNotUsedAsValues and makes you now require import type. I would keep the change as explicit type imports is way better for bundler/TypeScript, but I'm surprised that svelte-migrate codemod didn't catch this and that the error was hard to debug.
@stolinski
stolinski
merged commit c7516fc
into
mainJan 11, 2024
@stolinski
stolinski
deleted the

svelte-2

branch
April 5, 2024 18:22
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wesbos@Lms24@stolinski@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Migrate to SvelteKit 2.0 by wesbos · Pull Request #1458 · syntaxfm/website · GitHub
Skip to content
Migrate to SvelteKit 2.0 - #1458
Merged
stolinski merged 5 commits into
mainfrom 
svelte-2
Jan 11, 2024
Merged
Migrate to SvelteKit 2.0#1458
stolinski merged 5 commits into
mainfrom 
svelte-2
Conversation
@wesbos
@wesboswesbos
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
need to see if this builds, but seems pretty smooth.
@vercel
vercelBot
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewUpdated (UTC)
syntax-website✅ Ready (Inspect)Visit PreviewJan 11, 2024 7:59pm
@wesboswesbos
mentioned this pull request
Dec 14, 2023

Closed

@wesbos
wesbos
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Build is breaking - I think related to the Sentry integration / moving to Vite 5
/node_modules/@sentry/node/esm/transports/http.js". at error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/parseAst.js:337:30) at Module.error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:12753:16) at Module.traceVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:13190:29) at ModuleScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:11607:39) at FunctionScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at FunctionBodyScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at Identifier.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:7193:40) at NewExpression.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at ReturnStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at BlockStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4635:28) ELIFECYCLE Command failed with exit code 1.ERROR: "build:svelte" exited with 1. ELIFECYCLE Command failed with exit code 1.Error: Command "pnpm build" exited with 1
will ping @AbhiPrasad as he made the issue on sentry-javascript
getsentry/sentry-javascript#9851
@Lms24
Lms24
commented
Dec 15, 2023•

edited

Loading

Copy link


Copy Markdown

Hey @wesbos I'm currently trying to get the SDK to work with Kit 2.0. To debug, I cloned this repo and checked out your PR.
I think I've identified a fix for the problem but I'm not entirely sure because I don't get the exact same error and some other weird stuff is going on. The error I'm getting is pretty similar though to the one from CI.
Could you test something for me:

Add this exports property in node_modules/@sentry/sveltekit/package.json:
"exports": {
"browser": "./esm/index.client.js",
"node": "./cjs/index.server.js"
},
For me, adding these conditional exports resolved the build error.

If possible, I'd like to confirm this fixes things for you, too, before publishing the fix in the next SDK version.
some other weird stuff is going on
To expand on this: for some reason hydration seems to break in dev mode for me. For a split second, I can see the SSR html in the browser but then I get an error 500 page (no console output though). However, this still happens, even if I remove all Sentry SDK usage. Not sure if this is a kit bug or has something to do with the env variables I (didn't) set.
@Lms24Lms24
mentioned this pull request
Dec 15, 2023
 Merged

@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Would love to get this merged. Might dive in an confirm we are gtg here. Would love to get on Node 20.
@AbhiPrasad
AbhiPrasad
commented
Jan 10, 2024

Copy link


Copy Markdown

Latest version of the SDK should have SvelteKit 2.0 support - it was specifically released with https://github.com/getsentry/sentry-javascript/releases/tag/7.89.0
SDK is also tests with latest Node 20/21, so you should be good to go there!
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
@AbhiPrasad it seems like this error is still happening in Sentry/SvelteKit 7.93. I'll try removing the Sentry code and diving in further.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
As you suspected @AbhiPrasad the issue is not with Sentry. Very difficult to get a handle on where the problem actually is though.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Found it! SearchResults.svelte importing the type Tree without import type. 🥴
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Ok sorry for the spam, going to re-add the Sentry code. Test more and get this pushed up and merged.
@AbhiPrasad
AbhiPrasad
commented
Jan 11, 2024

Copy link


Copy Markdown

SearchResults.svelte importing the type Tree without import type
Very tricky. Looking at your tsconfig I do see "importsNotUsedAsValues": "preserve", which should mean you don't have to switch to import type. importsNotUsedAsValues is deprecated though, and replaced with new verbatimModuleSyntax TS option in the latest TS versions.
https://github.com/syntaxfm/website/blob/f2d24d98400e4c1a29ac9ceed70d8f5c57d0b96d/tsconfig.json#L13C3-L13C40
In Sveltekit 2.0 the generated tsconfig in ./.svelte-kit/tsconfig.json now sets verbatimModuleSyntax, which overrides importsNotUsedAsValues and makes you now require import type. I would keep the change as explicit type imports is way better for bundler/TypeScript, but I'm surprised that svelte-migrate codemod didn't catch this and that the error was hard to debug.
@stolinski
stolinski
merged commit c7516fc
into
mainJan 11, 2024
@stolinski
stolinski
deleted the

svelte-2

branch
April 5, 2024 18:22
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wesbos@Lms24@stolinski@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Migrate to SvelteKit 2.0 by wesbos · Pull Request #1458 · syntaxfm/website · GitHub
Skip to content
Migrate to SvelteKit 2.0 - #1458
Merged
stolinski merged 5 commits into
mainfrom 
svelte-2
Jan 11, 2024
Merged
Migrate to SvelteKit 2.0#1458
stolinski merged 5 commits into
mainfrom 
svelte-2
Conversation
@wesbos
@wesboswesbos
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
need to see if this builds, but seems pretty smooth.
@vercel
vercelBot
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewUpdated (UTC)
syntax-website✅ Ready (Inspect)Visit PreviewJan 11, 2024 7:59pm
@wesboswesbos
mentioned this pull request
Dec 14, 2023

Closed

@wesbos
wesbos
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Build is breaking - I think related to the Sentry integration / moving to Vite 5
/node_modules/@sentry/node/esm/transports/http.js". at error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/parseAst.js:337:30) at Module.error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:12753:16) at Module.traceVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:13190:29) at ModuleScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:11607:39) at FunctionScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at FunctionBodyScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at Identifier.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:7193:40) at NewExpression.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at ReturnStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at BlockStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4635:28) ELIFECYCLE Command failed with exit code 1.ERROR: "build:svelte" exited with 1. ELIFECYCLE Command failed with exit code 1.Error: Command "pnpm build" exited with 1
will ping @AbhiPrasad as he made the issue on sentry-javascript
getsentry/sentry-javascript#9851
@Lms24
Lms24
commented
Dec 15, 2023•

edited

Loading

Copy link


Copy Markdown

Hey @wesbos I'm currently trying to get the SDK to work with Kit 2.0. To debug, I cloned this repo and checked out your PR.
I think I've identified a fix for the problem but I'm not entirely sure because I don't get the exact same error and some other weird stuff is going on. The error I'm getting is pretty similar though to the one from CI.
Could you test something for me:

Add this exports property in node_modules/@sentry/sveltekit/package.json:
"exports": {
"browser": "./esm/index.client.js",
"node": "./cjs/index.server.js"
},
For me, adding these conditional exports resolved the build error.

If possible, I'd like to confirm this fixes things for you, too, before publishing the fix in the next SDK version.
some other weird stuff is going on
To expand on this: for some reason hydration seems to break in dev mode for me. For a split second, I can see the SSR html in the browser but then I get an error 500 page (no console output though). However, this still happens, even if I remove all Sentry SDK usage. Not sure if this is a kit bug or has something to do with the env variables I (didn't) set.
@Lms24Lms24
mentioned this pull request
Dec 15, 2023
 Merged

@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Would love to get this merged. Might dive in an confirm we are gtg here. Would love to get on Node 20.
@AbhiPrasad
AbhiPrasad
commented
Jan 10, 2024

Copy link


Copy Markdown

Latest version of the SDK should have SvelteKit 2.0 support - it was specifically released with https://github.com/getsentry/sentry-javascript/releases/tag/7.89.0
SDK is also tests with latest Node 20/21, so you should be good to go there!
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
@AbhiPrasad it seems like this error is still happening in Sentry/SvelteKit 7.93. I'll try removing the Sentry code and diving in further.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
As you suspected @AbhiPrasad the issue is not with Sentry. Very difficult to get a handle on where the problem actually is though.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Found it! SearchResults.svelte importing the type Tree without import type. 🥴
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Ok sorry for the spam, going to re-add the Sentry code. Test more and get this pushed up and merged.
@AbhiPrasad
AbhiPrasad
commented
Jan 11, 2024

Copy link


Copy Markdown

SearchResults.svelte importing the type Tree without import type
Very tricky. Looking at your tsconfig I do see "importsNotUsedAsValues": "preserve", which should mean you don't have to switch to import type. importsNotUsedAsValues is deprecated though, and replaced with new verbatimModuleSyntax TS option in the latest TS versions.
https://github.com/syntaxfm/website/blob/f2d24d98400e4c1a29ac9ceed70d8f5c57d0b96d/tsconfig.json#L13C3-L13C40
In Sveltekit 2.0 the generated tsconfig in ./.svelte-kit/tsconfig.json now sets verbatimModuleSyntax, which overrides importsNotUsedAsValues and makes you now require import type. I would keep the change as explicit type imports is way better for bundler/TypeScript, but I'm surprised that svelte-migrate codemod didn't catch this and that the error was hard to debug.
@stolinski
stolinski
merged commit c7516fc
into
mainJan 11, 2024
@stolinski
stolinski
deleted the

svelte-2

branch
April 5, 2024 18:22
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wesbos@Lms24@stolinski@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Migrate to SvelteKit 2.0 by wesbos · Pull Request #1458 · syntaxfm/website · GitHub
Skip to content
Migrate to SvelteKit 2.0 - #1458
Merged
stolinski merged 5 commits into
mainfrom 
svelte-2
Jan 11, 2024
Merged
Migrate to SvelteKit 2.0#1458
stolinski merged 5 commits into
mainfrom 
svelte-2
Conversation
@wesbos
@wesboswesbos
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
need to see if this builds, but seems pretty smooth.
@vercel
vercelBot
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewUpdated (UTC)
syntax-website✅ Ready (Inspect)Visit PreviewJan 11, 2024 7:59pm
@wesboswesbos
mentioned this pull request
Dec 14, 2023

Closed

@wesbos
wesbos
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Build is breaking - I think related to the Sentry integration / moving to Vite 5
/node_modules/@sentry/node/esm/transports/http.js". at error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/parseAst.js:337:30) at Module.error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:12753:16) at Module.traceVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:13190:29) at ModuleScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:11607:39) at FunctionScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at FunctionBodyScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at Identifier.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:7193:40) at NewExpression.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at ReturnStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at BlockStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4635:28) ELIFECYCLE Command failed with exit code 1.ERROR: "build:svelte" exited with 1. ELIFECYCLE Command failed with exit code 1.Error: Command "pnpm build" exited with 1
will ping @AbhiPrasad as he made the issue on sentry-javascript
getsentry/sentry-javascript#9851
@Lms24
Lms24
commented
Dec 15, 2023•

edited

Loading

Copy link


Copy Markdown

Hey @wesbos I'm currently trying to get the SDK to work with Kit 2.0. To debug, I cloned this repo and checked out your PR.
I think I've identified a fix for the problem but I'm not entirely sure because I don't get the exact same error and some other weird stuff is going on. The error I'm getting is pretty similar though to the one from CI.
Could you test something for me:

Add this exports property in node_modules/@sentry/sveltekit/package.json:
"exports": {
"browser": "./esm/index.client.js",
"node": "./cjs/index.server.js"
},
For me, adding these conditional exports resolved the build error.

If possible, I'd like to confirm this fixes things for you, too, before publishing the fix in the next SDK version.
some other weird stuff is going on
To expand on this: for some reason hydration seems to break in dev mode for me. For a split second, I can see the SSR html in the browser but then I get an error 500 page (no console output though). However, this still happens, even if I remove all Sentry SDK usage. Not sure if this is a kit bug or has something to do with the env variables I (didn't) set.
@Lms24Lms24
mentioned this pull request
Dec 15, 2023
 Merged

@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Would love to get this merged. Might dive in an confirm we are gtg here. Would love to get on Node 20.
@AbhiPrasad
AbhiPrasad
commented
Jan 10, 2024

Copy link


Copy Markdown

Latest version of the SDK should have SvelteKit 2.0 support - it was specifically released with https://github.com/getsentry/sentry-javascript/releases/tag/7.89.0
SDK is also tests with latest Node 20/21, so you should be good to go there!
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
@AbhiPrasad it seems like this error is still happening in Sentry/SvelteKit 7.93. I'll try removing the Sentry code and diving in further.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
As you suspected @AbhiPrasad the issue is not with Sentry. Very difficult to get a handle on where the problem actually is though.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Found it! SearchResults.svelte importing the type Tree without import type. 🥴
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Ok sorry for the spam, going to re-add the Sentry code. Test more and get this pushed up and merged.
@AbhiPrasad
AbhiPrasad
commented
Jan 11, 2024

Copy link


Copy Markdown

SearchResults.svelte importing the type Tree without import type
Very tricky. Looking at your tsconfig I do see "importsNotUsedAsValues": "preserve", which should mean you don't have to switch to import type. importsNotUsedAsValues is deprecated though, and replaced with new verbatimModuleSyntax TS option in the latest TS versions.
https://github.com/syntaxfm/website/blob/f2d24d98400e4c1a29ac9ceed70d8f5c57d0b96d/tsconfig.json#L13C3-L13C40
In Sveltekit 2.0 the generated tsconfig in ./.svelte-kit/tsconfig.json now sets verbatimModuleSyntax, which overrides importsNotUsedAsValues and makes you now require import type. I would keep the change as explicit type imports is way better for bundler/TypeScript, but I'm surprised that svelte-migrate codemod didn't catch this and that the error was hard to debug.
@stolinski
stolinski
merged commit c7516fc
into
mainJan 11, 2024
@stolinski
stolinski
deleted the

svelte-2

branch
April 5, 2024 18:22
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wesbos@Lms24@stolinski@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Migrate to SvelteKit 2.0 by wesbos · Pull Request #1458 · syntaxfm/website · GitHub
Skip to content
Migrate to SvelteKit 2.0 - #1458
Merged
stolinski merged 5 commits into
mainfrom 
svelte-2
Jan 11, 2024
Merged
Migrate to SvelteKit 2.0#1458
stolinski merged 5 commits into
mainfrom 
svelte-2
Conversation
@wesbos
@wesboswesbos
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
need to see if this builds, but seems pretty smooth.
@vercel
vercelBot
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewUpdated (UTC)
syntax-website✅ Ready (Inspect)Visit PreviewJan 11, 2024 7:59pm
@wesboswesbos
mentioned this pull request
Dec 14, 2023

Closed

@wesbos
wesbos
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Build is breaking - I think related to the Sentry integration / moving to Vite 5
/node_modules/@sentry/node/esm/transports/http.js". at error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/parseAst.js:337:30) at Module.error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:12753:16) at Module.traceVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:13190:29) at ModuleScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:11607:39) at FunctionScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at FunctionBodyScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at Identifier.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:7193:40) at NewExpression.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at ReturnStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at BlockStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4635:28) ELIFECYCLE Command failed with exit code 1.ERROR: "build:svelte" exited with 1. ELIFECYCLE Command failed with exit code 1.Error: Command "pnpm build" exited with 1
will ping @AbhiPrasad as he made the issue on sentry-javascript
getsentry/sentry-javascript#9851
@Lms24
Lms24
commented
Dec 15, 2023•

edited

Loading

Copy link


Copy Markdown

Hey @wesbos I'm currently trying to get the SDK to work with Kit 2.0. To debug, I cloned this repo and checked out your PR.
I think I've identified a fix for the problem but I'm not entirely sure because I don't get the exact same error and some other weird stuff is going on. The error I'm getting is pretty similar though to the one from CI.
Could you test something for me:

Add this exports property in node_modules/@sentry/sveltekit/package.json:
"exports": {
"browser": "./esm/index.client.js",
"node": "./cjs/index.server.js"
},
For me, adding these conditional exports resolved the build error.

If possible, I'd like to confirm this fixes things for you, too, before publishing the fix in the next SDK version.
some other weird stuff is going on
To expand on this: for some reason hydration seems to break in dev mode for me. For a split second, I can see the SSR html in the browser but then I get an error 500 page (no console output though). However, this still happens, even if I remove all Sentry SDK usage. Not sure if this is a kit bug or has something to do with the env variables I (didn't) set.
@Lms24Lms24
mentioned this pull request
Dec 15, 2023
 Merged

@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Would love to get this merged. Might dive in an confirm we are gtg here. Would love to get on Node 20.
@AbhiPrasad
AbhiPrasad
commented
Jan 10, 2024

Copy link


Copy Markdown

Latest version of the SDK should have SvelteKit 2.0 support - it was specifically released with https://github.com/getsentry/sentry-javascript/releases/tag/7.89.0
SDK is also tests with latest Node 20/21, so you should be good to go there!
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
@AbhiPrasad it seems like this error is still happening in Sentry/SvelteKit 7.93. I'll try removing the Sentry code and diving in further.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
As you suspected @AbhiPrasad the issue is not with Sentry. Very difficult to get a handle on where the problem actually is though.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Found it! SearchResults.svelte importing the type Tree without import type. 🥴
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Ok sorry for the spam, going to re-add the Sentry code. Test more and get this pushed up and merged.
@AbhiPrasad
AbhiPrasad
commented
Jan 11, 2024

Copy link


Copy Markdown

SearchResults.svelte importing the type Tree without import type
Very tricky. Looking at your tsconfig I do see "importsNotUsedAsValues": "preserve", which should mean you don't have to switch to import type. importsNotUsedAsValues is deprecated though, and replaced with new verbatimModuleSyntax TS option in the latest TS versions.
https://github.com/syntaxfm/website/blob/f2d24d98400e4c1a29ac9ceed70d8f5c57d0b96d/tsconfig.json#L13C3-L13C40
In Sveltekit 2.0 the generated tsconfig in ./.svelte-kit/tsconfig.json now sets verbatimModuleSyntax, which overrides importsNotUsedAsValues and makes you now require import type. I would keep the change as explicit type imports is way better for bundler/TypeScript, but I'm surprised that svelte-migrate codemod didn't catch this and that the error was hard to debug.
@stolinski
stolinski
merged commit c7516fc
into
mainJan 11, 2024
@stolinski
stolinski
deleted the

svelte-2

branch
April 5, 2024 18:22
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wesbos@Lms24@stolinski@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Migrate to SvelteKit 2.0 by wesbos · Pull Request #1458 · syntaxfm/website · GitHub
Skip to content
Migrate to SvelteKit 2.0 - #1458
Merged
stolinski merged 5 commits into
mainfrom 
svelte-2
Jan 11, 2024
Merged
Migrate to SvelteKit 2.0#1458
stolinski merged 5 commits into
mainfrom 
svelte-2
Conversation
@wesbos
@wesboswesbos
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
need to see if this builds, but seems pretty smooth.
@vercel
vercelBot
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewUpdated (UTC)
syntax-website✅ Ready (Inspect)Visit PreviewJan 11, 2024 7:59pm
@wesboswesbos
mentioned this pull request
Dec 14, 2023

Closed

@wesbos
wesbos
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Build is breaking - I think related to the Sentry integration / moving to Vite 5
/node_modules/@sentry/node/esm/transports/http.js". at error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/parseAst.js:337:30) at Module.error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:12753:16) at Module.traceVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:13190:29) at ModuleScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:11607:39) at FunctionScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at FunctionBodyScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at Identifier.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:7193:40) at NewExpression.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at ReturnStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at BlockStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4635:28) ELIFECYCLE Command failed with exit code 1.ERROR: "build:svelte" exited with 1. ELIFECYCLE Command failed with exit code 1.Error: Command "pnpm build" exited with 1
will ping @AbhiPrasad as he made the issue on sentry-javascript
getsentry/sentry-javascript#9851
@Lms24
Lms24
commented
Dec 15, 2023•

edited

Loading

Copy link


Copy Markdown

Hey @wesbos I'm currently trying to get the SDK to work with Kit 2.0. To debug, I cloned this repo and checked out your PR.
I think I've identified a fix for the problem but I'm not entirely sure because I don't get the exact same error and some other weird stuff is going on. The error I'm getting is pretty similar though to the one from CI.
Could you test something for me:

Add this exports property in node_modules/@sentry/sveltekit/package.json:
"exports": {
"browser": "./esm/index.client.js",
"node": "./cjs/index.server.js"
},
For me, adding these conditional exports resolved the build error.

If possible, I'd like to confirm this fixes things for you, too, before publishing the fix in the next SDK version.
some other weird stuff is going on
To expand on this: for some reason hydration seems to break in dev mode for me. For a split second, I can see the SSR html in the browser but then I get an error 500 page (no console output though). However, this still happens, even if I remove all Sentry SDK usage. Not sure if this is a kit bug or has something to do with the env variables I (didn't) set.
@Lms24Lms24
mentioned this pull request
Dec 15, 2023
 Merged

@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Would love to get this merged. Might dive in an confirm we are gtg here. Would love to get on Node 20.
@AbhiPrasad
AbhiPrasad
commented
Jan 10, 2024

Copy link


Copy Markdown

Latest version of the SDK should have SvelteKit 2.0 support - it was specifically released with https://github.com/getsentry/sentry-javascript/releases/tag/7.89.0
SDK is also tests with latest Node 20/21, so you should be good to go there!
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
@AbhiPrasad it seems like this error is still happening in Sentry/SvelteKit 7.93. I'll try removing the Sentry code and diving in further.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
As you suspected @AbhiPrasad the issue is not with Sentry. Very difficult to get a handle on where the problem actually is though.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Found it! SearchResults.svelte importing the type Tree without import type. 🥴
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Ok sorry for the spam, going to re-add the Sentry code. Test more and get this pushed up and merged.
@AbhiPrasad
AbhiPrasad
commented
Jan 11, 2024

Copy link


Copy Markdown

SearchResults.svelte importing the type Tree without import type
Very tricky. Looking at your tsconfig I do see "importsNotUsedAsValues": "preserve", which should mean you don't have to switch to import type. importsNotUsedAsValues is deprecated though, and replaced with new verbatimModuleSyntax TS option in the latest TS versions.
https://github.com/syntaxfm/website/blob/f2d24d98400e4c1a29ac9ceed70d8f5c57d0b96d/tsconfig.json#L13C3-L13C40
In Sveltekit 2.0 the generated tsconfig in ./.svelte-kit/tsconfig.json now sets verbatimModuleSyntax, which overrides importsNotUsedAsValues and makes you now require import type. I would keep the change as explicit type imports is way better for bundler/TypeScript, but I'm surprised that svelte-migrate codemod didn't catch this and that the error was hard to debug.
@stolinski
stolinski
merged commit c7516fc
into
mainJan 11, 2024
@stolinski
stolinski
deleted the

svelte-2

branch
April 5, 2024 18:22
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wesbos@Lms24@stolinski@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Migrate to SvelteKit 2.0 by wesbos · Pull Request #1458 · syntaxfm/website · GitHub
Skip to content
Migrate to SvelteKit 2.0 - #1458
Merged
stolinski merged 5 commits into
mainfrom 
svelte-2
Jan 11, 2024
Merged
Migrate to SvelteKit 2.0#1458
stolinski merged 5 commits into
mainfrom 
svelte-2
Conversation
@wesbos
@wesboswesbos
commented
Dec 14, 2023

Copy link


Copy Markdown

Collaborator
need to see if this builds, but seems pretty smooth.
@vercel
vercelBot
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewUpdated (UTC)
syntax-website✅ Ready (Inspect)Visit PreviewJan 11, 2024 7:59pm
@wesboswesbos
mentioned this pull request
Dec 14, 2023

Closed

@wesbos
wesbos
commented
Dec 14, 2023•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
Build is breaking - I think related to the Sentry integration / moving to Vite 5
/node_modules/@sentry/node/esm/transports/http.js". at error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/parseAst.js:337:30) at Module.error (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:12753:16) at Module.traceVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:13190:29) at ModuleScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:11607:39) at FunctionScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at FunctionBodyScope.findVariable (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:5911:38) at Identifier.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:7193:40) at NewExpression.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at ReturnStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4639:23) at BlockStatement.bind (file:///vercel/path0/node_modules/.pnpm/rollup@4.9.0/node_modules/rollup/dist/es/shared/node-entry.js:4635:28) ELIFECYCLE Command failed with exit code 1.ERROR: "build:svelte" exited with 1. ELIFECYCLE Command failed with exit code 1.Error: Command "pnpm build" exited with 1
will ping @AbhiPrasad as he made the issue on sentry-javascript
getsentry/sentry-javascript#9851
@Lms24
Lms24
commented
Dec 15, 2023•

edited

Loading

Copy link


Copy Markdown

Hey @wesbos I'm currently trying to get the SDK to work with Kit 2.0. To debug, I cloned this repo and checked out your PR.
I think I've identified a fix for the problem but I'm not entirely sure because I don't get the exact same error and some other weird stuff is going on. The error I'm getting is pretty similar though to the one from CI.
Could you test something for me:

Add this exports property in node_modules/@sentry/sveltekit/package.json:
"exports": {
"browser": "./esm/index.client.js",
"node": "./cjs/index.server.js"
},
For me, adding these conditional exports resolved the build error.

If possible, I'd like to confirm this fixes things for you, too, before publishing the fix in the next SDK version.
some other weird stuff is going on
To expand on this: for some reason hydration seems to break in dev mode for me. For a split second, I can see the SSR html in the browser but then I get an error 500 page (no console output though). However, this still happens, even if I remove all Sentry SDK usage. Not sure if this is a kit bug or has something to do with the env variables I (didn't) set.
@Lms24Lms24
mentioned this pull request
Dec 15, 2023
 Merged

@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Would love to get this merged. Might dive in an confirm we are gtg here. Would love to get on Node 20.
@AbhiPrasad
AbhiPrasad
commented
Jan 10, 2024

Copy link


Copy Markdown

Latest version of the SDK should have SvelteKit 2.0 support - it was specifically released with https://github.com/getsentry/sentry-javascript/releases/tag/7.89.0
SDK is also tests with latest Node 20/21, so you should be good to go there!
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
@AbhiPrasad it seems like this error is still happening in Sentry/SvelteKit 7.93. I'll try removing the Sentry code and diving in further.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
As you suspected @AbhiPrasad the issue is not with Sentry. Very difficult to get a handle on where the problem actually is though.
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Found it! SearchResults.svelte importing the type Tree without import type. 🥴
@stolinski
stolinski
commented
Jan 10, 2024

Copy link


Copy Markdown

Collaborator
Ok sorry for the spam, going to re-add the Sentry code. Test more and get this pushed up and merged.
@AbhiPrasad
AbhiPrasad
commented
Jan 11, 2024

Copy link


Copy Markdown

SearchResults.svelte importing the type Tree without import type
Very tricky. Looking at your tsconfig I do see "importsNotUsedAsValues": "preserve", which should mean you don't have to switch to import type. importsNotUsedAsValues is deprecated though, and replaced with new verbatimModuleSyntax TS option in the latest TS versions.
https://github.com/syntaxfm/website/blob/f2d24d98400e4c1a29ac9ceed70d8f5c57d0b96d/tsconfig.json#L13C3-L13C40
In Sveltekit 2.0 the generated tsconfig in ./.svelte-kit/tsconfig.json now sets verbatimModuleSyntax, which overrides importsNotUsedAsValues and makes you now require import type. I would keep the change as explicit type imports is way better for bundler/TypeScript, but I'm surprised that svelte-migrate codemod didn't catch this and that the error was hard to debug.
@stolinski
stolinski
merged commit c7516fc
into
mainJan 11, 2024
@stolinski
stolinski
deleted the

svelte-2

branch
April 5, 2024 18:22
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@wesbos@Lms24@stolinski@AbhiPrasad