Skip to content

Search for USB cams in RoboConUSBCamera instead of just assuming /dev/video0 - #41

Open
scorbett123 wants to merge 4 commits into
systemetric:masterfrom
RoboConOxfordshire:usb_cam_fix
Open

Search for USB cams in RoboConUSBCamera instead of just assuming /dev/video0#41
scorbett123 wants to merge 4 commits into
systemetric:masterfrom
RoboConOxfordshire:usb_cam_fix

Conversation

@scorbett123

@scorbett123scorbett123 commented Nov 9, 2022

Copy link
Copy Markdown

shardros
shardros reviewed Nov 10, 2022
View reviewed changes
Comment threadrobot/vision.py
Comment threadrobot/vision.py Outdated
Comment threadrobot/vision.py Outdated
Comment threadrobot/vision.py Outdated
@scorbett123@Minion3665
Add next steps to no USB camera detected error
ff97dbc
Co-authored-by: Skyler <skyler3665@gmail.com>
Minion3665
Minion3665 reviewed Nov 10, 2022
View reviewed changes

@Minion3665Minion3665 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made suggestions that together will dynamically get the number of the camera rather than needing to hardcode video0 and video1 (as well as checking for a USB camera rather than against a pi camera).

Please check them over and commit them if you feel they add value @scorbett123

Comment threadrobot/vision.py Outdated
Comment threadrobot/vision.py
scorbett123and others added 2 commits November 10, 2022 13:38
@scorbett123@Minion3665
Improve find_usb_camera
42feb83
search all of /dev/videoX
Check whether a camera is a USB cam instead of not being a pi cam
Co-authored-by: Skyler <skyler3665@gmail.com>
@scorbett123@Minion3665
Add re import
9d81ba2
Forgot this
Co-authored-by: Skyler <skyler3665@gmail.com>
Minion3665
Minion3665 approved these changes Nov 10, 2022
View reviewed changes

@Minion3665Minion3665 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and seems to work. Thank you very much!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Minion3665Minion3665Minion3665 approved these changes
@shardrosshardrosAwaiting requested review from shardros

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scorbett123@shardros@Minion3665