fix(tests): populate help-parameter vars in BeforeDiscovery so the param-help check runs

[tablackburn]

Problem

Help.tests.ps1 has a Pester v5 discovery/run-phase bug. The Context

Context 'Test <_> help parameter help for <commandName>'-Foreach $helpParameterNames {
It 'finds help parameter in code: <_>' { $_-in$commandParameterNames| Should -Be $true }
}

uses -Foreach $helpParameterNames, but $helpParameterNames was populated only in BeforeAll (run phase). Pester evaluates -Foreach during discovery, so the collection is $null then and the Context expands to zero tests. The 'no stale/extra parameters documented in help' check has therefore been a silent no-op — in this template and every module scaffolded from it.

(The sibling Context 'Parameter <_.Name>' -Foreach $commandParameters works precisely because $commandParametersis set in BeforeDiscovery.)

Fix

Populate $helpParameters/$helpParameterNames in BeforeDiscovery too (mirroring $commandParameters), so the Context generates one test per documented parameter.

Verification

Local Pester 5.7.1 run of a minimal mirror: a -Foreach collection set in BeforeDiscovery generated 3 tests; the same collection set only in BeforeAll generated 0.

Follow-up

This is the canonical fix; it needs propagating to the consumers' Help.tests.ps1 (the stalled style/align-test-scaffolding-with-template PRs ReScenePS #18 / Plex #55 should carry the fixed version).

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

@tablackburn, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 44 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 52c4ef7b-c73d-4e60-be99-51253a19cb04

📥 Commits

Reviewing files that changed from the base of the PR and between 090de78 and c7ea458.

📒 Files selected for processing (1)

• tests/Help.tests.ps1

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/help-tests-discovery-phase

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes a Pester v5 discovery/run-phase issue in the help tests so that the “no stale/extra parameters documented in help” checks actually generate and run test cases during discovery.

Changes:

• Populate $helpParameters / $helpParameterNames inside the per-command BeforeDiscovery block so Context ... -ForEach $helpParameterNames expands into tests at discovery time.
• Add clarifying comments explaining why the values are duplicated between BeforeDiscovery and BeforeAll.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.