Skip to content

@W-19831625: Add UAT support to TSC JWT Login - #1671

Merged
bcantoni merged 3 commits into
tableau:developmentfrom
BereketBirbo:dev/bereket.birbo/W-19831625
Oct 22, 2025
Merged

@W-19831625: Add UAT support to TSC JWT Login#1671
bcantoni merged 3 commits into
tableau:developmentfrom
BereketBirbo:dev/bereket.birbo/W-19831625

Conversation

@BereketBirbo

@BereketBirboBereketBirbo commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

added UAT (unified access token/ tableau cloud unified jwt) support for TSC JWT login

@salesforce-cla

salesforce-claBot commented Oct 17, 2025

Copy link
Copy Markdown

Thanks for the contribution! It looks like @BereketBirbo is an internal user so signing the CLA is not required. However, we need to confirm this.

@bcantoni

bcantoni commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Close and reopen to see if it clears the CLA issue.

@bcantonibcantoni reopened this Oct 20, 2025
@bcantoni

bcantoni commented Oct 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

@BereketBirbo please update your PR to fix the Black formatting issues (docs here: https://tableau.github.io/server-client-python/docs/dev-guide#code-and-commit)

@BereketBirbo

BereketBirbo commented Oct 20, 2025

Copy link
Copy Markdown
ContributorAuthor

@bcantoni I have fixed the black formatting issues. Thank you

jorwoods
jorwoods reviewed Oct 20, 2025
View reviewed changes
Comment threadtableauserverclient/models/tableau_auth.py Outdated
def __init__(
self,
jwt: str,
isUat: Optional[bool] = False,

@jorwoodsjorwoodsOct 20, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is None a valid value for isUat? Optional indicates that it is.

@BereketBirboBereketBirboOct 20, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is, but I just pushed another version making isUat just True or False as that is more clear

@BereketBirbo

BereketBirbo commented Oct 21, 2025

Copy link
Copy Markdown
ContributorAuthor

@bcantoni@jorwoods could you review my changes again? thank you

bcantoni
bcantoni approved these changes Oct 22, 2025
View reviewed changes

@bcantonibcantoni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good - thanks @BereketBirbo for the changes

@bcantoni
bcantoni merged commit cba111a into tableau:developmentOct 22, 2025
@bcantoni

bcantoni commented Dec 23, 2025

Copy link
Copy Markdown
Contributor

Corresponding doc changes: #1718

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcantonibcantonibcantoni approved these changes
+1 more reviewer
@jorwoodsjorwoodsjorwoods approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla:signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BereketBirbo@bcantoni@jorwoods