Skip to content

Respond to review feedback: cannot create GitHub issues programmatically - #1741

Closed
jacalata with Copilot wants to merge 1 commit into
developmentfrom
copilot/sub-pr-1737-again
Closed

Respond to review feedback: cannot create GitHub issues programmatically#1741
jacalata with Copilot wants to merge 1 commit into
developmentfrom
copilot/sub-pr-1737-again

Conversation

CopilotAI commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Review comment requested opening a GitHub issue to track incorrect pytest.approx usage in test_exponential_backoff.py.

Response provided

Replied to comment explaining lack of issue-creation permissions and provided complete issue details:

  • Root cause: Commit bfc692c converted self.assertAlmostEqual(x, y) to pytest.approx(x, y) instead of assert x == pytest.approx(y)
  • Affected lines: 11, 14, 16, 18, 20, 22, 37, 45, 50
  • Example fix: pytest.approx(mock_time(), 0.5)assert mock_time() == pytest.approx(0.5)

Awaiting clarification on whether to fix assertions in this PR or have user create issue manually.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

CopilotAI mentioned this pull request Feb 2, 2026
@jacalatajacalata closed this Feb 2, 2026
CopilotAI changed the title [WIP] Address feedback from review on release v0.39 PRRespond to review feedback: cannot create GitHub issues programmaticallyFeb 2, 2026
@jacalata
jacalata deleted the copilot/sub-pr-1737-again branch February 2, 2026 06:47
CopilotAI requested a review from jacalataFebruary 2, 2026 06:47
Copilot stopped work on behalf of jacalata due to an error February 2, 2026 06:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jacalata