Propagate variants attributes to method definitions. - #30
Conversation
tailhook
commented
Nov 19, 2016
Can you add a test for this feature? I'm not sure what are these imeta parameters at all and how we can apply meta parameters to "methods" which aren't actually the methods. |
Yamakaky
commented
Nov 21, 2016
In fact, the attributes specified to the variants of the error were propagated to the enum definition but not to the various matches in the methods definitions. |
ticki
commented
Jan 25, 2017
Can this be merged yet, @tailhook? |
tailhook
commented
Jan 25, 2017
Well, sorry for being silent for so much time here. The problem that might be with this PR, is that While it makes sense propagate conditional compilation attributes (i.e. |
ticki
commented
Jan 25, 2017
|
tailhook
commented
Jan 25, 2017
Ah, right. I've misread it at a glance.
It's there in this pull request: https://github.com/tailhook/quick-error/pull/30/files#diff-b4aea3e418ccdb71239b96952d9cddb6R529 Because conditional compilation requires it: https://github.com/tailhook/quick-error/pull/30/files#diff-b4aea3e418ccdb71239b96952d9cddb6R1144 So I guess this will break docstrings on variants (yet to check) |
tailhook
commented
Apr 24, 2017
From what I observe it works fine. Thanks, for contributing! Sorry for sooooo long delay. |
Yamakaky
commented
Apr 24, 2017
^^ |
No description provided.