Skip to content

Add tailscale_enable_funnel_to_localhost_plaintext_http1 to tailscale.h - #29

Merged
bradfitz merged 1 commit into
tailscale:mainfrom
yagil:yagil/funnel
Jan 21, 2025
Merged

Add tailscale_enable_funnel_to_localhost_plaintext_http1 to tailscale.h#29
bradfitz merged 1 commit into
tailscale:mainfrom
yagil:yagil/funnel

Conversation

@yagil

Copy link
Copy Markdown
Contributor

Adds a way to enable a funnel from libtailscale.

Comment threadtailscale.h Outdated
@bradfitz

Copy link
Copy Markdown
Member

Can you squash your commits in the branch together, down to 1 commit?

@bradfitzbradfitz changed the title Add tailscale_enable_funnel to tailscale.hAdd tailscale_enable_funnel_to_localhost_plaintext_http1 to tailscale.hJan 20, 2025
@bradfitz

Copy link
Copy Markdown
Member

@raggi, you cool with this API and name?

This gets it out of the way of something more general, like sent in #28.

@yagil

Copy link
Copy Markdown
ContributorAuthor

Can you squash your commits in the branch together, down to 1 commit?

done

@raggi

Copy link
Copy Markdown
Member

@raggi, you cool with this API and name?

This gets it out of the way of something more general, like sent in #28.

Yeah absolutely. We might want to take a struct approach, but we'd then need to decide about the whole enum ffi debacle. This SGTM.

Comment threadtailscale.h Outdated
@bradfitz

Copy link
Copy Markdown
Member

Please squash. We have "Squash & Merge" disabled on this repo.

@yagil

Copy link
Copy Markdown
ContributorAuthor

Please squash. We have "Squash & Merge" disabled on this repo.

Done

@bradfitz
bradfitz merged commit 9d45e58 into tailscale:mainJan 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yagil@bradfitz@raggi