Move the pin to Rust 1.98

[tamnd]

Closes#25. Follows tamnd/zu#516, which moves the row in toolchains.toml this repository copies.

The pin itself is two lines, the channel and rust-version. No workflow here names a version, since the clippy and test jobs read the toolchain file.

The first commit is what makes the second one green. 1.98 ships clippy::chunks_exact_to_as_chunks, which fires four times in this tree, so the pin bump would be a red CI without it. It is a good lint rather than a style note: chunks_exact(8) returns a slice whose length the compiler does not know, so each of those lines carried a try_into().expect("eight bytes") to get an array back out. as_chunks::<8>() puts the width in the type and both the conversion and its panic disappear. Three sites are the widths in Bytes::extend, the copy out of an engine column into the buffer behind a typed array; the fourth is the flat edge list, where a pair becomes a pair in the type.

as_chunks returns the remainder that chunks_exact dropped, and both call sites still want it dropped. extend copies whole elements, so a partial one is a caller handing over something that is not this column. The edge list refuses an odd length by name before that line, so the tail is provably empty.

Dependencies were checked against the registry the same day and are all on their newest series: napi 3.12.1, napi-derive 3.6.3, napi-build 2.4.1, arrow 59.2.0.

Verified on 1.98.0 locally: cargo fmt --check, cargo clippy --all-features -- -D warnings clean, npm run build:debug, and npm test at 363 tests, 354 passing, 9 skipped, none failing.

[tamnd]

Closes#25. Follows tamnd/zu#516, which moves the row in toolchains.toml this repository copies.

The pin itself is two lines, the channel and rust-version. No workflow here names a version, since the clippy and test jobs read the toolchain file.

The first commit is what makes the second one green. 1.98 ships clippy::chunks_exact_to_as_chunks, which fires four times in this tree, so the pin bump would be a red CI without it. It is a good lint rather than a style note: chunks_exact(8) returns a slice whose length the compiler does not know, so each of those lines carried a try_into().expect("eight bytes") to get an array back out. as_chunks::<8>() puts the width in the type and both the conversion and its panic disappear. Three sites are the widths in Bytes::extend, the copy out of an engine column into the buffer behind a typed array; the fourth is the flat edge list, where a pair becomes a pair in the type.

as_chunks returns the remainder that chunks_exact dropped, and both call sites still want it dropped. extend copies whole elements, so a partial one is a caller handing over something that is not this column. The edge list refuses an odd length by name before that line, so the tail is provably empty.

Dependencies were checked against the registry the same day and are all on their newest series: napi 3.12.1, napi-derive 3.6.3, napi-build 2.4.1, arrow 59.2.0.

Verified on 1.98.0 locally: cargo fmt --check, cargo clippy --all-features -- -D warnings clean, npm run build:debug, and npm test at 363 tests, 354 passing, 9 skipped, none failing.

[tamnd]

Closes#25. Follows tamnd/zu#516, which moves the row in toolchains.toml this repository copies.

The pin itself is two lines, the channel and rust-version. No workflow here names a version, since the clippy and test jobs read the toolchain file.

The first commit is what makes the second one green. 1.98 ships clippy::chunks_exact_to_as_chunks, which fires four times in this tree, so the pin bump would be a red CI without it. It is a good lint rather than a style note: chunks_exact(8) returns a slice whose length the compiler does not know, so each of those lines carried a try_into().expect("eight bytes") to get an array back out. as_chunks::<8>() puts the width in the type and both the conversion and its panic disappear. Three sites are the widths in Bytes::extend, the copy out of an engine column into the buffer behind a typed array; the fourth is the flat edge list, where a pair becomes a pair in the type.

as_chunks returns the remainder that chunks_exact dropped, and both call sites still want it dropped. extend copies whole elements, so a partial one is a caller handing over something that is not this column. The edge list refuses an odd length by name before that line, so the tail is provably empty.

Dependencies were checked against the registry the same day and are all on their newest series: napi 3.12.1, napi-derive 3.6.3, napi-build 2.4.1, arrow 59.2.0.

Verified on 1.98.0 locally: cargo fmt --check, cargo clippy --all-features -- -D warnings clean, npm run build:debug, and npm test at 363 tests, 354 passing, 9 skipped, none failing.

[tamnd]

Closes#25. Follows tamnd/zu#516, which moves the row in toolchains.toml this repository copies.

The pin itself is two lines, the channel and rust-version. No workflow here names a version, since the clippy and test jobs read the toolchain file.

The first commit is what makes the second one green. 1.98 ships clippy::chunks_exact_to_as_chunks, which fires four times in this tree, so the pin bump would be a red CI without it. It is a good lint rather than a style note: chunks_exact(8) returns a slice whose length the compiler does not know, so each of those lines carried a try_into().expect("eight bytes") to get an array back out. as_chunks::<8>() puts the width in the type and both the conversion and its panic disappear. Three sites are the widths in Bytes::extend, the copy out of an engine column into the buffer behind a typed array; the fourth is the flat edge list, where a pair becomes a pair in the type.

as_chunks returns the remainder that chunks_exact dropped, and both call sites still want it dropped. extend copies whole elements, so a partial one is a caller handing over something that is not this column. The edge list refuses an odd length by name before that line, so the tail is provably empty.

Dependencies were checked against the registry the same day and are all on their newest series: napi 3.12.1, napi-derive 3.6.3, napi-build 2.4.1, arrow 59.2.0.

Verified on 1.98.0 locally: cargo fmt --check, cargo clippy --all-features -- -D warnings clean, npm run build:debug, and npm test at 363 tests, 354 passing, 9 skipped, none failing.

[tamnd]

Closes#25. Follows tamnd/zu#516, which moves the row in toolchains.toml this repository copies.

The pin itself is two lines, the channel and rust-version. No workflow here names a version, since the clippy and test jobs read the toolchain file.

The first commit is what makes the second one green. 1.98 ships clippy::chunks_exact_to_as_chunks, which fires four times in this tree, so the pin bump would be a red CI without it. It is a good lint rather than a style note: chunks_exact(8) returns a slice whose length the compiler does not know, so each of those lines carried a try_into().expect("eight bytes") to get an array back out. as_chunks::<8>() puts the width in the type and both the conversion and its panic disappear. Three sites are the widths in Bytes::extend, the copy out of an engine column into the buffer behind a typed array; the fourth is the flat edge list, where a pair becomes a pair in the type.

as_chunks returns the remainder that chunks_exact dropped, and both call sites still want it dropped. extend copies whole elements, so a partial one is a caller handing over something that is not this column. The edge list refuses an odd length by name before that line, so the tail is provably empty.

Dependencies were checked against the registry the same day and are all on their newest series: napi 3.12.1, napi-derive 3.6.3, napi-build 2.4.1, arrow 59.2.0.

Verified on 1.98.0 locally: cargo fmt --check, cargo clippy --all-features -- -D warnings clean, npm run build:debug, and npm test at 363 tests, 354 passing, 9 skipped, none failing.

[tamnd]

Closes#25. Follows tamnd/zu#516, which moves the row in toolchains.toml this repository copies.

The pin itself is two lines, the channel and rust-version. No workflow here names a version, since the clippy and test jobs read the toolchain file.

The first commit is what makes the second one green. 1.98 ships clippy::chunks_exact_to_as_chunks, which fires four times in this tree, so the pin bump would be a red CI without it. It is a good lint rather than a style note: chunks_exact(8) returns a slice whose length the compiler does not know, so each of those lines carried a try_into().expect("eight bytes") to get an array back out. as_chunks::<8>() puts the width in the type and both the conversion and its panic disappear. Three sites are the widths in Bytes::extend, the copy out of an engine column into the buffer behind a typed array; the fourth is the flat edge list, where a pair becomes a pair in the type.

as_chunks returns the remainder that chunks_exact dropped, and both call sites still want it dropped. extend copies whole elements, so a partial one is a caller handing over something that is not this column. The edge list refuses an odd length by name before that line, so the tail is provably empty.

Dependencies were checked against the registry the same day and are all on their newest series: napi 3.12.1, napi-derive 3.6.3, napi-build 2.4.1, arrow 59.2.0.

Verified on 1.98.0 locally: cargo fmt --check, cargo clippy --all-features -- -D warnings clean, npm run build:debug, and npm test at 363 tests, 354 passing, 9 skipped, none failing.

[tamnd]

Closes#25. Follows tamnd/zu#516, which moves the row in toolchains.toml this repository copies.

The pin itself is two lines, the channel and rust-version. No workflow here names a version, since the clippy and test jobs read the toolchain file.

The first commit is what makes the second one green. 1.98 ships clippy::chunks_exact_to_as_chunks, which fires four times in this tree, so the pin bump would be a red CI without it. It is a good lint rather than a style note: chunks_exact(8) returns a slice whose length the compiler does not know, so each of those lines carried a try_into().expect("eight bytes") to get an array back out. as_chunks::<8>() puts the width in the type and both the conversion and its panic disappear. Three sites are the widths in Bytes::extend, the copy out of an engine column into the buffer behind a typed array; the fourth is the flat edge list, where a pair becomes a pair in the type.

as_chunks returns the remainder that chunks_exact dropped, and both call sites still want it dropped. extend copies whole elements, so a partial one is a caller handing over something that is not this column. The edge list refuses an odd length by name before that line, so the tail is provably empty.

Dependencies were checked against the registry the same day and are all on their newest series: napi 3.12.1, napi-derive 3.6.3, napi-build 2.4.1, arrow 59.2.0.

Verified on 1.98.0 locally: cargo fmt --check, cargo clippy --all-features -- -D warnings clean, npm run build:debug, and npm test at 363 tests, 354 passing, 9 skipped, none failing.

[tamnd]

Closes#25. Follows tamnd/zu#516, which moves the row in toolchains.toml this repository copies.

The pin itself is two lines, the channel and rust-version. No workflow here names a version, since the clippy and test jobs read the toolchain file.

The first commit is what makes the second one green. 1.98 ships clippy::chunks_exact_to_as_chunks, which fires four times in this tree, so the pin bump would be a red CI without it. It is a good lint rather than a style note: chunks_exact(8) returns a slice whose length the compiler does not know, so each of those lines carried a try_into().expect("eight bytes") to get an array back out. as_chunks::<8>() puts the width in the type and both the conversion and its panic disappear. Three sites are the widths in Bytes::extend, the copy out of an engine column into the buffer behind a typed array; the fourth is the flat edge list, where a pair becomes a pair in the type.

as_chunks returns the remainder that chunks_exact dropped, and both call sites still want it dropped. extend copies whole elements, so a partial one is a caller handing over something that is not this column. The edge list refuses an odd length by name before that line, so the tail is provably empty.

Dependencies were checked against the registry the same day and are all on their newest series: napi 3.12.1, napi-derive 3.6.3, napi-build 2.4.1, arrow 59.2.0.

Verified on 1.98.0 locally: cargo fmt --check, cargo clippy --all-features -- -D warnings clean, npm run build:debug, and npm test at 363 tests, 354 passing, 9 skipped, none failing.