Uh oh!
There was an error while loading. Please reload this page.
core: protect ro nodes on disconnect - #252
Merged
Merged
Conversation
oleg-jukovec
requested changes
Jun 3, 2026
oleg-jukovec
left a comment
Contributor
There was a problem hiding this comment.
Please, add a changelog entry + link to the PR: #248
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Col-Waltzforce-pushed
the
Col-Waltz/protect-disconnect-on-ro
branch
from
June 11, 2026 10:54
89e9d3e to
7195d22Compareoleg-jukovec
requested changes
Jun 18, 2026
oleg-jukovec
left a comment
Contributor
There was a problem hiding this comment.
Please, describe the change for a user in the CHANGELOG.md.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Col-Waltzforce-pushed
the
Col-Waltz/protect-disconnect-on-ro
branch
from
June 18, 2026 09:28
7195d22 to
da46d48Compareoleg-jukovec
requested changes
Jun 18, 2026
Uh oh!
There was an error while loading. Please reload this page.
Col-Waltzforce-pushed
the
Col-Waltz/protect-disconnect-on-ro
branch
from
June 18, 2026 14:06
da46d48 to
3b53938Compareoleg-jukovec
approved these changes
Jun 19, 2026
palage4a
requested changes
Jun 22, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Adds protection for on_disconnect trigger. After leader change it may return ERR_READONLY while deleting consumers. Now this trigger performs only local operations on ro node.
Col-Waltzforce-pushed
the
Col-Waltz/protect-disconnect-on-ro
branch
from
June 22, 2026 22:38
3b53938 to
26590c5Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds protection for on_disconnect trigger. After leader change it may return ERR_READONLY while deleting consumers. Now this trigger performs only local operations on ro node.